Upload knessetCorpus.py

knessetCorpus.py

@@ -2,10 +2,8 @@ import json
 import os
 from typing import List
 from huggingface_hub import hf_hub_url
-import zipfile
-import bz2
+
 import datasets
-import io
 
 
 _KnessetCorpus_CITATION = "@misc{goldin2024knesset, title={The Knesset Corpus: An Annotated Corpus of Hebrew Parliamentary Proceedings}, author={Gili Goldin and Nick Howell and Noam Ordan and Ella Rabinovich and Shuly Wintner}, year={2024}, eprint={2405.18115}, archivePrefix={arXiv}, primaryClass={cs.CL} }"
@@ -335,30 +333,18 @@ class KnessetCorpus(datasets.GeneratorBasedBuilder):
         )
     def _split_generators(self, dl_manager: datasets.DownloadManager) -> List[datasets.SplitGenerator]:
         urls = self.config.data_urls
+        downloaded_files = dl_manager.download_and_extract(urls)
 
-        if dl_manager.is_streaming:
-            return [
-                datasets.SplitGenerator(
-                    name=datasets.Split.TRAIN,
-                    gen_kwargs={"data_files": urls},
-                )
-            ]
-        else:
-            downloaded_files = dl_manager.download_and_extract(urls)
-
-            return [
-                datasets.SplitGenerator(
-                    name=datasets.Split.TRAIN,
-                    gen_kwargs={
-                        "data_files": downloaded_files
-                    },
-                ),
-            ]
+        return [
+            datasets.SplitGenerator(
+                name=datasets.Split.TRAIN,
+                gen_kwargs={
+                    "data_files": downloaded_files
+                },
+            ),
+        ]
 
     def _generate_examples(self, data_files):
-        """
-        Generate examples from files, supporting both streaming and non-streaming modes.
-        """
         if "all_features_sentences" in self.config.name:
             id_field_name = "sentence_id"
         elif self.config.name == "protocols":
@@ -367,36 +353,32 @@ class KnessetCorpus(datasets.GeneratorBasedBuilder):
             id_field_name = "faction_id"
         elif self.config.name == "knessetMembers":
             id_field_name = "person_id"
-        else:
-            id_field_name = "id"  # Default for generic configurations
 
-        for filepath in data_files:
+        for i, filepath in enumerate(data_files):
             try:
-                # Hugging Face automatically handles streaming
-                for line_number, row in enumerate(filepath):
-                    try:
-                        row = json.loads(row)
-                    except json.JSONDecodeError as e:
-                        print(f"Failed to decode JSON at line {line_number} in file {filepath}: {e}. Skipping.")
-                        continue
-
-                    # Extract the ID field
-                    id_ = row.get(id_field_name, f"unknown_{line_number}")
-                    if not id_:
-                        print(f"Key '{id_field_name}' not found in row at line {line_number}. Skipping row.")
-                        continue
-
-                    # Prepare the sample dictionary
-                    sample = {feature: row.get(feature, None) for feature in self._info().features}
-
-                    # Handle nested structures (e.g., `protocol_sentences`)
-                    if "protocol_sentences" in row:
-                        protocol_sentences = row.get("protocol_sentences", [])
-                        for sentence in protocol_sentences:
-                            sentence_id = sentence.get("sentence_id", None)
-                            if sentence_id:
-                                yield sentence_id, sentence
-                    else:
-                        yield id_, sample
+                with open(filepath, encoding="utf-8") as f:
+                    for line in f:
+                        sample = {}
+                        try:
+                            row = json.loads(line)
+                        except Exception as e:
+                            print(f'couldnt load sample. error was: {e}. Continuing to next sample')
+                            continue
+                        id_ = row.get(id_field_name, None)
+                        if id_ is None:
+                            print(f"Key '{id_field_name}' not found in row. Skipping this row. row is: {row}")
+                            continue
+                        for feature in self._info().features:
+                            sample[feature] = row[feature]
+                        try:
+                            yield id_, sample
+                        except Exception as e:
+                            print(f'couldnt yield sample. error: {e}. sample is: {sample}.', flush=True)
             except Exception as e:
-                print(f"Error processing file '{filepath}': {e}. Skipping.")
+                print(f"Error opening file '{filepath}': {e}. Skipping.")
+
+
+
+
+
+