NCC tests now pass

README.md

@@ -21,10 +21,10 @@ configs:
   data_files:
   - split: train
     path: data/ncc_books/*.parquet
-- config_name: ncc_newspapers
+- config_name: ncc_newspaper
   data_files:
   - split: train
-    path: data/ncc_newspapers/*.parquet
+    path: data/ncc_newspaper/*.parquet
 - config_name: ncc_maalfrid
   data_files:
   - split: train
@@ -141,22 +141,6 @@ configs:
   data_files:
   - split: train
     path: data/nota/*.parquet
-- config_name: ncc_newspapers
-  data_files:
-  - split: train
-    path: data/ncc_newspapers/*.parquet
-- config_name: ncc_books
-  data_files:
-  - split: train
-    path: data/ncc_books/*.parquet
-- config_name: ncc_maalfrid
-  data_files:
-  - split: train
-    path: data/ncc_maalfrid/*.parquet
-- config_name: ncc_parliament
-  data_files:
-  - split: train
-    path: data/ncc_parliament/*.parquet
 annotations_creators:
 - no-annotation
 language_creators:
@@ -190,7 +174,7 @@ https://github.com/huggingface/datasets/blob/main/templates/README_guide.md
 <!-- START README TABLE -->
 |              |                                                                                                                                                             |
 | ------------ | ----------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| **Version** | 1.1.0 ([Changelog](/CHANGELOG.md)) |
+| **Version**  | 1.1.0 ([Changelog](/CHANGELOG.md))                                                                                                                          |
 | **Language** | dan, dansk, Danish                                                                                                                                          |
 | **License**  | Openly Licensed, See the respective dataset                                                                                                                 |
 | **Models**   | For model trained used this data see [danish-foundation-models](https://huggingface.co/danish-foundation-models)                                            |
@@ -417,12 +401,22 @@ TODO:
 
 
 ### Dataset Statistics
+The following plot show the domains distribution of the following within the dynaword:
+
+<p align="center">
+<img src="./images/domain_distribution.png" width="600" style="margin-right: 10px;" />
+</p>
+
+
 
+<details>
+<summary>Per dataset histograms</summary>
 <!-- START-DATASET PLOTS -->
 <p align="center">
 <img src="./images/dist_document_length.png" width="600" style="margin-right: 10px;" />
 </p>
 <!-- END-DATASET PLOTS -->
+</details>
 
 ## Additional Information
 

data/ncc_books/ncc_books.md

@@ -9,6 +9,8 @@ task_categories:
   - fill-mask
 task_ids:
   - language-modeling
+domains:
+- Books
 ---
 
 # Dataset Card for Norwegian Colossal Corpus (books)

data/ncc_maalfrid/ncc_maalfrid.md

@@ -9,6 +9,8 @@ task_categories:
   - fill-mask
 task_ids:
   - language-modeling
+domains:
+- Web
 ---
 
 # Dataset Card for Norwegian Colossal Corpus (maalfrid)

data/ncc_newspaper/ncc_newspaper.parquet

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:9c7c54cb4d95bafb3863b1a1560d8192adfb20e28fe26a02b78ddee4e08dd109
-size 2409158
+oid sha256:6876f892b2ce4e0ca59fc19d6742547fb909edfe28e33466ad172420770311d2
+size 2419112

data/ncc_parliament/ncc_parliament.md

@@ -9,6 +9,8 @@ task_categories:
   - fill-mask
 task_ids:
   - language-modeling
+domains:
+  - Other
 ---
 
 # Dataset Card for Norwegian Colossal Corpus (parliament)

src/dynaword/dataset_structure.py

@@ -18,7 +18,6 @@ class SampleSchema(BaseModel):
     id: str
     text: str
     source: str
-    domain: str  # TODO: convert to literal
     added: date
     created: Annotated[tuple[date, date], BeforeValidator(ensure_tuple)]
     token_count: int

src/dynaword/plots.py

@@ -2,36 +2,12 @@ import logging
 from pathlib import Path
 
 import pandas as pd
-import plotly.express as px
 import plotnine as pn
 from datasets import Dataset
 
-from dynaword.tables import create_overview_table
-
 logger = logging.getLogger(__name__)
 
 
-def create_domain_distribution_plot(
-    save_dir: Path,
-):
-    df = create_overview_table(
-        add_readable_tokens=False, add_total_row=False, add_readme_references=False
-    )
-    fig = px.sunburst(df, path=["Domain", "Source"], values="N. Tokens")
-
-    fig.update_traces(textinfo="label+percent entry")
-    fig.update_layout(title="Dataset Distribution by Domain and Source")
-
-    img_path = save_dir / "images"
-    img_path.mkdir(parents=False, exist_ok=True)
-    save_path = img_path / "domain_distribution.png"
-    fig.write_image(
-        save_path,
-        width=800,
-        height=800,
-        scale=2,
-    )
-
 def create_descriptive_statistics_plots(
     dataset: Dataset,
     save_dir: Path,

src/dynaword/typings.py

@@ -3,7 +3,6 @@ from typing import Literal
 DOMAIN = Literal[
     "Books",
     "Conversation",
-    "Conversations",
     "Dialect",
     "Encyclopedic",
     "Legal",

src/dynaword/update_descriptive_statistics.py

@@ -13,6 +13,7 @@ import logging
 from pathlib import Path
 from typing import cast
 
+import plotly.express as px
 from datasets import Dataset, load_dataset
 
 from dynaword.datasheet import DataSheet
@@ -22,7 +23,7 @@ from dynaword.git_utilities import (
     get_latest_revision,
 )
 from dynaword.paths import repo_path
-from dynaword.tables import create_overview_table_str
+from dynaword.tables import create_overview_table, create_overview_table_str
 
 logger = logging.getLogger(__name__)
 
@@ -34,6 +35,31 @@ _datasets = [
 ]
 
 
+logger = logging.getLogger(__name__)
+
+
+def create_domain_distribution_plot(
+    save_dir: Path = repo_path,
+):
+    df = create_overview_table(
+        add_readable_tokens=False, add_total_row=False, add_readme_references=False
+    )
+    fig = px.sunburst(df, path=["Domain", "Source"], values="N. Tokens")
+
+    fig.update_traces(textinfo="label+percent entry")
+    fig.update_layout(title="Dataset Distribution by Domain and Source")
+
+    img_path = save_dir / "images"
+    img_path.mkdir(parents=False, exist_ok=True)
+    save_path = img_path / "domain_distribution.png"
+    fig.write_image(
+        save_path,
+        width=800,
+        height=800,
+        scale=2,
+    )
+
+
 def update_dataset(
     dataset_name: str,
     force: bool = False,
@@ -79,6 +105,8 @@ def update_dataset(
         logger.info("Updating Overview table")
         package = create_overview_table_str()
         sheet.body = sheet.replace_tag(package=package, tag="MAIN TABLE")
+        package = create_domain_distribution_plot()
+        sheet.body = sheet.replace_tag(package=package, tag="DOMAIN PLOT")
 
     sheet.write_to_path()
 

src/tests/test_unique_ids.py

@@ -1,3 +1,4 @@
+from collections import Counter
 from typing import cast
 
 from datasets import Dataset, load_dataset
@@ -9,4 +10,6 @@ def test_ensure_ids_are_unique():
     name = str(repo_path.resolve())
     ds = load_dataset(name, split="train")
     ds = cast(Dataset, ds)
-    assert len(set(ds["id"])) == len(ds)
+    counter = Counter(ds["id"])
+    duplicates = [item for item, count in counter.items() if count > 1]
+    assert len(duplicates) == 0, f"Duplicate IDs found: {duplicates}"