fix infinite image loading

app.py

@@ -245,12 +245,12 @@ def predict_depth(input_image):
 
         print("Depth map created!")
         print(f"Returning - output_path: {output_path}, focallength_px: {focallength_px}, raw_depth_path: {raw_depth_path}, temp_file: {temp_file}")
-        return output_path, f"Focal length: {focallength_px:.2f} pixels", raw_depth_path, temp_file, focallength_px
+        return output_path, f"Focal length: {focallength_px:.2f} pixels", raw_depth_path, focallength_px
     except Exception as e:
         import traceback
         error_message = f"An error occurred: {str(e)}\n\nTraceback:\n{traceback.format_exc()}"
         print(error_message)
-        return None, error_message, None, None, None
+        return None, error_message, None, None
     finally:
         if temp_file and os.path.exists(temp_file):
             os.remove(temp_file)
@@ -324,24 +324,23 @@ with gr.Blocks() as iface:
     model_status = gr.Textbox(label="3D Model Status")
     
     # Hidden components to store intermediate results
-    hidden_image_path = gr.State("temp_input_image.png")
     hidden_focal_length = gr.State()
     
     input_image.change(
-        lambda x: (x, x),  # This lambda function returns the image path twice
+        predict_depth,
         inputs=[input_image],
-        outputs=[hidden_image_path, input_image]  # Update hidden_image_path and keep the visible input_image
+        outputs=[depth_map, focal_length, raw_depth_csv, hidden_focal_length]
     )
     
     generate_3d_button.click(
         create_3d_model,
-        inputs=[raw_depth_csv, hidden_image_path, hidden_focal_length, simplification_factor, smoothing_iterations, thin_threshold],
+        inputs=[raw_depth_csv, input_image, hidden_focal_length, simplification_factor, smoothing_iterations, thin_threshold],
         outputs=[view_3d_model, download_3d_model, model_status]
     )
     
     regenerate_button.click(
         create_3d_model,
-        inputs=[raw_depth_csv, hidden_image_path, hidden_focal_length, simplification_factor, smoothing_iterations, thin_threshold],
+        inputs=[raw_depth_csv, input_image, hidden_focal_length, simplification_factor, smoothing_iterations, thin_threshold],
         outputs=[view_3d_model, download_3d_model, model_status]
     )
 

history.md

@@ -1,5 +1,11 @@
 # Change Log
 
+## 2024-10-05 22:00 PST
+### Infinite Image Reloading Issue
+- Problem: After recent changes, dragging an image into the interface causes it to flicker and continuously reload. The depth prediction does not run.
+- Suspected cause: Recent modifications to the input handling in the Gradio interface, particularly the `input_image.change` event.
+- Next steps: Revert the changes to the input handling and investigate a different approach to manage the image path.
+
 ## 2024-10-05 21:20 PST
 ### 3D Model Generation File Access Error
 - Problem: When attempting to generate the 3D model, an error occurred: "[Errno 2] No such file or directory: '/tmp/tmppgls861k.png'"