Update app.py

app.py

@@ -27,7 +27,7 @@ class AIEvaluationForm:
         components = {}
         
         with gr.Group():
-            gr.Markdown("## 📋 AI System Information")
+            gr.Markdown("## System Information")
             gr.Markdown("*Please provide basic information about the AI system being evaluated.*")
             
             components['name'] = gr.Textbox(
@@ -61,7 +61,7 @@ class AIEvaluationForm:
                 info="Primary category of the AI system"
             )
             
-            components['input modalities'] = gr.CheckboxGroup(
+            components['input_modalities'] = gr.CheckboxGroup(
                 choices=[
                     "Text",
                     "Image", 
@@ -71,10 +71,10 @@ class AIEvaluationForm:
                 ],
                 label="Input modalities (select all that apply)",
                 value=["Text"],
-                info="input modalities supported by the system"
+                info="Input modalities supported by the system"
             )
 
-            components['output modalities'] = gr.CheckboxGroup(
+            components['output_modalities'] = gr.CheckboxGroup(
                 choices=[
                     "Text",
                     "Image", 
@@ -84,7 +84,7 @@ class AIEvaluationForm:
                 ],
                 label="Output Modalities (select all that apply)",
                 value=["Text"],
-                info="output modalities supported by the system"
+                info="Output modalities supported by the system"
             )
         
         return list(components.values()), components
@@ -163,13 +163,13 @@ class AIEvaluationForm:
                 
             # Determine source type based on content
             if line.startswith('http'):
-                source_type = "🌐"
+                source_type = "Web"
                 name = line.split('/')[-1] if '/' in line else line
             elif 'internal' in line.lower() or 'proprietary' in line.lower():
-                source_type = "🏢"
+                source_type = "Internal"
                 name = line
             else:
-                source_type = "📄"
+                source_type = "Document"
                 name = line
             
             sources.append({
@@ -179,6 +179,17 @@ class AIEvaluationForm:
             })
         
         return sources
+
+    def load_uploaded_json(self, file):
+        """Load JSON from uploaded file"""
+        if file is None:
+            return {}
+        try:
+            with open(file.name, 'r') as f:
+                return json.load(f)
+        except Exception as e:
+            return {"error": str(e)}
+
         
     def generate_scorecard(self, *args) -> Tuple[Dict, str]:
         """Generate scorecard JSON from form inputs"""
@@ -187,10 +198,9 @@ class AIEvaluationForm:
         for i, arg in enumerate(args[:10]):  # Print first 10 for debugging
             print(f"Arg {i}: {type(arg)} = {arg}")
         
-        # Extract system info (first num_args arguments)
-        num_args = 6
-        name, provider, url, sys_type, inp_modalities, out_modalities = args[:num_args]
-        remaining_args = list(args[num_args:])
+        # Extract system info (first 6 arguments)
+        name, provider, url, sys_type, inp_modalities, out_modalities = args[:6]
+        remaining_args = list(args[6:])
         
         # Build metadata
         metadata = {
@@ -308,7 +318,7 @@ class AIEvaluationForm:
             
             # Header
             gr.Markdown("""
-            # 🔍 AI System Evaluation Scorecard
+            # AI System Evaluation Scorecard
             
             This comprehensive evaluation form helps you assess AI systems across multiple dimensions including bias, 
             cultural sensitivity, environmental impact, privacy, and more. Complete the sections relevant to your system 
@@ -326,17 +336,17 @@ class AIEvaluationForm:
             
             # Generate button and outputs
             with gr.Group():
-                gr.Markdown("## 📊 Generate Scorecard")
+                gr.Markdown("## Generate Scorecard")
                 
                 with gr.Row():
                     generate_btn = gr.Button(
-                        "🚀 Generate Evaluation Scorecard", 
+                        "Generate Evaluation Scorecard", 
                         variant="primary", 
                         size="lg",
                         scale=2
                     )
                     clear_btn = gr.Button(
-                        "🗑️ Clear Form", 
+                        "Clear Form", 
                         variant="secondary",
                         scale=1
                     )
@@ -346,7 +356,7 @@ class AIEvaluationForm:
                 
                 # Outputs
                 with gr.Group():
-                    gr.Markdown("### 📋 Generated Scorecard")
+                    gr.Markdown("### Generated Scorecard")
                     
                     with gr.Row():
                         json_output = gr.JSON(
@@ -359,13 +369,6 @@ class AIEvaluationForm:
                             label="Download Scorecard",
                             visible=False
                         )
-                        download_btn = gr.Button(
-                            "💾 Download JSON",
-                            visible=False,
-                            variant="secondary"
-                        )
-                        # Hidden HTML component for triggering downloads
-                        download_html = gr.HTML(visible=False)
             
             # Event handlers
             all_inputs = system_inputs + eval_inputs
@@ -386,25 +389,9 @@ class AIEvaluationForm:
                 
                 return (
                     scorecard,  # JSON display
-                    gr.File(value=filename, visible=True),  # File for download
-                    gr.Button(visible=True),  # Show download button
-                    gr.HTML(visible=False)  # Hidden HTML for download trigger
+                    gr.File(value=filename, visible=True)  # File for download
                 )
-
-            def trigger_download():
-                """Trigger file download via JavaScript"""
-                return gr.HTML("""
-                <script>
-                    // Find the download link and click it
-                    setTimeout(() => {
-                        const downloadLinks = document.querySelectorAll('a[download]');
-                        if (downloadLinks.length > 0) {
-                            downloadLinks[downloadLinks.length - 1].click();
-                        }
-                    }, 100);
-                </script>
-                """, visible=False)
-                
+            
             def clear_form():
                 """Clear all form inputs"""
                 return [None] * len(all_inputs)
@@ -413,16 +400,10 @@ class AIEvaluationForm:
             generate_btn.click(
                 fn=generate_with_progress,
                 inputs=all_inputs,
-                outputs=[json_output, download_file, download_btn, download_html],
+                outputs=[json_output, download_file],
                 show_progress="full"
             )
             
-            # Wire up download button to trigger download
-            download_btn.click(
-                fn=trigger_download,
-                outputs=download_html
-            )
-            
             clear_btn.click(
                 fn=clear_form,
                 outputs=all_inputs
@@ -430,8 +411,8 @@ class AIEvaluationForm:
             
             # Add example data button
             with gr.Group():
-                gr.Markdown("### 📚 Quick Start")
-                example_btn = gr.Button("📝 Load Example Data", variant="secondary")
+                gr.Markdown("### Quick Start")
+                example_btn = gr.Button("Load Example Data", variant="secondary")
                 
                 def load_example():
                     """Load example data for StarCoder2-like system"""
@@ -440,8 +421,8 @@ class AIEvaluationForm:
                         "BigCode",     # provider  
                         "https://huggingface.co/bigcode/starcoder2-15b",  # url
                         "Generative Model",  # type
-                        ["Text"],  # input modalities
-                        ["Text"],  # output modalities
+                        ["Text"],  # input modalities - FIXED: Added missing comma
+                        ["Text"]   # output modalities
                     ]
                     # Add default values for evaluation sections (all N/A initially)
                     remaining_defaults = []
@@ -459,28 +440,21 @@ class AIEvaluationForm:
                     fn=load_example,
                     outputs=all_inputs
                 )
+            
             with gr.Group():
-                gr.Markdown("### 📤 Upload Completed Evaluation JSON")
+                gr.Markdown("### Upload Completed Evaluation JSON")
                 uploaded_file = gr.File(label="Upload JSON File", file_types=[".json"])
                 uploaded_preview = gr.JSON(label="Preview of Uploaded Content")
-                uploaded_file.change(fn=load_uploaded_json, inputs=uploaded_file, outputs=uploaded_preview)
+                uploaded_file.change(fn=self.load_uploaded_json, inputs=uploaded_file, outputs=uploaded_preview)
 
             gr.Markdown("""
-                ### 📬 Submit Your Scorecard to the Eval Cards Repository
+                ### Submit Your Scorecard to the Eval Cards Repository
                 Once downloaded, you can contribute by submitting a pull request to [Eval Cards GitHub](https://github.com/evaleval/Eval_Cards).
                 Place your file in the `submissions/` directory.
             """)
 
         return demo
-
-def load_uploaded_json(file):
-    if file is None:
-        return {}
-    try:
-        with open(file.name, 'r') as f:
-            return json.load(f)
-    except Exception as e:
-        return {"error": str(e)}
+        
 
 def main():
     """Main function to run the application"""
@@ -491,9 +465,9 @@ def main():
         # Create and launch the interface
         demo = eval_form.create_interface()
         
-        print("🚀 Launching AI Evaluation Scorecard...")
-        print(f"📁 Loading questions from: {eval_form.template_file}")
-        print(f"📊 Found {len(eval_form.template)} evaluation categories")
+        print("Launching AI Evaluation Scorecard...")
+        print(f"Loading questions from: {eval_form.template_file}")
+        print(f"Found {len(eval_form.template)} evaluation categories")
         
         # Count total questions
         total_questions = sum(
@@ -501,7 +475,7 @@ def main():
             for section in eval_form.template.values() 
             for subsection in section.values()
         )
-        print(f"❓ Total evaluation questions: {total_questions}")
+        print(f"Total evaluation questions: {total_questions}")
         
         demo.launch(
             ssr_mode=False,
@@ -512,10 +486,10 @@ def main():
         )
         
     except FileNotFoundError as e:
-        print(f"❌ Error: {e}")
+        print(f"Error: {e}")
         print("Please ensure 'questions.yaml' exists in the current directory.")
     except Exception as e:
-        print(f"❌ Unexpected error: {e}")
+        print(f"Unexpected error: {e}")
 
 if __name__ == "__main__":
     main()