Commit
·
168c8d9
1
Parent(s):
74057de
Remove Redundant None Check for vector_similarity_weight (#4037)
Browse files### What problem does this PR solve?
The removed if statement is unnecessary and adds cognitive load for
readers.
The original code:
```
vector_similarity_weight = req.get("vector_similarity_weight", 0.3)
if vector_similarity_weight is None:
vector_similarity_weight = 0.3
```
has been simplified to:
```
vector_similarity_weight = req.get("vector_similarity_weight", 0.3)
```
### Type of change
- [x] Refactoring
- api/apps/dialog_app.py +0 -2
api/apps/dialog_app.py
CHANGED
@@ -41,8 +41,6 @@ def set_dialog():
|
|
41 |
req["rerank_id"] = ""
|
42 |
similarity_threshold = req.get("similarity_threshold", 0.1)
|
43 |
vector_similarity_weight = req.get("vector_similarity_weight", 0.3)
|
44 |
-
if vector_similarity_weight is None:
|
45 |
-
vector_similarity_weight = 0.3
|
46 |
llm_setting = req.get("llm_setting", {})
|
47 |
default_prompt = {
|
48 |
"system": """你是一个智能助手,请总结知识库的内容来回答问题,请列举知识库中的数据详细回答。当所有知识库内容都与问题无关时,你的回答必须包括“知识库中未找到您要的答案!”这句话。回答需要考虑聊天历史。
|
|
|
41 |
req["rerank_id"] = ""
|
42 |
similarity_threshold = req.get("similarity_threshold", 0.1)
|
43 |
vector_similarity_weight = req.get("vector_similarity_weight", 0.3)
|
|
|
|
|
44 |
llm_setting = req.get("llm_setting", {})
|
45 |
default_prompt = {
|
46 |
"system": """你是一个智能助手,请总结知识库的内容来回答问题,请列举知识库中的数据详细回答。当所有知识库内容都与问题无关时,你的回答必须包括“知识库中未找到您要的答案!”这句话。回答需要考虑聊天历史。
|