Datasets:

akumoth

/

peewee-issues

like 0

{ "login": "ascaron37", "id": 8329544, "node_id": "MDQ6VXNlcjgzMjk1NDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/8329544?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ascaron37", "html_url": "https://github.com/ascaron37", "followers_url": "https://api.github.com/users/ascaron37/followers", "following_url": "https://api.github.com/users/ascaron37/following{/other_user}", "gists_url": "https://api.github.com/users/ascaron37/gists{/gist_id}", "starred_url": "https://api.github.com/users/ascaron37/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ascaron37/subscriptions", "organizations_url": "https://api.github.com/users/ascaron37/orgs", "repos_url": "https://api.github.com/users/ascaron37/repos", "events_url": "https://api.github.com/users/ascaron37/events{/privacy}", "received_events_url": "https://api.github.com/users/ascaron37/received_events", "type": "User", "site_admin": false }

[]

[]

[ "So the reason the drop doesn't work is because Peewee, when \"safe=True\" (the default), attempts to check if the table exists in the current db. To get this working, you can just specify `safe=False`:\r\n\r\n```python\r\n# This will skip the check that the table exists, and then issue the\r\n# appropriate drop table.\r\ndb1.drop_tables([Model2], safe=False)\r\n```", "Perfect, thank you!" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2519/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Ahern542968", "id": 32890883, "node_id": "MDQ6VXNlcjMyODkwODgz", "avatar_url": "https://avatars.githubusercontent.com/u/32890883?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Ahern542968", "html_url": "https://github.com/Ahern542968", "followers_url": "https://api.github.com/users/Ahern542968/followers", "following_url": "https://api.github.com/users/Ahern542968/following{/other_user}", "gists_url": "https://api.github.com/users/Ahern542968/gists{/gist_id}", "starred_url": "https://api.github.com/users/Ahern542968/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Ahern542968/subscriptions", "organizations_url": "https://api.github.com/users/Ahern542968/orgs", "repos_url": "https://api.github.com/users/Ahern542968/repos", "events_url": "https://api.github.com/users/Ahern542968/events{/privacy}", "received_events_url": "https://api.github.com/users/Ahern542968/received_events", "type": "User", "site_admin": false }

[]

[]

[ "http://docs.peewee-orm.com/en/latest/peewee/playhouse.html#pool\r\n\r\nYou are not managing your connections.\r\n\r\nCall connect at the beginning of a request/thread, and close() at the end. This ensures that your conns are returned to the pool." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2518/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "spacialhufman", "id": 33603355, "node_id": "MDQ6VXNlcjMzNjAzMzU1", "avatar_url": "https://avatars.githubusercontent.com/u/33603355?v=4", "gravatar_id": "", "url": "https://api.github.com/users/spacialhufman", "html_url": "https://github.com/spacialhufman", "followers_url": "https://api.github.com/users/spacialhufman/followers", "following_url": "https://api.github.com/users/spacialhufman/following{/other_user}", "gists_url": "https://api.github.com/users/spacialhufman/gists{/gist_id}", "starred_url": "https://api.github.com/users/spacialhufman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/spacialhufman/subscriptions", "organizations_url": "https://api.github.com/users/spacialhufman/orgs", "repos_url": "https://api.github.com/users/spacialhufman/repos", "events_url": "https://api.github.com/users/spacialhufman/events{/privacy}", "received_events_url": "https://api.github.com/users/spacialhufman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Peewee will generate that `0 = 1` when you write an expression that evalutes to `WHERE x IN ()` (which is always false):\r\n\r\n```python\r\n.where(Model.field.in_([]))\r\n```\r\n\r\nSo in your example, at least one of your lists is empty, or alternatively your `tickets` iterator is a generator or something and returns a list, but when iterated the 2nd time it is consumed and returns an empty list." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2517/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "LLjiahai", "id": 30220658, "node_id": "MDQ6VXNlcjMwMjIwNjU4", "avatar_url": "https://avatars.githubusercontent.com/u/30220658?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LLjiahai", "html_url": "https://github.com/LLjiahai", "followers_url": "https://api.github.com/users/LLjiahai/followers", "following_url": "https://api.github.com/users/LLjiahai/following{/other_user}", "gists_url": "https://api.github.com/users/LLjiahai/gists{/gist_id}", "starred_url": "https://api.github.com/users/LLjiahai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LLjiahai/subscriptions", "organizations_url": "https://api.github.com/users/LLjiahai/orgs", "repos_url": "https://api.github.com/users/LLjiahai/repos", "events_url": "https://api.github.com/users/LLjiahai/events{/privacy}", "received_events_url": "https://api.github.com/users/LLjiahai/received_events", "type": "User", "site_admin": false }

[]

[]

[ "In this case, just instantiate the introspector directly - or pass it the underlying db instance:\r\n\r\n```python\r\n# Option 1:\r\nintrospector = Introspector(MySQLMetadata(database))\r\nintrospector.generate_models()\r\n\r\n# Option 2:\r\nmodels = generate_models(db.obj)\r\n```", "I gave this another look and made a better fix. Going forward introspection will work with a proxy just fine." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2516/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "peepo5", "id": 72892531, "node_id": "MDQ6VXNlcjcyODkyNTMx", "avatar_url": "https://avatars.githubusercontent.com/u/72892531?v=4", "gravatar_id": "", "url": "https://api.github.com/users/peepo5", "html_url": "https://github.com/peepo5", "followers_url": "https://api.github.com/users/peepo5/followers", "following_url": "https://api.github.com/users/peepo5/following{/other_user}", "gists_url": "https://api.github.com/users/peepo5/gists{/gist_id}", "starred_url": "https://api.github.com/users/peepo5/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/peepo5/subscriptions", "organizations_url": "https://api.github.com/users/peepo5/orgs", "repos_url": "https://api.github.com/users/peepo5/repos", "events_url": "https://api.github.com/users/peepo5/events{/privacy}", "received_events_url": "https://api.github.com/users/peepo5/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You need to read the documentation.\r\n\r\nTake 10 or 15 minutes and go through the quick start.\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/quickstart.html#retrieving-data", "So I have to iterate over the select to get any results? Your answer to my question did not help.", "http://docs.peewee-orm.com/en/latest/peewee/querying.html#selecting-a-single-record\r\n\r\nhttp://docs.peewee-orm.com/en/latest/peewee/querying.html#selecting-multiple-records", "To answer my own question, yes you must iterate. @coleifer are there any ways of not iterating to save time? like recieving an array of classes instead of just something to iterate upon. Thanks. And please give some explanation rather than just sending a link, thank you.", "https://docs.python.org/3/library/functions.html#func-list" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2515/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "xfl12345", "id": 17960863, "node_id": "MDQ6VXNlcjE3OTYwODYz", "avatar_url": "https://avatars.githubusercontent.com/u/17960863?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xfl12345", "html_url": "https://github.com/xfl12345", "followers_url": "https://api.github.com/users/xfl12345/followers", "following_url": "https://api.github.com/users/xfl12345/following{/other_user}", "gists_url": "https://api.github.com/users/xfl12345/gists{/gist_id}", "starred_url": "https://api.github.com/users/xfl12345/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xfl12345/subscriptions", "organizations_url": "https://api.github.com/users/xfl12345/orgs", "repos_url": "https://api.github.com/users/xfl12345/repos", "events_url": "https://api.github.com/users/xfl12345/events{/privacy}", "received_events_url": "https://api.github.com/users/xfl12345/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The `help_text` and `verbose_name` are used for integrations with flask-peewee (or other user-facing applications) and do not have any impact on the schema." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2514/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "neutralvibes", "id": 26578830, "node_id": "MDQ6VXNlcjI2NTc4ODMw", "avatar_url": "https://avatars.githubusercontent.com/u/26578830?v=4", "gravatar_id": "", "url": "https://api.github.com/users/neutralvibes", "html_url": "https://github.com/neutralvibes", "followers_url": "https://api.github.com/users/neutralvibes/followers", "following_url": "https://api.github.com/users/neutralvibes/following{/other_user}", "gists_url": "https://api.github.com/users/neutralvibes/gists{/gist_id}", "starred_url": "https://api.github.com/users/neutralvibes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/neutralvibes/subscriptions", "organizations_url": "https://api.github.com/users/neutralvibes/orgs", "repos_url": "https://api.github.com/users/neutralvibes/repos", "events_url": "https://api.github.com/users/neutralvibes/events{/privacy}", "received_events_url": "https://api.github.com/users/neutralvibes/received_events", "type": "User", "site_admin": false }

[]

[]

[ "~~Despite spending a few hours on it, a slap from myself helped me realise that perhaps OrderedDict isn't being used, despite database fields seemingly reproduced in reliable in order.~~ Nope, dict keys became reliably ordered from python 3.7.", "Dict keys are not sorted -- exactly. This is not an issue in my opinion, this is just the nature of dictionaries. A dictionary is an inherently unordered data-structure, and while later Python preserves the insert order, it's not something to rely upon.\r\n\r\nYou already have your list of attrs - so you probably want to do something like: `table.append([getattr(model, attr) for attr in list_of_attrs])`. Or just pull the keys out of the resulting dict in the order you need them.", "First, many thanks for reviewing.\r\n\r\nDicts have guaranteed order as of python 3.7 so can be relied upon. \r\n I have looked at the underlyng code and the reason is you convert the input to a `Set`. The reason for the lack of stability is because of a shortcut you use to convert the input.\r\n\r\n~~~python\r\n_clone_set = lambda s: set(s) if s else set()\r\n~~~\r\n\r\nSets still do not have this assurance, and I wonder if using a List would be better saving on converting many rows of data for the sake of it. I bow to your superior knowledge so shall leave it there.\r\n\r\nThanks again.", "We don't bow to anyone in Peewee!\r\n\r\nI think my recommendation to you is the same:\r\n\r\n* either do not use `model_to_dict()` and just grab the attrs you want explicitly\r\n* or, once you have the dict back, pull the fields out of it explicitly using a list comprehension or the like" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2513/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "est", "id": 23570, "node_id": "MDQ6VXNlcjIzNTcw", "avatar_url": "https://avatars.githubusercontent.com/u/23570?v=4", "gravatar_id": "", "url": "https://api.github.com/users/est", "html_url": "https://github.com/est", "followers_url": "https://api.github.com/users/est/followers", "following_url": "https://api.github.com/users/est/following{/other_user}", "gists_url": "https://api.github.com/users/est/gists{/gist_id}", "starred_url": "https://api.github.com/users/est/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/est/subscriptions", "organizations_url": "https://api.github.com/users/est/orgs", "repos_url": "https://api.github.com/users/est/repos", "events_url": "https://api.github.com/users/est/events{/privacy}", "received_events_url": "https://api.github.com/users/est/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Did you not read the [code comment](https://github.com/coleifer/peewee/blob/master/peewee.py#L658-L661)? This is not part of the public API.", "> Did you not read the code comment? This is not part of the public API.\r\n\r\nHi coleifer, I am using `logger.debug(\"sql is %s\", query)` with one of the parameter as a customized mysql BINARY field. I think it fits the code comment of \"This function is intended for debugging or logging purposes ONLY\".\r\n\r\nUnless there's another way to debug the SQL I am unaware of?\r\n", "The correct way to do this is:\r\n\r\n```python\r\n\r\nquery = MyModel.select().where(MyModel.foo == 'bar')\r\nsql, params = query.sql()\r\n```\r\n\r\nYou can inspect the sql string, which contains proper placeholders for the parameters, and the parameters themselves." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2512/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "conqp", "id": 3766192, "node_id": "MDQ6VXNlcjM3NjYxOTI=", "avatar_url": "https://avatars.githubusercontent.com/u/3766192?v=4", "gravatar_id": "", "url": "https://api.github.com/users/conqp", "html_url": "https://github.com/conqp", "followers_url": "https://api.github.com/users/conqp/followers", "following_url": "https://api.github.com/users/conqp/following{/other_user}", "gists_url": "https://api.github.com/users/conqp/gists{/gist_id}", "starred_url": "https://api.github.com/users/conqp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/conqp/subscriptions", "organizations_url": "https://api.github.com/users/conqp/orgs", "repos_url": "https://api.github.com/users/conqp/repos", "events_url": "https://api.github.com/users/conqp/events{/privacy}", "received_events_url": "https://api.github.com/users/conqp/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Please consult the docs here: http://docs.peewee-orm.com/en/latest/peewee/relationships.html#avoiding-the-n-1-problem\r\n\r\nFurthermore, you cannot go from \"many\" -> \"many\" in a single go without using prefetch. You can join \"upwards\" no problem, e.g., select all Systems and also grab their Deployment:\r\n\r\n```python\r\n# This executes in a single query.\r\nquery = System.select(System, Deployment).join(Deployment)\r\nfor system in query:\r\n print(system.id, system.deployment.annotation)\r\n```\r\n\r\nWe cannot do the reverse automatically, e.g., get deployments and all their systems, because of SQL's tabular nature.\r\n\r\nSo you can either:\r\n\r\n1. Use `prefetch()` (although I strongly advise profiling this beforehand to see if it actually provides any measurable improvements)\r\n2. Use N+1, e.g., for each deployment also query its systems.\r\n\r\nAlso note that in your first query you are not actually aggregating anything, and the query probably doesn't do what you think it does.\r\n\r\nThe docs provide many examples: http://docs.peewee-orm.com/en/latest/peewee/relationships.html#avoiding-the-n-1-problem\r\n\r\nLastly, queries generated by accessing a backref are not cached -- accessing the backref creates a new query. If you want to iterate over a backref multiple times you can just assign it to a local variable:\r\n\r\n```python\r\n\r\nuser = User.get(User.username == 'charlie')\r\ntweets = user.tweets\r\n# Query is only evaluated once:\r\nfor t in tweets: pass\r\nfor t in tweets: pass\r\n```" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2511/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jonashaag", "id": 175722, "node_id": "MDQ6VXNlcjE3NTcyMg==", "avatar_url": "https://avatars.githubusercontent.com/u/175722?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonashaag", "html_url": "https://github.com/jonashaag", "followers_url": "https://api.github.com/users/jonashaag/followers", "following_url": "https://api.github.com/users/jonashaag/following{/other_user}", "gists_url": "https://api.github.com/users/jonashaag/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonashaag/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonashaag/subscriptions", "organizations_url": "https://api.github.com/users/jonashaag/orgs", "repos_url": "https://api.github.com/users/jonashaag/repos", "events_url": "https://api.github.com/users/jonashaag/events{/privacy}", "received_events_url": "https://api.github.com/users/jonashaag/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks, this method now accepts a model class." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2510/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "1kastner", "id": 5236165, "node_id": "MDQ6VXNlcjUyMzYxNjU=", "avatar_url": "https://avatars.githubusercontent.com/u/5236165?v=4", "gravatar_id": "", "url": "https://api.github.com/users/1kastner", "html_url": "https://github.com/1kastner", "followers_url": "https://api.github.com/users/1kastner/followers", "following_url": "https://api.github.com/users/1kastner/following{/other_user}", "gists_url": "https://api.github.com/users/1kastner/gists{/gist_id}", "starred_url": "https://api.github.com/users/1kastner/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/1kastner/subscriptions", "organizations_url": "https://api.github.com/users/1kastner/orgs", "repos_url": "https://api.github.com/users/1kastner/repos", "events_url": "https://api.github.com/users/1kastner/events{/privacy}", "received_events_url": "https://api.github.com/users/1kastner/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm going to pass - I don't really see a need to export this." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2509/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "sherrrrr", "id": 31510228, "node_id": "MDQ6VXNlcjMxNTEwMjI4", "avatar_url": "https://avatars.githubusercontent.com/u/31510228?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sherrrrr", "html_url": "https://github.com/sherrrrr", "followers_url": "https://api.github.com/users/sherrrrr/followers", "following_url": "https://api.github.com/users/sherrrrr/following{/other_user}", "gists_url": "https://api.github.com/users/sherrrrr/gists{/gist_id}", "starred_url": "https://api.github.com/users/sherrrrr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sherrrrr/subscriptions", "organizations_url": "https://api.github.com/users/sherrrrr/orgs", "repos_url": "https://api.github.com/users/sherrrrr/repos", "events_url": "https://api.github.com/users/sherrrrr/events{/privacy}", "received_events_url": "https://api.github.com/users/sherrrrr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Here is an example (tested with mariadb 10.6):\r\n\r\n```python\r\nclass Reg(Model):\r\n key = CharField()\r\n value = TextField()\r\n\r\nReg.insert_many([('k%02d' % i, 'v%02d' % i) for i in range(100)]).execute()\r\ncols = Tuple(Reg.key, Reg.value)\r\nvalues = [('k02', 'v02'), ('k04', 'v04'), ('k06', 'v06')]\r\nquery = (Reg.select()\r\n .where(cols.in_(values))\r\n .order_by(Reg.key))\r\nfor reg in query:\r\n print(reg.key, reg.value)\r\n\r\n# Prints:\r\n# k02 v02\r\n# k04 v04\r\n# k06 v06\r\n```" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2508/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ashishkumarazuga", "id": 78608338, "node_id": "MDQ6VXNlcjc4NjA4MzM4", "avatar_url": "https://avatars.githubusercontent.com/u/78608338?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashishkumarazuga", "html_url": "https://github.com/ashishkumarazuga", "followers_url": "https://api.github.com/users/ashishkumarazuga/followers", "following_url": "https://api.github.com/users/ashishkumarazuga/following{/other_user}", "gists_url": "https://api.github.com/users/ashishkumarazuga/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashishkumarazuga/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashishkumarazuga/subscriptions", "organizations_url": "https://api.github.com/users/ashishkumarazuga/orgs", "repos_url": "https://api.github.com/users/ashishkumarazuga/repos", "events_url": "https://api.github.com/users/ashishkumarazuga/events{/privacy}", "received_events_url": "https://api.github.com/users/ashishkumarazuga/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This error is being thrown by your database, via your database driver, and is not raised by Peewee." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2507/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tirkarthi", "id": 3972343, "node_id": "MDQ6VXNlcjM5NzIzNDM=", "avatar_url": "https://avatars.githubusercontent.com/u/3972343?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tirkarthi", "html_url": "https://github.com/tirkarthi", "followers_url": "https://api.github.com/users/tirkarthi/followers", "following_url": "https://api.github.com/users/tirkarthi/following{/other_user}", "gists_url": "https://api.github.com/users/tirkarthi/gists{/gist_id}", "starred_url": "https://api.github.com/users/tirkarthi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tirkarthi/subscriptions", "organizations_url": "https://api.github.com/users/tirkarthi/orgs", "repos_url": "https://api.github.com/users/tirkarthi/repos", "events_url": "https://api.github.com/users/tirkarthi/events{/privacy}", "received_events_url": "https://api.github.com/users/tirkarthi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Steve Dower @zooba, a Microsoft employee, is railroading through this idiotic pep. From what I can see there are quite a few people who disagree with his decision:\r\n\r\nhttps://discuss.python.org/t/pep-632-deprecate-distutils-module/5134/29\r\n\r\nHe comes off as a smug, smarmy nitwit who cannot appreciate that real world users will be affected by this decision. Once again, Microsoft employees shitting up the party? Or just another petty tyrant who found a source of narcissistic supply in open source? You decide.", "As much as I sympathize with the reaction, the code should be updated in the future. It seems that the pep isn't going away.", "Fallback to the vendored distutils inside setuptools for now: 7ab5e401d85c1eec7aafbbe2fdf3c0344f82422b", "Anyone who stumbles upon this and can find examples of prior art for projects that build C extensions and are going through a similar migration, I'd appreciate links. I glanced around at a few projects I'm familiar with, and all of them are still on `distutils`." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2506/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tirkarthi", "id": 3972343, "node_id": "MDQ6VXNlcjM5NzIzNDM=", "avatar_url": "https://avatars.githubusercontent.com/u/3972343?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tirkarthi", "html_url": "https://github.com/tirkarthi", "followers_url": "https://api.github.com/users/tirkarthi/followers", "following_url": "https://api.github.com/users/tirkarthi/following{/other_user}", "gists_url": "https://api.github.com/users/tirkarthi/gists{/gist_id}", "starred_url": "https://api.github.com/users/tirkarthi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tirkarthi/subscriptions", "organizations_url": "https://api.github.com/users/tirkarthi/orgs", "repos_url": "https://api.github.com/users/tirkarthi/repos", "events_url": "https://api.github.com/users/tirkarthi/events{/privacy}", "received_events_url": "https://api.github.com/users/tirkarthi/received_events", "type": "User", "site_admin": false }

[]

[]

[ "That doesn't matter. The stdlib-provided mock is used for any python 3 or newer, and that old version is vendored for Python 2.x users.", "Got it, sorry for the noise." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2505/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "olvinroght", "id": 49984942, "node_id": "MDQ6VXNlcjQ5OTg0OTQy", "avatar_url": "https://avatars.githubusercontent.com/u/49984942?v=4", "gravatar_id": "", "url": "https://api.github.com/users/olvinroght", "html_url": "https://github.com/olvinroght", "followers_url": "https://api.github.com/users/olvinroght/followers", "following_url": "https://api.github.com/users/olvinroght/following{/other_user}", "gists_url": "https://api.github.com/users/olvinroght/gists{/gist_id}", "starred_url": "https://api.github.com/users/olvinroght/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/olvinroght/subscriptions", "organizations_url": "https://api.github.com/users/olvinroght/orgs", "repos_url": "https://api.github.com/users/olvinroght/repos", "events_url": "https://api.github.com/users/olvinroght/events{/privacy}", "received_events_url": "https://api.github.com/users/olvinroght/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Refer to the docs: https://www.postgresql.org/docs/current/datatype-json.html\r\n\r\nBut, simply, you cannot compare `json` values. I am not aware of any reason why you would want to use `json` over `jsonb`, so I would suggest that you just use `BinaryJSONField` (which additionally supports indexing).\r\n\r\nIf you really want to use `JSONField` then you should not use `get_or_create()` but instead use `insert(...).on_conflict()` and rely on a unique constraint." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2504/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "LLjiahai", "id": 30220658, "node_id": "MDQ6VXNlcjMwMjIwNjU4", "avatar_url": "https://avatars.githubusercontent.com/u/30220658?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LLjiahai", "html_url": "https://github.com/LLjiahai", "followers_url": "https://api.github.com/users/LLjiahai/followers", "following_url": "https://api.github.com/users/LLjiahai/following{/other_user}", "gists_url": "https://api.github.com/users/LLjiahai/gists{/gist_id}", "starred_url": "https://api.github.com/users/LLjiahai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LLjiahai/subscriptions", "organizations_url": "https://api.github.com/users/LLjiahai/orgs", "repos_url": "https://api.github.com/users/LLjiahai/repos", "events_url": "https://api.github.com/users/LLjiahai/events{/privacy}", "received_events_url": "https://api.github.com/users/LLjiahai/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2503/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "thisnugroho", "id": 49790011, "node_id": "MDQ6VXNlcjQ5NzkwMDEx", "avatar_url": "https://avatars.githubusercontent.com/u/49790011?v=4", "gravatar_id": "", "url": "https://api.github.com/users/thisnugroho", "html_url": "https://github.com/thisnugroho", "followers_url": "https://api.github.com/users/thisnugroho/followers", "following_url": "https://api.github.com/users/thisnugroho/following{/other_user}", "gists_url": "https://api.github.com/users/thisnugroho/gists{/gist_id}", "starred_url": "https://api.github.com/users/thisnugroho/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thisnugroho/subscriptions", "organizations_url": "https://api.github.com/users/thisnugroho/orgs", "repos_url": "https://api.github.com/users/thisnugroho/repos", "events_url": "https://api.github.com/users/thisnugroho/events{/privacy}", "received_events_url": "https://api.github.com/users/thisnugroho/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The `get_or_none()`, when used on a select query, does not accept any parameters -- though the error message is unhelpful here.\r\n\r\nIn your code you are:\r\n\r\n1. `SomeModel.select()` which creates a `ModelSelect` query\r\n2. Call the `get_or_none()` method on the `ModelSelect` query\r\n\r\nI think what you intended to do is this:\r\n\r\n```python\r\n\r\nSomeModel.select().where(SomeModel.field == value).get_or_none()\r\n```\r\n\r\nAlternatively, you can use the *shortcut* method on model, which *does* accept an expression:\r\n\r\n```python\r\n\r\nSomeModel.get_or_none(SomeModel.field == value)\r\n```\r\n\r\n* http://docs.peewee-orm.com/en/latest/peewee/api.html#Model.get_or_none" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2502/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "d0d0", "id": 553292, "node_id": "MDQ6VXNlcjU1MzI5Mg==", "avatar_url": "https://avatars.githubusercontent.com/u/553292?v=4", "gravatar_id": "", "url": "https://api.github.com/users/d0d0", "html_url": "https://github.com/d0d0", "followers_url": "https://api.github.com/users/d0d0/followers", "following_url": "https://api.github.com/users/d0d0/following{/other_user}", "gists_url": "https://api.github.com/users/d0d0/gists{/gist_id}", "starred_url": "https://api.github.com/users/d0d0/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/d0d0/subscriptions", "organizations_url": "https://api.github.com/users/d0d0/orgs", "repos_url": "https://api.github.com/users/d0d0/repos", "events_url": "https://api.github.com/users/d0d0/events{/privacy}", "received_events_url": "https://api.github.com/users/d0d0/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I don't really like this solution. The join will not correctly set-up the model graph, so the best solution in my opinion is to write:\r\n\r\n```python\r\nq = User.select(User, Tweet).from_(SQL(f'`users` as `t1` USE INDEX(`user_id`) ')).join(Tweet)\r\nfor x in q.objects():\r\n # assume username is on User table, and content is on Tweet table.\r\n print(x.username, x.content)\r\n```" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2501/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2501", "html_url": "https://github.com/coleifer/peewee/pull/2501", "diff_url": "https://github.com/coleifer/peewee/pull/2501.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2501.patch", "merged_at": null }

{ "login": "skontar", "id": 10827040, "node_id": "MDQ6VXNlcjEwODI3MDQw", "avatar_url": "https://avatars.githubusercontent.com/u/10827040?v=4", "gravatar_id": "", "url": "https://api.github.com/users/skontar", "html_url": "https://github.com/skontar", "followers_url": "https://api.github.com/users/skontar/followers", "following_url": "https://api.github.com/users/skontar/following{/other_user}", "gists_url": "https://api.github.com/users/skontar/gists{/gist_id}", "starred_url": "https://api.github.com/users/skontar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/skontar/subscriptions", "organizations_url": "https://api.github.com/users/skontar/orgs", "repos_url": "https://api.github.com/users/skontar/repos", "events_url": "https://api.github.com/users/skontar/events{/privacy}", "received_events_url": "https://api.github.com/users/skontar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The problem is python operator precedence. The following work as expected:\r\n\r\n```python\r\n\r\nPerson.select().where(Person.name.not_in([]))\r\n\r\nPerson.select().where(~(Person.name << []))\r\n\r\nPerson.select().where(~(Person.name.in_([])))\r\n```", "Thanks for reply. I see now, I got confused by SQL operator precedence. \r\nWould it not be better to translate to `WHERE (NOT \"t1\".\"name\" IN ())` for empty list, similarly as it does for non-empty list?\r\n\r\nI understand the reasoning and the problem, but I think this can potentially mask the issue until the list becomes empty one day and return unexpected results." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2500/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "q0w", "id": 43147888, "node_id": "MDQ6VXNlcjQzMTQ3ODg4", "avatar_url": "https://avatars.githubusercontent.com/u/43147888?v=4", "gravatar_id": "", "url": "https://api.github.com/users/q0w", "html_url": "https://github.com/q0w", "followers_url": "https://api.github.com/users/q0w/followers", "following_url": "https://api.github.com/users/q0w/following{/other_user}", "gists_url": "https://api.github.com/users/q0w/gists{/gist_id}", "starred_url": "https://api.github.com/users/q0w/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/q0w/subscriptions", "organizations_url": "https://api.github.com/users/q0w/orgs", "repos_url": "https://api.github.com/users/q0w/repos", "events_url": "https://api.github.com/users/q0w/events{/privacy}", "received_events_url": "https://api.github.com/users/q0w/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I really can't keep up with these new async-framework-of-the-day things. Additionally, connection handling doesn't work the way you might expect with async, so this is probably incorrect anyways." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2499/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2499", "html_url": "https://github.com/coleifer/peewee/pull/2499", "diff_url": "https://github.com/coleifer/peewee/pull/2499.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2499.patch", "merged_at": null }

{ "login": "ribx", "id": 4598953, "node_id": "MDQ6VXNlcjQ1OTg5NTM=", "avatar_url": "https://avatars.githubusercontent.com/u/4598953?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ribx", "html_url": "https://github.com/ribx", "followers_url": "https://api.github.com/users/ribx/followers", "following_url": "https://api.github.com/users/ribx/following{/other_user}", "gists_url": "https://api.github.com/users/ribx/gists{/gist_id}", "starred_url": "https://api.github.com/users/ribx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ribx/subscriptions", "organizations_url": "https://api.github.com/users/ribx/orgs", "repos_url": "https://api.github.com/users/ribx/repos", "events_url": "https://api.github.com/users/ribx/events{/privacy}", "received_events_url": "https://api.github.com/users/ribx/received_events", "type": "User", "site_admin": false }

[]

[]

[ "That version is not receiving patches, unfortunately. Your best bet is to fork it and patch it. You won't lose sync with upstream if you stay on 2.x." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2498/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "joaodlf", "id": 3275379, "node_id": "MDQ6VXNlcjMyNzUzNzk=", "avatar_url": "https://avatars.githubusercontent.com/u/3275379?v=4", "gravatar_id": "", "url": "https://api.github.com/users/joaodlf", "html_url": "https://github.com/joaodlf", "followers_url": "https://api.github.com/users/joaodlf/followers", "following_url": "https://api.github.com/users/joaodlf/following{/other_user}", "gists_url": "https://api.github.com/users/joaodlf/gists{/gist_id}", "starred_url": "https://api.github.com/users/joaodlf/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/joaodlf/subscriptions", "organizations_url": "https://api.github.com/users/joaodlf/orgs", "repos_url": "https://api.github.com/users/joaodlf/repos", "events_url": "https://api.github.com/users/joaodlf/events{/privacy}", "received_events_url": "https://api.github.com/users/joaodlf/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for the suggestion - this is implemented as `contained_by`.", "Thanks for the **incredible** feedback in such a short notice, do you plan on releasing a minor version with this feature any time in the near future?", "Besides this one change, there aren't really any other notable changes yet to justify a new release, in my opinion -- everything else is just docs or example updates. I'll probably wait until after the holidays.\r\n\r\nIf you want to use this now, but don't want to pin to `master` branch, I'd suggest just implementing your own subclass of ArrayField that implements `contained_by()` and using that in the meantime." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2497/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "jonathanmach", "id": 12788052, "node_id": "MDQ6VXNlcjEyNzg4MDUy", "avatar_url": "https://avatars.githubusercontent.com/u/12788052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonathanmach", "html_url": "https://github.com/jonathanmach", "followers_url": "https://api.github.com/users/jonathanmach/followers", "following_url": "https://api.github.com/users/jonathanmach/following{/other_user}", "gists_url": "https://api.github.com/users/jonathanmach/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonathanmach/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonathanmach/subscriptions", "organizations_url": "https://api.github.com/users/jonathanmach/orgs", "repos_url": "https://api.github.com/users/jonathanmach/repos", "events_url": "https://api.github.com/users/jonathanmach/events{/privacy}", "received_events_url": "https://api.github.com/users/jonathanmach/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2496/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2496", "html_url": "https://github.com/coleifer/peewee/pull/2496", "diff_url": "https://github.com/coleifer/peewee/pull/2496.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2496.patch", "merged_at": "2021-12-03T14:56:05" }

{ "login": "koadjunky", "id": 8714421, "node_id": "MDQ6VXNlcjg3MTQ0MjE=", "avatar_url": "https://avatars.githubusercontent.com/u/8714421?v=4", "gravatar_id": "", "url": "https://api.github.com/users/koadjunky", "html_url": "https://github.com/koadjunky", "followers_url": "https://api.github.com/users/koadjunky/followers", "following_url": "https://api.github.com/users/koadjunky/following{/other_user}", "gists_url": "https://api.github.com/users/koadjunky/gists{/gist_id}", "starred_url": "https://api.github.com/users/koadjunky/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/koadjunky/subscriptions", "organizations_url": "https://api.github.com/users/koadjunky/orgs", "repos_url": "https://api.github.com/users/koadjunky/repos", "events_url": "https://api.github.com/users/koadjunky/events{/privacy}", "received_events_url": "https://api.github.com/users/koadjunky/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm not going to download or run that code, but you are welcome to paste a short snippet demonstrating the issue - or even just the actual traceback...", "```\r\n(PeeWee-error) maciej@pippin:~/PeeWee-error$ python dsp_be/logic/planet.py \r\nTraceback (most recent call last):\r\n File \"dsp_be/logic/planet.py\", line 14, in <module>\r\n factory = Factory.create(planet=earth)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 6393, in create\r\n inst.save(force_insert=True)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 6603, in save\r\n pk = self.insert(**field_dict).execute()\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 1911, in inner\r\n return method(self, database, *args, **kwargs)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 1982, in execute\r\n return self._execute(database)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 2761, in _execute\r\n return super(Insert, self)._execute(database)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 2479, in _execute\r\n cursor = database.execute(self)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 3172, in execute\r\n sql, params = ctx.sql(query).query()\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 614, in sql\r\n return obj.__sql__(self)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 2738, in __sql__\r\n self._simple_insert(ctx)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 2588, in _simple_insert\r\n return self._generate_insert((self._insert,), ctx)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 2710, in _generate_insert\r\n return ctx.sql(CommaNodeList(all_values))\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 614, in sql\r\n return obj.__sql__(self)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 1777, in __sql__\r\n ctx.sql(self.nodes[n_nodes - 1])\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 614, in sql\r\n return obj.__sql__(self)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 1777, in __sql__\r\n ctx.sql(self.nodes[n_nodes - 1])\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 614, in sql\r\n return obj.__sql__(self)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 1383, in __sql__\r\n return ctx.value(self.value, self.converter)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 626, in value\r\n value = converter(value)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 5242, in db_value\r\n return self.rel_field.db_value(value)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 4569, in db_value\r\n return value if value is None else self.adapt(value)\r\n File \"/home/maciej/.pyenv/versions/PeeWee-error/lib/python3.8/site-packages/peewee.py\", line 4629, in adapt\r\n return int(value)\r\nTypeError: int() argument must be a string, a bytes-like object or a number, not 'Planet'\r\n```", "Looks like you have code here on line 14:\r\n\r\n```python\r\nfactory = Factory.create(planet=earth)\r\n```\r\n\r\nThe definition of `Factory.planet` (I'm guessing) is not a `ForeignKeyField` perhaps, when it should be. Possibly you put it as an IntegerField or something?", "It only happens if models are in different files. Merge it into one - and it works.\r\n\r\n```\r\n(PeeWee-error) maciej@pippin:~/PeeWee-error$ cat dsp_be/logic/__init__.py \r\nfrom typing import List, Type\r\n\r\nfrom peewee import DatabaseProxy, SqliteDatabase, Model\r\n\r\ndb_proxy = DatabaseProxy()\r\n\r\n\r\nclass BaseModel(Model):\r\n class Meta:\r\n database = db_proxy\r\n\r\n\r\ndef test_database(tables: List[Type[Model]]):\r\n db = SqliteDatabase(':memory:')\r\n db_proxy.initialize(db)\r\n db_proxy.connect()\r\n db_proxy.create_tables(tables)\r\n```\r\n\r\n```\r\n(PeeWee-error) maciej@pippin:~/PeeWee-error$ cat dsp_be/logic/planet.py \r\nfrom peewee import Field, CharField\r\n\r\nfrom dsp_be.logic import test_database, BaseModel\r\n\r\n\r\nclass Planet(BaseModel):\r\n name: Field = CharField()\r\n\r\n\r\nif __name__ == '__main__':\r\n from dsp_be.logic.factory import Factory\r\n test_database([Planet, Factory])\r\n earth = Planet.create(name='Earth')\r\n factory = Factory.create(planet=earth)\r\n```\r\n\r\n```\r\n(PeeWee-error) maciej@pippin:~/PeeWee-error$ cat dsp_be/logic/factory.py \r\nfrom peewee import Field, ForeignKeyField\r\n\r\nfrom dsp_be.logic import test_database, BaseModel\r\nfrom dsp_be.logic.planet import Planet\r\n\r\n\r\nclass Factory(BaseModel):\r\n planet: Field = ForeignKeyField(Planet, backref=\"planets\")\r\n\r\n\r\nif __name__ == '__main__':\r\n test_database([Planet, Factory])\r\n earth = Planet.create(name='Earth')\r\n factory = Factory.create(planet=earth)\r\n```", "You've got some bug in your code. This works fine for me:\r\n\r\n```python\r\n# testx/__init__.py\r\nfrom peewee import *\r\n\r\ndb = DatabaseProxy()\r\n\r\nclass BaseModel(Model):\r\n class Meta:\r\n database = db\r\n\r\n# testx/factory.py\r\nfrom peewee import ForeignKeyField\r\nfrom testx import BaseModel\r\nfrom testx.planet import Planet\r\n\r\nclass Factory(BaseModel):\r\n planet = ForeignKeyField(Planet)\r\n\r\n# testx/planet.py\r\nfrom peewee import TextField\r\nfrom testx import BaseModel\r\n\r\nclass Planet(BaseModel):\r\n name = TextField()\r\n\r\n# testx/main.py\r\nfrom peewee import *\r\nfrom testx import db\r\nfrom testx.planet import Planet\r\nfrom testx.factory import Factory\r\n\r\n\r\n_db = SqliteDatabase(':memory:')\r\ndb.initialize(_db)\r\ndb.create_tables([Factory, Planet])\r\n\r\np = Planet.create(name='earth')\r\nFactory.create(planet=p)\r\nprint(Factory.get().planet.name) # \"earth\"\r\n```", "I copied part of planet.py into main.py similar to your snippet and now it works. Weird.\r\n```\r\n# dsp_be/logic/main.py\r\nfrom peewee import SqliteDatabase\r\n\r\nfrom dsp_be.logic import test_database\r\n\r\n\r\nif __name__ == '__main__':\r\n from dsp_be.logic.factory import Factory, Planet\r\n test_database([Factory, Planet])\r\n earth = Planet.create(name='Earth')\r\n factory = Factory.create(planet=earth)\r\n```\r\nCan be used as an workaround through. Thanks for hint!" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2495/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "tdennisliu", "id": 34557499, "node_id": "MDQ6VXNlcjM0NTU3NDk5", "avatar_url": "https://avatars.githubusercontent.com/u/34557499?v=4", "gravatar_id": "", "url": "https://api.github.com/users/tdennisliu", "html_url": "https://github.com/tdennisliu", "followers_url": "https://api.github.com/users/tdennisliu/followers", "following_url": "https://api.github.com/users/tdennisliu/following{/other_user}", "gists_url": "https://api.github.com/users/tdennisliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/tdennisliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tdennisliu/subscriptions", "organizations_url": "https://api.github.com/users/tdennisliu/orgs", "repos_url": "https://api.github.com/users/tdennisliu/repos", "events_url": "https://api.github.com/users/tdennisliu/events{/privacy}", "received_events_url": "https://api.github.com/users/tdennisliu/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is a convention that is used throughout peewee examples, as well as my own code. Peewee module defines `__all__`, which controls what objects are exported, and I am happy with that. In your own code you are welcome to use whatever style you like, though." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2494/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "gjask", "id": 3306648, "node_id": "MDQ6VXNlcjMzMDY2NDg=", "avatar_url": "https://avatars.githubusercontent.com/u/3306648?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gjask", "html_url": "https://github.com/gjask", "followers_url": "https://api.github.com/users/gjask/followers", "following_url": "https://api.github.com/users/gjask/following{/other_user}", "gists_url": "https://api.github.com/users/gjask/gists{/gist_id}", "starred_url": "https://api.github.com/users/gjask/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gjask/subscriptions", "organizations_url": "https://api.github.com/users/gjask/orgs", "repos_url": "https://api.github.com/users/gjask/repos", "events_url": "https://api.github.com/users/gjask/events{/privacy}", "received_events_url": "https://api.github.com/users/gjask/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You want to specify `.coerce(False)`:\r\n\r\n```python\r\n\r\nTestTable.select(\r\n fn.Avg(TestTable.value).coerce(False).alias(\"avg_value\"),\r\n).scalar()\r\n```", "http://docs.peewee-orm.com/en/latest/peewee/api.html#Function.coerce" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2493/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "kezzhang", "id": 42364982, "node_id": "MDQ6VXNlcjQyMzY0OTgy", "avatar_url": "https://avatars.githubusercontent.com/u/42364982?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kezzhang", "html_url": "https://github.com/kezzhang", "followers_url": "https://api.github.com/users/kezzhang/followers", "following_url": "https://api.github.com/users/kezzhang/following{/other_user}", "gists_url": "https://api.github.com/users/kezzhang/gists{/gist_id}", "starred_url": "https://api.github.com/users/kezzhang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kezzhang/subscriptions", "organizations_url": "https://api.github.com/users/kezzhang/orgs", "repos_url": "https://api.github.com/users/kezzhang/repos", "events_url": "https://api.github.com/users/kezzhang/events{/privacy}", "received_events_url": "https://api.github.com/users/kezzhang/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I could swear I ran all the examples and they worked so possibly something has changed. 2.x is unmaintained since Feb 2018 so hard to say." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2492/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "nabinbhusal80", "id": 24907850, "node_id": "MDQ6VXNlcjI0OTA3ODUw", "avatar_url": "https://avatars.githubusercontent.com/u/24907850?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nabinbhusal80", "html_url": "https://github.com/nabinbhusal80", "followers_url": "https://api.github.com/users/nabinbhusal80/followers", "following_url": "https://api.github.com/users/nabinbhusal80/following{/other_user}", "gists_url": "https://api.github.com/users/nabinbhusal80/gists{/gist_id}", "starred_url": "https://api.github.com/users/nabinbhusal80/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nabinbhusal80/subscriptions", "organizations_url": "https://api.github.com/users/nabinbhusal80/orgs", "repos_url": "https://api.github.com/users/nabinbhusal80/repos", "events_url": "https://api.github.com/users/nabinbhusal80/events{/privacy}", "received_events_url": "https://api.github.com/users/nabinbhusal80/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I've implemented this, thanks for the suggestion. The endpoints can be specified using:\r\n\r\n```python\r\nFLASKDB_EXCLUDED_ROUTES = ('view1', 'view2'...)\r\n\r\n# Or,\r\nflask_db = FlaskDB(app, excluded_routes=set('view1', 'view2',...))\r\n```", "Hey @coleifer thank you so much for the solution. Somehow i missed it in docs. I was banging my head on this for a while. So amazing to see the quick response on this. \r\nI really appreciate it." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2491/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "aiqc", "id": 74990642, "node_id": "MDQ6VXNlcjc0OTkwNjQy", "avatar_url": "https://avatars.githubusercontent.com/u/74990642?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aiqc", "html_url": "https://github.com/aiqc", "followers_url": "https://api.github.com/users/aiqc/followers", "following_url": "https://api.github.com/users/aiqc/following{/other_user}", "gists_url": "https://api.github.com/users/aiqc/gists{/gist_id}", "starred_url": "https://api.github.com/users/aiqc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aiqc/subscriptions", "organizations_url": "https://api.github.com/users/aiqc/orgs", "repos_url": "https://api.github.com/users/aiqc/repos", "events_url": "https://api.github.com/users/aiqc/events{/privacy}", "received_events_url": "https://api.github.com/users/aiqc/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Yes, peewee supports all the same parameters as psycopg2, so:\r\n\r\n```python\r\n\r\n# for example:\r\ndb = PostgresqlDatabase('db_name', host='192.168.1.30', port=5432, user='postgres', password='xyz')\r\n```\r\n\r\nPsycopg2 connection doc: https://www.psycopg.org/docs/module.html#psycopg2.connect" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2490/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rmskinsa2", "id": 86251795, "node_id": "MDQ6VXNlcjg2MjUxNzk1", "avatar_url": "https://avatars.githubusercontent.com/u/86251795?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rmskinsa2", "html_url": "https://github.com/rmskinsa2", "followers_url": "https://api.github.com/users/rmskinsa2/followers", "following_url": "https://api.github.com/users/rmskinsa2/following{/other_user}", "gists_url": "https://api.github.com/users/rmskinsa2/gists{/gist_id}", "starred_url": "https://api.github.com/users/rmskinsa2/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rmskinsa2/subscriptions", "organizations_url": "https://api.github.com/users/rmskinsa2/orgs", "repos_url": "https://api.github.com/users/rmskinsa2/repos", "events_url": "https://api.github.com/users/rmskinsa2/events{/privacy}", "received_events_url": "https://api.github.com/users/rmskinsa2/received_events", "type": "User", "site_admin": false }

[]

[]

[ "https://stackoverflow.com/questions/463764/are-unique-indices-case-sensitive-in-mysql", "@coleifer Is there a way to make the column case sensitive via PeeWee, or is this something we need to do directly in the db?", "You should be able to specify the collation directly via Peewee:\r\n\r\n```python\r\nkey = CharField(collation='utf8_bin', unique=True)\r\n\r\n# Specify character set as well:\r\nkey = CharField(collation='utf8_bin', constraints=[SQL('character set utf8')], unique=True)\r\n```\r\n\r\nI haven't tested this myself, but this is based somewhat on the above-linked StackOverflow answer.", "Thank you! I'll try that and report back here in case someone else needs the info in future.", "For future folks: changing the `collation` and `constraints` kwargs on the `CharField`, followed by dropping/adding the column with Playhouse didn't change anything. But running some raw sql did:\r\n```\r\n # Make the name column case sensitive\r\n collate_sql = \"\"\"\r\n ALTER TABLE db.tbl\r\n MODIFY COLUMN col VARCHAR(255) COLLATE utf8_bin;\r\n \"\"\"\r\n db.execute_sql(collate_sql)\r\n```\r\nVerified by running `SHOW FULL COLUMNS FROM tbl;`\r\n\r\nNOTE the `MODIFY COLUMN` vs `ALTER COLUMN`. When I used `ALTER COLUMN` I kept getting a syntax error. But for some reason `MODIFY COLUMN` worked. I'm too unfamiliar with db administration and too strapped on time to know why, but figured I'd include that factoid." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2489/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "viponedream", "id": 16624529, "node_id": "MDQ6VXNlcjE2NjI0NTI5", "avatar_url": "https://avatars.githubusercontent.com/u/16624529?v=4", "gravatar_id": "", "url": "https://api.github.com/users/viponedream", "html_url": "https://github.com/viponedream", "followers_url": "https://api.github.com/users/viponedream/followers", "following_url": "https://api.github.com/users/viponedream/following{/other_user}", "gists_url": "https://api.github.com/users/viponedream/gists{/gist_id}", "starred_url": "https://api.github.com/users/viponedream/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/viponedream/subscriptions", "organizations_url": "https://api.github.com/users/viponedream/orgs", "repos_url": "https://api.github.com/users/viponedream/repos", "events_url": "https://api.github.com/users/viponedream/events{/privacy}", "received_events_url": "https://api.github.com/users/viponedream/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2488/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "johnziebro", "id": 90479072, "node_id": "MDQ6VXNlcjkwNDc5MDcy", "avatar_url": "https://avatars.githubusercontent.com/u/90479072?v=4", "gravatar_id": "", "url": "https://api.github.com/users/johnziebro", "html_url": "https://github.com/johnziebro", "followers_url": "https://api.github.com/users/johnziebro/followers", "following_url": "https://api.github.com/users/johnziebro/following{/other_user}", "gists_url": "https://api.github.com/users/johnziebro/gists{/gist_id}", "starred_url": "https://api.github.com/users/johnziebro/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/johnziebro/subscriptions", "organizations_url": "https://api.github.com/users/johnziebro/orgs", "repos_url": "https://api.github.com/users/johnziebro/repos", "events_url": "https://api.github.com/users/johnziebro/events{/privacy}", "received_events_url": "https://api.github.com/users/johnziebro/received_events", "type": "User", "site_admin": false }

[]

[]

[ ">I'd like to better understand the roundtrip process for serializing and deserializing.\r\n\r\nThe sqlite3 json data-type requires the data to be serialized into json. Simple as that. When reading row data off a cursor the JSONField will deserialize it back to an object.\r\n\r\nThe problem is actually rather from python's own `json` module not supporting `datetime`-like out of the box. Which is a pretty glaring oversight in my opinion, but something to take up with the core team.", "@coleifer could you let me know if this would be a good strategy to follow?\r\n\r\nGenerally speaking, the [direction for encoding per this stackoverflow](https://stackoverflow.com/a/27058505/1663382) is to subclass json.JSONEncoder/JSONDecoder with a custom class, then provide it to json.dumps/loads as the 'cls' parameter using functools.partial. I believe what I was hung up on from the Peewee doc's was how to use the custom encoder and that json_loads was missing from the example.\r\n\r\n```\r\nclass DateTimeEncoder(JSONEncoder)\r\n # custom encode implementation here\r\n ...\r\n\r\nclass DateTimeDecoder(JSONDecoder)\r\n # custom decode implementation here\r\n ...\r\n\r\n# assign dumps and loads functions\r\nmy_json_dumps = functools.partial(json.dumps, cls=DateTimeEncoder)\r\nmy_json_loads = functools.partial(json.loads, cls=DateTimeDecoder)\r\n\r\nclass SomeModel(Model):\r\n # Specify our custom serialization function.\r\n json_data = JSONField(json_dumps=my_json_dumps, json_loads=my_json_loads)\r\n```", "There are a number of options: https://stackoverflow.com/questions/11875770/how-to-overcome-datetime-datetime-not-json-serializable", "For posterity or if anyone else needs an example as I did not see this in any other closed issues, @coleifer thanks again! \r\n\r\n### Solution\r\n```\r\nimport json\r\nimport pendulum as pdlm\r\nfrom functools import partial\r\n\r\n\r\nclass PendulumDateTimeEncoder(json.JSONEncoder):\r\n \"\"\"\r\n Provides json encoding as string for pendulum.DateTime objects\r\n including timezone or UTC.\r\n \"\"\"\r\n\r\n def default(self, object):\r\n\r\n # handle pendulum.DateTime objects\r\n if isinstance(object, pdlm.DateTime):\r\n\r\n # generate ISO 8601 string\r\n return object.to_iso8601_string()\r\n\r\n return super().default(object)\r\n\r\n\r\nclass PendulumDateTimeDecoder(json.JSONDecoder):\r\n \"\"\"\r\n Provides json datetime stored as string decoding for\r\n pendulum.DateTime objects.\r\n \"\"\"\r\n\r\n def decode(self, object):\r\n\r\n # handle pendulum.DateTime objects\r\n if isinstance(object, str):\r\n\r\n # load as json string\r\n object = json.loads(object)\r\n\r\n # return ISO 8601 string as pendulum DateTime\r\n return pdlm.parse(object)\r\n\r\n return super().decode(object)\r\n\r\n\r\n# assign dumps and loads functions\r\ncustom_dumps = partial(json.dumps, cls=PendulumDateTimeEncoder)\r\ncustom_loads = partial(json.loads, cls=PendulumDateTimeDecoder)\r\n```\r\n\r\n### Test\r\n```\r\nnow = pdlm.now('UTC')\r\ndumped = custom_dumps(now)\r\nloaded = custom_loads(dumped)\r\nassert loaded == now, \"Round-trip serialization failed.\"\r\nassert loaded.tz.name == \"UTC\", \"Timezone round-trip failure.\"\r\n```\r\n\r\n### ORM Class\r\n```\r\nclass TimelineModel(BaseModel):\r\n \"\"\" ORM model for Timeline. \"\"\"\r\n intervals = JSONField(json_dumps=custom_dumps, json_loads=custom_loads)\r\n```" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2487/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "rbracco", "id": 47190785, "node_id": "MDQ6VXNlcjQ3MTkwNzg1", "avatar_url": "https://avatars.githubusercontent.com/u/47190785?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rbracco", "html_url": "https://github.com/rbracco", "followers_url": "https://api.github.com/users/rbracco/followers", "following_url": "https://api.github.com/users/rbracco/following{/other_user}", "gists_url": "https://api.github.com/users/rbracco/gists{/gist_id}", "starred_url": "https://api.github.com/users/rbracco/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rbracco/subscriptions", "organizations_url": "https://api.github.com/users/rbracco/orgs", "repos_url": "https://api.github.com/users/rbracco/repos", "events_url": "https://api.github.com/users/rbracco/events{/privacy}", "received_events_url": "https://api.github.com/users/rbracco/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'm getting some really weird results. I tried to hack around it by calling `ModelResult.get(audio_id=af.id, model_id=tm.id)` and manually updating if it existed, and if it didnt, catching the `DoesNotExist` and manually creating the `ModelResult` with\r\n\r\n```\r\nmax_id = ModelResult.select(fn.MAX(ModelResult.id)).scalar() + 1\r\nmr = ModelResult(\r\n id=max_id,\r\n prediction=pred,\r\n loss=loss,\r\n audio_id=af.id,\r\n model_id=tm.id,\r\n )\r\nmr.save()\r\n```\r\nIt worked for like 20 rows and then the rows stopped getting added and the ID stopped incrementing. I set a breakpoint and everything looks good in the ModelResult instance but mr.save() is returning 0. I searched and found #1198 which makes me think something is really wrong. \r\n\r\n**Edit:** I started using `mr.save(force_insert=True)` which worked and then checked the docs and saw that it happens when you create your own non-integer primary key which I don't think I did. My schema doesn't use `PrimaryKey` anywhere but I checked the schema in SQLite browser and I now see that the `id` field for `ModelResult` is `NUMERIC` not `INTEGER`. I'm not sure how this happened but I believe that's the issue. I'm going to explore a bit more and I'll post here and close out if I confirm. ", "There's nothing wrong with peewee, surely this is something in your code or schema.\r\n\r\n```python\r\nclass Audio(Base):\r\n name = TextField()\r\n\r\nclass Note(Base):\r\n name = TextField()\r\n\r\nclass Result(Base):\r\n audio = ForeignKeyField(Audio)\r\n note = ForeignKeyField(Note, null=True)\r\n\r\ndb.create_tables([Audio, Note, Result])\r\n\r\na1 = Audio.create(name='a1')\r\na2 = Audio.create(name='a2')\r\nn1 = Note.create(name='n1')\r\nn2 = Note.create(name='n2')\r\n\r\nr1a, created = Result.get_or_create(audio=a1)\r\nassert created\r\nr1b, created = Result.get_or_create(audio=a1)\r\nassert not created\r\nassert r1a.id == r1b.id\r\n\r\nr2a, created = Result.get_or_create(audio=a2, note=n2)\r\nassert created\r\nr2b, created = Result.get_or_create(audio=a2, note=n2)\r\nassert not created\r\nassert r2a.id == r2b.id\r\n```" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2486/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "pylipp", "id": 10617122, "node_id": "MDQ6VXNlcjEwNjE3MTIy", "avatar_url": "https://avatars.githubusercontent.com/u/10617122?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pylipp", "html_url": "https://github.com/pylipp", "followers_url": "https://api.github.com/users/pylipp/followers", "following_url": "https://api.github.com/users/pylipp/following{/other_user}", "gists_url": "https://api.github.com/users/pylipp/gists{/gist_id}", "starred_url": "https://api.github.com/users/pylipp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pylipp/subscriptions", "organizations_url": "https://api.github.com/users/pylipp/orgs", "repos_url": "https://api.github.com/users/pylipp/repos", "events_url": "https://api.github.com/users/pylipp/events{/privacy}", "received_events_url": "https://api.github.com/users/pylipp/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I found the text and admonition confusing, even in context. I'll pass for now but will think about whether some improvement to the docs is needed for this situation." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2485/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2485", "html_url": "https://github.com/coleifer/peewee/pull/2485", "diff_url": "https://github.com/coleifer/peewee/pull/2485.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2485.patch", "merged_at": null }

{ "login": "sebo-b", "id": 51707418, "node_id": "MDQ6VXNlcjUxNzA3NDE4", "avatar_url": "https://avatars.githubusercontent.com/u/51707418?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sebo-b", "html_url": "https://github.com/sebo-b", "followers_url": "https://api.github.com/users/sebo-b/followers", "following_url": "https://api.github.com/users/sebo-b/following{/other_user}", "gists_url": "https://api.github.com/users/sebo-b/gists{/gist_id}", "starred_url": "https://api.github.com/users/sebo-b/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sebo-b/subscriptions", "organizations_url": "https://api.github.com/users/sebo-b/orgs", "repos_url": "https://api.github.com/users/sebo-b/repos", "events_url": "https://api.github.com/users/sebo-b/events{/privacy}", "received_events_url": "https://api.github.com/users/sebo-b/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Postgres/psycopg2 does not provide a lastrowid db-api method -- you need to use RETURNING with postgres. This is handled automatically for you when you use the models APIs, but **not** when you are using the low-level query builder (e.g. `Table`)." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2484/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "pylipp", "id": 10617122, "node_id": "MDQ6VXNlcjEwNjE3MTIy", "avatar_url": "https://avatars.githubusercontent.com/u/10617122?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pylipp", "html_url": "https://github.com/pylipp", "followers_url": "https://api.github.com/users/pylipp/followers", "following_url": "https://api.github.com/users/pylipp/following{/other_user}", "gists_url": "https://api.github.com/users/pylipp/gists{/gist_id}", "starred_url": "https://api.github.com/users/pylipp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pylipp/subscriptions", "organizations_url": "https://api.github.com/users/pylipp/orgs", "repos_url": "https://api.github.com/users/pylipp/repos", "events_url": "https://api.github.com/users/pylipp/events{/privacy}", "received_events_url": "https://api.github.com/users/pylipp/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Not a fan of links becoming stale?\r\n" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2483/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2483", "html_url": "https://github.com/coleifer/peewee/pull/2483", "diff_url": "https://github.com/coleifer/peewee/pull/2483.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2483.patch", "merged_at": null }

{ "login": "dhrumilp31", "id": 87986360, "node_id": "MDQ6VXNlcjg3OTg2MzYw", "avatar_url": "https://avatars.githubusercontent.com/u/87986360?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dhrumilp31", "html_url": "https://github.com/dhrumilp31", "followers_url": "https://api.github.com/users/dhrumilp31/followers", "following_url": "https://api.github.com/users/dhrumilp31/following{/other_user}", "gists_url": "https://api.github.com/users/dhrumilp31/gists{/gist_id}", "starred_url": "https://api.github.com/users/dhrumilp31/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dhrumilp31/subscriptions", "organizations_url": "https://api.github.com/users/dhrumilp31/orgs", "repos_url": "https://api.github.com/users/dhrumilp31/repos", "events_url": "https://api.github.com/users/dhrumilp31/events{/privacy}", "received_events_url": "https://api.github.com/users/dhrumilp31/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You need to re-bind the models to the postgres database in order for them to be created on the Pg database:\r\n\r\n```python\r\ndb = PostgresqlDatabase('prodigy_db', user='usr', password='pwd', host='host', port=5432)\r\ndb.bind(models.values())\r\ndb.create_tables(list(models.values()), safe=False)\r\n```", "Thanks @coleifer, it worked. Appreciate the quick response. " ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2482/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "stenci", "id": 5955495, "node_id": "MDQ6VXNlcjU5NTU0OTU=", "avatar_url": "https://avatars.githubusercontent.com/u/5955495?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stenci", "html_url": "https://github.com/stenci", "followers_url": "https://api.github.com/users/stenci/followers", "following_url": "https://api.github.com/users/stenci/following{/other_user}", "gists_url": "https://api.github.com/users/stenci/gists{/gist_id}", "starred_url": "https://api.github.com/users/stenci/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stenci/subscriptions", "organizations_url": "https://api.github.com/users/stenci/orgs", "repos_url": "https://api.github.com/users/stenci/repos", "events_url": "https://api.github.com/users/stenci/events{/privacy}", "received_events_url": "https://api.github.com/users/stenci/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2481/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2481", "html_url": "https://github.com/coleifer/peewee/pull/2481", "diff_url": "https://github.com/coleifer/peewee/pull/2481.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2481.patch", "merged_at": "2021-10-29T11:09:10" }

{ "login": "mattangus", "id": 5302804, "node_id": "MDQ6VXNlcjUzMDI4MDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/5302804?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mattangus", "html_url": "https://github.com/mattangus", "followers_url": "https://api.github.com/users/mattangus/followers", "following_url": "https://api.github.com/users/mattangus/following{/other_user}", "gists_url": "https://api.github.com/users/mattangus/gists{/gist_id}", "starred_url": "https://api.github.com/users/mattangus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mattangus/subscriptions", "organizations_url": "https://api.github.com/users/mattangus/orgs", "repos_url": "https://api.github.com/users/mattangus/repos", "events_url": "https://api.github.com/users/mattangus/events{/privacy}", "received_events_url": "https://api.github.com/users/mattangus/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The transaction details are wrapped by the driver, so I can't really comment on why this is the case with pymysql. I'd suggest possibly trying to ping the db before beginning transactions if its possible your connection has been idle for quite some time. You can do this quite easily.\r\n\r\nhttps://pymysql.readthedocs.io/en/latest/modules/connections.html#pymysql.connections.Connection.ping\r\n\r\n```python\r\n\r\ndb = ReconnectMySQLDatabase(...)\r\n\r\ntry:\r\n db.connection().ping(reconnect=False)\r\nexcept:\r\n db.close()\r\n db.connect()\r\n```\r\n\r\nCouple things to consider, though. Why are you leaving open connections sitting idle for a long time? This may indicate a problematic design. If this is a web app, you should probably be using the PooledMySQLDatabase and opening/closing connections each request. If this is something else, however, I'd suggest either a) connect/close when you need to do work, or b) use something like the code above to ensure connection liveness." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2480/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "mgorny", "id": 110765, "node_id": "MDQ6VXNlcjExMDc2NQ==", "avatar_url": "https://avatars.githubusercontent.com/u/110765?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mgorny", "html_url": "https://github.com/mgorny", "followers_url": "https://api.github.com/users/mgorny/followers", "following_url": "https://api.github.com/users/mgorny/following{/other_user}", "gists_url": "https://api.github.com/users/mgorny/gists{/gist_id}", "starred_url": "https://api.github.com/users/mgorny/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mgorny/subscriptions", "organizations_url": "https://api.github.com/users/mgorny/orgs", "repos_url": "https://api.github.com/users/mgorny/repos", "events_url": "https://api.github.com/users/mgorny/events{/privacy}", "received_events_url": "https://api.github.com/users/mgorny/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks for reporting and bisecting, I've got a fix and will push a new release later today.", "Thank you, I can confirm that tests pass on master now." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2479/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "gaspardbb", "id": 40466739, "node_id": "MDQ6VXNlcjQwNDY2NzM5", "avatar_url": "https://avatars.githubusercontent.com/u/40466739?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gaspardbb", "html_url": "https://github.com/gaspardbb", "followers_url": "https://api.github.com/users/gaspardbb/followers", "following_url": "https://api.github.com/users/gaspardbb/following{/other_user}", "gists_url": "https://api.github.com/users/gaspardbb/gists{/gist_id}", "starred_url": "https://api.github.com/users/gaspardbb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gaspardbb/subscriptions", "organizations_url": "https://api.github.com/users/gaspardbb/orgs", "repos_url": "https://api.github.com/users/gaspardbb/repos", "events_url": "https://api.github.com/users/gaspardbb/events{/privacy}", "received_events_url": "https://api.github.com/users/gaspardbb/received_events", "type": "User", "site_admin": false }

[]

[]

[ "What database driver are you using this with, out of curiosity? The example works fine with Sqlite but I'm wondering if this is a result of psycopg2 doing its mogrifying client-side.", "This was with Postgre. Indeed, the issue was raised on l. 3144, `cursor.execute(sql, params or ())`." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2478/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "NaelsonDouglas", "id": 8750259, "node_id": "MDQ6VXNlcjg3NTAyNTk=", "avatar_url": "https://avatars.githubusercontent.com/u/8750259?v=4", "gravatar_id": "", "url": "https://api.github.com/users/NaelsonDouglas", "html_url": "https://github.com/NaelsonDouglas", "followers_url": "https://api.github.com/users/NaelsonDouglas/followers", "following_url": "https://api.github.com/users/NaelsonDouglas/following{/other_user}", "gists_url": "https://api.github.com/users/NaelsonDouglas/gists{/gist_id}", "starred_url": "https://api.github.com/users/NaelsonDouglas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/NaelsonDouglas/subscriptions", "organizations_url": "https://api.github.com/users/NaelsonDouglas/orgs", "repos_url": "https://api.github.com/users/NaelsonDouglas/repos", "events_url": "https://api.github.com/users/NaelsonDouglas/events{/privacy}", "received_events_url": "https://api.github.com/users/NaelsonDouglas/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I'll pass." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2477/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2477", "html_url": "https://github.com/coleifer/peewee/pull/2477", "diff_url": "https://github.com/coleifer/peewee/pull/2477.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2477.patch", "merged_at": null }

{ "login": "ThaoPN", "id": 19179219, "node_id": "MDQ6VXNlcjE5MTc5MjE5", "avatar_url": "https://avatars.githubusercontent.com/u/19179219?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ThaoPN", "html_url": "https://github.com/ThaoPN", "followers_url": "https://api.github.com/users/ThaoPN/followers", "following_url": "https://api.github.com/users/ThaoPN/following{/other_user}", "gists_url": "https://api.github.com/users/ThaoPN/gists{/gist_id}", "starred_url": "https://api.github.com/users/ThaoPN/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ThaoPN/subscriptions", "organizations_url": "https://api.github.com/users/ThaoPN/orgs", "repos_url": "https://api.github.com/users/ThaoPN/repos", "events_url": "https://api.github.com/users/ThaoPN/events{/privacy}", "received_events_url": "https://api.github.com/users/ThaoPN/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Your first query \"add_one_null_row()\" is not specifying any value at all for `not_null_field`, while your second query \"add_multiple_null_row()\" is explicitly specifying NULL for `not_null_field`. I am guessing that older MySQL (with its many quirks) handles these situations differently, raising an IntegrityError for the first case, but possibly silently converting the second case to an empty string or something like that?\r\n\r\nIn short: I think this is a MySQL thing. Both the error *and* the warning are generated by MySQL. I suspect there is a MySQL setting you can enable which will cause the IntegrityError to be raised in both cases -- possibly you are on an old MySQL or running with relaxed settings?\r\n\r\nIn any case, I suggest consulting the MySQL docs or checking out StackOverflow.\r\n\r\nWhen I run this on MariaDB 10.4, I get an IntegrityError for *both* queries -- as expected. The first query gives the integrityerror for Column \"text\" cannot be null, and the second query gives the integrityerror for Column \"not_null_field\" cannot be null." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2476/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "larsch", "id": 15712, "node_id": "MDQ6VXNlcjE1NzEy", "avatar_url": "https://avatars.githubusercontent.com/u/15712?v=4", "gravatar_id": "", "url": "https://api.github.com/users/larsch", "html_url": "https://github.com/larsch", "followers_url": "https://api.github.com/users/larsch/followers", "following_url": "https://api.github.com/users/larsch/following{/other_user}", "gists_url": "https://api.github.com/users/larsch/gists{/gist_id}", "starred_url": "https://api.github.com/users/larsch/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/larsch/subscriptions", "organizations_url": "https://api.github.com/users/larsch/orgs", "repos_url": "https://api.github.com/users/larsch/repos", "events_url": "https://api.github.com/users/larsch/events{/privacy}", "received_events_url": "https://api.github.com/users/larsch/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The reason for this is that Peewee is attempting to reconstruct the model-graph, so the \"sum\" attribute (which logically belongs to Bar) is placed in `row.bar.sum`.\r\n\r\nHere:\r\n\r\n```python\r\n\r\nsq = (Bar.select(Bar.foo_id, fn.SUM(Bar.value).alias('sum'))\r\n .group_by(Bar.foo_id))\r\nquery = (Foo.select(Foo.name, sq.c.sum.alias('sum'))\r\n .join(sq, on=(Foo.id == sq.c.foo_id))\r\n .order_by(Foo.name))\r\n\r\nfor foo in query:\r\n print(foo.name, foo.bar.sum)\r\n\r\n# BarBaz 13\r\n# BazFoo 13\r\n# FooBar 13\r\n```\r\n\r\nIf you want all attributes simply put on the model being selected, specify `.objects()` in your outer query:\r\n\r\n```python\r\nfor foo in query.objects():\r\n print(foo.name, foo.sum)\r\n```\r\n\r\nDetails here: http://docs.peewee-orm.com/en/latest/peewee/relationships.html#selecting-from-multiple-sources" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2475/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "SilvanVerhoeven", "id": 44174681, "node_id": "MDQ6VXNlcjQ0MTc0Njgx", "avatar_url": "https://avatars.githubusercontent.com/u/44174681?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SilvanVerhoeven", "html_url": "https://github.com/SilvanVerhoeven", "followers_url": "https://api.github.com/users/SilvanVerhoeven/followers", "following_url": "https://api.github.com/users/SilvanVerhoeven/following{/other_user}", "gists_url": "https://api.github.com/users/SilvanVerhoeven/gists{/gist_id}", "starred_url": "https://api.github.com/users/SilvanVerhoeven/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SilvanVerhoeven/subscriptions", "organizations_url": "https://api.github.com/users/SilvanVerhoeven/orgs", "repos_url": "https://api.github.com/users/SilvanVerhoeven/repos", "events_url": "https://api.github.com/users/SilvanVerhoeven/events{/privacy}", "received_events_url": "https://api.github.com/users/SilvanVerhoeven/received_events", "type": "User", "site_admin": false }

[]

[]

[ "There's a little helper you can use to wrap a select query:\r\n\r\n```python\r\nclass A(Base):\r\n a = TextField()\r\n\r\nclass B(Base):\r\n b = TextField()\r\n\r\ndb.create_tables([A, B])\r\n\r\nA.insert_many([('a%d' % i,) for i in range(10)]).execute()\r\nB.insert_many([('b%d' % i,) for i in range(10)]).execute()\r\n\r\nq1 = A.select(A.a).order_by(A.a).limit(5)\r\nq2 = B.select(B.b).order_by(B.b).limit(5)\r\n\r\n# Wrap the queries in the form SELECT * FROM (SELECT ... LIMIT 5)\r\nwq1 = q1.select_from(SQL('*'))\r\nwq2 = q2.select_from(SQL('*'))\r\n\r\n# Create the union - note that it may be necessary to re-bind the\r\n# query to the database. I've fixed this, but it is not contained in the\r\n# current release on PyPI.\r\nu = (wq1 | wq2).bind(db)\r\n\r\nfor row in u:\r\n print(row)\r\n```\r\n\r\nThis prints:\r\n\r\n```\r\n{'a': 'a0'}\r\n{'a': 'a1'}\r\n{'a': 'a2'}\r\n{'a': 'a3'}\r\n{'a': 'a4'}\r\n{'a': 'b0'}\r\n{'a': 'b1'}\r\n{'a': 'b2'}\r\n{'a': 'b3'}\r\n{'a': 'b4'}\r\n```" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2474/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "elderlabs", "id": 30255476, "node_id": "MDQ6VXNlcjMwMjU1NDc2", "avatar_url": "https://avatars.githubusercontent.com/u/30255476?v=4", "gravatar_id": "", "url": "https://api.github.com/users/elderlabs", "html_url": "https://github.com/elderlabs", "followers_url": "https://api.github.com/users/elderlabs/followers", "following_url": "https://api.github.com/users/elderlabs/following{/other_user}", "gists_url": "https://api.github.com/users/elderlabs/gists{/gist_id}", "starred_url": "https://api.github.com/users/elderlabs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/elderlabs/subscriptions", "organizations_url": "https://api.github.com/users/elderlabs/orgs", "repos_url": "https://api.github.com/users/elderlabs/repos", "events_url": "https://api.github.com/users/elderlabs/events{/privacy}", "received_events_url": "https://api.github.com/users/elderlabs/received_events", "type": "User", "site_admin": false }

[]

[]

[ "There are a number of psycopg3 changes that look to be backwards-incompatible (which is understandable) but will likely be a pain to identify and work around. Parameter binding, especially, looks like it has changed quite a bit.\r\n\r\nIt's definitely on my radar and will be added to Peewee, but I will probably wait a bit to add support. If anyone is interested in the meantime, feel free to implement this in a standalone/extension module.", "Hello\r\n\r\nI looked at your extension but I wondering, can I use this in conjuction with PostgresqlExtDatabase?\r\n\r\nAny plans on built-in support for psycopg3? Considering is also adding it in their next release and it is a stable release..", "Are there any specific features of `PostgresqlExtDatabase` you were intending to use - e.g. jsonb, arrays? I'll have to spend some time seeing what works and what doesn't, since we use some helpers from `psycopg2.extras` (e.g. `Json`).", "I'm going through all my raw SQL code currently, but if I'm not mistaken I will have some jsonb-specifics.\r\n\r\nI will use psycopg2 for now though, but it would be great to see support for 3.", "No, I agree with you, things are going to be moving towards psycopg3 in the coming years so I'll want to be ready for that. Thanks for the ping on this, I'll be aiming to getting parity for psycopg3 with the current PostgresqlExtDatabase. No definitive timeline but it's a priority for me." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2473/reactions", "total_count": 5, "+1": 5, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "balloonz", "id": 6794239, "node_id": "MDQ6VXNlcjY3OTQyMzk=", "avatar_url": "https://avatars.githubusercontent.com/u/6794239?v=4", "gravatar_id": "", "url": "https://api.github.com/users/balloonz", "html_url": "https://github.com/balloonz", "followers_url": "https://api.github.com/users/balloonz/followers", "following_url": "https://api.github.com/users/balloonz/following{/other_user}", "gists_url": "https://api.github.com/users/balloonz/gists{/gist_id}", "starred_url": "https://api.github.com/users/balloonz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/balloonz/subscriptions", "organizations_url": "https://api.github.com/users/balloonz/orgs", "repos_url": "https://api.github.com/users/balloonz/repos", "events_url": "https://api.github.com/users/balloonz/events{/privacy}", "received_events_url": "https://api.github.com/users/balloonz/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Why are you manually specifying the ID for an auto-incrementing (opaque) primary key? The `bulk_create()` API is a shorthand for generating an `insert_many()`. Just use `insert_many()` if you really want to explicitly set these, I suppose.", "I was importing some data into the database which involve relational data.\r\nI thought `bulk_create()` as an alternative to `insert_many()` may also work.\r\nIf it is intended behavior, I will stick to `insert_many()`. \r\nThanks for the quick response. \r\n\r\n", "If you want, you can disable the primary keys `auto_increment` attribute during bulk loading, but (especially if you're just creating the models to insert the data only) insert many is probably a fine choice." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2472/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "chrisemke", "id": 63082743, "node_id": "MDQ6VXNlcjYzMDgyNzQz", "avatar_url": "https://avatars.githubusercontent.com/u/63082743?v=4", "gravatar_id": "", "url": "https://api.github.com/users/chrisemke", "html_url": "https://github.com/chrisemke", "followers_url": "https://api.github.com/users/chrisemke/followers", "following_url": "https://api.github.com/users/chrisemke/following{/other_user}", "gists_url": "https://api.github.com/users/chrisemke/gists{/gist_id}", "starred_url": "https://api.github.com/users/chrisemke/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/chrisemke/subscriptions", "organizations_url": "https://api.github.com/users/chrisemke/orgs", "repos_url": "https://api.github.com/users/chrisemke/repos", "events_url": "https://api.github.com/users/chrisemke/events{/privacy}", "received_events_url": "https://api.github.com/users/chrisemke/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Added basic support in: `playhouse.mysql_ext.MariaDBConnectorDatabase`" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2471/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ecpost", "id": 16603401, "node_id": "MDQ6VXNlcjE2NjAzNDAx", "avatar_url": "https://avatars.githubusercontent.com/u/16603401?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ecpost", "html_url": "https://github.com/ecpost", "followers_url": "https://api.github.com/users/ecpost/followers", "following_url": "https://api.github.com/users/ecpost/following{/other_user}", "gists_url": "https://api.github.com/users/ecpost/gists{/gist_id}", "starred_url": "https://api.github.com/users/ecpost/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ecpost/subscriptions", "organizations_url": "https://api.github.com/users/ecpost/orgs", "repos_url": "https://api.github.com/users/ecpost/repos", "events_url": "https://api.github.com/users/ecpost/events{/privacy}", "received_events_url": "https://api.github.com/users/ecpost/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The columns you can filter on are added as HIDDEN columns *after* the exported columns. So you would have:\r\n\r\n```\r\ntable func: series(<start=0>, <stop=None>, <step=1>)\r\n\r\nclass Series(TableFunction):\r\n params = ['start', 'stop', 'step']\r\n columns = ['value']\r\n\r\n...\r\n\r\nCREATE VIRTUAL TABLE series(start, stop, step, value HIDDEN)\r\n```\r\n\r\nWhen looking up the constrained column, we subtract from it the number of \"non-hidden\" columns to get the index of the hidden/parameterized column.\r\n\r\nI've added a check that this value does not drop below zero: 56fe72362a65199eb75bf25684eb290c57e3a37f", "Ah, ok. So that line is only meant to apply to those hidden columns, which would only be the non-negative cases. Thanks for the quick response and fix!" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2470/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Gaming32", "id": 42721887, "node_id": "MDQ6VXNlcjQyNzIxODg3", "avatar_url": "https://avatars.githubusercontent.com/u/42721887?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Gaming32", "html_url": "https://github.com/Gaming32", "followers_url": "https://api.github.com/users/Gaming32/followers", "following_url": "https://api.github.com/users/Gaming32/following{/other_user}", "gists_url": "https://api.github.com/users/Gaming32/gists{/gist_id}", "starred_url": "https://api.github.com/users/Gaming32/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Gaming32/subscriptions", "organizations_url": "https://api.github.com/users/Gaming32/orgs", "repos_url": "https://api.github.com/users/Gaming32/repos", "events_url": "https://api.github.com/users/Gaming32/events{/privacy}", "received_events_url": "https://api.github.com/users/Gaming32/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Detailed walkthrough of `Context.value`:\r\n```python\r\n def value(self, value, converter=None, add_param=True):\r\n # add_param = True\r\n # converter = <bound method Field.db_value of <CharField: User.token>>\r\n # value = 'ba8a310b920ece30e4e28e6f67d40a53'\r\n if converter:\r\n value = converter(value)\r\n elif converter is None and self.state.converter:\r\n # Explicitly check for None so that \"False\" can be used to signify\r\n # that no conversion should be applied.\r\n value = self.state.converter(value)\r\n\r\n # value is still 'ba8a310b920ece30e4e28e6f67d40a53'\r\n if isinstance(value, Node):\r\n with self(converter=None):\r\n return self.sql(value)\r\n elif is_model(value):\r\n # Under certain circumstances, we could end-up treating a model-\r\n # class itself as a value. This check ensures that we drop the\r\n # table alias into the query instead of trying to parameterize a\r\n # model (for instance, passing a model as a function argument).\r\n with self.scope_column():\r\n return self.sql(value)\r\n\r\n self._values.append(value) # Values obtains the value 'ba8a310b920ece30e4e28e6f67d40a53'\r\n return self.literal(self.state.param or '?') if add_param else self # self.literal('?') is called, as add_param is True\r\n```", "The ? is the param placeholder. Parameters are bound the placeholders. This is to avoid sql injections.", "It prevents the database from being updated though", "How do I put a string into my database then?", "Do you mean to imply that the fundamental operation of updating data is completely broken?", "```python\r\ndb = SqliteDatabase(':memory:')\r\n\r\nclass User(Model):\r\n token = TextField()\r\n class Meta:\r\n database = db\r\n\r\nUser.create_table()\r\n\r\nuser = User.create(token='')\r\nuser.save()\r\n\r\nuser.token = 'new-token'\r\nuser.save()\r\n\r\nuser_db = User.get(User.id == user.id)\r\nprint(user_db.id, user_db.token)\r\n\r\nUser.update(token='new2').where(User.id == user.id).execute()\r\n\r\nuser_db = User.get(User.id == user.id)\r\nprint(user_db.id, user_db.token)\r\n```\r\n\r\nPrints\r\n\r\n```\r\n1 new-token\r\n1 new2\r\n```", "Why was my comment deleted? I need legitimate help here. " ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2469/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "milesgranger", "id": 13764397, "node_id": "MDQ6VXNlcjEzNzY0Mzk3", "avatar_url": "https://avatars.githubusercontent.com/u/13764397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/milesgranger", "html_url": "https://github.com/milesgranger", "followers_url": "https://api.github.com/users/milesgranger/followers", "following_url": "https://api.github.com/users/milesgranger/following{/other_user}", "gists_url": "https://api.github.com/users/milesgranger/gists{/gist_id}", "starred_url": "https://api.github.com/users/milesgranger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/milesgranger/subscriptions", "organizations_url": "https://api.github.com/users/milesgranger/orgs", "repos_url": "https://api.github.com/users/milesgranger/repos", "events_url": "https://api.github.com/users/milesgranger/events{/privacy}", "received_events_url": "https://api.github.com/users/milesgranger/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is a Postgres limitation - for some reason Postgres does not behave well with certain data-types in these expressions. Related issues:\r\n\r\n* #2457\r\n* #2308\r\n* #2292\r\n* https://dba.stackexchange.com/questions/228046/why-do-i-need-to-cast-null-to-column-type/228058#228058\r\n\r\nI cannot really offer a solution at this time, other than to suggest using individual updates / calls to `save()`. Doing updates in a loop inside a transaction may be just as fast (if not faster) than the `bulk_update` anyways.", "Thank you, appreciate the information! :pray: " ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2468/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "iamthen0ise", "id": 1730030, "node_id": "MDQ6VXNlcjE3MzAwMzA=", "avatar_url": "https://avatars.githubusercontent.com/u/1730030?v=4", "gravatar_id": "", "url": "https://api.github.com/users/iamthen0ise", "html_url": "https://github.com/iamthen0ise", "followers_url": "https://api.github.com/users/iamthen0ise/followers", "following_url": "https://api.github.com/users/iamthen0ise/following{/other_user}", "gists_url": "https://api.github.com/users/iamthen0ise/gists{/gist_id}", "starred_url": "https://api.github.com/users/iamthen0ise/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iamthen0ise/subscriptions", "organizations_url": "https://api.github.com/users/iamthen0ise/orgs", "repos_url": "https://api.github.com/users/iamthen0ise/repos", "events_url": "https://api.github.com/users/iamthen0ise/events{/privacy}", "received_events_url": "https://api.github.com/users/iamthen0ise/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You are using the transaction bit incorrectly I would say. Here's how I would do it:\r\n\r\n```python\r\n\r\nfor item in insert_items:\r\n with db.atomic() as txn:\r\n try:\r\n model.create(**item)\r\n except IntegrityError:\r\n txn.rollback()\r\n else:\r\n txn.commit()\r\n```", "Still getting `current transaction is aborted, commands ignored until end of transaction block` using described method.", "I'm sure you have some bug in your code. This works just fine:\r\n\r\n```python\r\ndb = PostgresqlDatabase('peewee_test')\r\n\r\nclass Reg(Model):\r\n key = CharField(unique=True)\r\n class Meta:\r\n database = db\r\n\r\ndb.create_tables([Reg])\r\nfor k in 'abcadaec':\r\n with db.atomic() as txn:\r\n try:\r\n Reg.create(key=k)\r\n except IntegrityError:\r\n txn.rollback()\r\n else:\r\n txn.commit()\r\n\r\nassert [r.key for r in Reg.select().order_by(Reg.key)] == list('abcde')\r\ndb.drop_tables([Reg])\r\n\r\n```", "Hmm, it works for soft inserts like `model.get_or_create()`, but causes block for strict `create` operation.\r\n\r\nDon't know if it good by design, but it helps me and all working like magic now. Will check the sources for reference.\r\n\r\nThank you for your help! :) " ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2467/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "penja", "id": 2717390, "node_id": "MDQ6VXNlcjI3MTczOTA=", "avatar_url": "https://avatars.githubusercontent.com/u/2717390?v=4", "gravatar_id": "", "url": "https://api.github.com/users/penja", "html_url": "https://github.com/penja", "followers_url": "https://api.github.com/users/penja/followers", "following_url": "https://api.github.com/users/penja/following{/other_user}", "gists_url": "https://api.github.com/users/penja/gists{/gist_id}", "starred_url": "https://api.github.com/users/penja/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/penja/subscriptions", "organizations_url": "https://api.github.com/users/penja/orgs", "repos_url": "https://api.github.com/users/penja/repos", "events_url": "https://api.github.com/users/penja/events{/privacy}", "received_events_url": "https://api.github.com/users/penja/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks, this should be fixed now.", "@coleifer Thank you for so hot fix." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2466/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "sherrrrr", "id": 31510228, "node_id": "MDQ6VXNlcjMxNTEwMjI4", "avatar_url": "https://avatars.githubusercontent.com/u/31510228?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sherrrrr", "html_url": "https://github.com/sherrrrr", "followers_url": "https://api.github.com/users/sherrrrr/followers", "following_url": "https://api.github.com/users/sherrrrr/following{/other_user}", "gists_url": "https://api.github.com/users/sherrrrr/gists{/gist_id}", "starred_url": "https://api.github.com/users/sherrrrr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sherrrrr/subscriptions", "organizations_url": "https://api.github.com/users/sherrrrr/orgs", "repos_url": "https://api.github.com/users/sherrrrr/repos", "events_url": "https://api.github.com/users/sherrrrr/events{/privacy}", "received_events_url": "https://api.github.com/users/sherrrrr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You overrode the pk, now just subclass `ForeignKeyField` and override the field_type property:\r\n\r\n```python\r\nclass UnsignedBigAutoField(BigAutoField):\r\n field_type = 'BIGINT UNSIGNED AUTO_INCREMENT'\r\n\r\nclass UnsignedForeignKeyField(ForeignKeyField):\r\n field_type = 'BIGINT UNSIGNED'\r\n\r\nclass User(Base):\r\n id = UnsignedBigAutoField()\r\n\r\nclass Tweet(Base):\r\n id = UnsignedBigAutoField()\r\n user = UnsignedForeignKeyField(User)\r\n```" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2465/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "sherrrrr", "id": 31510228, "node_id": "MDQ6VXNlcjMxNTEwMjI4", "avatar_url": "https://avatars.githubusercontent.com/u/31510228?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sherrrrr", "html_url": "https://github.com/sherrrrr", "followers_url": "https://api.github.com/users/sherrrrr/followers", "following_url": "https://api.github.com/users/sherrrrr/following{/other_user}", "gists_url": "https://api.github.com/users/sherrrrr/gists{/gist_id}", "starred_url": "https://api.github.com/users/sherrrrr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sherrrrr/subscriptions", "organizations_url": "https://api.github.com/users/sherrrrr/orgs", "repos_url": "https://api.github.com/users/sherrrrr/repos", "events_url": "https://api.github.com/users/sherrrrr/events{/privacy}", "received_events_url": "https://api.github.com/users/sherrrrr/received_events", "type": "User", "site_admin": false }

[]

[]

[ ">At first I thought every request is default to master, then I found that if one request switch to slave, _database in User became slave, then if gevent switch to another greenlet with a new request, then User's database is default to slave.\r\n\r\nYeah, I think you're right actually, and the implementation needs a change. Originally the idea I had was to just make sure that binding was a thread-safe operation, and that within a running thread, a different thread cannot alter the db. But, as you indicate, it also makes sense to me to preserve the \"default\" db.\r\n\r\nYou can use your patch or you can try out this commit: 00498bfc073569a63cb30fa43d706fdcc3e14dc0" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2464/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Sonotoki-da", "id": 34913890, "node_id": "MDQ6VXNlcjM0OTEzODkw", "avatar_url": "https://avatars.githubusercontent.com/u/34913890?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Sonotoki-da", "html_url": "https://github.com/Sonotoki-da", "followers_url": "https://api.github.com/users/Sonotoki-da/followers", "following_url": "https://api.github.com/users/Sonotoki-da/following{/other_user}", "gists_url": "https://api.github.com/users/Sonotoki-da/gists{/gist_id}", "starred_url": "https://api.github.com/users/Sonotoki-da/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Sonotoki-da/subscriptions", "organizations_url": "https://api.github.com/users/Sonotoki-da/orgs", "repos_url": "https://api.github.com/users/Sonotoki-da/repos", "events_url": "https://api.github.com/users/Sonotoki-da/events{/privacy}", "received_events_url": "https://api.github.com/users/Sonotoki-da/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The problem is here. Calling `query.get()` returns a model instance (if one exists) or raises a `DoesNotExist` if not. You are comparing the return value to `is True` -- and while the result (a model instance) is \"truthy\", it is *not* `True` - it is a model instance.\r\n\r\n```python\r\nif q.get_user_status(user_id=123456) is True:\r\n print(\"Subscribed\")\r\nelse:\r\n print(\"Not subscribed yet\")\r\n```\r\n\r\nYou should instead write:\r\n\r\n```python\r\ntry:\r\n user = q.get_user_status(user_id=123456)\r\nexcept q.TgUser.DoesNotExist:\r\n # user with id=123456 does not exist\r\n print('user does not exist')\r\nelse:\r\n if user.subscribed:\r\n print('subscribed')\r\n else:\r\n print('not subscribed')\r\n```", "omg... Thank you very much! > < It's working now!\r\nAnd sorry for taking your time to this kind of question :') I'll study further!" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2463/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "sherrrrr", "id": 31510228, "node_id": "MDQ6VXNlcjMxNTEwMjI4", "avatar_url": "https://avatars.githubusercontent.com/u/31510228?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sherrrrr", "html_url": "https://github.com/sherrrrr", "followers_url": "https://api.github.com/users/sherrrrr/followers", "following_url": "https://api.github.com/users/sherrrrr/following{/other_user}", "gists_url": "https://api.github.com/users/sherrrrr/gists{/gist_id}", "starred_url": "https://api.github.com/users/sherrrrr/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sherrrrr/subscriptions", "organizations_url": "https://api.github.com/users/sherrrrr/orgs", "repos_url": "https://api.github.com/users/sherrrrr/repos", "events_url": "https://api.github.com/users/sherrrrr/events{/privacy}", "received_events_url": "https://api.github.com/users/sherrrrr/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is expected, if somewhat non-obvious. The whole purpose of using the `ThreadSafeDatabaseMetadata` is for when you plan to switch the database at run-time in a multi-threaded application, so the assumption is that at multiple points during runtime you will be explicitly binding the models to a database, e.g.:\r\n\r\n```python\r\n\r\n# BaseModel declares that it uses ThreadSafeDatabaseMetadata\r\n\r\nclass A(BaseModel):\r\n pass\r\n\r\nclass B(BaseModel):\r\n pass\r\n\r\nmaster = PostgresqlDatabase(...)\r\nreplica = PostgresqlDatabase(...)\r\n\r\n# Explicitly bind the models.\r\nmaster.bind([A, B])\r\n```\r\n\r\nWith that said, it *should* still inherit the \"default\" or original Meta.database, so I will put together a patch for this.", "b782657823a64fcdef6674cadccb2f2679933e6f" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2462/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "bgriffen", "id": 2667869, "node_id": "MDQ6VXNlcjI2Njc4Njk=", "avatar_url": "https://avatars.githubusercontent.com/u/2667869?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bgriffen", "html_url": "https://github.com/bgriffen", "followers_url": "https://api.github.com/users/bgriffen/followers", "following_url": "https://api.github.com/users/bgriffen/following{/other_user}", "gists_url": "https://api.github.com/users/bgriffen/gists{/gist_id}", "starred_url": "https://api.github.com/users/bgriffen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bgriffen/subscriptions", "organizations_url": "https://api.github.com/users/bgriffen/orgs", "repos_url": "https://api.github.com/users/bgriffen/repos", "events_url": "https://api.github.com/users/bgriffen/events{/privacy}", "received_events_url": "https://api.github.com/users/bgriffen/received_events", "type": "User", "site_admin": false }

[]

[]

[ "It turns out you can't feed it a list of dictionaries like you can with `insert_many`. I worked around it by creating a list of instances. Not sure if this is the best solution to my situation but it works.\r\n\r\n```python\r\nupdates = []\r\nfor u in self.update_l:\r\n e = db.PaperDB(**u)\r\n updates.append(e)\r\n\r\nwith self.dbase.atomic():\r\n db.PaperDB.bulk_update(updates,fields=self.cols, batch_size=1000)\r\n```\r\n", "The docs should make this clear: http://docs.peewee-orm.com/en/latest/peewee/api.html#Model.bulk_update\r\n\r\nAlso note that the way `bulk_update()` is implemented, it uses a couple tricks to try to do it efficiently. **However** it may actually be more performant and simple to just issue an UPDATE for each model instance/row and do this within a transaction. I suggest going with the simplest possible thing until you find that it has become a significant bottleneck." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2461/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Baloneo", "id": 16448666, "node_id": "MDQ6VXNlcjE2NDQ4NjY2", "avatar_url": "https://avatars.githubusercontent.com/u/16448666?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Baloneo", "html_url": "https://github.com/Baloneo", "followers_url": "https://api.github.com/users/Baloneo/followers", "following_url": "https://api.github.com/users/Baloneo/following{/other_user}", "gists_url": "https://api.github.com/users/Baloneo/gists{/gist_id}", "starred_url": "https://api.github.com/users/Baloneo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Baloneo/subscriptions", "organizations_url": "https://api.github.com/users/Baloneo/orgs", "repos_url": "https://api.github.com/users/Baloneo/repos", "events_url": "https://api.github.com/users/Baloneo/events{/privacy}", "received_events_url": "https://api.github.com/users/Baloneo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "There are a couple ways, but probably the one I recommend for dynamically building up a query is to use reduce:\r\n\r\n```python\r\n\r\nexprs = []\r\nif name:\r\n exprs.append(ProductType.name == name)\r\nif other:\r\n exprs.append(ProductType.other == other)\r\n\r\nif exprs:\r\n query = query.where(reduce(operator.and_, exprs))\r\n```\r\n\r\nSince you're using the same operator (AND) you can also just chain the calls:\r\n\r\n```python\r\n\r\nquery = ProductType.select()\r\nif name:\r\n query = query.where(ProductType.name == name)\r\nif other:\r\n query = query.where(ProductType.other == other)\r\n...\r\n```", "thanks!" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2460/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "LVerneyPEReN", "id": 58298410, "node_id": "MDQ6VXNlcjU4Mjk4NDEw", "avatar_url": "https://avatars.githubusercontent.com/u/58298410?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LVerneyPEReN", "html_url": "https://github.com/LVerneyPEReN", "followers_url": "https://api.github.com/users/LVerneyPEReN/followers", "following_url": "https://api.github.com/users/LVerneyPEReN/following{/other_user}", "gists_url": "https://api.github.com/users/LVerneyPEReN/gists{/gist_id}", "starred_url": "https://api.github.com/users/LVerneyPEReN/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LVerneyPEReN/subscriptions", "organizations_url": "https://api.github.com/users/LVerneyPEReN/orgs", "repos_url": "https://api.github.com/users/LVerneyPEReN/repos", "events_url": "https://api.github.com/users/LVerneyPEReN/events{/privacy}", "received_events_url": "https://api.github.com/users/LVerneyPEReN/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Sqlite does not have a dedicated date/datetime type. It is up to you, the developer, to ensure that your datetimes are stored in a way that supports correct lexicographic ordering. Additionally, Peewee does not apply any conversion at all to datetime objects - it hands them as-is to the db driver. It is actually the sqlite driver that is handling the conversion for sqlite: (`import sqlite3; sqlite3.adapters`). This is consistent and supports lexicographic ordering, but if you've stored your datetimes in ISO format in Sqlite, then you may have some work to do to get them working properly with python's sqlite3 module.\r\n\r\nYou can:\r\n\r\n* register a different adapter for `datetime.datetime` that converts them to string in iso format - this may be the easiest\r\n* write a custom `DateTimeField` subclass that implements a `db_value()` method that returns the datetime in isoformat\r\n* update your data to use the python format (probably undesirable, but mentioning it as a possibility)\r\n\r\nAll that said, at the end of the day this is not really a peewee issue -- this is a consequence of the behavior of the python sqlite driver and sqlite's own lack of a dedicated datetime type.", "Thanks for the very quick response, this is indeed an issue due to having iso formatted values in db!\r\n\r\nI tried to debug how they happened to get there, and it seems `DateTimeField` does not convert iso formatted datetime strings to a date object, but rather append them silently to the database.\r\n\r\nThis seems to be an easy mistake which could happen often, and quite silent.\r\n\r\nWhat about extending https://github.com/coleifer/peewee/blob/master/peewee.py#L4971-L4975 to also support isoformat formats?\r\n\r\nI think something like\r\n\r\n```python\r\nformats = [\r\n '%Y-%m-%dT%H:%M:%S.%f%z',\r\n '%Y-%m-%dT%H:%M:%S.%f',\r\n '%Y-%m-%d %H:%M:%S.%f',\r\n '%Y-%m-%dT%H:%M:%S%z',\r\n '%Y-%m-%dT%H:%M:%S',\r\n '%Y-%m-%d %H:%M:%S',\r\n '%Y-%m-%d',\r\n]\r\n```\r\n\r\nshould handle all these cases properly.\r\n\r\n**EDIT**: The same formats addition is probably required as well in `DateField` and `TimeField`. I may have missed something, but I don't see any reason why isoformatted strings would not get promoted to relevant date objects for proper addition by peewee.\r\n\r\nThanks!", "That will allow you to read them back but the problem is still that the data in your db was written in iso format.\r\n\r\nSubclassing and implementing your formats and the corresponding db_value() method should cover all the bases.", "To expand on my comment, there are 2 sides to the adaptation process. The side where you take a python value (a datetime in this example) and convert it to something the db understands, and the other side where you get a value from the db and convert it to something python understands.\r\n\r\nJust extending the `formats` won't really help because it only affects the 2nd side (going from db -> python). That's why I suggested implementing `db_value()` which will correctly convert the datetime to an isoformat string before sending it to the db.\r\n\r\n```python\r\n\r\n# minimal example\r\nclass ISODateTimeField(DateTimeField):\r\n def db_value(self, val):\r\n if val is not None:\r\n return val.isoformat()\r\n def python_value(self, val):\r\n if val is not None:\r\n return datetime.datetime.strptime(val, '%Y-%m-%dT%H:%M:%S.%f')\r\n```", "Sorry, I think my latest comment may not have been clear about the details of my error (and history) and my proposal.\r\n\r\nFirst, I should emphasize that BETWEEN operation is behaving as expected for datetime objects. The issue boils down to database insertion. Then, I should also emphasize that I do not have a pre-existent database but am creating a database from scratch using Peewee from the beginning and pushing data into it.\r\n\r\nMy mistake and the source of this issue boils down to how Peewee deals with incompatible values with compatible types for datetime fields.\r\n\r\nHere is a minimal illustration about upon the quickstart page of the docs :\r\n\r\n\r\n```python\r\nfrom datetime import datetime\r\nfrom peewee import *\r\n\r\ndb = SqliteDatabase('people.db')\r\n\r\nclass Person(Model):\r\n name = CharField()\r\n birthday = DateTimeField()\r\n\r\n class Meta:\r\n database = db # This model uses the \"people.db\" database.\r\n\r\ndb.connect()\r\ndb.create_tables([Person])\r\n\r\n\r\n# Create a person with a datetime object as birthday, this is the most typical use case\r\nuncle_bob = Person(name='Bob', birthday=datetime(1960, 1, 15, 1, 0, 0))\r\nuncle_bob.save()\r\n\r\n# Create a person with a string representing a date. String format matches one of https://github.com/coleifer/peewee/blob/master/peewee.py#L4971-L4975 so we hit https://github.com/coleifer/peewee/blob/master/peewee.py#L4948 and it is promoted to datetime object.\r\n# This is therefore **the same behavior** as before, as expected\r\nuncle_sam = Person(\r\n name='Sam',\r\n birthday=\"1960-01-15 01:00:00\"\r\n)\r\nuncle_sam.save()\r\n\r\n# Create a person with an isoformatted string. This format does not match any of the known formats for DateTimeField, so we hit https://github.com/coleifer/peewee/blob/master/peewee.py#L4949-L4951 which is completely silent and the value is inserted as is in the database.\r\n# This is how I ended up with isoformatted dates in my db, by (incorrectly) manipulating an isoformatted string at some point (while I thought I had a datetime object) and Peewee / sqlite3 not throwing any error at me.\r\nuncle_tom = Person(\r\n name='tom',\r\n birthday=\"1960-01-15T01:00:00Z\"\r\n)\r\nuncle_tom.save()\r\n\r\n# Note that when the object type is incompatible, sqlite3 will shout. But for any string which does not match a known date format, it gets inserted as is in the db.\r\nuncle_guy = Person(name='Guy', birthday=\"This is definitely not a date\")\r\nuncle_guy.save() #\r\n```\r\n\r\n\r\n\r\nI feel like the fact that Peewee supports some date string formats is giving the wrong message that passing string instead of datetime object is safe, and one is likely to assume isoformatted datetime is fine. This is not the case.\r\n\r\nSo, I would like Peewee to minimize the possibility to reproduce this error (while trying to reduce the extra work on Peewee to a minimum) by:\r\n* Adding new formats in https://github.com/coleifer/peewee/blob/master/peewee.py#L4971-L4975 to support isoformatted dates the same way as the other date format. See https://github.com/coleifer/peewee/issues/2459#issuecomment-905605324.\r\n* Probably add a `logging.warning` item in https://github.com/coleifer/peewee/blob/master/peewee.py#L4950 so that this promotion error is no longer silent and the user has some form of easy discovery that they are not using Peewee the right way.\r\n\r\nI can offer to handle a PR for this if this can be useful and you agree with my reading of this issue.", "I'd suggest doing stronger validation before insertion into the DB and keeping in mind Sqlite's loose typing -- for fiddly things like datetimes this can be a gotcha for Sqlite users as it is up to you to be consistent about how you insert them to preserve ordering. I don't plan to make changes on the Peewee side at this time." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2459/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "netsamir", "id": 1165885, "node_id": "MDQ6VXNlcjExNjU4ODU=", "avatar_url": "https://avatars.githubusercontent.com/u/1165885?v=4", "gravatar_id": "", "url": "https://api.github.com/users/netsamir", "html_url": "https://github.com/netsamir", "followers_url": "https://api.github.com/users/netsamir/followers", "following_url": "https://api.github.com/users/netsamir/following{/other_user}", "gists_url": "https://api.github.com/users/netsamir/gists{/gist_id}", "starred_url": "https://api.github.com/users/netsamir/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/netsamir/subscriptions", "organizations_url": "https://api.github.com/users/netsamir/orgs", "repos_url": "https://api.github.com/users/netsamir/repos", "events_url": "https://api.github.com/users/netsamir/events{/privacy}", "received_events_url": "https://api.github.com/users/netsamir/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi,\r\n\r\nI think I have found the solution to my problem by logging with DEBUG.\r\n\r\nI have rewritten the query like that :\r\n\r\n for row in User.select(User.Service, fn.count(1).alias('count')).group_by(User.Service):\r\n print(row.Service, row.count)\r\n\r\n DEBUG:peewee:('SELECT \"t1\".\"Service\", count(?) AS \"count\" FROM \"sag\" AS \"t1\" GROUP BY \"t1\".\"Service\"', [1])\r\n\r\ninstead of \r\n\r\n DEBUG:peewee:('SELECT \"t1\".\"id\", \"t1\".\"LogSysTime\", \"t1\".\"LogCorrelationId\", \"t1\".\"ApplicationId\", \"t1\".\"UnitName\", \"t1\".\"Primitive\", \"t1\".\"Priority\", \"t1\".\"RequControl\", \"t1\".\"RequtRef\", \"t1\".\"RequType\", \"t1\".\"Requestor\", \"t1\".\"Resp\", \"t1\".\"ReserRef\", \"t1\".\"ResponseControl\", \"t1\".\"Service\", \"t1\".\"Status\", \"t1\".\"SwtRef\", \"t1\".\"SwRequestRef\", \"t1\".\"SwResponseRef\", \"t1\".\"SwTime\", \"t1\".\"TransferRef\", \"t1\".\"PayloadSize\", count(?) AS \"count\" FROM \"sag\" AS \"t1\" GROUP BY \"t1\".\"Service\"', [1])", "If you were using postgres your first query would not have even run because you were selecting all columns but only grouping by one of them.\r\n\r\nThe second query is correct:\r\n\r\n q = User.select(User.Service, fn.count(User.id).alias('count')).group_by(User.Service)" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2458/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "milesgranger", "id": 13764397, "node_id": "MDQ6VXNlcjEzNzY0Mzk3", "avatar_url": "https://avatars.githubusercontent.com/u/13764397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/milesgranger", "html_url": "https://github.com/milesgranger", "followers_url": "https://api.github.com/users/milesgranger/followers", "following_url": "https://api.github.com/users/milesgranger/following{/other_user}", "gists_url": "https://api.github.com/users/milesgranger/gists{/gist_id}", "starred_url": "https://api.github.com/users/milesgranger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/milesgranger/subscriptions", "organizations_url": "https://api.github.com/users/milesgranger/orgs", "repos_url": "https://api.github.com/users/milesgranger/repos", "events_url": "https://api.github.com/users/milesgranger/events{/privacy}", "received_events_url": "https://api.github.com/users/milesgranger/received_events", "type": "User", "site_admin": false }

[]

[]

[ "See #2308" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2457/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "ekiim", "id": 6476691, "node_id": "MDQ6VXNlcjY0NzY2OTE=", "avatar_url": "https://avatars.githubusercontent.com/u/6476691?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekiim", "html_url": "https://github.com/ekiim", "followers_url": "https://api.github.com/users/ekiim/followers", "following_url": "https://api.github.com/users/ekiim/following{/other_user}", "gists_url": "https://api.github.com/users/ekiim/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekiim/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekiim/subscriptions", "organizations_url": "https://api.github.com/users/ekiim/orgs", "repos_url": "https://api.github.com/users/ekiim/repos", "events_url": "https://api.github.com/users/ekiim/events{/privacy}", "received_events_url": "https://api.github.com/users/ekiim/received_events", "type": "User", "site_admin": false }

[]

[]

[ "No, mocking a sql database is an extremely complex affair. Most people use shallow mocks or just an in memory sqlite database for testing." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2456/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "aparcar", "id": 16000931, "node_id": "MDQ6VXNlcjE2MDAwOTMx", "avatar_url": "https://avatars.githubusercontent.com/u/16000931?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aparcar", "html_url": "https://github.com/aparcar", "followers_url": "https://api.github.com/users/aparcar/followers", "following_url": "https://api.github.com/users/aparcar/following{/other_user}", "gists_url": "https://api.github.com/users/aparcar/gists{/gist_id}", "starred_url": "https://api.github.com/users/aparcar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aparcar/subscriptions", "organizations_url": "https://api.github.com/users/aparcar/orgs", "repos_url": "https://api.github.com/users/aparcar/repos", "events_url": "https://api.github.com/users/aparcar/events{/privacy}", "received_events_url": "https://api.github.com/users/aparcar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Actually the solution is as simple as `(idlist.split(\",\") if idlist else [])`", "a643a6952372e22ce658c8ca9a23322bb4b2ab57" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2455/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/coleifer/peewee/pulls/2455", "html_url": "https://github.com/coleifer/peewee/pull/2455", "diff_url": "https://github.com/coleifer/peewee/pull/2455.diff", "patch_url": "https://github.com/coleifer/peewee/pull/2455.patch", "merged_at": null }

{ "login": "madMathematician971", "id": 63659861, "node_id": "MDQ6VXNlcjYzNjU5ODYx", "avatar_url": "https://avatars.githubusercontent.com/u/63659861?v=4", "gravatar_id": "", "url": "https://api.github.com/users/madMathematician971", "html_url": "https://github.com/madMathematician971", "followers_url": "https://api.github.com/users/madMathematician971/followers", "following_url": "https://api.github.com/users/madMathematician971/following{/other_user}", "gists_url": "https://api.github.com/users/madMathematician971/gists{/gist_id}", "starred_url": "https://api.github.com/users/madMathematician971/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/madMathematician971/subscriptions", "organizations_url": "https://api.github.com/users/madMathematician971/orgs", "repos_url": "https://api.github.com/users/madMathematician971/repos", "events_url": "https://api.github.com/users/madMathematician971/events{/privacy}", "received_events_url": "https://api.github.com/users/madMathematician971/received_events", "type": "User", "site_admin": false }

[]

[]

[ "How is an upsert supposed to work across multiple tables? I think you do not understand how many-to-many actually works -- there is a junction table. There is no such thing as website.regions - that information is stored in the through table." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2454/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "wes9319", "id": 11861951, "node_id": "MDQ6VXNlcjExODYxOTUx", "avatar_url": "https://avatars.githubusercontent.com/u/11861951?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wes9319", "html_url": "https://github.com/wes9319", "followers_url": "https://api.github.com/users/wes9319/followers", "following_url": "https://api.github.com/users/wes9319/following{/other_user}", "gists_url": "https://api.github.com/users/wes9319/gists{/gist_id}", "starred_url": "https://api.github.com/users/wes9319/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wes9319/subscriptions", "organizations_url": "https://api.github.com/users/wes9319/orgs", "repos_url": "https://api.github.com/users/wes9319/repos", "events_url": "https://api.github.com/users/wes9319/events{/privacy}", "received_events_url": "https://api.github.com/users/wes9319/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I don't know if I can change this logic without introducing a possible regression for users who select arbitrary sql functions and do not alias them. The current logic looks if there's a \".\" within the column name, takes the stuff to the right of it and strips `\"` and `)`, e.g.:\r\n\r\nUPPER(\"t1\".\"name\") -> \"name\") -> name\r\n\r\nThe downside is that this logic is also being applied to explicitly-given aliases. Let me think about it.", "The fix involved basically ensuring that user-provided aliases would be preserved, but at the same time I've tried to improve the logic when guessing at the intended destination column when it is not provided." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2453/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "SilvanVerhoeven", "id": 44174681, "node_id": "MDQ6VXNlcjQ0MTc0Njgx", "avatar_url": "https://avatars.githubusercontent.com/u/44174681?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SilvanVerhoeven", "html_url": "https://github.com/SilvanVerhoeven", "followers_url": "https://api.github.com/users/SilvanVerhoeven/followers", "following_url": "https://api.github.com/users/SilvanVerhoeven/following{/other_user}", "gists_url": "https://api.github.com/users/SilvanVerhoeven/gists{/gist_id}", "starred_url": "https://api.github.com/users/SilvanVerhoeven/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SilvanVerhoeven/subscriptions", "organizations_url": "https://api.github.com/users/SilvanVerhoeven/orgs", "repos_url": "https://api.github.com/users/SilvanVerhoeven/repos", "events_url": "https://api.github.com/users/SilvanVerhoeven/events{/privacy}", "received_events_url": "https://api.github.com/users/SilvanVerhoeven/received_events", "type": "User", "site_admin": false }

[]

[]

[ "What version of sqlite are you using?", "The requirements.txt requires peewee 3.9.6", "No, what version of sqlite.", "I'm sorry. SQLite 3.31.1 (retrieved via `select sqlite_version()`)", "This example code is working fine for me, I suppose you have some issue in your code or you can try updating your peewee if the code below does not work for you:\r\n\r\n```python\r\nfrom peewee import *\r\n\r\ndb = SqliteDatabase(':memory:')\r\n\r\nclass Foo(Model):\r\n name = TextField()\r\n class Meta: database = db\r\n\r\ndb.create_tables([Foo])\r\nfor name in ('huey', 'mickey', 'zaizee'):\r\n Foo.create(name=name)\r\n\r\ndb.execute_sql('create view foo_view as select upper(name) as name from foo')\r\nclass FooView(Foo):\r\n class Meta:\r\n primary_key = False\r\n table_name = 'foo_view'\r\n\r\nprint([row.name for row in FooView.select()])\r\n```\r\n\r\nPrints: `['HUEY', 'MICKEY', 'ZAIZEE']`" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2452/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "Baloneo", "id": 16448666, "node_id": "MDQ6VXNlcjE2NDQ4NjY2", "avatar_url": "https://avatars.githubusercontent.com/u/16448666?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Baloneo", "html_url": "https://github.com/Baloneo", "followers_url": "https://api.github.com/users/Baloneo/followers", "following_url": "https://api.github.com/users/Baloneo/following{/other_user}", "gists_url": "https://api.github.com/users/Baloneo/gists{/gist_id}", "starred_url": "https://api.github.com/users/Baloneo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Baloneo/subscriptions", "organizations_url": "https://api.github.com/users/Baloneo/orgs", "repos_url": "https://api.github.com/users/Baloneo/repos", "events_url": "https://api.github.com/users/Baloneo/events{/privacy}", "received_events_url": "https://api.github.com/users/Baloneo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "db.close()\r\n```\r\n'Attempting to close database while '\r\npeewee.OperationalError: Attempting to close database while transaction is open\r\n```", "```\r\n\r\nclass ReconnectMixin(object):\r\n \"\"\"\r\n Mixin class that attempts to automatically reconnect to the database under\r\n certain error conditions.\r\n\r\n For example, MySQL servers will typically close connections that are idle\r\n for 28800 seconds (\"wait_timeout\" setting). If your application makes use\r\n of long-lived connections, you may find your connections are closed after\r\n a period of no activity. This mixin will attempt to reconnect automatically\r\n when these errors occur.\r\n\r\n This mixin class probably should not be used with Postgres (unless you\r\n REALLY know what you are doing) and definitely has no business being used\r\n with Sqlite. If you wish to use with Postgres, you will need to adapt the\r\n `reconnect_errors` attribute to something appropriate for Postgres.\r\n \"\"\"\r\n reconnect_errors = (\r\n # Error class, error message fragment (or empty string for all).\r\n (OperationalError, '2006'), # MySQL server has gone away.\r\n (OperationalError, '2013'), # Lost connection to MySQL server.\r\n (OperationalError, '2014'), # Commands out of sync.\r\n (InterfaceError, \"(0, '')\"), # add error \r\n\r\n # mysql-connector raises a slightly different error when an idle\r\n # connection is terminated by the server. This is equivalent to 2013.\r\n (OperationalError, 'MySQL Connection not available.'),\r\n )\r\n\r\n def __init__(self, *args, **kwargs):\r\n super(ReconnectMixin, self).__init__(*args, **kwargs)\r\n\r\n # Normalize the reconnect errors to a more efficient data-structure.\r\n self._reconnect_errors = {}\r\n for exc_class, err_fragment in self.reconnect_errors:\r\n self._reconnect_errors.setdefault(exc_class, [])\r\n self._reconnect_errors[exc_class].append(err_fragment.lower())\r\n\r\n def execute_sql(self, sql, params=None, commit=SENTINEL):\r\n try:\r\n return super(ReconnectMixin, self).execute_sql(sql, params, commit)\r\n except Exception as exc:\r\n exc_class = type(exc)\r\n if exc_class not in self._reconnect_errors:\r\n raise exc\r\n\r\n exc_repr = str(exc).lower()\r\n print('exc_repr', exc_repr, 'ccc', self._reconnect_errors[exc_class])\r\n for err_fragment in self._reconnect_errors[exc_class]:\r\n if err_fragment in exc_repr:\r\n break\r\n else:\r\n raise exc\r\n\r\n if not self.is_closed():\r\n print('in_transaction --->', db.in_transaction())\r\n self.close()\r\n self.connect()\r\n\r\n return super(ReconnectMixin, self).execute_sql(sql, params, commit)\r\n```\r\n`self.is_closed()` is `False`, but `db.in_transaction()` is `True`, in close function:\r\n```\r\n def close(self):\r\n with self._lock:\r\n if self.deferred:\r\n raise InterfaceError('Error, database must be initialized '\r\n 'before opening a connection.')\r\n if self.in_transaction():\r\n raise OperationalError('Attempting to close database while '\r\n 'transaction is open.')\r\n is_open = not self._state.closed\r\n try:\r\n if is_open:\r\n with __exception_wrapper__:\r\n self._close(self._state.conn)\r\n finally:\r\n self._state.reset()\r\n return is_open\r\n```\r\n\r\nalways raise OperationalError, caused to never reconnect successfully, Is there any good solution?\r\n\r\n\r\n", "The reconnecting mixin does not play well with transactions, but this should make sense to you if you think about it. What is peewee supposed to do upon reconnect? Re-execute any previous queries that were executed in the transaction?\r\n\r\nIn cases like these you probably need to handle it at the application level. Attempting to steamroll over the problems by reconnecting is not a good solution in any event." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2451/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "konradkur", "id": 22791650, "node_id": "MDQ6VXNlcjIyNzkxNjUw", "avatar_url": "https://avatars.githubusercontent.com/u/22791650?v=4", "gravatar_id": "", "url": "https://api.github.com/users/konradkur", "html_url": "https://github.com/konradkur", "followers_url": "https://api.github.com/users/konradkur/followers", "following_url": "https://api.github.com/users/konradkur/following{/other_user}", "gists_url": "https://api.github.com/users/konradkur/gists{/gist_id}", "starred_url": "https://api.github.com/users/konradkur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/konradkur/subscriptions", "organizations_url": "https://api.github.com/users/konradkur/orgs", "repos_url": "https://api.github.com/users/konradkur/repos", "events_url": "https://api.github.com/users/konradkur/events{/privacy}", "received_events_url": "https://api.github.com/users/konradkur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "This is not really exposed. Operations may be composed of multiple steps, so the migrations module uses an abstraction (`Operation`) to run potentially multiple queries. Additionally, steps may include validation that requires a previous step having been run (before the sql is generated). How do you get the sql for an operation in general, though (which may be composed of sub-operations)?\r\n\r\n```python\r\n# i think this should, generally, work\r\nop = migrator.add_column('my_sqlite_table', 'new_col', TextField(default=''))\r\nq = [op]\r\nwhile q:\r\n item = q.pop()\r\n if isinstance(item, Operation):\r\n kw = item.kwargs.copy()\r\n kw['with_context'] = True\r\n q.append(getattr(migrator, item.method)(*item.args, **kw))\r\n elif isinstance(item, list):\r\n q.extend(item[::-1])\r\n elif isinstance(item, Node):\r\n print(migrator.make_context().sql(item).query())\r\n else:\r\n print(item.query())\r\n```\r\n\r\nAlternatively, you can attach a sql log handler:\r\n\r\n```python\r\nimport logging\r\nlogger = logging.getLogger('peewee')\r\nlogger.addHandler(logging.StreamHandler())\r\nlogger.setLevel(logging.DEBUG)\r\n```" ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2450/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "AidenEllis", "id": 64432103, "node_id": "MDQ6VXNlcjY0NDMyMTAz", "avatar_url": "https://avatars.githubusercontent.com/u/64432103?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AidenEllis", "html_url": "https://github.com/AidenEllis", "followers_url": "https://api.github.com/users/AidenEllis/followers", "following_url": "https://api.github.com/users/AidenEllis/following{/other_user}", "gists_url": "https://api.github.com/users/AidenEllis/gists{/gist_id}", "starred_url": "https://api.github.com/users/AidenEllis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AidenEllis/subscriptions", "organizations_url": "https://api.github.com/users/AidenEllis/orgs", "repos_url": "https://api.github.com/users/AidenEllis/repos", "events_url": "https://api.github.com/users/AidenEllis/events{/privacy}", "received_events_url": "https://api.github.com/users/AidenEllis/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2449/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 1, "eyes": 0 }

{ "login": "Baloneo", "id": 16448666, "node_id": "MDQ6VXNlcjE2NDQ4NjY2", "avatar_url": "https://avatars.githubusercontent.com/u/16448666?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Baloneo", "html_url": "https://github.com/Baloneo", "followers_url": "https://api.github.com/users/Baloneo/followers", "following_url": "https://api.github.com/users/Baloneo/following{/other_user}", "gists_url": "https://api.github.com/users/Baloneo/gists{/gist_id}", "starred_url": "https://api.github.com/users/Baloneo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Baloneo/subscriptions", "organizations_url": "https://api.github.com/users/Baloneo/orgs", "repos_url": "https://api.github.com/users/Baloneo/repos", "events_url": "https://api.github.com/users/Baloneo/events{/privacy}", "received_events_url": "https://api.github.com/users/Baloneo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "table name is not a pointer, it is set and stored in the model class' `table_name` attribute. If you want to change it at run-time, then you need to call `ModelClass._meta.set_table_name()`." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2448/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "alexpirine", "id": 1610035, "node_id": "MDQ6VXNlcjE2MTAwMzU=", "avatar_url": "https://avatars.githubusercontent.com/u/1610035?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alexpirine", "html_url": "https://github.com/alexpirine", "followers_url": "https://api.github.com/users/alexpirine/followers", "following_url": "https://api.github.com/users/alexpirine/following{/other_user}", "gists_url": "https://api.github.com/users/alexpirine/gists{/gist_id}", "starred_url": "https://api.github.com/users/alexpirine/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alexpirine/subscriptions", "organizations_url": "https://api.github.com/users/alexpirine/orgs", "repos_url": "https://api.github.com/users/alexpirine/repos", "events_url": "https://api.github.com/users/alexpirine/events{/privacy}", "received_events_url": "https://api.github.com/users/alexpirine/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I like to keep it as a placeholder in case I want to fill it in." ]

{ "url": "https://api.github.com/repos/coleifer/peewee/issues/2447/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }