instruction
stringclasses 1
value | input
stringlengths 7
89.9k
| output
stringlengths 1
20.9k
|
|---|---|---|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-17 <BUGS> static void udf_pc_to_char ( struct super_block * sb , unsigned char * from , int fromlen , unsigned char * to ) <BUGE> { struct pathComponent * pc ; int elen = 0 ; <BUGS> <BUGE> unsigned char * p = to ; <BUGS> <BUGE> while ( elen < fromlen ) { pc = ( struct pathComponent * ) ( from + elen ) ; switch ( pc -> componentType ) { case 1 : if ( pc -> lengthComponentIdent > 0 ) break ; case 2 : <BUGS> <BUGE> p = to ; * p ++ = '/' ; <BUGS> <BUGE> break ; case 3 : <BUGS> <BUGE> memcpy ( p , "../" , 3 ) ; p += 3 ; <BUGS> <BUGE> break ; case 4 : <BUGS> <BUGE> memcpy ( p , "./" , 2 ) ; p += 2 ; <BUGS> <BUGE> break ; case 5 : <BUGS> p += udf_get_filename ( sb , pc -> componentIdent , p , pc -> lengthComponentIdent ) ; <BUGE> * p ++ = '/' ; <BUGS> <BUGE> break ; } elen += sizeof ( struct pathComponent ) + pc -> lengthComponentIdent ; } if ( p > to + 1 ) p [ - 1 ] = '\\0' ; else p [ 0 ] = '\\0' ; <BUGS> <BUGE> }
| <FIXS> static int udf_pc_to_char ( struct super_block * sb , unsigned char * from , int fromlen , unsigned char * to , int tolen ) <FIXE> <FIXS> int comp_len ; <FIXE> <FIXS> tolen -- ; <FIXE> <FIXS> if ( tolen == 0 ) return - ENAMETOOLONG ; <FIXE> <FIXS> tolen -- ; <FIXE> <FIXS> if ( tolen < 3 ) return - ENAMETOOLONG ; <FIXE> <FIXS> tolen -= 3 ; <FIXE> <FIXS> if ( tolen < 2 ) return - ENAMETOOLONG ; <FIXE> <FIXS> tolen -= 2 ; <FIXE> <FIXS> comp_len = udf_get_filename ( sb , pc -> componentIdent , pc -> lengthComponentIdent , p , tolen ) ; p += comp_len ; tolen -= comp_len ; if ( tolen == 0 ) return - ENAMETOOLONG ; <FIXE> <FIXS> tolen -- ; <FIXE> <FIXS> return 0 ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-20 static int fsck_gitmodules_fn ( const char * var , const char * value , void * vdata ) { struct fsck_gitmodules_data * data = vdata ; const char * subsection , * key ; int subsection_len ; char * name ; if ( parse_config_key ( var , "submodule" , & subsection , & subsection_len , & key ) < 0 || ! subsection ) return 0 ; name = xmemdupz ( subsection , subsection_len ) ; if ( check_submodule_name ( name ) < 0 ) data -> ret |= report ( data -> options , data -> obj , FSCK_MSG_GITMODULES_NAME , "disallowed submodule name: %s" , name ) ; if ( ! strcmp ( key , "url" ) && value && looks_like_command_line_option ( value ) ) data -> ret |= report ( data -> options , data -> obj , FSCK_MSG_GITMODULES_URL , "disallowed submodule url: %s" , value ) ; <BUGS> <BUGE> free ( name ) ; return 0 ; }
| <FIXS> if ( ! strcmp ( key , "path" ) && value && looks_like_command_line_option ( value ) ) data -> ret |= report ( data -> options , data -> obj , FSCK_MSG_GITMODULES_PATH , "disallowed submodule path: %s" , value ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-264 static void chase_port ( struct edgeport_port * port , unsigned long timeout , int flush ) { int baud_rate ; struct tty_struct * tty = tty_port_tty_get ( & port -> port -> port ) ; struct usb_serial * serial = port -> port -> serial ; wait_queue_t wait ; unsigned long flags ; <BUGS> <BUGE> if ( ! timeout ) timeout = ( HZ * EDGE_CLOSING_WAIT ) / 100 ; spin_lock_irqsave ( & port -> ep_lock , flags ) ; init_waitqueue_entry ( & wait , current ) ; add_wait_queue ( & tty -> write_wait , & wait ) ; for ( ; ; ) { set_current_state ( TASK_INTERRUPTIBLE ) ; if ( kfifo_len ( & port -> write_fifo ) == 0 || timeout == 0 || signal_pending ( current ) || serial -> disconnected ) break ; spin_unlock_irqrestore ( & port -> ep_lock , flags ) ; timeout = schedule_timeout ( timeout ) ; spin_lock_irqsave ( & port -> ep_lock , flags ) ; } set_current_state ( TASK_RUNNING ) ; remove_wait_queue ( & tty -> write_wait , & wait ) ; if ( flush ) kfifo_reset_out ( & port -> write_fifo ) ; spin_unlock_irqrestore ( & port -> ep_lock , flags ) ; tty_kref_put ( tty ) ; timeout += jiffies ; while ( ( long ) ( jiffies - timeout ) < 0 && ! signal_pending ( current ) && ! serial -> disconnected ) { if ( ! tx_active ( port ) ) break ; msleep ( 10 ) ; } if ( serial -> disconnected ) return ; baud_rate = port -> baud_rate ; if ( baud_rate == 0 ) baud_rate = 50 ; msleep ( max ( 1 , DIV_ROUND_UP ( 10000 , baud_rate ) ) ) ; }
| <FIXS> if ( ! tty ) return ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static int atusb_get_and_show_revision ( struct atusb * atusb ) { struct usb_device * usb_dev = atusb -> usb_dev ; <BUGS> unsigned char buffer [ 3 ] ; <BUGE> int ret ; <BUGS> <BUGE> ret = atusb_control_msg ( atusb , usb_rcvctrlpipe ( usb_dev , 0 ) , ATUSB_ID , ATUSB_REQ_FROM_DEV , 0 , 0 , buffer , 3 , 1000 ) ; if ( ret >= 0 ) { atusb -> fw_ver_maj = buffer [ 0 ] ; atusb -> fw_ver_min = buffer [ 1 ] ; atusb -> fw_hw_type = buffer [ 2 ] ; dev_info ( & usb_dev -> dev , "Firmware: major: %u, minor: %u, hardware type: %u\\n" , atusb -> fw_ver_maj , atusb -> fw_ver_min , atusb -> fw_hw_type ) ; } if ( atusb -> fw_ver_maj == 0 && atusb -> fw_ver_min < 2 ) { dev_info ( & usb_dev -> dev , "Firmware version (%u.%u) predates our first public release." , atusb -> fw_ver_maj , atusb -> fw_ver_min ) ; dev_info ( & usb_dev -> dev , "Please update to version 0.2 or newer" ) ; } <BUGS> <BUGE> return ret ; }
| <FIXS> unsigned char * buffer ; <FIXE> <FIXS> buffer = kmalloc ( 3 , GFP_KERNEL ) ; if ( ! buffer ) return - ENOMEM ; <FIXE> <FIXS> kfree ( buffer ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-345 static int daemon_AuthUserPwd ( char * username , char * password , char * errbuf ) { # ifdef _WIN32 <BUGS> <BUGE> HANDLE Token ; <BUGS> <BUGE> if ( LogonUser ( username , "." , password , LOGON32_LOGON_NETWORK , LOGON32_PROVIDER_DEFAULT , & Token ) == 0 ) { <BUGS> pcap_fmt_errmsg_for_win32_err ( errbuf , PCAP_ERRBUF_SIZE , GetLastError ( ) , "LogonUser() failed" ) ; <BUGE> return - 1 ; } if ( ImpersonateLoggedOnUser ( Token ) == 0 ) { <BUGS> pcap_fmt_errmsg_for_win32_err ( errbuf , PCAP_ERRBUF_SIZE , <BUGE> GetLastError ( ) , "ImpersonateLoggedOnUser() failed" ) ; <BUGS> <BUGE> CloseHandle ( Token ) ; return - 1 ; } CloseHandle ( Token ) ; return 0 ; # else <BUGS> <BUGE> struct passwd * user ; char * user_password ; # ifdef HAVE_GETSPNAM struct spwd * usersp ; # endif char * crypt_password ; if ( ( user = getpwnam ( username ) ) == NULL ) { <BUGS> pcap_snprintf ( errbuf , PCAP_ERRBUF_SIZE , "Authentication failed: user name or password incorrect" ) ; <BUGE> return - 1 ; } # ifdef HAVE_GETSPNAM if ( ( usersp = getspnam ( username ) ) == NULL ) { <BUGS> pcap_snprintf ( errbuf , PCAP_ERRBUF_SIZE , "Authentication failed: user name or password incorrect" ) ; <BUGE> return - 1 ; } user_password = usersp -> sp_pwdp ; # else user_password = user -> pw_passwd ; # endif <BUGS> <BUGE> crypt_password = crypt ( password , user_password ) ; if ( crypt_password == NULL ) <BUGS> <BUGE> { pcap_snprintf ( errbuf , PCAP_ERRBUF_SIZE , "Authentication failed" ) ; return - 1 ; } <BUGS> if ( strcmp ( user_password , crypt_password ) != 0 ) { pcap_snprintf ( errbuf , PCAP_ERRBUF_SIZE , "Authentication failed: user name or password incorrect" ) ; return - 1 ; } <BUGE> if ( setuid ( user -> pw_uid ) ) { <BUGS> <BUGE> pcap_fmt_errmsg_for_errno ( errbuf , PCAP_ERRBUF_SIZE , <BUGS> errno , "setuid" ) ; <BUGE> return - 1 ; } return 0 ; # endif }
| <FIXS> DWORD error ; <FIXE> <FIXS> char errmsgbuf [ PCAP_ERRBUF_SIZE ] ; <FIXE> <FIXS> pcap_snprintf ( errbuf , PCAP_ERRBUF_SIZE , "Authentication failed" ) ; error = GetLastError ( ) ; if ( error != ERROR_LOGON_FAILURE ) { pcap_fmt_errmsg_for_win32_err ( errmsgbuf , PCAP_ERRBUF_SIZE , error , "LogonUser() failed" ) ; rpcapd_log ( LOGPRIO_ERROR , "%s" , errmsgbuf ) ; } <FIXE> <FIXS> pcap_snprintf ( errbuf , PCAP_ERRBUF_SIZE , "Authentication failed" ) ; pcap_fmt_errmsg_for_win32_err ( errmsgbuf , PCAP_ERRBUF_SIZE , <FIXE> <FIXS> rpcapd_log ( LOGPRIO_ERROR , "%s" , errmsgbuf ) ; <FIXE> <FIXS> int error ; <FIXE> <FIXS> pcap_snprintf ( errbuf , PCAP_ERRBUF_SIZE , "Authentication failed" ) ; <FIXE> <FIXS> pcap_snprintf ( errbuf , PCAP_ERRBUF_SIZE , "Authentication failed" ) ; <FIXE> <FIXS> errno = 0 ; <FIXE> <FIXS> { error = errno ; pcap_snprintf ( errbuf , PCAP_ERRBUF_SIZE , "Authentication failed" ) ; if ( error == 0 ) { rpcapd_log ( LOGPRIO_ERROR , "crypt() failed" ) ; } else { rpcapd_log ( LOGPRIO_ERROR , "crypt() failed: %s" , strerror ( error ) ) ; } return - 1 ; } if ( strcmp ( user_password , crypt_password ) != 0 ) <FIXE> <FIXS> <FIXE> <FIXS> error = errno ; <FIXE> <FIXS> error , "setuid" ) ; rpcapd_log ( LOGPRIO_ERROR , "setuid() failed: %s" , strerror ( error ) ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-190 static PyObject * <BUGS> _Unpickler_MemoGet ( UnpicklerObject * self , Py_ssize_t idx ) <BUGE> { <BUGS> if ( idx < 0 || idx >= self -> memo_size ) <BUGE> return NULL ; return self -> memo [ idx ] ; }
| <FIXS> _Unpickler_MemoGet ( UnpicklerObject * self , size_t idx ) <FIXE> <FIXS> if ( idx >= self -> memo_size ) <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-000 void sas_deform_port ( struct asd_sas_phy * phy , int gone ) { struct sas_ha_struct * sas_ha = phy -> ha ; struct asd_sas_port * port = phy -> port ; struct sas_internal * si = to_sas_internal ( sas_ha -> core . shost -> transportt ) ; struct domain_device * dev ; unsigned long flags ; if ( ! port ) return ; dev = port -> port_dev ; if ( dev ) dev -> pathways -- ; if ( port -> num_phys == 1 ) { sas_unregister_domain_devices ( port , gone ) ; <BUGS> <BUGE> sas_port_delete ( port -> port ) ; port -> port = NULL ; } else { sas_port_delete_phy ( port -> port , phy -> phy ) ; sas_device_set_phy ( dev , port -> port ) ; } if ( si -> dft -> lldd_port_deformed ) si -> dft -> lldd_port_deformed ( phy ) ; spin_lock_irqsave ( & sas_ha -> phy_port_lock , flags ) ; spin_lock ( & port -> phy_list_lock ) ; list_del_init ( & phy -> port_phy_el ) ; sas_phy_set_target ( phy , NULL ) ; phy -> port = NULL ; port -> num_phys -- ; port -> phy_mask &= ~ ( 1U << phy -> id ) ; if ( port -> num_phys == 0 ) { INIT_LIST_HEAD ( & port -> phy_list ) ; memset ( port -> sas_addr , 0 , SAS_ADDR_SIZE ) ; memset ( port -> attached_sas_addr , 0 , SAS_ADDR_SIZE ) ; port -> class = 0 ; port -> iproto = 0 ; port -> tproto = 0 ; port -> oob_mode = 0 ; port -> phy_mask = 0 ; } spin_unlock ( & port -> phy_list_lock ) ; spin_unlock_irqrestore ( & sas_ha -> phy_port_lock , flags ) ; return ; }
| <FIXS> sas_destruct_devices ( port ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-125 static stmt_ty <BUGS> ast_for_with_stmt ( struct compiling * c , const node * n , int is_async ) <BUGE> { <BUGS> <BUGE> int i , n_items , nch_minus_type , has_type_comment ; asdl_seq * items , * body ; string type_comment ; if ( is_async && c -> c_feature_version < 5 ) { ast_error ( c , n , "Async with statements are only supported in Python 3.5 and greater" ) ; return NULL ; } REQ ( n , with_stmt ) ; has_type_comment = TYPE ( CHILD ( n , NCH ( n ) - 2 ) ) == TYPE_COMMENT ; nch_minus_type = NCH ( n ) - has_type_comment ; n_items = ( nch_minus_type - 2 ) / 2 ; items = _Ta3_asdl_seq_new ( n_items , c -> c_arena ) ; if ( ! items ) return NULL ; for ( i = 1 ; i < nch_minus_type - 2 ; i += 2 ) { withitem_ty item = ast_for_with_item ( c , CHILD ( n , i ) ) ; if ( ! item ) return NULL ; asdl_seq_SET ( items , ( i - 1 ) / 2 , item ) ; } body = ast_for_suite ( c , CHILD ( n , NCH ( n ) - 1 ) ) ; if ( ! body ) return NULL ; if ( has_type_comment ) type_comment = NEW_TYPE_COMMENT ( CHILD ( n , NCH ( n ) - 2 ) ) ; else type_comment = NULL ; if ( is_async ) <BUGS> return AsyncWith ( items , body , type_comment , LINENO ( n ) , n -> n_col_offset , c -> c_arena ) ; <BUGE> else return With ( items , body , type_comment , LINENO ( n ) , n -> n_col_offset , c -> c_arena ) ; }
| <FIXS> ast_for_with_stmt ( struct compiling * c , const node * n0 , bool is_async ) <FIXE> <FIXS> const node * const n = is_async ? CHILD ( n0 , 1 ) : n0 ; <FIXE> <FIXS> return AsyncWith ( items , body , type_comment , LINENO ( n0 ) , n0 -> n_col_offset , c -> c_arena ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-362 struct request * blk_mq_tag_to_rq ( struct blk_mq_tags * tags , unsigned int tag ) { <BUGS> struct request * rq = tags -> rqs [ tag ] ; struct blk_flush_queue * fq = blk_get_flush_queue ( rq -> q , rq -> mq_ctx ) ; if ( ! is_flush_request ( rq , fq , tag ) ) return rq ; return fq -> flush_rq ; <BUGE> }
| <FIXS> return tags -> rqs [ tag ] ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 void loadServerConfigFromString ( char * config ) { char * err = NULL ; int linenum = 0 , totlines , i ; int slaveof_linenum = 0 ; sds * lines ; lines = sdssplitlen ( config , strlen ( config ) , "\\n" , 1 , & totlines ) ; for ( i = 0 ; i < totlines ; i ++ ) { sds * argv ; int argc ; linenum = i + 1 ; lines [ i ] = sdstrim ( lines [ i ] , " \\t\\r\\n" ) ; if ( lines [ i ] [ 0 ] == '#' || lines [ i ] [ 0 ] == '\\0' ) continue ; argv = sdssplitargs ( lines [ i ] , & argc ) ; if ( argv == NULL ) { err = "Unbalanced quotes in configuration line" ; goto loaderr ; } if ( argc == 0 ) { sdsfreesplitres ( argv , argc ) ; continue ; } sdstolower ( argv [ 0 ] ) ; if ( ! strcasecmp ( argv [ 0 ] , "timeout" ) && argc == 2 ) { server . maxidletime = atoi ( argv [ 1 ] ) ; if ( server . maxidletime < 0 ) { err = "Invalid timeout value" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "tcp-keepalive" ) && argc == 2 ) { server . tcpkeepalive = atoi ( argv [ 1 ] ) ; if ( server . tcpkeepalive < 0 ) { err = "Invalid tcp-keepalive value" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "protected-mode" ) && argc == 2 ) { if ( ( server . protected_mode = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "port" ) && argc == 2 ) { server . port = atoi ( argv [ 1 ] ) ; if ( server . port < 0 || server . port > 65535 ) { err = "Invalid port" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "tcp-backlog" ) && argc == 2 ) { server . tcp_backlog = atoi ( argv [ 1 ] ) ; if ( server . tcp_backlog < 0 ) { err = "Invalid backlog value" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "bind" ) && argc >= 2 ) { int j , addresses = argc - 1 ; if ( addresses > CONFIG_BINDADDR_MAX ) { err = "Too many bind addresses specified" ; goto loaderr ; } for ( j = 0 ; j < addresses ; j ++ ) server . bindaddr [ j ] = zstrdup ( argv [ j + 1 ] ) ; server . bindaddr_count = addresses ; } else if ( ! strcasecmp ( argv [ 0 ] , "unixsocket" ) && argc == 2 ) { server . unixsocket = zstrdup ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "unixsocketperm" ) && argc == 2 ) { errno = 0 ; server . unixsocketperm = ( mode_t ) strtol ( argv [ 1 ] , NULL , 8 ) ; if ( errno || server . unixsocketperm > 0777 ) { err = "Invalid socket file permissions" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "save" ) ) { if ( argc == 3 ) { int seconds = atoi ( argv [ 1 ] ) ; int changes = atoi ( argv [ 2 ] ) ; if ( seconds < 1 || changes < 0 ) { err = "Invalid save parameters" ; goto loaderr ; } appendServerSaveParams ( seconds , changes ) ; } else if ( argc == 2 && ! strcasecmp ( argv [ 1 ] , "" ) ) { resetServerSaveParams ( ) ; } } else if ( ! strcasecmp ( argv [ 0 ] , "dir" ) && argc == 2 ) { if ( chdir ( argv [ 1 ] ) == - 1 ) { serverLog ( LL_WARNING , "Can\'t chdir to \'%s\': %s" , argv [ 1 ] , strerror ( errno ) ) ; exit ( 1 ) ; } } else if ( ! strcasecmp ( argv [ 0 ] , "loglevel" ) && argc == 2 ) { server . verbosity = configEnumGetValue ( loglevel_enum , argv [ 1 ] ) ; if ( server . verbosity == INT_MIN ) { err = "Invalid log level. " "Must be one of debug, verbose, notice, warning" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "logfile" ) && argc == 2 ) { FILE * logfp ; zfree ( server . logfile ) ; server . logfile = zstrdup ( argv [ 1 ] ) ; if ( server . logfile [ 0 ] != '\\0' ) { logfp = fopen ( server . logfile , "a" ) ; if ( logfp == NULL ) { err = sdscatprintf ( sdsempty ( ) , "Can\'t open the log file: %s" , strerror ( errno ) ) ; goto loaderr ; } fclose ( logfp ) ; } } else if ( ! strcasecmp ( argv [ 0 ] , "syslog-enabled" ) && argc == 2 ) { if ( ( server . syslog_enabled = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "syslog-ident" ) && argc == 2 ) { if ( server . syslog_ident ) zfree ( server . syslog_ident ) ; server . syslog_ident = zstrdup ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "syslog-facility" ) && argc == 2 ) { server . syslog_facility = configEnumGetValue ( syslog_facility_enum , argv [ 1 ] ) ; if ( server . syslog_facility == INT_MIN ) { err = "Invalid log facility. Must be one of USER or between LOCAL0-LOCAL7" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "databases" ) && argc == 2 ) { server . dbnum = atoi ( argv [ 1 ] ) ; if ( server . dbnum < 1 ) { err = "Invalid number of databases" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "include" ) && argc == 2 ) { loadServerConfig ( argv [ 1 ] , NULL ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "maxclients" ) && argc == 2 ) { server . maxclients = atoi ( argv [ 1 ] ) ; if ( server . maxclients < 1 ) { err = "Invalid max clients limit" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "maxmemory" ) && argc == 2 ) { server . maxmemory = memtoll ( argv [ 1 ] , NULL ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "maxmemory-policy" ) && argc == 2 ) { server . maxmemory_policy = configEnumGetValue ( maxmemory_policy_enum , argv [ 1 ] ) ; if ( server . maxmemory_policy == INT_MIN ) { err = "Invalid maxmemory policy" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "maxmemory-samples" ) && argc == 2 ) { server . maxmemory_samples = atoi ( argv [ 1 ] ) ; if ( server . maxmemory_samples <= 0 ) { err = "maxmemory-samples must be 1 or greater" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "lfu-log-factor" ) && argc == 2 ) { server . lfu_log_factor = atoi ( argv [ 1 ] ) ; if ( server . maxmemory_samples < 0 ) { err = "lfu-log-factor must be 0 or greater" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "lfu-decay-time" ) && argc == 2 ) { server . lfu_decay_time = atoi ( argv [ 1 ] ) ; if ( server . maxmemory_samples < 1 ) { err = "lfu-decay-time must be 0 or greater" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "slaveof" ) && argc == 3 ) { slaveof_linenum = linenum ; server . masterhost = sdsnew ( argv [ 1 ] ) ; server . masterport = atoi ( argv [ 2 ] ) ; server . repl_state = REPL_STATE_CONNECT ; } else if ( ! strcasecmp ( argv [ 0 ] , "repl-ping-slave-period" ) && argc == 2 ) { server . repl_ping_slave_period = atoi ( argv [ 1 ] ) ; if ( server . repl_ping_slave_period <= 0 ) { err = "repl-ping-slave-period must be 1 or greater" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "repl-timeout" ) && argc == 2 ) { server . repl_timeout = atoi ( argv [ 1 ] ) ; if ( server . repl_timeout <= 0 ) { err = "repl-timeout must be 1 or greater" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "repl-disable-tcp-nodelay" ) && argc == 2 ) { if ( ( server . repl_disable_tcp_nodelay = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "repl-diskless-sync" ) && argc == 2 ) { if ( ( server . repl_diskless_sync = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "repl-diskless-sync-delay" ) && argc == 2 ) { server . repl_diskless_sync_delay = atoi ( argv [ 1 ] ) ; if ( server . repl_diskless_sync_delay < 0 ) { err = "repl-diskless-sync-delay can\'t be negative" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "repl-backlog-size" ) && argc == 2 ) { long long size = memtoll ( argv [ 1 ] , NULL ) ; if ( size <= 0 ) { err = "repl-backlog-size must be 1 or greater." ; goto loaderr ; } resizeReplicationBacklog ( size ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "repl-backlog-ttl" ) && argc == 2 ) { server . repl_backlog_time_limit = atoi ( argv [ 1 ] ) ; if ( server . repl_backlog_time_limit < 0 ) { err = "repl-backlog-ttl can\'t be negative " ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "masterauth" ) && argc == 2 ) { zfree ( server . masterauth ) ; server . masterauth = zstrdup ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "slave-serve-stale-data" ) && argc == 2 ) { if ( ( server . repl_serve_stale_data = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "slave-read-only" ) && argc == 2 ) { if ( ( server . repl_slave_ro = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "rdbcompression" ) && argc == 2 ) { if ( ( server . rdb_compression = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "rdbchecksum" ) && argc == 2 ) { if ( ( server . rdb_checksum = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "activerehashing" ) && argc == 2 ) { if ( ( server . activerehashing = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "lazyfree-lazy-eviction" ) && argc == 2 ) { if ( ( server . lazyfree_lazy_eviction = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "lazyfree-lazy-expire" ) && argc == 2 ) { if ( ( server . lazyfree_lazy_expire = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "lazyfree-lazy-server-del" ) && argc == 2 ) { if ( ( server . lazyfree_lazy_server_del = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "slave-lazy-flush" ) && argc == 2 ) { if ( ( server . repl_slave_lazy_flush = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "daemonize" ) && argc == 2 ) { if ( ( server . daemonize = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "hz" ) && argc == 2 ) { server . hz = atoi ( argv [ 1 ] ) ; if ( server . hz < CONFIG_MIN_HZ ) server . hz = CONFIG_MIN_HZ ; if ( server . hz > CONFIG_MAX_HZ ) server . hz = CONFIG_MAX_HZ ; } else if ( ! strcasecmp ( argv [ 0 ] , "appendonly" ) && argc == 2 ) { int yes ; if ( ( yes = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } server . aof_state = yes ? AOF_ON : AOF_OFF ; } else if ( ! strcasecmp ( argv [ 0 ] , "appendfilename" ) && argc == 2 ) { if ( ! pathIsBaseName ( argv [ 1 ] ) ) { err = "appendfilename can\'t be a path, just a filename" ; goto loaderr ; } zfree ( server . aof_filename ) ; server . aof_filename = zstrdup ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "no-appendfsync-on-rewrite" ) && argc == 2 ) { if ( ( server . aof_no_fsync_on_rewrite = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "appendfsync" ) && argc == 2 ) { server . aof_fsync = configEnumGetValue ( aof_fsync_enum , argv [ 1 ] ) ; if ( server . aof_fsync == INT_MIN ) { err = "argument must be \'no\', \'always\' or \'everysec\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "auto-aof-rewrite-percentage" ) && argc == 2 ) { server . aof_rewrite_perc = atoi ( argv [ 1 ] ) ; if ( server . aof_rewrite_perc < 0 ) { err = "Invalid negative percentage for AOF auto rewrite" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "auto-aof-rewrite-min-size" ) && argc == 2 ) { server . aof_rewrite_min_size = memtoll ( argv [ 1 ] , NULL ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "aof-rewrite-incremental-fsync" ) && argc == 2 ) { if ( ( server . aof_rewrite_incremental_fsync = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "aof-load-truncated" ) && argc == 2 ) { if ( ( server . aof_load_truncated = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "aof-use-rdb-preamble" ) && argc == 2 ) { if ( ( server . aof_use_rdb_preamble = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "requirepass" ) && argc == 2 ) { if ( strlen ( argv [ 1 ] ) > CONFIG_AUTHPASS_MAX_LEN ) { err = "Password is longer than CONFIG_AUTHPASS_MAX_LEN" ; goto loaderr ; } server . requirepass = zstrdup ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "pidfile" ) && argc == 2 ) { zfree ( server . pidfile ) ; server . pidfile = zstrdup ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "dbfilename" ) && argc == 2 ) { if ( ! pathIsBaseName ( argv [ 1 ] ) ) { err = "dbfilename can\'t be a path, just a filename" ; goto loaderr ; } zfree ( server . rdb_filename ) ; server . rdb_filename = zstrdup ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "hash-max-ziplist-entries" ) && argc == 2 ) { server . hash_max_ziplist_entries = memtoll ( argv [ 1 ] , NULL ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "hash-max-ziplist-value" ) && argc == 2 ) { server . hash_max_ziplist_value = memtoll ( argv [ 1 ] , NULL ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "list-max-ziplist-entries" ) && argc == 2 ) { } else if ( ! strcasecmp ( argv [ 0 ] , "list-max-ziplist-value" ) && argc == 2 ) { } else if ( ! strcasecmp ( argv [ 0 ] , "list-max-ziplist-size" ) && argc == 2 ) { server . list_max_ziplist_size = atoi ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "list-compress-depth" ) && argc == 2 ) { server . list_compress_depth = atoi ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "set-max-intset-entries" ) && argc == 2 ) { server . set_max_intset_entries = memtoll ( argv [ 1 ] , NULL ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "zset-max-ziplist-entries" ) && argc == 2 ) { server . zset_max_ziplist_entries = memtoll ( argv [ 1 ] , NULL ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "zset-max-ziplist-value" ) && argc == 2 ) { server . zset_max_ziplist_value = memtoll ( argv [ 1 ] , NULL ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "hll-sparse-max-bytes" ) && argc == 2 ) { server . hll_sparse_max_bytes = memtoll ( argv [ 1 ] , NULL ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "rename-command" ) && argc == 3 ) { struct redisCommand * cmd = lookupCommand ( argv [ 1 ] ) ; int retval ; if ( ! cmd ) { err = "No such command in rename-command" ; goto loaderr ; } retval = dictDelete ( server . commands , argv [ 1 ] ) ; serverAssert ( retval == DICT_OK ) ; if ( sdslen ( argv [ 2 ] ) != 0 ) { sds copy = sdsdup ( argv [ 2 ] ) ; retval = dictAdd ( server . commands , copy , cmd ) ; if ( retval != DICT_OK ) { sdsfree ( copy ) ; err = "Target command name already exists" ; goto loaderr ; } } } else if ( ! strcasecmp ( argv [ 0 ] , "cluster-enabled" ) && argc == 2 ) { if ( ( server . cluster_enabled = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "cluster-config-file" ) && argc == 2 ) { zfree ( server . cluster_configfile ) ; server . cluster_configfile = zstrdup ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "cluster-announce-ip" ) && argc == 2 ) { zfree ( server . cluster_announce_ip ) ; server . cluster_announce_ip = zstrdup ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "cluster-announce-port" ) && argc == 2 ) { server . cluster_announce_port = atoi ( argv [ 1 ] ) ; if ( server . cluster_announce_port < 0 || server . cluster_announce_port > 65535 ) { err = "Invalid port" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "cluster-announce-bus-port" ) && argc == 2 ) { server . cluster_announce_bus_port = atoi ( argv [ 1 ] ) ; if ( server . cluster_announce_bus_port < 0 || server . cluster_announce_bus_port > 65535 ) { err = "Invalid port" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "cluster-require-full-coverage" ) && argc == 2 ) { if ( ( server . cluster_require_full_coverage = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "cluster-node-timeout" ) && argc == 2 ) { server . cluster_node_timeout = strtoll ( argv [ 1 ] , NULL , 10 ) ; if ( server . cluster_node_timeout <= 0 ) { err = "cluster node timeout must be 1 or greater" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "cluster-migration-barrier" ) && argc == 2 ) { server . cluster_migration_barrier = atoi ( argv [ 1 ] ) ; if ( server . cluster_migration_barrier < 0 ) { err = "cluster migration barrier must zero or positive" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "cluster-slave-validity-factor" ) && argc == 2 ) { server . cluster_slave_validity_factor = atoi ( argv [ 1 ] ) ; if ( server . cluster_slave_validity_factor < 0 ) { err = "cluster slave validity factor must be zero or positive" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "lua-time-limit" ) && argc == 2 ) { server . lua_time_limit = strtoll ( argv [ 1 ] , NULL , 10 ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "slowlog-log-slower-than" ) && argc == 2 ) { server . slowlog_log_slower_than = strtoll ( argv [ 1 ] , NULL , 10 ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "latency-monitor-threshold" ) && argc == 2 ) { server . latency_monitor_threshold = strtoll ( argv [ 1 ] , NULL , 10 ) ; if ( server . latency_monitor_threshold < 0 ) { err = "The latency threshold can\'t be negative" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "slowlog-max-len" ) && argc == 2 ) { server . slowlog_max_len = strtoll ( argv [ 1 ] , NULL , 10 ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "client-output-buffer-limit" ) && argc == 5 ) { int class = getClientTypeByName ( argv [ 1 ] ) ; unsigned long long hard , soft ; int soft_seconds ; <BUGS> if ( class == - 1 ) { err = "Unrecognized client limit class" ; <BUGE> goto loaderr ; } hard = memtoll ( argv [ 2 ] , NULL ) ; soft = memtoll ( argv [ 3 ] , NULL ) ; soft_seconds = atoi ( argv [ 4 ] ) ; if ( soft_seconds < 0 ) { err = "Negative number of seconds in soft limit is invalid" ; goto loaderr ; } server . client_obuf_limits [ class ] . hard_limit_bytes = hard ; server . client_obuf_limits [ class ] . soft_limit_bytes = soft ; server . client_obuf_limits [ class ] . soft_limit_seconds = soft_seconds ; } else if ( ! strcasecmp ( argv [ 0 ] , "stop-writes-on-bgsave-error" ) && argc == 2 ) { if ( ( server . stop_writes_on_bgsave_err = yesnotoi ( argv [ 1 ] ) ) == - 1 ) { err = "argument must be \'yes\' or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "slave-priority" ) && argc == 2 ) { server . slave_priority = atoi ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "slave-announce-ip" ) && argc == 2 ) { zfree ( server . slave_announce_ip ) ; server . slave_announce_ip = zstrdup ( argv [ 1 ] ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "slave-announce-port" ) && argc == 2 ) { server . slave_announce_port = atoi ( argv [ 1 ] ) ; if ( server . slave_announce_port < 0 || server . slave_announce_port > 65535 ) { err = "Invalid port" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "min-slaves-to-write" ) && argc == 2 ) { server . repl_min_slaves_to_write = atoi ( argv [ 1 ] ) ; if ( server . repl_min_slaves_to_write < 0 ) { err = "Invalid value for min-slaves-to-write." ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "min-slaves-max-lag" ) && argc == 2 ) { server . repl_min_slaves_max_lag = atoi ( argv [ 1 ] ) ; if ( server . repl_min_slaves_max_lag < 0 ) { err = "Invalid value for min-slaves-max-lag." ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "notify-keyspace-events" ) && argc == 2 ) { int flags = keyspaceEventsStringToFlags ( argv [ 1 ] ) ; if ( flags == - 1 ) { err = "Invalid event class character. Use \'g$lshzxeA\'." ; goto loaderr ; } server . notify_keyspace_events = flags ; } else if ( ! strcasecmp ( argv [ 0 ] , "supervised" ) && argc == 2 ) { server . supervised_mode = configEnumGetValue ( supervised_mode_enum , argv [ 1 ] ) ; if ( server . supervised_mode == INT_MIN ) { err = "Invalid option for \'supervised\'. " "Allowed values: \'upstart\', \'systemd\', \'auto\', or \'no\'" ; goto loaderr ; } } else if ( ! strcasecmp ( argv [ 0 ] , "loadmodule" ) && argc >= 2 ) { queueLoadModule ( argv [ 1 ] , & argv [ 2 ] , argc - 2 ) ; } else if ( ! strcasecmp ( argv [ 0 ] , "sentinel" ) ) { if ( argc != 1 ) { if ( ! server . sentinel_mode ) { err = "sentinel directive while not in sentinel mode" ; goto loaderr ; } err = sentinelHandleConfiguration ( argv + 1 , argc - 1 ) ; if ( err ) goto loaderr ; } } else { err = "Bad directive or wrong number of arguments" ; goto loaderr ; } sdsfreesplitres ( argv , argc ) ; } if ( server . cluster_enabled && server . masterhost ) { linenum = slaveof_linenum ; i = linenum - 1 ; err = "slaveof directive not allowed in cluster mode" ; goto loaderr ; } sdsfreesplitres ( lines , totlines ) ; return ; loaderr : fprintf ( stderr , "\\n*** FATAL CONFIG FILE ERROR ***\\n" ) ; fprintf ( stderr , "Reading the configuration file, at line %d\\n" , linenum ) ; fprintf ( stderr , ">>> \'%s\'\\n" , lines [ i ] ) ; fprintf ( stderr , "%s\\n" , err ) ; exit ( 1 ) ; }
| <FIXS> if ( class == - 1 || class == CLIENT_TYPE_MASTER ) { err = "Unrecognized client limit class: the user specified " "an invalid one, or \'master\' which has no buffer limits." ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static struct nvmet_fc_tgt_queue * nvmet_fc_find_target_queue ( struct nvmet_fc_tgtport * tgtport , u64 connection_id ) { struct nvmet_fc_tgt_assoc * assoc ; struct nvmet_fc_tgt_queue * queue ; u64 association_id = nvmet_fc_getassociationid ( connection_id ) ; u16 qid = nvmet_fc_getqueueid ( connection_id ) ; unsigned long flags ; <BUGS> <BUGE> spin_lock_irqsave ( & tgtport -> lock , flags ) ; list_for_each_entry ( assoc , & tgtport -> assoc_list , a_list ) { if ( association_id == assoc -> association_id ) { queue = assoc -> queues [ qid ] ; if ( queue && ( ! atomic_read ( & queue -> connected ) || ! nvmet_fc_tgt_q_get ( queue ) ) ) queue = NULL ; spin_unlock_irqrestore ( & tgtport -> lock , flags ) ; return queue ; } } spin_unlock_irqrestore ( & tgtport -> lock , flags ) ; return NULL ; }
| <FIXS> if ( qid > NVMET_NR_QUEUES ) return NULL ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static bool ldm_frag_add ( const u8 * data , int size , struct list_head * frags ) { struct frag * f ; struct list_head * item ; int rec , num , group ; BUG_ON ( ! data || ! frags ) ; if ( size < 2 * VBLK_SIZE_HEAD ) { ldm_error ( "Value of size is to small." ) ; return false ; } group = get_unaligned_be32 ( data + 0x08 ) ; rec = get_unaligned_be16 ( data + 0x0C ) ; num = get_unaligned_be16 ( data + 0x0E ) ; if ( ( num < 1 ) || ( num > 4 ) ) { ldm_error ( "A VBLK claims to have %d parts." , num ) ; return false ; } if ( rec >= num ) { ldm_error ( "REC value (%d) exceeds NUM value (%d)" , rec , num ) ; return false ; } list_for_each ( item , frags ) { f = list_entry ( item , struct frag , list ) ; if ( f -> group == group ) goto found ; } f = kmalloc ( sizeof ( * f ) + size * num , GFP_KERNEL ) ; if ( ! f ) { ldm_crit ( "Out of memory." ) ; return false ; } f -> group = group ; f -> num = num ; f -> rec = rec ; f -> map = 0xFF << num ; list_add_tail ( & f -> list , frags ) ; found : <BUGS> <BUGE> if ( f -> map & ( 1 << rec ) ) { ldm_error ( "Duplicate VBLK, part %d." , rec ) ; f -> map &= 0x7F ; return false ; } f -> map |= ( 1 << rec ) ; data += VBLK_SIZE_HEAD ; size -= VBLK_SIZE_HEAD ; memcpy ( f -> data + rec * ( size - VBLK_SIZE_HEAD ) + VBLK_SIZE_HEAD , data , size ) ; return true ; }
| <FIXS> if ( rec >= f -> num ) { ldm_error ( "REC value (%d) exceeds NUM value (%d)" , rec , f -> num ) ; return false ; } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-399 static void nlmclnt_unlock_callback ( struct rpc_task * task , void * data ) { struct nlm_rqst * req = data ; u32 status = ntohl ( req -> a_res . status ) ; if ( RPC_ASSASSINATED ( task ) ) goto die ; if ( task -> tk_status < 0 ) { dprintk ( "lockd: unlock failed (err = %d)\\n" , - task -> tk_status ) ; <BUGS> <BUGE> goto retry_rebind ; <BUGS> <BUGE> } if ( status == NLM_LCK_DENIED_GRACE_PERIOD ) { rpc_delay ( task , NLMCLNT_GRACE_WAIT ) ; goto retry_unlock ; } if ( status != NLM_LCK_GRANTED ) printk ( KERN_WARNING "lockd: unexpected unlock status: %d\\n" , status ) ; die : return ; retry_rebind : nlm_rebind_host ( req -> a_host ) ; retry_unlock : rpc_restart_call ( task ) ; }
| <FIXS> switch ( task -> tk_status ) { case - EACCES : case - EIO : goto die ; default : <FIXE> <FIXS> } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-284 int socket_create ( uint16_t port ) { int sfd = - 1 ; int yes = 1 ; # ifdef WIN32 WSADATA wsa_data ; if ( ! wsa_init ) { if ( WSAStartup ( MAKEWORD ( 2 , 2 ) , & wsa_data ) != ERROR_SUCCESS ) { fprintf ( stderr , "WSAStartup failed!\\n" ) ; ExitProcess ( - 1 ) ; } wsa_init = 1 ; } # endif struct sockaddr_in saddr ; if ( 0 > ( sfd = socket ( PF_INET , SOCK_STREAM , IPPROTO_TCP ) ) ) { perror ( "socket()" ) ; return - 1 ; } if ( setsockopt ( sfd , SOL_SOCKET , SO_REUSEADDR , ( void * ) & yes , sizeof ( int ) ) == - 1 ) { perror ( "setsockopt()" ) ; socket_close ( sfd ) ; return - 1 ; } # ifdef SO_NOSIGPIPE if ( setsockopt ( sfd , SOL_SOCKET , SO_NOSIGPIPE , ( void * ) & yes , sizeof ( int ) ) == - 1 ) { perror ( "setsockopt()" ) ; socket_close ( sfd ) ; return - 1 ; } # endif memset ( ( void * ) & saddr , 0 , sizeof ( saddr ) ) ; saddr . sin_family = AF_INET ; <BUGS> saddr . sin_addr . s_addr = htonl ( INADDR_ANY ) ; <BUGE> saddr . sin_port = htons ( port ) ; if ( 0 > bind ( sfd , ( struct sockaddr * ) & saddr , sizeof ( saddr ) ) ) { perror ( "bind()" ) ; socket_close ( sfd ) ; return - 1 ; } if ( listen ( sfd , 1 ) == - 1 ) { perror ( "listen()" ) ; socket_close ( sfd ) ; return - 1 ; } return sfd ; }
| <FIXS> saddr . sin_addr . s_addr = htonl ( INADDR_LOOPBACK ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static int nl80211_start_sched_scan ( struct sk_buff * skb , struct genl_info * info ) { struct cfg80211_sched_scan_request * request ; struct cfg80211_registered_device * rdev = info -> user_ptr [ 0 ] ; struct net_device * dev = info -> user_ptr [ 1 ] ; struct nlattr * attr ; struct wiphy * wiphy ; int err , tmp , n_ssids = 0 , n_channels , i ; u32 interval ; enum ieee80211_band band ; size_t ie_len ; if ( ! ( rdev -> wiphy . flags & WIPHY_FLAG_SUPPORTS_SCHED_SCAN ) || ! rdev -> ops -> sched_scan_start ) return - EOPNOTSUPP ; if ( ! is_valid_ie_attr ( info -> attrs [ NL80211_ATTR_IE ] ) ) return - EINVAL ; if ( rdev -> sched_scan_req ) return - EINPROGRESS ; if ( ! info -> attrs [ NL80211_ATTR_SCHED_SCAN_INTERVAL ] ) return - EINVAL ; interval = nla_get_u32 ( info -> attrs [ NL80211_ATTR_SCHED_SCAN_INTERVAL ] ) ; if ( interval == 0 ) return - EINVAL ; wiphy = & rdev -> wiphy ; if ( info -> attrs [ NL80211_ATTR_SCAN_FREQUENCIES ] ) { n_channels = validate_scan_freqs ( info -> attrs [ NL80211_ATTR_SCAN_FREQUENCIES ] ) ; if ( ! n_channels ) return - EINVAL ; } else { n_channels = 0 ; for ( band = 0 ; band < IEEE80211_NUM_BANDS ; band ++ ) if ( wiphy -> bands [ band ] ) n_channels += wiphy -> bands [ band ] -> n_channels ; } if ( info -> attrs [ NL80211_ATTR_SCAN_SSIDS ] ) nla_for_each_nested ( attr , info -> attrs [ NL80211_ATTR_SCAN_SSIDS ] , tmp ) n_ssids ++ ; if ( n_ssids > wiphy -> max_scan_ssids ) return - EINVAL ; if ( info -> attrs [ NL80211_ATTR_IE ] ) ie_len = nla_len ( info -> attrs [ NL80211_ATTR_IE ] ) ; else ie_len = 0 ; if ( ie_len > wiphy -> max_scan_ie_len ) return - EINVAL ; request = kzalloc ( sizeof ( * request ) + sizeof ( * request -> ssids ) * n_ssids + sizeof ( * request -> channels ) * n_channels + ie_len , GFP_KERNEL ) ; if ( ! request ) return - ENOMEM ; if ( n_ssids ) request -> ssids = ( void * ) & request -> channels [ n_channels ] ; request -> n_ssids = n_ssids ; if ( ie_len ) { if ( request -> ssids ) request -> ie = ( void * ) ( request -> ssids + n_ssids ) ; else request -> ie = ( void * ) ( request -> channels + n_channels ) ; } i = 0 ; if ( info -> attrs [ NL80211_ATTR_SCAN_FREQUENCIES ] ) { nla_for_each_nested ( attr , info -> attrs [ NL80211_ATTR_SCAN_FREQUENCIES ] , tmp ) { struct ieee80211_channel * chan ; chan = ieee80211_get_channel ( wiphy , nla_get_u32 ( attr ) ) ; if ( ! chan ) { err = - EINVAL ; goto out_free ; } if ( chan -> flags & IEEE80211_CHAN_DISABLED ) continue ; request -> channels [ i ] = chan ; i ++ ; } } else { for ( band = 0 ; band < IEEE80211_NUM_BANDS ; band ++ ) { int j ; if ( ! wiphy -> bands [ band ] ) continue ; for ( j = 0 ; j < wiphy -> bands [ band ] -> n_channels ; j ++ ) { struct ieee80211_channel * chan ; chan = & wiphy -> bands [ band ] -> channels [ j ] ; if ( chan -> flags & IEEE80211_CHAN_DISABLED ) continue ; request -> channels [ i ] = chan ; i ++ ; } } } if ( ! i ) { err = - EINVAL ; goto out_free ; } request -> n_channels = i ; i = 0 ; if ( info -> attrs [ NL80211_ATTR_SCAN_SSIDS ] ) { nla_for_each_nested ( attr , info -> attrs [ NL80211_ATTR_SCAN_SSIDS ] , tmp ) { <BUGS> <BUGE> if ( request -> ssids [ i ] . ssid_len > IEEE80211_MAX_SSID_LEN ) { err = - EINVAL ; goto out_free ; } memcpy ( request -> ssids [ i ] . ssid , nla_data ( attr ) , nla_len ( attr ) ) ; <BUGS> request -> ssids [ i ] . ssid_len = nla_len ( attr ) ; <BUGE> i ++ ; } } if ( info -> attrs [ NL80211_ATTR_IE ] ) { request -> ie_len = nla_len ( info -> attrs [ NL80211_ATTR_IE ] ) ; memcpy ( ( void * ) request -> ie , nla_data ( info -> attrs [ NL80211_ATTR_IE ] ) , request -> ie_len ) ; } request -> dev = dev ; request -> wiphy = & rdev -> wiphy ; request -> interval = interval ; err = rdev -> ops -> sched_scan_start ( & rdev -> wiphy , dev , request ) ; if ( ! err ) { rdev -> sched_scan_req = request ; nl80211_send_sched_scan ( rdev , dev , NL80211_CMD_START_SCHED_SCAN ) ; goto out ; } out_free : kfree ( request ) ; out : return err ; }
| <FIXS> request -> ssids [ i ] . ssid_len = nla_len ( attr ) ; <FIXE> <FIXS> <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-476 static int tower_probe ( struct usb_interface * interface , const struct usb_device_id * id ) { struct device * idev = & interface -> dev ; struct usb_device * udev = interface_to_usbdev ( interface ) ; struct lego_usb_tower * dev = NULL ; struct usb_host_interface * iface_desc ; struct usb_endpoint_descriptor * endpoint ; struct tower_get_version_reply get_version_reply ; int i ; int retval = - ENOMEM ; int result ; dev = kmalloc ( sizeof ( struct lego_usb_tower ) , GFP_KERNEL ) ; if ( ! dev ) goto exit ; mutex_init ( & dev -> lock ) ; dev -> udev = udev ; dev -> open_count = 0 ; dev -> read_buffer = NULL ; dev -> read_buffer_length = 0 ; dev -> read_packet_length = 0 ; spin_lock_init ( & dev -> read_buffer_lock ) ; dev -> packet_timeout_jiffies = msecs_to_jiffies ( packet_timeout ) ; dev -> read_last_arrival = jiffies ; init_waitqueue_head ( & dev -> read_wait ) ; init_waitqueue_head ( & dev -> write_wait ) ; dev -> interrupt_in_buffer = NULL ; dev -> interrupt_in_endpoint = NULL ; dev -> interrupt_in_urb = NULL ; dev -> interrupt_in_running = 0 ; dev -> interrupt_in_done = 0 ; dev -> interrupt_out_buffer = NULL ; dev -> interrupt_out_endpoint = NULL ; dev -> interrupt_out_urb = NULL ; dev -> interrupt_out_busy = 0 ; iface_desc = interface -> cur_altsetting ; for ( i = 0 ; i < iface_desc -> desc . bNumEndpoints ; ++ i ) { endpoint = & iface_desc -> endpoint [ i ] . desc ; if ( usb_endpoint_xfer_int ( endpoint ) ) { if ( usb_endpoint_dir_in ( endpoint ) ) dev -> interrupt_in_endpoint = endpoint ; else dev -> interrupt_out_endpoint = endpoint ; } } if ( dev -> interrupt_in_endpoint == NULL ) { dev_err ( idev , "interrupt in endpoint not found\\n" ) ; goto error ; } if ( dev -> interrupt_out_endpoint == NULL ) { dev_err ( idev , "interrupt out endpoint not found\\n" ) ; goto error ; } dev -> read_buffer = kmalloc ( read_buffer_size , GFP_KERNEL ) ; if ( ! dev -> read_buffer ) goto error ; dev -> interrupt_in_buffer = kmalloc ( usb_endpoint_maxp ( dev -> interrupt_in_endpoint ) , GFP_KERNEL ) ; if ( ! dev -> interrupt_in_buffer ) goto error ; dev -> interrupt_in_urb = usb_alloc_urb ( 0 , GFP_KERNEL ) ; if ( ! dev -> interrupt_in_urb ) goto error ; dev -> interrupt_out_buffer = kmalloc ( write_buffer_size , GFP_KERNEL ) ; if ( ! dev -> interrupt_out_buffer ) goto error ; dev -> interrupt_out_urb = usb_alloc_urb ( 0 , GFP_KERNEL ) ; if ( ! dev -> interrupt_out_urb ) goto error ; dev -> interrupt_in_interval = interrupt_in_interval ? interrupt_in_interval : dev -> interrupt_in_endpoint -> bInterval ; dev -> interrupt_out_interval = interrupt_out_interval ? interrupt_out_interval : dev -> interrupt_out_endpoint -> bInterval ; <BUGS> usb_set_intfdata ( interface , dev ) ; retval = usb_register_dev ( interface , & tower_class ) ; if ( retval ) { dev_err ( idev , "Not able to get a minor for this device.\\n" ) ; usb_set_intfdata ( interface , NULL ) ; goto error ; } dev -> minor = interface -> minor ; dev_info ( & interface -> dev , "LEGO USB Tower #%d now attached to major " "%d minor %d\\n" , ( dev -> minor - LEGO_USB_TOWER_MINOR_BASE ) , USB_MAJOR , dev -> minor ) ; <BUGE> result = usb_control_msg ( udev , usb_rcvctrlpipe ( udev , 0 ) , LEGO_USB_TOWER_REQUEST_GET_VERSION , USB_TYPE_VENDOR | USB_DIR_IN | USB_RECIP_DEVICE , 0 , 0 , & get_version_reply , sizeof ( get_version_reply ) , 1000 ) ; if ( result < 0 ) { dev_err ( idev , "LEGO USB Tower get version control request failed\\n" ) ; retval = result ; goto error ; } dev_info ( & interface -> dev , "LEGO USB Tower firmware version is %d.%d " "build %d\\n" , get_version_reply . major , get_version_reply . minor , le16_to_cpu ( get_version_reply . build_no ) ) ; <BUGS> <BUGE> exit : return retval ; error : tower_delete ( dev ) ; return retval ; }
| <FIXS> <FIXE> <FIXS> usb_set_intfdata ( interface , dev ) ; retval = usb_register_dev ( interface , & tower_class ) ; if ( retval ) { dev_err ( idev , "Not able to get a minor for this device.\\n" ) ; usb_set_intfdata ( interface , NULL ) ; goto error ; } dev -> minor = interface -> minor ; dev_info ( & interface -> dev , "LEGO USB Tower #%d now attached to major " "%d minor %d\\n" , ( dev -> minor - LEGO_USB_TOWER_MINOR_BASE ) , USB_MAJOR , dev -> minor ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static int netlbl_cipsov4_add_common ( struct genl_info * info , struct cipso_v4_doi * doi_def ) { struct nlattr * nla ; int nla_rem ; u32 iter = 0 ; doi_def -> doi = nla_get_u32 ( info -> attrs [ NLBL_CIPSOV4_A_DOI ] ) ; if ( nla_validate_nested ( info -> attrs [ NLBL_CIPSOV4_A_TAGLST ] , NLBL_CIPSOV4_A_MAX , netlbl_cipsov4_genl_policy ) != 0 ) return - EINVAL ; nla_for_each_nested ( nla , info -> attrs [ NLBL_CIPSOV4_A_TAGLST ] , nla_rem ) if ( nla -> nla_type == NLBL_CIPSOV4_A_TAG ) { <BUGS> if ( iter > CIPSO_V4_TAG_MAXCNT ) <BUGE> return - EINVAL ; doi_def -> tags [ iter ++ ] = nla_get_u8 ( nla ) ; } <BUGS> if ( iter < CIPSO_V4_TAG_MAXCNT ) doi_def -> tags [ iter ] = CIPSO_V4_TAG_INVALID ; <BUGE> return 0 ; }
| <FIXS> if ( iter >= CIPSO_V4_TAG_MAXCNT ) <FIXE> <FIXS> while ( iter < CIPSO_V4_TAG_MAXCNT ) doi_def -> tags [ iter ++ ] = CIPSO_V4_TAG_INVALID ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-125 static int count_comp_fors ( struct compiling * c , const node * n ) { int n_fors = 0 ; <BUGS> int is_async ; <BUGE> count_comp_for : <BUGS> is_async = 0 ; <BUGE> n_fors ++ ; REQ ( n , comp_for ) ; <BUGS> if ( TYPE ( CHILD ( n , 0 ) ) == ASYNC ) { is_async = 1 ; <BUGE> } <BUGS> if ( NCH ( n ) == ( 5 + is_async ) ) { n = CHILD ( n , 4 + is_async ) ; <BUGE> } else { return n_fors ; } count_comp_iter : REQ ( n , comp_iter ) ; n = CHILD ( n , 0 ) ; if ( TYPE ( n ) == comp_for ) goto count_comp_for ; else if ( TYPE ( n ) == comp_if ) { if ( NCH ( n ) == 3 ) { n = CHILD ( n , 2 ) ; goto count_comp_iter ; } else return n_fors ; } <BUGS> <BUGE> PyErr_SetString ( PyExc_SystemError , "logic error in count_comp_fors" ) ; return - 1 ; }
| <FIXS> <FIXE> <FIXS> <FIXE> <FIXS> if ( NCH ( n ) == 2 ) { REQ ( CHILD ( n , 0 ) , NAME ) ; assert ( strcmp ( STR ( CHILD ( n , 0 ) ) , "async" ) == 0 ) ; n = CHILD ( n , 1 ) ; <FIXE> <FIXS> else if ( NCH ( n ) == 1 ) { n = CHILD ( n , 0 ) ; } else { goto error ; } if ( NCH ( n ) == ( 5 ) ) { n = CHILD ( n , 4 ) ; <FIXE> <FIXS> error : <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-476 static Sdb * store_versioninfo_gnu_verdef ( ELFOBJ * bin , Elf_ ( Shdr ) * shdr , int sz ) { const char * section_name = "" ; const char * link_section_name = "" ; char * end = NULL ; Elf_ ( Shdr ) * link_shdr = NULL ; ut8 dfs [ sizeof ( Elf_ ( Verdef ) ) ] = { 0 } ; Sdb * sdb ; int cnt , i ; if ( shdr -> sh_link > bin -> ehdr . e_shnum ) { return false ; } link_shdr = & bin -> shdr [ shdr -> sh_link ] ; if ( shdr -> sh_size < 1 || shdr -> sh_size > SIZE_MAX ) { return false ; } Elf_ ( Verdef ) * defs = calloc ( shdr -> sh_size , sizeof ( char ) ) ; if ( ! defs ) { return false ; } if ( bin -> shstrtab && shdr -> sh_name < bin -> shstrtab_size ) { section_name = & bin -> shstrtab [ shdr -> sh_name ] ; } if ( link_shdr && bin -> shstrtab && link_shdr -> sh_name < bin -> shstrtab_size ) { link_section_name = & bin -> shstrtab [ link_shdr -> sh_name ] ; } if ( ! defs ) { bprintf ( "Warning: Cannot allocate memory (Check Elf_(Verdef))\\n" ) ; return NULL ; } sdb = sdb_new0 ( ) ; end = ( char * ) defs + shdr -> sh_size ; sdb_set ( sdb , "section_name" , section_name , 0 ) ; sdb_num_set ( sdb , "entries" , shdr -> sh_info , 0 ) ; sdb_num_set ( sdb , "addr" , shdr -> sh_addr , 0 ) ; sdb_num_set ( sdb , "offset" , shdr -> sh_offset , 0 ) ; sdb_num_set ( sdb , "link" , shdr -> sh_link , 0 ) ; sdb_set ( sdb , "link_section_name" , link_section_name , 0 ) ; for ( cnt = 0 , i = 0 ; i >= 0 && cnt < shdr -> sh_info && ( end - ( char * ) defs > i ) ; ++ cnt ) { Sdb * sdb_verdef = sdb_new0 ( ) ; char * vstart = ( ( char * ) defs ) + i ; char key [ 32 ] = { 0 } ; Elf_ ( Verdef ) * verdef = ( Elf_ ( Verdef ) * ) vstart ; Elf_ ( Verdaux ) aux = { 0 } ; int j = 0 ; int isum = 0 ; r_buf_read_at ( bin -> b , shdr -> sh_offset + i , dfs , sizeof ( Elf_ ( Verdef ) ) ) ; verdef -> vd_version = READ16 ( dfs , j ) verdef -> vd_flags = READ16 ( dfs , j ) verdef -> vd_ndx = READ16 ( dfs , j ) verdef -> vd_cnt = READ16 ( dfs , j ) verdef -> vd_hash = READ32 ( dfs , j ) verdef -> vd_aux = READ32 ( dfs , j ) verdef -> vd_next = READ32 ( dfs , j ) int vdaux = verdef -> vd_aux ; <BUGS> if ( vdaux < 1 || ( char * ) UINTPTR_MAX - vstart < vdaux ) { <BUGE> sdb_free ( sdb_verdef ) ; goto out_error ; } vstart += vdaux ; if ( vstart > end || end - vstart < sizeof ( Elf_ ( Verdaux ) ) ) { sdb_free ( sdb_verdef ) ; goto out_error ; } j = 0 ; aux . vda_name = READ32 ( vstart , j ) aux . vda_next = READ32 ( vstart , j ) isum = i + verdef -> vd_aux ; if ( aux . vda_name > bin -> dynstr_size ) { sdb_free ( sdb_verdef ) ; goto out_error ; } sdb_num_set ( sdb_verdef , "idx" , i , 0 ) ; sdb_num_set ( sdb_verdef , "vd_version" , verdef -> vd_version , 0 ) ; sdb_num_set ( sdb_verdef , "vd_ndx" , verdef -> vd_ndx , 0 ) ; sdb_num_set ( sdb_verdef , "vd_cnt" , verdef -> vd_cnt , 0 ) ; sdb_set ( sdb_verdef , "vda_name" , & bin -> dynstr [ aux . vda_name ] , 0 ) ; sdb_set ( sdb_verdef , "flags" , get_ver_flags ( verdef -> vd_flags ) , 0 ) ; for ( j = 1 ; j < verdef -> vd_cnt ; ++ j ) { int k ; Sdb * sdb_parent = sdb_new0 ( ) ; isum += aux . vda_next ; vstart += aux . vda_next ; if ( vstart > end || end - vstart < sizeof ( Elf_ ( Verdaux ) ) ) { sdb_free ( sdb_verdef ) ; sdb_free ( sdb_parent ) ; goto out_error ; } k = 0 ; aux . vda_name = READ32 ( vstart , k ) aux . vda_next = READ32 ( vstart , k ) if ( aux . vda_name > bin -> dynstr_size ) { sdb_free ( sdb_verdef ) ; sdb_free ( sdb_parent ) ; goto out_error ; } sdb_num_set ( sdb_parent , "idx" , isum , 0 ) ; sdb_num_set ( sdb_parent , "parent" , j , 0 ) ; sdb_set ( sdb_parent , "vda_name" , & bin -> dynstr [ aux . vda_name ] , 0 ) ; snprintf ( key , sizeof ( key ) , "parent%d" , j - 1 ) ; sdb_ns_set ( sdb_verdef , key , sdb_parent ) ; } snprintf ( key , sizeof ( key ) , "verdef%d" , cnt ) ; sdb_ns_set ( sdb , key , sdb_verdef ) ; if ( ! verdef -> vd_next ) { sdb_free ( sdb_verdef ) ; goto out_error ; } if ( ( st32 ) verdef -> vd_next < 1 ) { eprintf ( "Warning: Invalid vd_next in the ELF version\\n" ) ; break ; } i += verdef -> vd_next ; } free ( defs ) ; return sdb ; out_error : free ( defs ) ; sdb_free ( sdb ) ; return NULL ; }
| <FIXS> if ( vdaux < 1 || vstart + vdaux < vstart ) { <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-835 static const u_char * ikev1_nonce_print ( netdissect_options * ndo , u_char tpay _U_ , const struct isakmp_gen * ext , u_int item_len _U_ , const u_char * ep , uint32_t phase _U_ , uint32_t doi _U_ , uint32_t proto _U_ , int depth _U_ ) { struct isakmp_gen e ; ND_PRINT ( ( ndo , "%s:" , NPSTR ( ISAKMP_NPTYPE_NONCE ) ) ) ; ND_TCHECK ( * ext ) ; UNALIGNED_MEMCPY ( & e , ext , sizeof ( e ) ) ; <BUGS> ND_PRINT ( ( ndo , " n len=%d" , ntohs ( e . len ) - 4 ) ) ; if ( 2 < ndo -> ndo_vflag && 4 < ntohs ( e . len ) ) { <BUGE> ND_PRINT ( ( ndo , " " ) ) ; if ( ! rawprint ( ndo , ( const uint8_t * ) ( ext + 1 ) , ntohs ( e . len ) - 4 ) ) goto trunc ; <BUGS> } else if ( 1 < ndo -> ndo_vflag && 4 < ntohs ( e . len ) ) { <BUGE> ND_PRINT ( ( ndo , " " ) ) ; <BUGS> if ( ! ike_show_somedata ( ndo , ( const u_char * ) ( const uint8_t * ) ( ext + 1 ) , ep ) ) <BUGE> goto trunc ; <BUGS> <BUGE> } return ( const u_char * ) ext + ntohs ( e . len ) ; trunc : ND_PRINT ( ( ndo , " [|%s]" , NPSTR ( ISAKMP_NPTYPE_NONCE ) ) ) ; return NULL ; }
| <FIXS> ND_PRINT ( ( ndo , " n len=%u" , ntohs ( e . len ) - 4 ) ) ; if ( ntohs ( e . len ) > 4 ) { if ( ndo -> ndo_vflag > 2 ) { <FIXE> <FIXS> } else if ( ndo -> ndo_vflag > 1 ) { <FIXE> <FIXS> if ( ! ike_show_somedata ( ndo , ( const u_char * ) ( ext + 1 ) , ep ) ) <FIXE> <FIXS> } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-264 static int futex_wait_requeue_pi ( u32 __user * uaddr , unsigned int flags , u32 val , ktime_t * abs_time , u32 bitset , u32 __user * uaddr2 ) { struct hrtimer_sleeper timeout , * to = NULL ; struct rt_mutex_waiter rt_waiter ; struct rt_mutex * pi_mutex = NULL ; struct futex_hash_bucket * hb ; union futex_key key2 = FUTEX_KEY_INIT ; struct futex_q q = futex_q_init ; int res , ret ; if ( uaddr == uaddr2 ) return - EINVAL ; if ( ! bitset ) return - EINVAL ; if ( abs_time ) { to = & timeout ; hrtimer_init_on_stack ( & to -> timer , ( flags & FLAGS_CLOCKRT ) ? CLOCK_REALTIME : CLOCK_MONOTONIC , HRTIMER_MODE_ABS ) ; hrtimer_init_sleeper ( to , current ) ; hrtimer_set_expires_range_ns ( & to -> timer , * abs_time , current -> timer_slack_ns ) ; } debug_rt_mutex_init_waiter ( & rt_waiter ) ; RB_CLEAR_NODE ( & rt_waiter . pi_tree_entry ) ; RB_CLEAR_NODE ( & rt_waiter . tree_entry ) ; rt_waiter . task = NULL ; ret = get_futex_key ( uaddr2 , flags & FLAGS_SHARED , & key2 , VERIFY_WRITE ) ; if ( unlikely ( ret != 0 ) ) goto out ; q . bitset = bitset ; q . rt_waiter = & rt_waiter ; q . requeue_pi_key = & key2 ; ret = futex_wait_setup ( uaddr , val , flags , & q , & hb ) ; if ( ret ) goto out_key2 ; <BUGS> <BUGE> futex_wait_queue_me ( hb , & q , to ) ; spin_lock ( & hb -> lock ) ; ret = handle_early_requeue_pi_wakeup ( hb , & q , & key2 , to ) ; spin_unlock ( & hb -> lock ) ; if ( ret ) goto out_put_keys ; if ( ! q . rt_waiter ) { if ( q . pi_state && ( q . pi_state -> owner != current ) ) { spin_lock ( q . lock_ptr ) ; ret = fixup_pi_state_owner ( uaddr2 , & q , current ) ; spin_unlock ( q . lock_ptr ) ; } } else { WARN_ON ( ! q . pi_state ) ; pi_mutex = & q . pi_state -> pi_mutex ; ret = rt_mutex_finish_proxy_lock ( pi_mutex , to , & rt_waiter , 1 ) ; debug_rt_mutex_free_waiter ( & rt_waiter ) ; spin_lock ( q . lock_ptr ) ; res = fixup_owner ( uaddr2 , & q , ! ret ) ; if ( res ) ret = ( res < 0 ) ? res : 0 ; unqueue_me_pi ( & q ) ; } if ( ret == - EFAULT ) { if ( pi_mutex && rt_mutex_owner ( pi_mutex ) == current ) rt_mutex_unlock ( pi_mutex ) ; } else if ( ret == - EINTR ) { ret = - EWOULDBLOCK ; } out_put_keys : put_futex_key ( & q . key ) ; out_key2 : put_futex_key ( & key2 ) ; out : if ( to ) { hrtimer_cancel ( & to -> timer ) ; destroy_hrtimer_on_stack ( & to -> timer ) ; } return ret ; }
| <FIXS> if ( match_futex ( & q . key , & key2 ) ) { ret = - EINVAL ; goto out_put_keys ; } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-000 int propagate_mnt ( struct mount * dest_mnt , struct mountpoint * dest_mp , struct mount * source_mnt , struct hlist_head * tree_list ) { struct mount * m , * n ; int ret = 0 ; user_ns = current -> nsproxy -> mnt_ns -> user_ns ; last_dest = dest_mnt ; <BUGS> <BUGE> last_source = source_mnt ; mp = dest_mp ; list = tree_list ; dest_master = dest_mnt -> mnt_master ; for ( n = next_peer ( dest_mnt ) ; n != dest_mnt ; n = next_peer ( n ) ) { ret = propagate_one ( n ) ; if ( ret ) goto out ; } for ( m = next_group ( dest_mnt , dest_mnt ) ; m ; m = next_group ( m , dest_mnt ) ) { n = m ; do { ret = propagate_one ( n ) ; if ( ret ) goto out ; n = next_peer ( n ) ; } while ( n != m ) ; } out : read_seqlock_excl ( & mount_lock ) ; hlist_for_each_entry ( n , tree_list , mnt_hash ) { m = n -> mnt_parent ; if ( m -> mnt_master != dest_mnt -> mnt_master ) CLEAR_MNT_MARK ( m -> mnt_master ) ; } read_sequnlock_excl ( & mount_lock ) ; return ret ; }
| <FIXS> first_source = source_mnt ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static int tt_s2_4600_frontend_attach ( struct dvb_usb_adapter * adap ) { struct dvb_usb_device * d = adap -> dev ; struct dw2102_state * state = d -> priv ; <BUGS> u8 obuf [ 3 ] = { 0xe , 0x80 , 0 } ; u8 ibuf [ ] = { 0 } ; <BUGE> struct i2c_adapter * i2c_adapter ; struct i2c_client * client ; struct i2c_board_info board_info ; struct m88ds3103_platform_data m88ds3103_pdata = { } ; struct ts2020_config ts2020_config = { } ; <BUGS> if ( dvb_usb_generic_rw ( d , obuf , 3 , ibuf , 1 , 0 ) < 0 ) <BUGE> err ( "command 0x0e transfer failed." ) ; <BUGS> obuf [ 0 ] = 0xe ; obuf [ 1 ] = 0x02 ; obuf [ 2 ] = 1 ; if ( dvb_usb_generic_rw ( d , obuf , 3 , ibuf , 1 , 0 ) < 0 ) <BUGE> err ( "command 0x0e transfer failed." ) ; msleep ( 300 ) ; <BUGS> obuf [ 0 ] = 0xe ; obuf [ 1 ] = 0x83 ; obuf [ 2 ] = 0 ; if ( dvb_usb_generic_rw ( d , obuf , 3 , ibuf , 1 , 0 ) < 0 ) <BUGE> err ( "command 0x0e transfer failed." ) ; <BUGS> obuf [ 0 ] = 0xe ; obuf [ 1 ] = 0x83 ; obuf [ 2 ] = 1 ; if ( dvb_usb_generic_rw ( d , obuf , 3 , ibuf , 1 , 0 ) < 0 ) <BUGE> err ( "command 0x0e transfer failed." ) ; <BUGS> obuf [ 0 ] = 0x51 ; if ( dvb_usb_generic_rw ( d , obuf , 1 , ibuf , 1 , 0 ) < 0 ) <BUGE> err ( "command 0x51 transfer failed." ) ; <BUGS> <BUGE> m88ds3103_pdata . clk = 27000000 ; m88ds3103_pdata . i2c_wr_max = 33 ; m88ds3103_pdata . ts_mode = M88DS3103_TS_CI ; m88ds3103_pdata . ts_clk = 16000 ; m88ds3103_pdata . ts_clk_pol = 0 ; m88ds3103_pdata . spec_inv = 0 ; m88ds3103_pdata . agc = 0x99 ; m88ds3103_pdata . agc_inv = 0 ; m88ds3103_pdata . clk_out = M88DS3103_CLOCK_OUT_ENABLED ; m88ds3103_pdata . envelope_mode = 0 ; m88ds3103_pdata . lnb_hv_pol = 1 ; m88ds3103_pdata . lnb_en_pol = 0 ; memset ( & board_info , 0 , sizeof ( board_info ) ) ; strlcpy ( board_info . type , "m88ds3103" , I2C_NAME_SIZE ) ; board_info . addr = 0x68 ; board_info . platform_data = & m88ds3103_pdata ; request_module ( "m88ds3103" ) ; client = i2c_new_device ( & d -> i2c_adap , & board_info ) ; if ( client == NULL || client -> dev . driver == NULL ) return - ENODEV ; if ( ! try_module_get ( client -> dev . driver -> owner ) ) { i2c_unregister_device ( client ) ; return - ENODEV ; } adap -> fe_adap [ 0 ] . fe = m88ds3103_pdata . get_dvb_frontend ( client ) ; i2c_adapter = m88ds3103_pdata . get_i2c_adapter ( client ) ; state -> i2c_client_demod = client ; ts2020_config . fe = adap -> fe_adap [ 0 ] . fe ; memset ( & board_info , 0 , sizeof ( board_info ) ) ; strlcpy ( board_info . type , "ts2022" , I2C_NAME_SIZE ) ; board_info . addr = 0x60 ; board_info . platform_data = & ts2020_config ; request_module ( "ts2020" ) ; client = i2c_new_device ( i2c_adapter , & board_info ) ; if ( client == NULL || client -> dev . driver == NULL ) { dvb_frontend_detach ( adap -> fe_adap [ 0 ] . fe ) ; return - ENODEV ; } if ( ! try_module_get ( client -> dev . driver -> owner ) ) { i2c_unregister_device ( client ) ; dvb_frontend_detach ( adap -> fe_adap [ 0 ] . fe ) ; return - ENODEV ; } adap -> fe_adap [ 0 ] . fe -> ops . read_signal_strength = adap -> fe_adap [ 0 ] . fe -> ops . tuner_ops . get_rf_strength ; state -> i2c_client_tuner = client ; state -> fe_read_status = adap -> fe_adap [ 0 ] . fe -> ops . read_status ; adap -> fe_adap [ 0 ] . fe -> ops . read_status = tt_s2_4600_read_status ; state -> last_lock = 0 ; return 0 ; }
| <FIXS> <FIXE> <FIXS> mutex_lock ( & d -> data_mutex ) ; state -> data [ 0 ] = 0xe ; state -> data [ 1 ] = 0x80 ; state -> data [ 2 ] = 0x0 ; if ( dvb_usb_generic_rw ( d , state -> data , 3 , state -> data , 1 , 0 ) < 0 ) <FIXE> <FIXS> state -> data [ 0 ] = 0xe ; state -> data [ 1 ] = 0x02 ; state -> data [ 2 ] = 1 ; if ( dvb_usb_generic_rw ( d , state -> data , 3 , state -> data , 1 , 0 ) < 0 ) <FIXE> <FIXS> state -> data [ 0 ] = 0xe ; state -> data [ 1 ] = 0x83 ; state -> data [ 2 ] = 0 ; if ( dvb_usb_generic_rw ( d , state -> data , 3 , state -> data , 1 , 0 ) < 0 ) <FIXE> <FIXS> state -> data [ 0 ] = 0xe ; state -> data [ 1 ] = 0x83 ; state -> data [ 2 ] = 1 ; if ( dvb_usb_generic_rw ( d , state -> data , 3 , state -> data , 1 , 0 ) < 0 ) <FIXE> <FIXS> state -> data [ 0 ] = 0x51 ; if ( dvb_usb_generic_rw ( d , state -> data , 1 , state -> data , 1 , 0 ) < 0 ) <FIXE> <FIXS> mutex_unlock ( & d -> data_mutex ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-862 <BUGS> static void construct_get_dest_keyring ( struct key * * _dest_keyring ) <BUGE> { struct request_key_auth * rka ; const struct cred * cred = current_cred ( ) ; struct key * dest_keyring = * _dest_keyring , * authkey ; <BUGS> <BUGE> kenter ( "%p" , dest_keyring ) ; if ( dest_keyring ) { key_get ( dest_keyring ) ; } else { <BUGS> <BUGE> switch ( cred -> jit_keyring ) { case KEY_REQKEY_DEFL_DEFAULT : case KEY_REQKEY_DEFL_REQUESTOR_KEYRING : if ( cred -> request_key_auth ) { authkey = cred -> request_key_auth ; down_read ( & authkey -> sem ) ; rka = authkey -> payload . data [ 0 ] ; if ( ! test_bit ( KEY_FLAG_REVOKED , & authkey -> flags ) ) dest_keyring = key_get ( rka -> dest_keyring ) ; up_read ( & authkey -> sem ) ; <BUGS> if ( dest_keyring ) <BUGE> break ; <BUGS> <BUGE> } case KEY_REQKEY_DEFL_THREAD_KEYRING : dest_keyring = key_get ( cred -> thread_keyring ) ; if ( dest_keyring ) break ; case KEY_REQKEY_DEFL_PROCESS_KEYRING : dest_keyring = key_get ( cred -> process_keyring ) ; if ( dest_keyring ) break ; case KEY_REQKEY_DEFL_SESSION_KEYRING : rcu_read_lock ( ) ; dest_keyring = key_get ( rcu_dereference ( cred -> session_keyring ) ) ; rcu_read_unlock ( ) ; if ( dest_keyring ) break ; case KEY_REQKEY_DEFL_USER_SESSION_KEYRING : dest_keyring = key_get ( cred -> user -> session_keyring ) ; break ; case KEY_REQKEY_DEFL_USER_KEYRING : dest_keyring = key_get ( cred -> user -> uid_keyring ) ; break ; case KEY_REQKEY_DEFL_GROUP_KEYRING : default : BUG ( ) ; } <BUGS> <BUGE> } * _dest_keyring = dest_keyring ; kleave ( " [dk %d]" , key_serial ( dest_keyring ) ) ; <BUGS> return ; <BUGE> }
| <FIXS> static int construct_get_dest_keyring ( struct key * * _dest_keyring ) <FIXE> <FIXS> int ret ; <FIXE> <FIXS> bool do_perm_check = true ; <FIXE> <FIXS> if ( dest_keyring ) { do_perm_check = false ; <FIXE> <FIXS> } <FIXE> <FIXS> if ( dest_keyring && do_perm_check ) { ret = key_permission ( make_key_ref ( dest_keyring , 1 ) , KEY_NEED_WRITE ) ; if ( ret ) { key_put ( dest_keyring ) ; return ret ; } } <FIXE> <FIXS> return 0 ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-763 static OM_uint32 init_ctx_new ( OM_uint32 * minor_status , spnego_gss_cred_id_t spcred , gss_ctx_id_t * ctx , send_token_flag * tokflag ) { OM_uint32 ret ; spnego_gss_ctx_id_t sc = NULL ; <BUGS> sc = create_spnego_ctx ( ) ; <BUGE> if ( sc == NULL ) return GSS_S_FAILURE ; ret = get_negotiable_mechs ( minor_status , spcred , GSS_C_INITIATE , & sc -> mech_set ) ; if ( ret != GSS_S_COMPLETE ) goto cleanup ; sc -> internal_mech = & sc -> mech_set -> elements [ 0 ] ; if ( put_mech_set ( sc -> mech_set , & sc -> DER_mechTypes ) < 0 ) { ret = GSS_S_FAILURE ; goto cleanup ; } sc -> ctx_handle = GSS_C_NO_CONTEXT ; * ctx = ( gss_ctx_id_t ) sc ; sc = NULL ; * tokflag = INIT_TOKEN_SEND ; ret = GSS_S_CONTINUE_NEEDED ; cleanup : release_spnego_ctx ( & sc ) ; return ret ; }
| <FIXS> sc = create_spnego_ctx ( 1 ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-476 static int nfc_llcp_build_gb ( struct nfc_llcp_local * local ) { <BUGS> u8 * gb_cur , * version_tlv , version , version_length ; u8 * lto_tlv , lto_length ; u8 * wks_tlv , wks_length ; u8 * miux_tlv , miux_length ; <BUGE> __be16 wks = cpu_to_be16 ( local -> local_wks ) ; u8 gb_len = 0 ; int ret = 0 ; version = LLCP_VERSION_11 ; version_tlv = nfc_llcp_build_tlv ( LLCP_TLV_VERSION , & version , 1 , & version_length ) ; <BUGS> <BUGE> gb_len += version_length ; lto_tlv = nfc_llcp_build_tlv ( LLCP_TLV_LTO , & local -> lto , 1 , & lto_length ) ; <BUGS> <BUGE> gb_len += lto_length ; pr_debug ( "Local wks 0x%lx\\n" , local -> local_wks ) ; wks_tlv = nfc_llcp_build_tlv ( LLCP_TLV_WKS , ( u8 * ) & wks , 2 , & wks_length ) ; <BUGS> <BUGE> gb_len += wks_length ; miux_tlv = nfc_llcp_build_tlv ( LLCP_TLV_MIUX , ( u8 * ) & local -> miux , 0 , & miux_length ) ; <BUGS> <BUGE> gb_len += miux_length ; gb_len += ARRAY_SIZE ( llcp_magic ) ; if ( gb_len > NFC_MAX_GT_LEN ) { ret = - EINVAL ; goto out ; } gb_cur = local -> gb ; memcpy ( gb_cur , llcp_magic , ARRAY_SIZE ( llcp_magic ) ) ; gb_cur += ARRAY_SIZE ( llcp_magic ) ; memcpy ( gb_cur , version_tlv , version_length ) ; gb_cur += version_length ; memcpy ( gb_cur , lto_tlv , lto_length ) ; gb_cur += lto_length ; memcpy ( gb_cur , wks_tlv , wks_length ) ; gb_cur += wks_length ; memcpy ( gb_cur , miux_tlv , miux_length ) ; gb_cur += miux_length ; local -> gb_len = gb_len ; out : kfree ( version_tlv ) ; kfree ( lto_tlv ) ; kfree ( wks_tlv ) ; kfree ( miux_tlv ) ; return ret ; }
| <FIXS> u8 * gb_cur , version , version_length ; u8 lto_length , wks_length , miux_length ; u8 * version_tlv = NULL , * lto_tlv = NULL , * wks_tlv = NULL , * miux_tlv = NULL ; <FIXE> <FIXS> if ( ! version_tlv ) { ret = - ENOMEM ; goto out ; } <FIXE> <FIXS> if ( ! lto_tlv ) { ret = - ENOMEM ; goto out ; } <FIXE> <FIXS> if ( ! wks_tlv ) { ret = - ENOMEM ; goto out ; } <FIXE> <FIXS> if ( ! miux_tlv ) { ret = - ENOMEM ; goto out ; } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-787 static int next_state_class ( CClassNode * cc , OnigCodePoint * vs , enum CCVALTYPE * type , enum CCSTATE * state , ScanEnv * env ) { int r ; if ( * state == CCS_RANGE ) return ONIGERR_CHAR_CLASS_VALUE_AT_END_OF_RANGE ; if ( * state == CCS_VALUE && * type != CCV_CLASS ) { if ( * type == CCV_SB ) BITSET_SET_BIT ( cc -> bs , ( int ) ( * vs ) ) ; else if ( * type == CCV_CODE_POINT ) { r = add_code_range ( & ( cc -> mbuf ) , env , * vs , * vs ) ; if ( r < 0 ) return r ; } } <BUGS> <BUGE> * state = CCS_VALUE ; * type = CCV_CLASS ; return 0 ; }
| <FIXS> if ( * state != CCS_START ) <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-20 static gboolean parse_toshiba_packet ( FILE_T fh , struct wtap_pkthdr * phdr , Buffer * buf , int * err , gchar * * err_info ) { union wtap_pseudo_header * pseudo_header = & phdr -> pseudo_header ; char line [ TOSHIBA_LINE_LENGTH ] ; int num_items_scanned ; <BUGS> int pkt_len , pktnum , hr , min , sec , csec ; <BUGE> char channel [ 10 ] , direction [ 10 ] ; int i , hex_lines ; guint8 * pd ; if ( file_gets ( line , TOSHIBA_LINE_LENGTH , fh ) == NULL ) { * err = file_error ( fh , err_info ) ; if ( * err == 0 ) { * err = WTAP_ERR_SHORT_READ ; } return FALSE ; } num_items_scanned = sscanf ( line , "%9d] %2d:%2d:%2d.%9d %9s %9s" , & pktnum , & hr , & min , & sec , & csec , channel , direction ) ; if ( num_items_scanned != 7 ) { * err = WTAP_ERR_BAD_FILE ; * err_info = g_strdup ( "toshiba: record header isn\'t valid" ) ; return FALSE ; } do { if ( file_gets ( line , TOSHIBA_LINE_LENGTH , fh ) == NULL ) { * err = file_error ( fh , err_info ) ; if ( * err == 0 ) { * err = WTAP_ERR_SHORT_READ ; } return FALSE ; } line [ 16 ] = '\\0' ; } while ( strcmp ( line , "OFFSET 0001-0203" ) != 0 ) ; <BUGS> num_items_scanned = sscanf ( line + 64 , "LEN=%9d" , & pkt_len ) ; <BUGE> if ( num_items_scanned != 1 ) { * err = WTAP_ERR_BAD_FILE ; * err_info = g_strdup ( "toshiba: OFFSET line doesn\'t have valid LEN item" ) ; <BUGS> <BUGE> return FALSE ; } phdr -> rec_type = REC_TYPE_PACKET ; phdr -> presence_flags = WTAP_HAS_TS | WTAP_HAS_CAP_LEN ; phdr -> ts . secs = hr * 3600 + min * 60 + sec ; phdr -> ts . nsecs = csec * 10000000 ; phdr -> caplen = pkt_len ; phdr -> len = pkt_len ; switch ( channel [ 0 ] ) { case 'B' : phdr -> pkt_encap = WTAP_ENCAP_ISDN ; pseudo_header -> isdn . uton = ( direction [ 0 ] == 'T' ) ; pseudo_header -> isdn . channel = ( guint8 ) strtol ( & channel [ 1 ] , NULL , 10 ) ; break ; case 'D' : phdr -> pkt_encap = WTAP_ENCAP_ISDN ; pseudo_header -> isdn . uton = ( direction [ 0 ] == 'T' ) ; pseudo_header -> isdn . channel = 0 ; break ; default : phdr -> pkt_encap = WTAP_ENCAP_ETHERNET ; pseudo_header -> eth . fcs_len = - 1 ; break ; } <BUGS> ws_buffer_assure_space ( buf , TOSHIBA_MAX_PACKET_LEN ) ; <BUGE> pd = ws_buffer_start_ptr ( buf ) ; hex_lines = pkt_len / 16 + ( ( pkt_len % 16 ) ? 1 : 0 ) ; for ( i = 0 ; i < hex_lines ; i ++ ) { if ( file_gets ( line , TOSHIBA_LINE_LENGTH , fh ) == NULL ) { * err = file_error ( fh , err_info ) ; if ( * err == 0 ) { * err = WTAP_ERR_SHORT_READ ; } return FALSE ; } if ( ! parse_single_hex_dump_line ( line , pd , i * 16 ) ) { * err = WTAP_ERR_BAD_FILE ; * err_info = g_strdup ( "toshiba: hex dump not valid" ) ; return FALSE ; } } return TRUE ; }
| <FIXS> guint pkt_len ; int pktnum , hr , min , sec , csec ; <FIXE> <FIXS> num_items_scanned = sscanf ( line + 64 , "LEN=%9u" , & pkt_len ) ; <FIXE> <FIXS> return FALSE ; } if ( pkt_len > WTAP_MAX_PACKET_SIZE ) { * err = WTAP_ERR_BAD_FILE ; * err_info = g_strdup_printf ( "toshiba: File has %u-byte packet, bigger than maximum of %u" , pkt_len , WTAP_MAX_PACKET_SIZE ) ; <FIXE> <FIXS> ws_buffer_assure_space ( buf , pkt_len ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-416 static int l2tp_ip_bind ( struct sock * sk , struct sockaddr * uaddr , int addr_len ) { struct inet_sock * inet = inet_sk ( sk ) ; struct sockaddr_l2tpip * addr = ( struct sockaddr_l2tpip * ) uaddr ; struct net * net = sock_net ( sk ) ; int ret ; int chk_addr_ret ; <BUGS> if ( ! sock_flag ( sk , SOCK_ZAPPED ) ) return - EINVAL ; <BUGE> if ( addr_len < sizeof ( struct sockaddr_l2tpip ) ) return - EINVAL ; if ( addr -> l2tp_family != AF_INET ) return - EINVAL ; ret = - EADDRINUSE ; read_lock_bh ( & l2tp_ip_lock ) ; if ( __l2tp_ip_bind_lookup ( net , addr -> l2tp_addr . s_addr , sk -> sk_bound_dev_if , addr -> l2tp_conn_id ) ) goto out_in_use ; read_unlock_bh ( & l2tp_ip_lock ) ; lock_sock ( sk ) ; <BUGS> <BUGE> if ( sk -> sk_state != TCP_CLOSE || addr_len < sizeof ( struct sockaddr_l2tpip ) ) goto out ; chk_addr_ret = inet_addr_type ( net , addr -> l2tp_addr . s_addr ) ; ret = - EADDRNOTAVAIL ; if ( addr -> l2tp_addr . s_addr && chk_addr_ret != RTN_LOCAL && chk_addr_ret != RTN_MULTICAST && chk_addr_ret != RTN_BROADCAST ) goto out ; if ( addr -> l2tp_addr . s_addr ) inet -> inet_rcv_saddr = inet -> inet_saddr = addr -> l2tp_addr . s_addr ; if ( chk_addr_ret == RTN_MULTICAST || chk_addr_ret == RTN_BROADCAST ) inet -> inet_saddr = 0 ; sk_dst_reset ( sk ) ; l2tp_ip_sk ( sk ) -> conn_id = addr -> l2tp_conn_id ; write_lock_bh ( & l2tp_ip_lock ) ; sk_add_bind_node ( sk , & l2tp_ip_bind_table ) ; sk_del_node_init ( sk ) ; write_unlock_bh ( & l2tp_ip_lock ) ; ret = 0 ; sock_reset_flag ( sk , SOCK_ZAPPED ) ; out : release_sock ( sk ) ; return ret ; out_in_use : read_unlock_bh ( & l2tp_ip_lock ) ; return ret ; }
| <FIXS> <FIXE> <FIXS> if ( ! sock_flag ( sk , SOCK_ZAPPED ) ) goto out ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-264 <BUGS> static unsigned int stack_maxrandom_size ( void ) <BUGE> { <BUGS> unsigned int max = 0 ; <BUGE> if ( ( current -> flags & PF_RANDOMIZE ) && ! ( current -> personality & ADDR_NO_RANDOMIZE ) ) { <BUGS> max = ( ( - 1U ) & STACK_RND_MASK ) << PAGE_SHIFT ; <BUGE> } return max ; }
| <FIXS> static unsigned long stack_maxrandom_size ( void ) <FIXE> <FIXS> unsigned long max = 0 ; <FIXE> <FIXS> max = ( ( - 1UL ) & STACK_RND_MASK ) << PAGE_SHIFT ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-399 static int ceph_x_verify_authorizer_reply ( struct ceph_auth_client * ac , struct ceph_authorizer * a , size_t len ) { struct ceph_x_authorizer * au = ( void * ) a ; struct ceph_x_ticket_handler * th ; int ret = 0 ; struct ceph_x_authorize_reply reply ; <BUGS> <BUGE> void * p = au -> reply_buf ; void * end = p + sizeof ( au -> reply_buf ) ; th = get_ticket_handler ( ac , au -> service ) ; if ( IS_ERR ( th ) ) return PTR_ERR ( th ) ; <BUGS> ret = ceph_x_decrypt ( & th -> session_key , & p , end , & reply , sizeof ( reply ) ) ; <BUGE> if ( ret < 0 ) return ret ; if ( ret != sizeof ( reply ) ) return - EPERM ; if ( au -> nonce + 1 != le64_to_cpu ( reply . nonce_plus_one ) ) ret = - EPERM ; else ret = 0 ; dout ( "verify_authorizer_reply nonce %llx got %llx ret %d\\n" , au -> nonce , le64_to_cpu ( reply . nonce_plus_one ) , ret ) ; return ret ; }
| <FIXS> void * preply = & reply ; <FIXE> <FIXS> ret = ceph_x_decrypt ( & th -> session_key , & p , end , & preply , sizeof ( reply ) ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-20 static void activate_desktop_file ( ActivateParameters * parameters , NautilusFile * file ) { ActivateParametersDesktop * parameters_desktop ; char * primary , * secondary , * display_name ; GtkWidget * dialog ; GdkScreen * screen ; char * uri ; screen = gtk_widget_get_screen ( GTK_WIDGET ( parameters -> parent_window ) ) ; if ( ! nautilus_file_is_trusted_link ( file ) ) { parameters_desktop = g_new0 ( ActivateParametersDesktop , 1 ) ; if ( parameters -> parent_window ) { parameters_desktop -> parent_window = parameters -> parent_window ; g_object_add_weak_pointer ( G_OBJECT ( parameters_desktop -> parent_window ) , ( gpointer * ) & parameters_desktop -> parent_window ) ; } parameters_desktop -> file = nautilus_file_ref ( file ) ; primary = _ ( "Untrusted application launcher" ) ; display_name = nautilus_file_get_display_name ( file ) ; secondary = g_strdup_printf ( _ ( "The application launcher “%s” has not been marked as trusted. " "If you do not know the source of this file, launching it may be unsafe." ) , display_name ) ; dialog = gtk_message_dialog_new ( parameters -> parent_window , 0 , GTK_MESSAGE_WARNING , GTK_BUTTONS_NONE , NULL ) ; g_object_set ( dialog , "text" , primary , "secondary-text" , secondary , NULL ) ; gtk_dialog_add_button ( GTK_DIALOG ( dialog ) , <BUGS> _ ( "_Launch Anyway" ) , RESPONSE_RUN ) ; <BUGE> if ( nautilus_file_can_set_permissions ( file ) ) { gtk_dialog_add_button ( GTK_DIALOG ( dialog ) , <BUGS> _ ( "Mark as _Trusted" ) , RESPONSE_MARK_TRUSTED ) ; <BUGE> } <BUGS> gtk_dialog_add_button ( GTK_DIALOG ( dialog ) , _ ( "_Cancel" ) , GTK_RESPONSE_CANCEL ) ; gtk_dialog_set_default_response ( GTK_DIALOG ( dialog ) , GTK_RESPONSE_CANCEL ) ; <BUGE> g_signal_connect ( dialog , "response" , G_CALLBACK ( untrusted_launcher_response_callback ) , parameters_desktop ) ; gtk_widget_show ( dialog ) ; g_free ( display_name ) ; g_free ( secondary ) ; return ; } uri = nautilus_file_get_uri ( file ) ; DEBUG ( "Launching trusted launcher %s" , uri ) ; nautilus_launch_desktop_file ( screen , uri , NULL , parameters -> parent_window ) ; g_free ( uri ) ; }
| <FIXS> _ ( "_Cancel" ) , GTK_RESPONSE_CANCEL ) ; gtk_dialog_set_default_response ( GTK_DIALOG ( dialog ) , GTK_RESPONSE_CANCEL ) ; <FIXE> <FIXS> _ ( "Trust and _Launch" ) , GTK_RESPONSE_OK ) ; <FIXE> <FIXS> <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 char * irc_ctcp_dcc_filename_without_quotes ( const char * filename ) { int length ; length = strlen ( filename ) ; <BUGS> if ( length > 0 ) <BUGE> { if ( ( filename [ 0 ] == \'\\"\' ) && ( filename [ length - 1 ] == \'\\"\' ) ) return weechat_strndup ( filename + 1 , length - 2 ) ; } return strdup ( filename ) ; }
| <FIXS> if ( length > 1 ) <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-416 char * my_asctime ( time_t t ) { struct tm * tm ; char * str ; int len ; tm = localtime ( & t ) ; <BUGS> <BUGE> str = g_strdup ( asctime ( tm ) ) ; len = strlen ( str ) ; if ( len > 0 ) str [ len - 1 ] = '\\0' ; return str ; }
| <FIXS> if ( tm == NULL ) return g_strdup ( "???" ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-125 static void handle_ppp ( netdissect_options * ndo , u_int proto , const u_char * p , int length ) { if ( ( proto & 0xff00 ) == 0x7e00 ) { ppp_hdlc ( ndo , p - 1 , length ) ; return ; } switch ( proto ) { case PPP_LCP : case PPP_IPCP : case PPP_OSICP : case PPP_MPLSCP : case PPP_IPV6CP : case PPP_CCP : case PPP_BACP : handle_ctrl_proto ( ndo , proto , p , length ) ; break ; case PPP_ML : handle_mlppp ( ndo , p , length ) ; break ; case PPP_CHAP : handle_chap ( ndo , p , length ) ; break ; case PPP_PAP : handle_pap ( ndo , p , length ) ; break ; case PPP_BAP : handle_bap ( ndo , p , length ) ; break ; case ETHERTYPE_IP : case PPP_VJNC : case PPP_IP : ip_print ( ndo , p , length ) ; break ; case ETHERTYPE_IPV6 : case PPP_IPV6 : ip6_print ( ndo , p , length ) ; break ; case ETHERTYPE_IPX : case PPP_IPX : ipx_print ( ndo , p , length ) ; break ; case PPP_OSI : <BUGS> isoclns_print ( ndo , p , length , length ) ; <BUGE> break ; case PPP_MPLS_UCAST : case PPP_MPLS_MCAST : mpls_print ( ndo , p , length ) ; break ; case PPP_COMP : ND_PRINT ( ( ndo , "compressed PPP data" ) ) ; break ; default : ND_PRINT ( ( ndo , "%s " , tok2str ( ppptype2str , "unknown PPP protocol (0x%04x)" , proto ) ) ) ; print_unknown_data ( ndo , p , "\\n\\t" , length ) ; break ; } }
| <FIXS> isoclns_print ( ndo , p , length ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-000 static void * bpf_any_get ( void * raw , enum bpf_type type ) { switch ( type ) { case BPF_TYPE_PROG : <BUGS> atomic_inc ( & ( ( struct bpf_prog * ) raw ) -> aux -> refcnt ) ; <BUGE> break ; case BPF_TYPE_MAP : <BUGS> bpf_map_inc ( raw , true ) ; <BUGE> break ; default : WARN_ON_ONCE ( 1 ) ; break ; } return raw ; }
| <FIXS> raw = bpf_prog_inc ( raw ) ; <FIXE> <FIXS> raw = bpf_map_inc ( raw , true ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-59 static bool dump_fd_info ( const char * dest_filename , char * source_filename , int source_base_ofs , uid_t uid , gid_t gid ) { <BUGS> FILE * fp = fopen ( dest_filename , "w" ) ; <BUGE> if ( ! fp ) return false ; unsigned fd = 0 ; while ( fd <= 99999 ) { sprintf ( source_filename + source_base_ofs , "fd/%u" , fd ) ; char * name = malloc_readlink ( source_filename ) ; if ( ! name ) break ; fprintf ( fp , "%u:%s\\n" , fd , name ) ; free ( name ) ; sprintf ( source_filename + source_base_ofs , "fdinfo/%u" , fd ) ; fd ++ ; FILE * in = fopen ( source_filename , "r" ) ; if ( ! in ) continue ; char buf [ 128 ] ; while ( fgets ( buf , sizeof ( buf ) - 1 , in ) ) { char * eol = strchrnul ( buf , '\\n' ) ; eol [ 0 ] = '\\n' ; eol [ 1 ] = '\\0' ; fputs ( buf , fp ) ; } fclose ( in ) ; } const int dest_fd = fileno ( fp ) ; if ( fchown ( dest_fd , uid , gid ) < 0 ) { perror_msg ( "Can\'t change \'%s\' ownership to %lu:%lu" , dest_filename , ( long ) uid , ( long ) gid ) ; fclose ( fp ) ; unlink ( dest_filename ) ; return false ; } fclose ( fp ) ; return true ; }
| <FIXS> FILE * fp = fopen ( dest_filename , "wx" ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 <BUGS> static void predict_and_reconstruct_intra_block ( int plane , int block , BLOCK_SIZE plane_bsize , TX_SIZE tx_size , void * arg ) { struct intra_args * const args = ( struct intra_args * ) arg ; VP9_COMMON * const cm = args -> cm ; MACROBLOCKD * const xd = args -> xd ; <BUGE> struct macroblockd_plane * const pd = & xd -> plane [ plane ] ; <BUGS> MODE_INFO * const mi = xd -> mi [ 0 ] ; const MB_PREDICTION_MODE mode = ( plane == 0 ) ? get_y_mode ( mi , block ) : mi -> mbmi . uv_mode ; int x , y ; <BUGE> uint8_t * dst ; <BUGS> txfrm_block_to_raster_xy ( plane_bsize , tx_size , block , & x , & y ) ; dst = & pd -> dst . buf [ 4 * y * pd -> dst . stride + 4 * x ] ; vp9_predict_intra_block ( xd , block >> ( tx_size << 1 ) , b_width_log2 ( plane_bsize ) , tx_size , mode , <BUGE> dst , pd -> dst . stride , dst , pd -> dst . stride , <BUGS> x , y , plane ) ; if ( ! mi -> mbmi . skip ) { const int eob = vp9_decode_block_tokens ( cm , xd , plane , block , plane_bsize , x , y , tx_size , args -> r ) ; inverse_transform_block ( xd , plane , block , tx_size , dst , pd -> dst . stride , eob ) ; <BUGE> } }
| <FIXS> static void predict_and_reconstruct_intra_block ( MACROBLOCKD * const xd , vpx_reader * r , MB_MODE_INFO * const mbmi , int plane , int row , int col , TX_SIZE tx_size ) { <FIXE> <FIXS> PREDICTION_MODE mode = ( plane == 0 ) ? mbmi -> mode : mbmi -> uv_mode ; <FIXE> <FIXS> dst = & pd -> dst . buf [ 4 * row * pd -> dst . stride + 4 * col ] ; if ( mbmi -> sb_type < BLOCK_8X8 ) if ( plane == 0 ) mode = xd -> mi [ 0 ] -> bmi [ ( row << 1 ) + col ] . as_mode ; vp9_predict_intra_block ( xd , pd -> n4_wl , tx_size , mode , <FIXE> <FIXS> col , row , plane ) ; if ( ! mbmi -> skip ) { const TX_TYPE tx_type = ( plane || xd -> lossless ) ? DCT_DCT : intra_mode_to_tx_type_lookup [ mode ] ; const scan_order * sc = ( plane || xd -> lossless ) ? & vp9_default_scan_orders [ tx_size ] : & vp9_scan_orders [ tx_size ] [ tx_type ] ; const int eob = vp9_decode_block_tokens ( xd , plane , sc , col , row , tx_size , r , mbmi -> segment_id ) ; inverse_transform_block_intra ( xd , plane , tx_type , tx_size , dst , pd -> dst . stride , eob ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-476 static int forward_search_range ( regex_t * reg , const UChar * str , const UChar * end , UChar * s , UChar * range , UChar * * low , UChar * * high , UChar * * low_prev ) { UChar * p , * pprev = ( UChar * ) NULL ; # ifdef ONIG_DEBUG_SEARCH fprintf ( stderr , "forward_search_range: str: %d, end: %d, s: %d, range: %d\\n" , ( int ) str , ( int ) end , ( int ) s , ( int ) range ) ; # endif p = s ; if ( reg -> dmin > 0 ) { if ( ONIGENC_IS_SINGLEBYTE ( reg -> enc ) ) { p += reg -> dmin ; } else { UChar * q = p + reg -> dmin ; if ( q >= end ) return 0 ; while ( p < q ) p += enclen ( reg -> enc , p ) ; } } retry : switch ( reg -> optimize ) { case ONIG_OPTIMIZE_EXACT : p = slow_search ( reg -> enc , reg -> exact , reg -> exact_end , p , end , range ) ; break ; case ONIG_OPTIMIZE_EXACT_IC : p = slow_search_ic ( reg -> enc , reg -> case_fold_flag , reg -> exact , reg -> exact_end , p , end , range ) ; break ; case ONIG_OPTIMIZE_EXACT_BM : p = bm_search ( reg , reg -> exact , reg -> exact_end , p , end , range ) ; break ; case ONIG_OPTIMIZE_EXACT_BM_NOT_REV : p = bm_search_notrev ( reg , reg -> exact , reg -> exact_end , p , end , range ) ; break ; case ONIG_OPTIMIZE_MAP : p = map_search ( reg -> enc , reg -> map , p , range ) ; break ; } if ( p && p < range ) { if ( p - reg -> dmin < s ) { retry_gate : pprev = p ; p += enclen ( reg -> enc , p ) ; goto retry ; } if ( reg -> sub_anchor ) { UChar * prev ; switch ( reg -> sub_anchor ) { case ANCHOR_BEGIN_LINE : if ( ! ON_STR_BEGIN ( p ) ) { prev = onigenc_get_prev_char_head ( reg -> enc , ( pprev ? pprev : str ) , p ) ; if ( ! ONIGENC_IS_MBC_NEWLINE ( reg -> enc , prev , end ) ) goto retry_gate ; } break ; case ANCHOR_END_LINE : if ( ON_STR_END ( p ) ) { # ifndef USE_NEWLINE_AT_END_OF_STRING_HAS_EMPTY_LINE prev = ( UChar * ) onigenc_get_prev_char_head ( reg -> enc , ( pprev ? pprev : str ) , p ) ; if ( prev && ONIGENC_IS_MBC_NEWLINE ( reg -> enc , prev , end ) ) goto retry_gate ; # endif } else if ( ! ONIGENC_IS_MBC_NEWLINE ( reg -> enc , p , end ) # ifdef USE_CRNL_AS_LINE_TERMINATOR && ! ONIGENC_IS_MBC_CRNL ( reg -> enc , p , end ) # endif ) goto retry_gate ; break ; } } if ( reg -> dmax == 0 ) { * low = p ; if ( low_prev ) { if ( * low > s ) * low_prev = onigenc_get_prev_char_head ( reg -> enc , s , p ) ; else * low_prev = onigenc_get_prev_char_head ( reg -> enc , ( pprev ? pprev : str ) , p ) ; } } else { if ( reg -> dmax != ONIG_INFINITE_DISTANCE ) { <BUGS> <BUGE> * low = p - reg -> dmax ; if ( * low > s ) { * low = onigenc_get_right_adjust_char_head_with_prev ( reg -> enc , s , * low , ( const UChar * * ) low_prev ) ; if ( low_prev && IS_NULL ( * low_prev ) ) * low_prev = onigenc_get_prev_char_head ( reg -> enc , ( pprev ? pprev : s ) , * low ) ; } else { if ( low_prev ) * low_prev = onigenc_get_prev_char_head ( reg -> enc , ( pprev ? pprev : str ) , * low ) ; } } } <BUGS> <BUGE> * high = p - reg -> dmin ; # ifdef ONIG_DEBUG_SEARCH fprintf ( stderr , "forward_search_range success: low: %d, high: %d, dmin: %d, dmax: %d\\n" , ( int ) ( * low - str ) , ( int ) ( * high - str ) , reg -> dmin , reg -> dmax ) ; # endif return 1 ; } return 0 ; }
| <FIXS> if ( p - str < reg -> dmax ) { * low = ( UChar * ) str ; if ( low_prev ) * low_prev = onigenc_get_prev_char_head ( reg -> enc , str , * low ) ; } else { <FIXE> <FIXS> } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 void impeg2d_dec_hdr ( void * pv_dec , impeg2d_video_decode_ip_t * ps_ip , impeg2d_video_decode_op_t * ps_op ) { UWORD32 u4_bits_read ; dec_state_t * ps_dec ; ps_dec = ( dec_state_t * ) pv_dec ; ps_op -> s_ivd_video_decode_op_t . u4_error_code = 0 ; impeg2d_bit_stream_init ( & ( ps_dec -> s_bit_stream ) , ps_ip -> s_ivd_video_decode_ip_t . pv_stream_buffer , ps_ip -> s_ivd_video_decode_ip_t . u4_num_Bytes ) ; { { IMPEG2D_ERROR_CODES_T e_error ; e_error = impeg2d_process_video_header ( ps_dec ) ; if ( ( IMPEG2D_ERROR_CODES_T ) IVD_ERROR_NONE != e_error ) { ps_op -> s_ivd_video_decode_op_t . u4_error_code = e_error ; u4_bits_read = impeg2d_bit_stream_num_bits_read ( & ps_dec -> s_bit_stream ) ; ps_op -> s_ivd_video_decode_op_t . u4_num_bytes_consumed = u4_bits_read >> 3 ; if ( ps_op -> s_ivd_video_decode_op_t . u4_num_bytes_consumed > ps_ip -> s_ivd_video_decode_ip_t . u4_num_Bytes ) { ps_op -> s_ivd_video_decode_op_t . u4_num_bytes_consumed = ps_ip -> s_ivd_video_decode_ip_t . u4_num_Bytes ; } if ( ps_op -> s_ivd_video_decode_op_t . u4_error_code == 0 ) ps_op -> s_ivd_video_decode_op_t . u4_error_code = e_error ; <BUGS> <BUGE> impeg2d_next_code ( ps_dec , SEQUENCE_HEADER_CODE ) ; return ; } } ps_op -> s_ivd_video_decode_op_t . u4_pic_ht = ps_dec -> u2_vertical_size ; ps_op -> s_ivd_video_decode_op_t . u4_pic_wd = ps_dec -> u2_horizontal_size ; ps_op -> s_ivd_video_decode_op_t . e_pic_type = IV_NA_FRAME ; ps_op -> s_ivd_video_decode_op_t . u4_error_code = IV_SUCCESS ; u4_bits_read = impeg2d_bit_stream_num_bits_read ( & ps_dec -> s_bit_stream ) ; ps_op -> s_ivd_video_decode_op_t . u4_num_bytes_consumed = u4_bits_read >> 3 ; if ( ps_op -> s_ivd_video_decode_op_t . u4_num_bytes_consumed > ps_ip -> s_ivd_video_decode_ip_t . u4_num_Bytes ) { ps_op -> s_ivd_video_decode_op_t . u4_num_bytes_consumed = ps_ip -> s_ivd_video_decode_ip_t . u4_num_Bytes ; } ps_op -> s_ivd_video_decode_op_t . u4_frame_decoded_flag = 0 ; ps_dec -> u2_header_done = 1 ; } }
| <FIXS> if ( IMPEG2D_UNSUPPORTED_DIMENSIONS == e_error ) { ps_op -> s_ivd_video_decode_op_t . u4_num_bytes_consumed = 0 ; ps_dec -> u2_header_done = 0 ; ps_op -> s_ivd_video_decode_op_t . u4_pic_ht = ps_dec -> u2_reinit_max_height ; ps_op -> s_ivd_video_decode_op_t . u4_pic_wd = ps_dec -> u2_reinit_max_width ; } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static int filter_frame ( AVFilterLink * inlink , AVFrame * in ) { unsigned x , y ; AVFilterContext * ctx = inlink -> dst ; VignetteContext * s = ctx -> priv ; AVFilterLink * outlink = inlink -> dst -> outputs [ 0 ] ; AVFrame * out ; out = ff_get_video_buffer ( outlink , outlink -> w , outlink -> h ) ; if ( ! out ) { av_frame_free ( & in ) ; return AVERROR ( ENOMEM ) ; } av_frame_copy_props ( out , in ) ; if ( s -> eval_mode == EVAL_MODE_FRAME ) update_context ( s , inlink , in ) ; if ( s -> desc -> flags & AV_PIX_FMT_FLAG_RGB ) { uint8_t * dst = out -> data [ 0 ] ; const uint8_t * src = in -> data [ 0 ] ; const float * fmap = s -> fmap ; const int dst_linesize = out -> linesize [ 0 ] ; const int src_linesize = in -> linesize [ 0 ] ; const int fmap_linesize = s -> fmap_linesize ; for ( y = 0 ; y < inlink -> h ; y ++ ) { uint8_t * dstp = dst ; const uint8_t * srcp = src ; for ( x = 0 ; x < inlink -> w ; x ++ , dstp += 3 , srcp += 3 ) { const float f = fmap [ x ] ; dstp [ 0 ] = av_clip_uint8 ( srcp [ 0 ] * f + get_dither_value ( s ) ) ; dstp [ 1 ] = av_clip_uint8 ( srcp [ 1 ] * f + get_dither_value ( s ) ) ; dstp [ 2 ] = av_clip_uint8 ( srcp [ 2 ] * f + get_dither_value ( s ) ) ; } dst += dst_linesize ; src += src_linesize ; fmap += fmap_linesize ; } } else { int plane ; <BUGS> for ( plane = 0 ; plane < 4 && in -> data [ plane ] ; plane ++ ) { <BUGE> uint8_t * dst = out -> data [ plane ] ; const uint8_t * src = in -> data [ plane ] ; const float * fmap = s -> fmap ; const int dst_linesize = out -> linesize [ plane ] ; const int src_linesize = in -> linesize [ plane ] ; const int fmap_linesize = s -> fmap_linesize ; const int chroma = plane == 1 || plane == 2 ; const int hsub = chroma ? s -> desc -> log2_chroma_w : 0 ; const int vsub = chroma ? s -> desc -> log2_chroma_h : 0 ; const int w = FF_CEIL_RSHIFT ( inlink -> w , hsub ) ; const int h = FF_CEIL_RSHIFT ( inlink -> h , vsub ) ; for ( y = 0 ; y < h ; y ++ ) { uint8_t * dstp = dst ; const uint8_t * srcp = src ; for ( x = 0 ; x < w ; x ++ ) { const double dv = get_dither_value ( s ) ; if ( chroma ) * dstp ++ = av_clip_uint8 ( fmap [ x << hsub ] * ( * srcp ++ - 127 ) + 127 + dv ) ; else * dstp ++ = av_clip_uint8 ( fmap [ x ] * * srcp ++ + dv ) ; } dst += dst_linesize ; src += src_linesize ; fmap += fmap_linesize << vsub ; } } } return ff_filter_frame ( outlink , out ) ; }
| <FIXS> for ( plane = 0 ; plane < 4 && in -> data [ plane ] && in -> linesize [ plane ] ; plane ++ ) { <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-362 void __kvm_migrate_pit_timer ( struct kvm_vcpu * vcpu ) { struct kvm_pit * pit = vcpu -> kvm -> arch . vpit ; struct hrtimer * timer ; if ( ! kvm_vcpu_is_bsp ( vcpu ) || ! pit ) return ; timer = & pit -> pit_state . timer ; <BUGS> <BUGE> if ( hrtimer_cancel ( timer ) ) hrtimer_start_expires ( timer , HRTIMER_MODE_ABS ) ; <BUGS> <BUGE> }
| <FIXS> mutex_lock ( & pit -> pit_state . lock ) ; <FIXE> <FIXS> mutex_unlock ( & pit -> pit_state . lock ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-000 static int em_loop ( struct x86_emulate_ctxt * ctxt ) { <BUGS> <BUGE> register_address_increment ( ctxt , reg_rmw ( ctxt , VCPU_REGS_RCX ) , - 1 ) ; if ( ( address_mask ( ctxt , reg_read ( ctxt , VCPU_REGS_RCX ) ) != 0 ) && ( ctxt -> b == 0xe2 || test_cc ( ctxt -> b ^ 0x5 , ctxt -> eflags ) ) ) <BUGS> jmp_rel ( ctxt , ctxt -> src . val ) ; return X86EMUL_CONTINUE ; <BUGE> }
| <FIXS> int rc = X86EMUL_CONTINUE ; <FIXE> <FIXS> rc = jmp_rel ( ctxt , ctxt -> src . val ) ; return rc ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static ssize_t k90_show_macro_mode ( struct device * dev , struct device_attribute * attr , char * buf ) { int ret ; struct usb_interface * usbif = to_usb_interface ( dev -> parent ) ; struct usb_device * usbdev = interface_to_usbdev ( usbif ) ; const char * macro_mode ; <BUGS> char data [ 8 ] ; <BUGE> ret = usb_control_msg ( usbdev , usb_rcvctrlpipe ( usbdev , 0 ) , K90_REQUEST_GET_MODE , USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE , 0 , 0 , data , 2 , USB_CTRL_SET_TIMEOUT ) ; if ( ret < 0 ) { dev_warn ( dev , "Failed to get K90 initial mode (error %d).\\n" , ret ) ; <BUGS> return - EIO ; <BUGE> } switch ( data [ 0 ] ) { case K90_MACRO_MODE_HW : macro_mode = "HW" ; break ; case K90_MACRO_MODE_SW : macro_mode = "SW" ; break ; default : dev_warn ( dev , "K90 in unknown mode: %02hhx.\\n" , data [ 0 ] ) ; <BUGS> return - EIO ; <BUGE> } <BUGS> return snprintf ( buf , PAGE_SIZE , "%s\\n" , macro_mode ) ; <BUGE> }
| <FIXS> char * data ; data = kmalloc ( 2 , GFP_KERNEL ) ; if ( ! data ) return - ENOMEM ; <FIXE> <FIXS> ret = - EIO ; goto out ; <FIXE> <FIXS> ret = - EIO ; goto out ; <FIXE> <FIXS> ret = snprintf ( buf , PAGE_SIZE , "%s\\n" , macro_mode ) ; out : kfree ( data ) ; return ret ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-787 static void add_password ( AUTH_HDR * request , unsigned char type , CONST char * password , char * secret ) { MD5_CTX md5_secret , my_md5 ; unsigned char misc [ AUTH_VECTOR_LEN ] ; int i ; int length = strlen ( password ) ; unsigned char hashed [ 256 + AUTH_PASS_LEN ] ; unsigned char * vector ; attribute_t * attr ; if ( length > MAXPASS ) { length = MAXPASS ; } if ( length == 0 ) { length = AUTH_PASS_LEN ; } if ( ( length & ( AUTH_PASS_LEN - 1 ) ) != 0 ) { length += ( AUTH_PASS_LEN - 1 ) ; length &= ~ ( AUTH_PASS_LEN - 1 ) ; } memset ( hashed , 0 , length ) ; <BUGS> memcpy ( hashed , password , strlen ( password ) ) ; <BUGE> attr = find_attribute ( request , PW_PASSWORD ) ; if ( type == PW_PASSWORD ) { vector = request -> vector ; } else { vector = attr -> data ; } MD5Init ( & md5_secret ) ; MD5Update ( & md5_secret , ( unsigned char * ) secret , strlen ( secret ) ) ; my_md5 = md5_secret ; MD5Update ( & my_md5 , vector , AUTH_VECTOR_LEN ) ; MD5Final ( misc , & my_md5 ) ; xor ( hashed , misc , AUTH_PASS_LEN ) ; for ( i = 1 ; i < ( length >> 4 ) ; i ++ ) { my_md5 = md5_secret ; MD5Update ( & my_md5 , & hashed [ ( i - 1 ) * AUTH_PASS_LEN ] , AUTH_PASS_LEN ) ; MD5Final ( misc , & my_md5 ) ; xor ( & hashed [ i * AUTH_PASS_LEN ] , misc , AUTH_PASS_LEN ) ; } if ( type == PW_OLD_PASSWORD ) { attr = find_attribute ( request , PW_OLD_PASSWORD ) ; } if ( ! attr ) { add_attribute ( request , type , hashed , length ) ; } else { memcpy ( attr -> data , hashed , length ) ; } }
| <FIXS> memcpy ( hashed , password , length ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 <BUGS> static int m88rs2000_frontend_attach ( struct dvb_usb_adapter * d ) <BUGE> { <BUGS> u8 obuf [ ] = { 0x51 } ; u8 ibuf [ ] = { 0 } ; if ( dvb_usb_generic_rw ( d -> dev , obuf , 1 , ibuf , 1 , 0 ) < 0 ) <BUGE> err ( "command 0x51 transfer failed." ) ; <BUGS> d -> fe_adap [ 0 ] . fe = dvb_attach ( m88rs2000_attach , & s421_m88rs2000_config , & d -> dev -> i2c_adap ) ; if ( d -> fe_adap [ 0 ] . fe == NULL ) <BUGE> return - EIO ; <BUGS> if ( dvb_attach ( ts2020_attach , d -> fe_adap [ 0 ] . fe , <BUGE> & dw2104_ts2020_config , <BUGS> & d -> dev -> i2c_adap ) ) { <BUGE> info ( "Attached RS2000/TS2020!" ) ; return 0 ; } info ( "Failed to attach RS2000/TS2020!" ) ; return - EIO ; }
| <FIXS> static int m88rs2000_frontend_attach ( struct dvb_usb_adapter * adap ) <FIXE> <FIXS> struct dvb_usb_device * d = adap -> dev ; struct dw2102_state * state = d -> priv ; mutex_lock ( & d -> data_mutex ) ; state -> data [ 0 ] = 0x51 ; if ( dvb_usb_generic_rw ( d , state -> data , 1 , state -> data , 1 , 0 ) < 0 ) <FIXE> <FIXS> mutex_unlock ( & d -> data_mutex ) ; adap -> fe_adap [ 0 ] . fe = dvb_attach ( m88rs2000_attach , & s421_m88rs2000_config , & d -> i2c_adap ) ; if ( adap -> fe_adap [ 0 ] . fe == NULL ) <FIXE> <FIXS> if ( dvb_attach ( ts2020_attach , adap -> fe_adap [ 0 ] . fe , <FIXE> <FIXS> & d -> i2c_adap ) ) { <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-362 void sctp_generate_heartbeat_event ( unsigned long data ) { int error = 0 ; struct sctp_transport * transport = ( struct sctp_transport * ) data ; struct sctp_association * asoc = transport -> asoc ; <BUGS> struct net * net = sock_net ( asoc -> base . sk ) ; bh_lock_sock ( asoc -> base . sk ) ; if ( sock_owned_by_user ( asoc -> base . sk ) ) { <BUGE> pr_debug ( "%s: sock is busy\\n" , __func__ ) ; if ( ! mod_timer ( & transport -> hb_timer , jiffies + ( HZ / 20 ) ) ) sctp_transport_hold ( transport ) ; goto out_unlock ; } if ( transport -> dead ) goto out_unlock ; error = sctp_do_sm ( net , SCTP_EVENT_T_TIMEOUT , SCTP_ST_TIMEOUT ( SCTP_EVENT_TIMEOUT_HEARTBEAT ) , asoc -> state , asoc -> ep , asoc , transport , GFP_ATOMIC ) ; if ( error ) <BUGS> asoc -> base . sk -> sk_err = - error ; <BUGE> out_unlock : <BUGS> bh_unlock_sock ( asoc -> base . sk ) ; <BUGE> sctp_transport_put ( transport ) ; }
| <FIXS> struct sock * sk = asoc -> base . sk ; struct net * net = sock_net ( sk ) ; bh_lock_sock ( sk ) ; if ( sock_owned_by_user ( sk ) ) { <FIXE> <FIXS> sk -> sk_err = - error ; <FIXE> <FIXS> bh_unlock_sock ( sk ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-189 TSQuery QTN2QT ( QTNode * in ) { TSQuery out ; int len ; int sumlen = 0 , nnode = 0 ; QTN2QTState state ; cntsize ( in , & sumlen , & nnode ) ; <BUGS> <BUGE> len = COMPUTESIZE ( nnode , sumlen ) ; out = ( TSQuery ) palloc0 ( len ) ; SET_VARSIZE ( out , len ) ; out -> size = nnode ; state . curitem = GETQUERY ( out ) ; state . operand = state . curoperand = GETOPERAND ( out ) ; fillQT ( & state , in ) ; return out ; }
| <FIXS> if ( TSQUERY_TOO_BIG ( nnode , sumlen ) ) ereport ( ERROR , ( errcode ( ERRCODE_PROGRAM_LIMIT_EXCEEDED ) , errmsg ( "tsquery is too large" ) ) ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static void set_roi_map ( const vpx_codec_enc_cfg_t * cfg , vpx_codec_ctx_t * codec ) { unsigned int i ; <BUGS> vpx_roi_map_t roi = { 0 } ; <BUGE> roi . rows = ( cfg -> g_h + 15 ) / 16 ; roi . cols = ( cfg -> g_w + 15 ) / 16 ; roi . delta_q [ 0 ] = 0 ; roi . delta_q [ 1 ] = - 2 ; roi . delta_q [ 2 ] = - 4 ; roi . delta_q [ 3 ] = - 6 ; roi . delta_lf [ 0 ] = 0 ; roi . delta_lf [ 1 ] = 1 ; roi . delta_lf [ 2 ] = 2 ; roi . delta_lf [ 3 ] = 3 ; roi . static_threshold [ 0 ] = 1500 ; roi . static_threshold [ 1 ] = 1000 ; roi . static_threshold [ 2 ] = 500 ; roi . static_threshold [ 3 ] = 0 ; roi . roi_map = ( uint8_t * ) malloc ( roi . rows * roi . cols ) ; for ( i = 0 ; i < roi . rows * roi . cols ; ++ i ) roi . roi_map [ i ] = i % 4 ; if ( vpx_codec_control ( codec , VP8E_SET_ROI_MAP , & roi ) ) die_codec ( codec , "Failed to set ROI map" ) ; free ( roi . roi_map ) ; }
| <FIXS> vpx_roi_map_t roi ; memset ( & roi , 0 , sizeof ( roi ) ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static int jpeg2000_decode_tile ( Jpeg2000DecoderContext * s , Jpeg2000Tile * tile , AVFrame * picture ) { int compno , reslevelno , bandno ; int x , y ; uint8_t * line ; Jpeg2000T1Context t1 ; for ( compno = 0 ; compno < s -> ncomponents ; compno ++ ) { Jpeg2000Component * comp = tile -> comp + compno ; Jpeg2000CodingStyle * codsty = tile -> codsty + compno ; for ( reslevelno = 0 ; reslevelno < codsty -> nreslevels2decode ; reslevelno ++ ) { Jpeg2000ResLevel * rlevel = comp -> reslevel + reslevelno ; for ( bandno = 0 ; bandno < rlevel -> nbands ; bandno ++ ) { int nb_precincts , precno ; Jpeg2000Band * band = rlevel -> band + bandno ; int cblkno = 0 , bandpos ; bandpos = bandno + ( reslevelno > 0 ) ; if ( band -> coord [ 0 ] [ 0 ] == band -> coord [ 0 ] [ 1 ] || band -> coord [ 1 ] [ 0 ] == band -> coord [ 1 ] [ 1 ] ) continue ; nb_precincts = rlevel -> num_precincts_x * rlevel -> num_precincts_y ; for ( precno = 0 ; precno < nb_precincts ; precno ++ ) { Jpeg2000Prec * prec = band -> prec + precno ; for ( cblkno = 0 ; cblkno < prec -> nb_codeblocks_width * prec -> nb_codeblocks_height ; cblkno ++ ) { int x , y ; Jpeg2000Cblk * cblk = prec -> cblk + cblkno ; decode_cblk ( s , codsty , & t1 , cblk , cblk -> coord [ 0 ] [ 1 ] - cblk -> coord [ 0 ] [ 0 ] , cblk -> coord [ 1 ] [ 1 ] - cblk -> coord [ 1 ] [ 0 ] , bandpos ) ; x = cblk -> coord [ 0 ] [ 0 ] ; y = cblk -> coord [ 1 ] [ 0 ] ; if ( codsty -> transform == FF_DWT97 ) dequantization_float ( x , y , cblk , comp , & t1 , band ) ; else dequantization_int ( x , y , cblk , comp , & t1 , band ) ; } } } } ff_dwt_decode ( & comp -> dwt , codsty -> transform == FF_DWT97 ? ( void * ) comp -> f_data : ( void * ) comp -> i_data ) ; } if ( tile -> codsty [ 0 ] . mct ) mct_decode ( s , tile ) ; if ( s -> cdef [ 0 ] < 0 ) { for ( x = 0 ; x < s -> ncomponents ; x ++ ) s -> cdef [ x ] = x + 1 ; if ( ( s -> ncomponents & 1 ) == 0 ) s -> cdef [ s -> ncomponents - 1 ] = 0 ; } if ( s -> precision <= 8 ) { for ( compno = 0 ; compno < s -> ncomponents ; compno ++ ) { Jpeg2000Component * comp = tile -> comp + compno ; Jpeg2000CodingStyle * codsty = tile -> codsty + compno ; float * datap = comp -> f_data ; int32_t * i_datap = comp -> i_data ; int cbps = s -> cbps [ compno ] ; int w = tile -> comp [ compno ] . coord [ 0 ] [ 1 ] - s -> image_offset_x ; int planar = ! ! picture -> data [ 2 ] ; int pixelsize = planar ? 1 : s -> ncomponents ; int plane = 0 ; if ( planar ) plane = s -> cdef [ compno ] ? s -> cdef [ compno ] - 1 : ( s -> ncomponents - 1 ) ; y = tile -> comp [ compno ] . coord [ 1 ] [ 0 ] - s -> image_offset_y ; <BUGS> line = picture -> data [ plane ] + y * picture -> linesize [ plane ] ; <BUGE> for ( ; y < tile -> comp [ compno ] . coord [ 1 ] [ 1 ] - s -> image_offset_y ; y += s -> cdy [ compno ] ) { uint8_t * dst ; x = tile -> comp [ compno ] . coord [ 0 ] [ 0 ] - s -> image_offset_x ; <BUGS> dst = line + x * pixelsize + compno * ! planar ; <BUGE> if ( codsty -> transform == FF_DWT97 ) { for ( ; x < w ; x += s -> cdx [ compno ] ) { int val = lrintf ( * datap ) + ( 1 << ( cbps - 1 ) ) ; val = av_clip ( val , 0 , ( 1 << cbps ) - 1 ) ; * dst = val << ( 8 - cbps ) ; datap ++ ; dst += pixelsize ; } } else { for ( ; x < w ; x += s -> cdx [ compno ] ) { int val = * i_datap + ( 1 << ( cbps - 1 ) ) ; val = av_clip ( val , 0 , ( 1 << cbps ) - 1 ) ; * dst = val << ( 8 - cbps ) ; i_datap ++ ; dst += pixelsize ; } } line += picture -> linesize [ plane ] ; } } } else { for ( compno = 0 ; compno < s -> ncomponents ; compno ++ ) { Jpeg2000Component * comp = tile -> comp + compno ; Jpeg2000CodingStyle * codsty = tile -> codsty + compno ; float * datap = comp -> f_data ; int32_t * i_datap = comp -> i_data ; uint16_t * linel ; int cbps = s -> cbps [ compno ] ; int w = tile -> comp [ compno ] . coord [ 0 ] [ 1 ] - s -> image_offset_x ; int planar = ! ! picture -> data [ 2 ] ; int pixelsize = planar ? 1 : s -> ncomponents ; int plane = 0 ; if ( planar ) plane = s -> cdef [ compno ] ? s -> cdef [ compno ] - 1 : ( s -> ncomponents - 1 ) ; y = tile -> comp [ compno ] . coord [ 1 ] [ 0 ] - s -> image_offset_y ; <BUGS> linel = ( uint16_t * ) picture -> data [ plane ] + y * ( picture -> linesize [ plane ] >> 1 ) ; <BUGE> for ( ; y < tile -> comp [ compno ] . coord [ 1 ] [ 1 ] - s -> image_offset_y ; y += s -> cdy [ compno ] ) { uint16_t * dst ; x = tile -> comp [ compno ] . coord [ 0 ] [ 0 ] - s -> image_offset_x ; <BUGS> dst = linel + ( x * pixelsize + compno * ! planar ) ; <BUGE> if ( codsty -> transform == FF_DWT97 ) { for ( ; x < w ; x += s -> cdx [ compno ] ) { int val = lrintf ( * datap ) + ( 1 << ( cbps - 1 ) ) ; val = av_clip ( val , 0 , ( 1 << cbps ) - 1 ) ; * dst = val << ( 16 - cbps ) ; datap ++ ; dst += pixelsize ; } } else { for ( ; x < w ; x += s -> cdx [ compno ] ) { int val = * i_datap + ( 1 << ( cbps - 1 ) ) ; val = av_clip ( val , 0 , ( 1 << cbps ) - 1 ) ; * dst = val << ( 16 - cbps ) ; i_datap ++ ; dst += pixelsize ; } } linel += picture -> linesize [ plane ] >> 1 ; } } } return 0 ; }
| <FIXS> line = picture -> data [ plane ] + y / s -> cdy [ compno ] * picture -> linesize [ plane ] ; <FIXE> <FIXS> dst = line + x / s -> cdx [ compno ] * pixelsize + compno * ! planar ; <FIXE> <FIXS> linel = ( uint16_t * ) picture -> data [ plane ] + y / s -> cdy [ compno ] * ( picture -> linesize [ plane ] >> 1 ) ; <FIXE> <FIXS> dst = linel + ( x / s -> cdx [ compno ] * pixelsize + compno * ! planar ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-189 <BUGS> void oz_hcd_get_desc_cnf ( void * hport , u8 req_id , int status , const u8 * desc , int length , int offset , int total_size ) <BUGE> { struct oz_port * port = hport ; struct urb * urb ; int err = 0 ; oz_dbg ( ON , "oz_hcd_get_desc_cnf length = %d offs = %d tot_size = %d\\n" , length , offset , total_size ) ; urb = oz_find_urb_by_id ( port , 0 , req_id ) ; if ( ! urb ) return ; if ( status == 0 ) { <BUGS> int copy_len ; int required_size = urb -> transfer_buffer_length ; <BUGE> if ( required_size > total_size ) required_size = total_size ; copy_len = required_size - offset ; if ( length <= copy_len ) copy_len = length ; memcpy ( urb -> transfer_buffer + offset , desc , copy_len ) ; offset += copy_len ; if ( offset < required_size ) { struct usb_ctrlrequest * setup = ( struct usb_ctrlrequest * ) urb -> setup_packet ; unsigned wvalue = le16_to_cpu ( setup -> wValue ) ; if ( oz_enqueue_ep_urb ( port , 0 , 0 , urb , req_id ) ) err = - ENOMEM ; else if ( oz_usb_get_desc_req ( port -> hpd , req_id , setup -> bRequestType , ( u8 ) ( wvalue >> 8 ) , ( u8 ) wvalue , setup -> wIndex , offset , required_size - offset ) ) { oz_dequeue_ep_urb ( port , 0 , 0 , urb ) ; err = - ENOMEM ; } if ( err == 0 ) return ; } } urb -> actual_length = total_size ; oz_complete_urb ( port -> ozhcd -> hcd , urb , 0 ) ; }
| <FIXS> void oz_hcd_get_desc_cnf ( void * hport , u8 req_id , u8 status , const u8 * desc , u8 length , u16 offset , u16 total_size ) <FIXE> <FIXS> unsigned int copy_len ; unsigned int required_size = urb -> transfer_buffer_length ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-200 inline int web_client_api_request_v1_data ( RRDHOST * host , struct web_client * w , char * url ) { debug ( D_WEB_CLIENT , "%llu: API v1 data with URL \'%s\'" , w -> id , url ) ; int ret = 400 ; BUFFER * dimensions = NULL ; buffer_flush ( w -> response . data ) ; char * google_version = "0.6" , * google_reqId = "0" , * google_sig = "0" , * google_out = "json" , * responseHandler = NULL , * outFileName = NULL ; time_t last_timestamp_in_data = 0 , google_timestamp = 0 ; char * chart = NULL , * before_str = NULL , * after_str = NULL , * group_time_str = NULL , * points_str = NULL ; int group = RRDR_GROUPING_AVERAGE ; uint32_t format = DATASOURCE_JSON ; uint32_t options = 0x00000000 ; while ( url ) { char * value = mystrsep ( & url , "?&" ) ; if ( ! value || ! * value ) continue ; char * name = mystrsep ( & value , "=" ) ; if ( ! name || ! * name ) continue ; if ( ! value || ! * value ) continue ; debug ( D_WEB_CLIENT , "%llu: API v1 data query param \'%s\' with value \'%s\'" , w -> id , name , value ) ; if ( ! strcmp ( name , "chart" ) ) chart = value ; else if ( ! strcmp ( name , "dimension" ) || ! strcmp ( name , "dim" ) || ! strcmp ( name , "dimensions" ) || ! strcmp ( name , "dims" ) ) { if ( ! dimensions ) dimensions = buffer_create ( 100 ) ; buffer_strcat ( dimensions , "|" ) ; buffer_strcat ( dimensions , value ) ; } else if ( ! strcmp ( name , "after" ) ) after_str = value ; else if ( ! strcmp ( name , "before" ) ) before_str = value ; else if ( ! strcmp ( name , "points" ) ) points_str = value ; else if ( ! strcmp ( name , "gtime" ) ) group_time_str = value ; else if ( ! strcmp ( name , "group" ) ) { group = web_client_api_request_v1_data_group ( value , RRDR_GROUPING_AVERAGE ) ; } else if ( ! strcmp ( name , "format" ) ) { format = web_client_api_request_v1_data_format ( value ) ; } else if ( ! strcmp ( name , "options" ) ) { options |= web_client_api_request_v1_data_options ( value ) ; } else if ( ! strcmp ( name , "callback" ) ) { responseHandler = value ; } else if ( ! strcmp ( name , "filename" ) ) { outFileName = value ; } else if ( ! strcmp ( name , "tqx" ) ) { char * tqx_name , * tqx_value ; while ( value ) { tqx_value = mystrsep ( & value , ";" ) ; if ( ! tqx_value || ! * tqx_value ) continue ; tqx_name = mystrsep ( & tqx_value , ":" ) ; if ( ! tqx_name || ! * tqx_name ) continue ; if ( ! tqx_value || ! * tqx_value ) continue ; if ( ! strcmp ( tqx_name , "version" ) ) google_version = tqx_value ; else if ( ! strcmp ( tqx_name , "reqId" ) ) google_reqId = tqx_value ; else if ( ! strcmp ( tqx_name , "sig" ) ) { google_sig = tqx_value ; google_timestamp = strtoul ( google_sig , NULL , 0 ) ; } else if ( ! strcmp ( tqx_name , "out" ) ) { google_out = tqx_value ; format = web_client_api_request_v1_data_google_format ( google_out ) ; } else if ( ! strcmp ( tqx_name , "responseHandler" ) ) responseHandler = tqx_value ; else if ( ! strcmp ( tqx_name , "outFileName" ) ) outFileName = tqx_value ; } } } <BUGS> <BUGE> if ( ! chart || ! * chart ) { buffer_sprintf ( w -> response . data , "No chart id is given at the request." ) ; goto cleanup ; } RRDSET * st = rrdset_find ( host , chart ) ; if ( ! st ) st = rrdset_find_byname ( host , chart ) ; if ( ! st ) { buffer_strcat ( w -> response . data , "Chart is not found: " ) ; buffer_strcat_htmlescape ( w -> response . data , chart ) ; ret = 404 ; goto cleanup ; } st -> last_accessed_time = now_realtime_sec ( ) ; long long before = ( before_str && * before_str ) ? str2l ( before_str ) : 0 ; long long after = ( after_str && * after_str ) ? str2l ( after_str ) : 0 ; int points = ( points_str && * points_str ) ? str2i ( points_str ) : 0 ; long group_time = ( group_time_str && * group_time_str ) ? str2l ( group_time_str ) : 0 ; debug ( D_WEB_CLIENT , "%llu: API command \'data\' for chart \'%s\', dimensions \'%s\', after \'%lld\', before \'%lld\', points \'%d\', group \'%d\', format \'%u\', options \'0x%08x\'" , w -> id , chart , ( dimensions ) ? buffer_tostring ( dimensions ) : "" , after , before , points , group , format , options ) ; if ( outFileName && * outFileName ) { buffer_sprintf ( w -> response . header , "Content-Disposition: attachment; filename=\\"%s\\"\\r\\n" , outFileName ) ; debug ( D_WEB_CLIENT , "%llu: generating outfilename header: \'%s\'" , w -> id , outFileName ) ; } if ( format == DATASOURCE_DATATABLE_JSONP ) { if ( responseHandler == NULL ) responseHandler = "google.visualization.Query.setResponse" ; debug ( D_WEB_CLIENT_ACCESS , "%llu: GOOGLE JSON/JSONP: version = \'%s\', reqId = \'%s\', sig = \'%s\', out = \'%s\', responseHandler = \'%s\', outFileName = \'%s\'" , w -> id , google_version , google_reqId , google_sig , google_out , responseHandler , outFileName ) ; buffer_sprintf ( w -> response . data , "%s({version:\'%s\',reqId:\'%s\',status:\'ok\',sig:\'%ld\',table:" , responseHandler , google_version , google_reqId , st -> last_updated . tv_sec ) ; } else if ( format == DATASOURCE_JSONP ) { if ( responseHandler == NULL ) responseHandler = "callback" ; buffer_strcat ( w -> response . data , responseHandler ) ; buffer_strcat ( w -> response . data , "(" ) ; } ret = rrdset2anything_api_v1 ( st , w -> response . data , dimensions , format , points , after , before , group , group_time , options , & last_timestamp_in_data ) ; if ( format == DATASOURCE_DATATABLE_JSONP ) { if ( google_timestamp < last_timestamp_in_data ) buffer_strcat ( w -> response . data , "});" ) ; else { buffer_flush ( w -> response . data ) ; buffer_sprintf ( w -> response . data , "%s({version:\'%s\',reqId:\'%s\',status:\'error\',errors:[{reason:\'not_modified\',message:\'Data not modified\'}]});" , responseHandler , google_version , google_reqId ) ; } } else if ( format == DATASOURCE_JSONP ) buffer_strcat ( w -> response . data , ");" ) ; cleanup : buffer_free ( dimensions ) ; return ret ; }
| <FIXS> fix_google_param ( google_out ) ; fix_google_param ( google_sig ) ; fix_google_param ( google_reqId ) ; fix_google_param ( google_version ) ; fix_google_param ( responseHandler ) ; fix_google_param ( outFileName ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-125 int TS_OBJ_print_bio ( BIO * bio , const ASN1_OBJECT * obj ) { char obj_txt [ 128 ] ; <BUGS> int len = OBJ_obj2txt ( obj_txt , sizeof ( obj_txt ) , obj , 0 ) ; BIO_write ( bio , obj_txt , len ) ; BIO_write ( bio , "\\n" , 1 ) ; <BUGE> return 1 ; }
| <FIXS> OBJ_obj2txt ( obj_txt , sizeof ( obj_txt ) , obj , 0 ) ; BIO_printf ( bio , "%s\\n" , obj_txt ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 <BUGS> static void <BUGE> horAcc8 ( TIFF * tif , uint8 * cp0 , tmsize_t cc ) { tmsize_t stride = PredictorState ( tif ) -> stride ; unsigned char * cp = ( unsigned char * ) cp0 ; <BUGS> assert ( ( cc % stride ) == 0 ) ; <BUGE> if ( cc > stride ) { if ( stride == 3 ) { unsigned int cr = cp [ 0 ] ; unsigned int cg = cp [ 1 ] ; unsigned int cb = cp [ 2 ] ; cc -= 3 ; cp += 3 ; while ( cc > 0 ) { cp [ 0 ] = ( unsigned char ) ( ( cr += cp [ 0 ] ) & 0xff ) ; cp [ 1 ] = ( unsigned char ) ( ( cg += cp [ 1 ] ) & 0xff ) ; cp [ 2 ] = ( unsigned char ) ( ( cb += cp [ 2 ] ) & 0xff ) ; cc -= 3 ; cp += 3 ; } } else if ( stride == 4 ) { unsigned int cr = cp [ 0 ] ; unsigned int cg = cp [ 1 ] ; unsigned int cb = cp [ 2 ] ; unsigned int ca = cp [ 3 ] ; cc -= 4 ; cp += 4 ; while ( cc > 0 ) { cp [ 0 ] = ( unsigned char ) ( ( cr += cp [ 0 ] ) & 0xff ) ; cp [ 1 ] = ( unsigned char ) ( ( cg += cp [ 1 ] ) & 0xff ) ; cp [ 2 ] = ( unsigned char ) ( ( cb += cp [ 2 ] ) & 0xff ) ; cp [ 3 ] = ( unsigned char ) ( ( ca += cp [ 3 ] ) & 0xff ) ; cc -= 4 ; cp += 4 ; } } else { cc -= stride ; do { REPEAT4 ( stride , cp [ stride ] = ( unsigned char ) ( ( cp [ stride ] + * cp ) & 0xff ) ; cp ++ ) cc -= stride ; } while ( cc > 0 ) ; } } <BUGS> <BUGE> }
| <FIXS> static int <FIXE> <FIXS> if ( ( cc % stride ) != 0 ) { TIFFErrorExt ( tif -> tif_clientdata , "horAcc8" , "%s" , "(cc%stride)!=0" ) ; return 0 ; } <FIXE> <FIXS> return 1 ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-772 static int hwsim_new_radio_nl ( struct sk_buff * msg , struct genl_info * info ) { struct hwsim_new_radio_params param = { 0 } ; const char * hwname = NULL ; int ret ; param . reg_strict = info -> attrs [ HWSIM_ATTR_REG_STRICT_REG ] ; param . p2p_device = info -> attrs [ HWSIM_ATTR_SUPPORT_P2P_DEVICE ] ; param . channels = channels ; param . destroy_on_close = info -> attrs [ HWSIM_ATTR_DESTROY_RADIO_ON_CLOSE ] ; if ( info -> attrs [ HWSIM_ATTR_CHANNELS ] ) param . channels = nla_get_u32 ( info -> attrs [ HWSIM_ATTR_CHANNELS ] ) ; if ( info -> attrs [ HWSIM_ATTR_NO_VIF ] ) param . no_vif = true ; if ( info -> attrs [ HWSIM_ATTR_RADIO_NAME ] ) { hwname = kasprintf ( GFP_KERNEL , "%.*s" , nla_len ( info -> attrs [ HWSIM_ATTR_RADIO_NAME ] ) , ( char * ) nla_data ( info -> attrs [ HWSIM_ATTR_RADIO_NAME ] ) ) ; if ( ! hwname ) return - ENOMEM ; param . hwname = hwname ; } if ( info -> attrs [ HWSIM_ATTR_USE_CHANCTX ] ) param . use_chanctx = true ; else param . use_chanctx = ( param . channels > 1 ) ; if ( info -> attrs [ HWSIM_ATTR_REG_HINT_ALPHA2 ] ) param . reg_alpha2 = nla_data ( info -> attrs [ HWSIM_ATTR_REG_HINT_ALPHA2 ] ) ; if ( info -> attrs [ HWSIM_ATTR_REG_CUSTOM_REG ] ) { u32 idx = nla_get_u32 ( info -> attrs [ HWSIM_ATTR_REG_CUSTOM_REG ] ) ; <BUGS> if ( idx >= ARRAY_SIZE ( hwsim_world_regdom_custom ) ) <BUGE> return - EINVAL ; <BUGS> <BUGE> param . regd = hwsim_world_regdom_custom [ idx ] ; } ret = mac80211_hwsim_new_radio ( info , & param ) ; kfree ( hwname ) ; return ret ; }
| <FIXS> if ( idx >= ARRAY_SIZE ( hwsim_world_regdom_custom ) ) { kfree ( hwname ) ; <FIXE> <FIXS> } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static int candidate_refresh_aq ( const CYCLIC_REFRESH * cr , const MB_MODE_INFO * mbmi , <BUGS> BLOCK_SIZE bsize , int use_rd ) { if ( use_rd ) { if ( cr -> projected_rate_sb < cr -> thresh_rate_sb ) return 1 ; else if ( bsize < cr -> min_block_size || ( mbmi -> mv [ 0 ] . as_int != 0 && cr -> projected_dist_sb > cr -> thresh_dist_sb ) || ! is_inter_block ( mbmi ) ) return 0 ; <BUGE> else <BUGS> return 1 ; } else { if ( bsize < cr -> min_block_size || mbmi -> mv [ 0 ] . as_int != 0 || ! is_inter_block ( mbmi ) ) return 0 ; else return 1 ; } <BUGE> }
| <FIXS> int64_t rate , int64_t dist , int bsize ) { MV mv = mbmi -> mv [ 0 ] . as_mv ; if ( dist > cr -> thresh_dist_sb && ( mv . row > cr -> motion_thresh || mv . row < - cr -> motion_thresh || mv . col > cr -> motion_thresh || mv . col < - cr -> motion_thresh || ! is_inter_block ( mbmi ) ) ) return CR_SEGMENT_ID_BASE ; else if ( bsize >= BLOCK_16X16 && rate < cr -> thresh_rate_sb && is_inter_block ( mbmi ) && mbmi -> mv [ 0 ] . as_int == 0 && cr -> rate_boost_fac > 10 ) return CR_SEGMENT_ID_BOOST2 ; <FIXE> <FIXS> return CR_SEGMENT_ID_BOOST1 ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-125 <BUGS> int ntlm_read_message_fields ( wStream * s , NTLM_MESSAGE_FIELDS * fields ) <BUGE> { if ( Stream_GetRemainingLength ( s ) < 8 ) return - 1 ; Stream_Read_UINT16 ( s , fields -> Len ) ; Stream_Read_UINT16 ( s , fields -> MaxLen ) ; Stream_Read_UINT32 ( s , fields -> BufferOffset ) ; return 1 ; }
| <FIXS> static int ntlm_read_message_fields ( wStream * s , NTLM_MESSAGE_FIELDS * fields ) <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-189 int midi_synth_load_patch ( int dev , int format , const char __user * addr , <BUGS> int offs , int count , int pmgr_flag ) <BUGE> { int orig_dev = synth_devs [ dev ] -> midi_dev ; struct sysex_info sysex ; int i ; unsigned long left , src_offs , eox_seen = 0 ; int first_byte = 1 ; int hdr_size = ( unsigned long ) & sysex . data [ 0 ] - ( unsigned long ) & sysex ; leave_sysex ( dev ) ; if ( ! prefix_cmd ( orig_dev , 0xf0 ) ) return 0 ; if ( format != SYSEX_PATCH ) <BUGS> { <BUGE> return - EINVAL ; <BUGS> } <BUGE> if ( count < hdr_size ) <BUGS> { <BUGE> return - EINVAL ; <BUGS> } <BUGE> count -= hdr_size ; <BUGS> if ( copy_from_user ( & ( ( char * ) & sysex ) [ offs ] , & ( addr ) [ offs ] , hdr_size - offs ) ) <BUGE> return - EFAULT ; <BUGS> if ( count < sysex . len ) { <BUGE> sysex . len = count ; <BUGS> } <BUGE> left = sysex . len ; src_offs = 0 ; for ( i = 0 ; i < left && ! signal_pending ( current ) ; i ++ ) { unsigned char data ; if ( get_user ( data , ( unsigned char __user * ) ( addr + hdr_size + i ) ) ) return - EFAULT ; eox_seen = ( i > 0 && data & 0x80 ) ; if ( eox_seen && data != 0xf7 ) data = 0xf7 ; if ( i == 0 ) { if ( data != 0xf0 ) { printk ( KERN_WARNING "midi_synth: Sysex start missing\\n" ) ; return - EINVAL ; } } while ( ! midi_devs [ orig_dev ] -> outputc ( orig_dev , ( unsigned char ) ( data & 0xff ) ) && ! signal_pending ( current ) ) schedule ( ) ; if ( ! first_byte && data & 0x80 ) return 0 ; first_byte = 0 ; } if ( ! eox_seen ) midi_outc ( orig_dev , 0xf7 ) ; return 0 ; }
| <FIXS> int count , int pmgr_flag ) <FIXE> <FIXS> <FIXE> <FIXS> <FIXE> <FIXS> <FIXE> <FIXS> <FIXE> <FIXS> if ( copy_from_user ( & sysex , addr , hdr_size ) ) <FIXE> <FIXS> if ( ( unsigned ) count < ( unsigned ) sysex . len ) <FIXE> <FIXS> <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-416 static ssize_t userfaultfd_ctx_read ( struct userfaultfd_ctx * ctx , int no_wait , struct uffd_msg * msg ) { ssize_t ret ; DECLARE_WAITQUEUE ( wait , current ) ; struct userfaultfd_wait_queue * uwq ; LIST_HEAD ( fork_event ) ; struct userfaultfd_ctx * fork_nctx = NULL ; spin_lock ( & ctx -> fd_wqh . lock ) ; __add_wait_queue ( & ctx -> fd_wqh , & wait ) ; for ( ; ; ) { set_current_state ( TASK_INTERRUPTIBLE ) ; spin_lock ( & ctx -> fault_pending_wqh . lock ) ; uwq = find_userfault ( ctx ) ; if ( uwq ) { write_seqcount_begin ( & ctx -> refile_seq ) ; list_del ( & uwq -> wq . entry ) ; __add_wait_queue ( & ctx -> fault_wqh , & uwq -> wq ) ; write_seqcount_end ( & ctx -> refile_seq ) ; * msg = uwq -> msg ; spin_unlock ( & ctx -> fault_pending_wqh . lock ) ; ret = 0 ; break ; } spin_unlock ( & ctx -> fault_pending_wqh . lock ) ; spin_lock ( & ctx -> event_wqh . lock ) ; uwq = find_userfault_evt ( ctx ) ; if ( uwq ) { * msg = uwq -> msg ; if ( uwq -> msg . event == UFFD_EVENT_FORK ) { fork_nctx = ( struct userfaultfd_ctx * ) ( unsigned long ) uwq -> msg . arg . reserved . reserved1 ; list_move ( & uwq -> wq . entry , & fork_event ) ; <BUGS> <BUGE> spin_unlock ( & ctx -> event_wqh . lock ) ; ret = 0 ; break ; } userfaultfd_event_complete ( ctx , uwq ) ; spin_unlock ( & ctx -> event_wqh . lock ) ; ret = 0 ; break ; } spin_unlock ( & ctx -> event_wqh . lock ) ; if ( signal_pending ( current ) ) { ret = - ERESTARTSYS ; break ; } if ( no_wait ) { ret = - EAGAIN ; break ; } spin_unlock ( & ctx -> fd_wqh . lock ) ; schedule ( ) ; spin_lock ( & ctx -> fd_wqh . lock ) ; } __remove_wait_queue ( & ctx -> fd_wqh , & wait ) ; __set_current_state ( TASK_RUNNING ) ; spin_unlock ( & ctx -> fd_wqh . lock ) ; if ( ! ret && msg -> event == UFFD_EVENT_FORK ) { ret = resolve_userfault_fork ( ctx , fork_nctx , msg ) ; <BUGS> if ( ! ret ) { <BUGE> spin_lock ( & ctx -> event_wqh . lock ) ; if ( ! list_empty ( & fork_event ) ) { <BUGS> <BUGE> uwq = list_first_entry ( & fork_event , typeof ( * uwq ) , wq . entry ) ; list_del ( & uwq -> wq . entry ) ; __add_wait_queue ( & ctx -> event_wqh , & uwq -> wq ) ; <BUGS> <BUGE> userfaultfd_event_complete ( ctx , uwq ) ; <BUGS> <BUGE> } spin_unlock ( & ctx -> event_wqh . lock ) ; <BUGS> } <BUGE> } return ret ; }
| <FIXS> userfaultfd_ctx_get ( fork_nctx ) ; <FIXE> <FIXS> <FIXE> <FIXS> userfaultfd_ctx_put ( fork_nctx ) ; <FIXE> <FIXS> if ( likely ( ! ret ) ) <FIXE> <FIXS> } else { if ( ret ) userfaultfd_ctx_put ( fork_nctx ) ; <FIXE> <FIXS> <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 <BUGS> static int decode_coefs ( VP9_COMMON * cm , const MACROBLOCKD * xd , PLANE_TYPE type , int16_t * dqcoeff , TX_SIZE tx_size , const int16_t * dq , <BUGE> int ctx , const int16_t * scan , const int16_t * nb , <BUGS> vp9_reader * r ) { <BUGE> const int max_eob = 16 << ( tx_size << 1 ) ; <BUGS> const FRAME_CONTEXT * const fc = & cm -> fc ; FRAME_COUNTS * const counts = & cm -> counts ; <BUGE> const int ref = is_inter_block ( & xd -> mi [ 0 ] -> mbmi ) ; int band , c = 0 ; <BUGS> const vp9_prob ( * coef_probs ) [ COEFF_CONTEXTS ] [ UNCONSTRAINED_NODES ] = <BUGE> fc -> coef_probs [ tx_size ] [ type ] [ ref ] ; <BUGS> const vp9_prob * prob ; unsigned int ( * coef_counts ) [ COEFF_CONTEXTS ] [ UNCONSTRAINED_NODES + 1 ] = counts -> coef [ tx_size ] [ type ] [ ref ] ; unsigned int ( * eob_branch_count ) [ COEFF_CONTEXTS ] = counts -> eob_branch [ tx_size ] [ type ] [ ref ] ; <BUGE> uint8_t token_cache [ 32 * 32 ] ; <BUGS> const uint8_t * cat6 ; <BUGE> const uint8_t * band_translate = get_band_translate ( tx_size ) ; const int dq_shift = ( tx_size == TX_32X32 ) ; <BUGS> int v ; <BUGE> int16_t dqv = dq [ 0 ] ; <BUGS> <BUGE> while ( c < max_eob ) { <BUGS> int val ; <BUGE> band = * band_translate ++ ; prob = coef_probs [ band ] [ ctx ] ; <BUGS> if ( ! cm -> frame_parallel_decoding_mode ) <BUGE> ++ eob_branch_count [ band ] [ ctx ] ; <BUGS> if ( ! vp9_read ( r , prob [ EOB_CONTEXT_NODE ] ) ) { <BUGE> INCREMENT_COUNT ( EOB_MODEL_TOKEN ) ; break ; } <BUGS> while ( ! vp9_read ( r , prob [ ZERO_CONTEXT_NODE ] ) ) { <BUGE> INCREMENT_COUNT ( ZERO_TOKEN ) ; dqv = dq [ 1 ] ; token_cache [ scan [ c ] ] = 0 ; ++ c ; if ( c >= max_eob ) return c ; ctx = get_coef_context ( nb , token_cache , c ) ; band = * band_translate ++ ; prob = coef_probs [ band ] [ ctx ] ; } <BUGS> if ( ! vp9_read ( r , prob [ ONE_CONTEXT_NODE ] ) ) { <BUGE> INCREMENT_COUNT ( ONE_TOKEN ) ; <BUGS> WRITE_COEF_CONTINUE ( 1 , ONE_TOKEN ) ; <BUGE> } <BUGS> INCREMENT_COUNT ( TWO_TOKEN ) ; prob = vp9_pareto8_full [ prob [ PIVOT_NODE ] - 1 ] ; if ( ! vp9_read ( r , prob [ LOW_VAL_CONTEXT_NODE ] ) ) { if ( ! vp9_read ( r , prob [ TWO_CONTEXT_NODE ] ) ) { WRITE_COEF_CONTINUE ( 2 , TWO_TOKEN ) ; <BUGE> } <BUGS> if ( ! vp9_read ( r , prob [ THREE_CONTEXT_NODE ] ) ) { WRITE_COEF_CONTINUE ( 3 , THREE_TOKEN ) ; <BUGE> } <BUGS> WRITE_COEF_CONTINUE ( 4 , FOUR_TOKEN ) ; } if ( ! vp9_read ( r , prob [ HIGH_LOW_CONTEXT_NODE ] ) ) { if ( ! vp9_read ( r , prob [ CAT_ONE_CONTEXT_NODE ] ) ) { val = CAT1_MIN_VAL ; ADJUST_COEF ( CAT1_PROB0 , 0 ) ; WRITE_COEF_CONTINUE ( val , CATEGORY1_TOKEN ) ; } val = CAT2_MIN_VAL ; ADJUST_COEF ( CAT2_PROB1 , 1 ) ; ADJUST_COEF ( CAT2_PROB0 , 0 ) ; WRITE_COEF_CONTINUE ( val , CATEGORY2_TOKEN ) ; } if ( ! vp9_read ( r , prob [ CAT_THREEFOUR_CONTEXT_NODE ] ) ) { if ( ! vp9_read ( r , prob [ CAT_THREE_CONTEXT_NODE ] ) ) { val = CAT3_MIN_VAL ; ADJUST_COEF ( CAT3_PROB2 , 2 ) ; ADJUST_COEF ( CAT3_PROB1 , 1 ) ; ADJUST_COEF ( CAT3_PROB0 , 0 ) ; WRITE_COEF_CONTINUE ( val , CATEGORY3_TOKEN ) ; } val = CAT4_MIN_VAL ; ADJUST_COEF ( CAT4_PROB3 , 3 ) ; ADJUST_COEF ( CAT4_PROB2 , 2 ) ; ADJUST_COEF ( CAT4_PROB1 , 1 ) ; ADJUST_COEF ( CAT4_PROB0 , 0 ) ; WRITE_COEF_CONTINUE ( val , CATEGORY4_TOKEN ) ; } if ( ! vp9_read ( r , prob [ CAT_FIVE_CONTEXT_NODE ] ) ) { val = CAT5_MIN_VAL ; ADJUST_COEF ( CAT5_PROB4 , 4 ) ; ADJUST_COEF ( CAT5_PROB3 , 3 ) ; ADJUST_COEF ( CAT5_PROB2 , 2 ) ; ADJUST_COEF ( CAT5_PROB1 , 1 ) ; ADJUST_COEF ( CAT5_PROB0 , 0 ) ; WRITE_COEF_CONTINUE ( val , CATEGORY5_TOKEN ) ; } val = 0 ; cat6 = cat6_prob ; while ( * cat6 ) val = ( val << 1 ) | vp9_read ( r , * cat6 ++ ) ; val += CAT6_MIN_VAL ; WRITE_COEF_CONTINUE ( val , CATEGORY6_TOKEN ) ; <BUGE> } return c ; }
| <FIXS> static int decode_coefs ( const MACROBLOCKD * xd , PLANE_TYPE type , tran_low_t * dqcoeff , TX_SIZE tx_size , const int16_t * dq , <FIXE> <FIXS> vpx_reader * r ) { FRAME_COUNTS * counts = xd -> counts ; <FIXE> <FIXS> const FRAME_CONTEXT * const fc = xd -> fc ; <FIXE> <FIXS> const vpx_prob ( * coef_probs ) [ COEFF_CONTEXTS ] [ UNCONSTRAINED_NODES ] = <FIXE> <FIXS> const vpx_prob * prob ; unsigned int ( * coef_counts ) [ COEFF_CONTEXTS ] [ UNCONSTRAINED_NODES + 1 ] ; unsigned int ( * eob_branch_count ) [ COEFF_CONTEXTS ] ; <FIXE> <FIXS> <FIXE> <FIXS> int v , token ; <FIXE> <FIXS> const uint8_t * cat1_prob ; const uint8_t * cat2_prob ; const uint8_t * cat3_prob ; const uint8_t * cat4_prob ; const uint8_t * cat5_prob ; const uint8_t * cat6_prob ; if ( counts ) { coef_counts = counts -> coef [ tx_size ] [ type ] [ ref ] ; eob_branch_count = counts -> eob_branch [ tx_size ] [ type ] [ ref ] ; } # if CONFIG_VP9_HIGHBITDEPTH if ( xd -> bd > VPX_BITS_8 ) { if ( xd -> bd == VPX_BITS_10 ) { cat1_prob = vp9_cat1_prob_high10 ; cat2_prob = vp9_cat2_prob_high10 ; cat3_prob = vp9_cat3_prob_high10 ; cat4_prob = vp9_cat4_prob_high10 ; cat5_prob = vp9_cat5_prob_high10 ; cat6_prob = vp9_cat6_prob_high10 ; } else { cat1_prob = vp9_cat1_prob_high12 ; cat2_prob = vp9_cat2_prob_high12 ; cat3_prob = vp9_cat3_prob_high12 ; cat4_prob = vp9_cat4_prob_high12 ; cat5_prob = vp9_cat5_prob_high12 ; cat6_prob = vp9_cat6_prob_high12 ; } } else { cat1_prob = vp9_cat1_prob ; cat2_prob = vp9_cat2_prob ; cat3_prob = vp9_cat3_prob ; cat4_prob = vp9_cat4_prob ; cat5_prob = vp9_cat5_prob ; cat6_prob = vp9_cat6_prob ; } # else cat1_prob = vp9_cat1_prob ; cat2_prob = vp9_cat2_prob ; cat3_prob = vp9_cat3_prob ; cat4_prob = vp9_cat4_prob ; cat5_prob = vp9_cat5_prob ; cat6_prob = vp9_cat6_prob ; # endif <FIXE> <FIXS> int val = - 1 ; <FIXE> <FIXS> if ( counts ) <FIXE> <FIXS> if ( ! vpx_read ( r , prob [ EOB_CONTEXT_NODE ] ) ) { <FIXE> <FIXS> while ( ! vpx_read ( r , prob [ ZERO_CONTEXT_NODE ] ) ) { <FIXE> <FIXS> if ( ! vpx_read ( r , prob [ ONE_CONTEXT_NODE ] ) ) { <FIXE> <FIXS> token = ONE_TOKEN ; val = 1 ; } else { INCREMENT_COUNT ( TWO_TOKEN ) ; token = vpx_read_tree ( r , vp9_coef_con_tree , vp9_pareto8_full [ prob [ PIVOT_NODE ] - 1 ] ) ; switch ( token ) { case TWO_TOKEN : case THREE_TOKEN : case FOUR_TOKEN : val = token ; break ; case CATEGORY1_TOKEN : val = CAT1_MIN_VAL + read_coeff ( cat1_prob , 1 , r ) ; break ; case CATEGORY2_TOKEN : val = CAT2_MIN_VAL + read_coeff ( cat2_prob , 2 , r ) ; break ; case CATEGORY3_TOKEN : val = CAT3_MIN_VAL + read_coeff ( cat3_prob , 3 , r ) ; break ; case CATEGORY4_TOKEN : val = CAT4_MIN_VAL + read_coeff ( cat4_prob , 4 , r ) ; break ; case CATEGORY5_TOKEN : val = CAT5_MIN_VAL + read_coeff ( cat5_prob , 5 , r ) ; break ; case CATEGORY6_TOKEN : # if CONFIG_VP9_HIGHBITDEPTH switch ( xd -> bd ) { case VPX_BITS_8 : val = CAT6_MIN_VAL + read_coeff ( cat6_prob , 14 , r ) ; break ; case VPX_BITS_10 : val = CAT6_MIN_VAL + read_coeff ( cat6_prob , 16 , r ) ; break ; case VPX_BITS_12 : val = CAT6_MIN_VAL + read_coeff ( cat6_prob , 18 , r ) ; break ; default : assert ( 0 ) ; return - 1 ; <FIXE> <FIXS> # else val = CAT6_MIN_VAL + read_coeff ( cat6_prob , 14 , r ) ; # endif break ; <FIXE> <FIXS> <FIXE> <FIXS> v = ( val * dqv ) >> dq_shift ; # if CONFIG_COEFFICIENT_RANGE_CHECKING # if CONFIG_VP9_HIGHBITDEPTH dqcoeff [ scan [ c ] ] = highbd_check_range ( ( vpx_read_bit ( r ) ? - v : v ) , xd -> bd ) ; # else dqcoeff [ scan [ c ] ] = check_range ( vpx_read_bit ( r ) ? - v : v ) ; # endif # else dqcoeff [ scan [ c ] ] = vpx_read_bit ( r ) ? - v : v ; # endif token_cache [ scan [ c ] ] = vp9_pt_energy_class [ token ] ; ++ c ; ctx = get_coef_context ( nb , token_cache , c ) ; dqv = dq [ 1 ] ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-416 static void host_callback ( void * arg , int status , int timeouts , unsigned char * abuf , int alen ) { struct host_query * hquery = ( struct host_query * ) arg ; int addinfostatus = ARES_SUCCESS ; hquery -> timeouts += timeouts ; hquery -> remaining -- ; if ( status == ARES_SUCCESS ) { addinfostatus = ares__parse_into_addrinfo ( abuf , alen , hquery -> ai ) ; } else if ( status == ARES_EDESTRUCTION ) { end_hquery ( hquery , status ) ; <BUGS> <BUGE> } if ( ! hquery -> remaining ) { if ( addinfostatus != ARES_SUCCESS ) { end_hquery ( hquery , addinfostatus ) ; } else if ( hquery -> ai -> nodes ) { end_hquery ( hquery , ARES_SUCCESS ) ; } else if ( status == ARES_ENOTFOUND ) { next_lookup ( hquery , status ) ; } else { end_hquery ( hquery , status ) ; } } }
| <FIXS> return ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 DECLAREcpFunc ( cpContig2SeparateByRow ) { tsize_t scanlinesizein = TIFFScanlineSize ( in ) ; tsize_t scanlinesizeout = TIFFScanlineSize ( out ) ; tdata_t inbuf ; tdata_t outbuf ; register uint8 * inp , * outp ; register uint32 n ; uint32 row ; tsample_t s ; <BUGS> <BUGE> inbuf = _TIFFmalloc ( scanlinesizein ) ; outbuf = _TIFFmalloc ( scanlinesizeout ) ; if ( ! inbuf || ! outbuf ) goto bad ; _TIFFmemset ( inbuf , 0 , scanlinesizein ) ; _TIFFmemset ( outbuf , 0 , scanlinesizeout ) ; for ( s = 0 ; s < spp ; s ++ ) { for ( row = 0 ; row < imagelength ; row ++ ) { if ( TIFFReadScanline ( in , inbuf , row , 0 ) < 0 && ! ignore ) { TIFFError ( TIFFFileName ( in ) , "Error, can\'t read scanline %lu" , ( unsigned long ) row ) ; goto bad ; } inp = ( ( uint8 * ) inbuf ) + s ; outp = ( uint8 * ) outbuf ; for ( n = imagewidth ; n -- > 0 ; ) { * outp ++ = * inp ; inp += spp ; } if ( TIFFWriteScanline ( out , outbuf , row , s ) < 0 ) { TIFFError ( TIFFFileName ( out ) , "Error, can\'t write scanline %lu" , ( unsigned long ) row ) ; goto bad ; } } } if ( inbuf ) _TIFFfree ( inbuf ) ; if ( outbuf ) _TIFFfree ( outbuf ) ; return 1 ; bad : if ( inbuf ) _TIFFfree ( inbuf ) ; if ( outbuf ) _TIFFfree ( outbuf ) ; return 0 ; }
| <FIXS> uint16 bps = 0 ; ( void ) TIFFGetField ( in , TIFFTAG_BITSPERSAMPLE , & bps ) ; if ( bps != 8 ) { TIFFError ( TIFFFileName ( in ) , "Error, can only handle BitsPerSample=8 in %s" , "cpContig2SeparateByRow" ) ; return 0 ; } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-399 static void free_huge_page ( struct page * page ) { struct hstate * h = page_hstate ( page ) ; int nid = page_to_nid ( page ) ; <BUGS> struct address_space * mapping ; mapping = ( struct address_space * ) page_private ( page ) ; <BUGE> set_page_private ( page , 0 ) ; page -> mapping = NULL ; BUG_ON ( page_count ( page ) ) ; BUG_ON ( page_mapcount ( page ) ) ; INIT_LIST_HEAD ( & page -> lru ) ; spin_lock ( & hugetlb_lock ) ; if ( h -> surplus_huge_pages_node [ nid ] && huge_page_order ( h ) < MAX_ORDER ) { update_and_free_page ( h , page ) ; h -> surplus_huge_pages -- ; h -> surplus_huge_pages_node [ nid ] -- ; } else { enqueue_huge_page ( h , page ) ; } spin_unlock ( & hugetlb_lock ) ; <BUGS> if ( mapping ) hugetlb_put_quota ( mapping , 1 ) ; <BUGE> }
| <FIXS> struct hugepage_subpool * spool = ( struct hugepage_subpool * ) page_private ( page ) ; <FIXE> <FIXS> hugepage_subpool_put_pages ( spool , 1 ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 <BUGS> void vp9_fht4x4_sse2 ( const int16_t * input , int16_t * output , <BUGE> int stride , int tx_type ) { __m128i in [ 4 ] ; switch ( tx_type ) { case DCT_DCT : <BUGS> vp9_fdct4x4_sse2 ( input , output , stride ) ; <BUGE> break ; case ADST_DCT : load_buffer_4x4 ( input , in , stride ) ; fadst4_sse2 ( in ) ; fdct4_sse2 ( in ) ; write_buffer_4x4 ( output , in ) ; break ; case DCT_ADST : load_buffer_4x4 ( input , in , stride ) ; fdct4_sse2 ( in ) ; fadst4_sse2 ( in ) ; write_buffer_4x4 ( output , in ) ; break ; case ADST_ADST : load_buffer_4x4 ( input , in , stride ) ; fadst4_sse2 ( in ) ; fadst4_sse2 ( in ) ; write_buffer_4x4 ( output , in ) ; break ; default : assert ( 0 ) ; break ; } }
| <FIXS> void vp9_fht4x4_sse2 ( const int16_t * input , tran_low_t * output , <FIXE> <FIXS> vpx_fdct4x4_sse2 ( input , output , stride ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-20 <BUGS> error_t mqttSnClientDisconnect ( MqttSnClientContext * context ) <BUGE> { error_t error ; systime_t time ; if ( context == NULL ) return ERROR_INVALID_PARAMETER ; error = NO_ERROR ; while ( ! error ) { time = osGetSystemTime ( ) ; if ( context -> state == MQTT_SN_CLIENT_STATE_ACTIVE ) { context -> startTime = time ; <BUGS> error = mqttSnClientSendDisconnect ( context , 0 ) ; <BUGE> } else if ( context -> state == MQTT_SN_CLIENT_STATE_SENDING_REQ ) { if ( timeCompare ( time , context -> startTime + context -> timeout ) >= 0 ) { mqttSnClientShutdownConnection ( context ) ; error = ERROR_TIMEOUT ; } else if ( timeCompare ( time , context -> retransmitStartTime + MQTT_SN_CLIENT_RETRY_TIMEOUT ) >= 0 ) { <BUGS> error = mqttSnClientSendDisconnect ( context , 0 ) ; <BUGE> } else { error = mqttSnClientProcessEvents ( context , MQTT_SN_CLIENT_TICK_INTERVAL ) ; } } else if ( context -> state == MQTT_SN_CLIENT_STATE_DISCONNECTING ) { error = mqttSnClientShutdownConnection ( context ) ; mqttSnClientCloseConnection ( context ) ; context -> state = MQTT_SN_CLIENT_STATE_DISCONNECTED ; } else if ( context -> state == MQTT_SN_CLIENT_STATE_DISCONNECTED ) { break ; } else { error = ERROR_WRONG_STATE ; } } if ( error != NO_ERROR && error != ERROR_WOULD_BLOCK ) { mqttSnClientCloseConnection ( context ) ; context -> state = MQTT_SN_CLIENT_STATE_DISCONNECTED ; } return error ; }
| <FIXS> error_t mqttSnClientDisconnect ( MqttSnClientContext * context , systime_t duration ) <FIXE> <FIXS> error = mqttSnClientSendDisconnect ( context , duration / 1000 ) ; <FIXE> <FIXS> error = mqttSnClientSendDisconnect ( context , duration / 1000 ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 <BUGS> static const char * parse_object ( cJSON * item , const char * value ) <BUGE> { cJSON * child ; <BUGS> if ( * value != '{' ) { ep = value ; return 0 ; } <BUGE> item -> type = cJSON_Object ; value = skip ( value + 1 ) ; <BUGS> if ( * value == '}' ) return value + 1 ; if ( ! ( item -> child = child = cJSON_New_Item ( ) ) ) return 0 ; if ( ! ( value = skip ( parse_string ( child , skip ( value ) ) ) ) ) return 0 ; child -> string = child -> valuestring ; child -> valuestring = 0 ; if ( * value != ':' ) { ep = value ; return 0 ; <BUGE> } <BUGS> if ( ! ( value = skip ( parse_value ( child , skip ( value + 1 ) ) ) ) ) return 0 ; while ( * value == ',' ) { cJSON * new_item ; if ( ! ( new_item = cJSON_New_Item ( ) ) ) return 0 ; child -> next = new_item ; new_item -> prev = child ; child = new_item ; if ( ! ( value = skip ( parse_string ( child , skip ( value + 1 ) ) ) ) ) return 0 ; child -> string = child -> valuestring ; child -> valuestring = 0 ; if ( * value != ':' ) { ep = value ; return 0 ; } if ( ! ( value = skip ( parse_value ( child , skip ( value + 1 ) ) ) ) ) return 0 ; } if ( * value == '}' ) return value + 1 ; ep = value ; return 0 ; <BUGE> }
| <FIXS> static const char * parse_object ( cJSON * item , const char * value , const char * * ep ) <FIXE> <FIXS> if ( * value != '{' ) { * ep = value ; return 0 ; } <FIXE> <FIXS> if ( * value == '}' ) return value + 1 ; item -> child = child = cJSON_New_Item ( ) ; if ( ! item -> child ) return 0 ; value = skip ( parse_string ( child , skip ( value ) , ep ) ) ; if ( ! value ) return 0 ; child -> string = child -> valuestring ; child -> valuestring = 0 ; if ( * value != ':' ) { * ep = value ; return 0 ; } value = skip ( parse_value ( child , skip ( value + 1 ) , ep ) ) ; if ( ! value ) return 0 ; while ( * value == ',' ) { cJSON * new_item ; if ( ! ( new_item = cJSON_New_Item ( ) ) ) return 0 ; child -> next = new_item ; new_item -> prev = child ; child = new_item ; value = skip ( parse_string ( child , skip ( value + 1 ) , ep ) ) ; if ( ! value ) return 0 ; child -> string = child -> valuestring ; child -> valuestring = 0 ; if ( * value != ':' ) { * ep = value ; return 0 ; } value = skip ( parse_value ( child , skip ( value + 1 ) , ep ) ) ; if ( ! value ) return 0 ; <FIXE> <FIXS> if ( * value == '}' ) return value + 1 ; * ep = value ; return 0 ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-264 static int hfsplus_readdir ( struct file * filp , void * dirent , filldir_t filldir ) { struct inode * inode = filp -> f_path . dentry -> d_inode ; struct super_block * sb = inode -> i_sb ; int len , err ; char strbuf [ HFSPLUS_MAX_STRLEN + 1 ] ; hfsplus_cat_entry entry ; struct hfs_find_data fd ; struct hfsplus_readdir_data * rd ; u16 type ; if ( filp -> f_pos >= inode -> i_size ) return 0 ; err = hfs_find_init ( HFSPLUS_SB ( sb ) -> cat_tree , & fd ) ; if ( err ) return err ; hfsplus_cat_build_key ( sb , fd . search_key , inode -> i_ino , NULL ) ; err = hfs_brec_find ( & fd ) ; if ( err ) goto out ; switch ( ( u32 ) filp -> f_pos ) { case 0 : if ( filldir ( dirent , "." , 1 , 0 , inode -> i_ino , DT_DIR ) ) goto out ; filp -> f_pos ++ ; case 1 : <BUGS> <BUGE> hfs_bnode_read ( fd . bnode , & entry , fd . entryoffset , fd . entrylength ) ; if ( be16_to_cpu ( entry . type ) != HFSPLUS_FOLDER_THREAD ) { printk ( KERN_ERR "hfs: bad catalog folder thread\\n" ) ; err = - EIO ; goto out ; } if ( fd . entrylength < HFSPLUS_MIN_THREAD_SZ ) { printk ( KERN_ERR "hfs: truncated catalog thread\\n" ) ; err = - EIO ; goto out ; } if ( filldir ( dirent , ".." , 2 , 1 , be32_to_cpu ( entry . thread . parentID ) , DT_DIR ) ) goto out ; filp -> f_pos ++ ; default : if ( filp -> f_pos >= inode -> i_size ) goto out ; err = hfs_brec_goto ( & fd , filp -> f_pos - 1 ) ; if ( err ) goto out ; } for ( ; ; ) { if ( be32_to_cpu ( fd . key -> cat . parent ) != inode -> i_ino ) { printk ( KERN_ERR "hfs: walked past end of dir\\n" ) ; <BUGS> <BUGE> err = - EIO ; goto out ; } hfs_bnode_read ( fd . bnode , & entry , fd . entryoffset , fd . entrylength ) ; type = be16_to_cpu ( entry . type ) ; len = HFSPLUS_MAX_STRLEN ; err = hfsplus_uni2asc ( sb , & fd . key -> cat . name , strbuf , & len ) ; if ( err ) goto out ; if ( type == HFSPLUS_FOLDER ) { if ( fd . entrylength < sizeof ( struct hfsplus_cat_folder ) ) { printk ( KERN_ERR "hfs: small dir entry\\n" ) ; err = - EIO ; goto out ; } if ( HFSPLUS_SB ( sb ) -> hidden_dir && HFSPLUS_SB ( sb ) -> hidden_dir -> i_ino == be32_to_cpu ( entry . folder . id ) ) goto next ; if ( filldir ( dirent , strbuf , len , filp -> f_pos , be32_to_cpu ( entry . folder . id ) , DT_DIR ) ) break ; } else if ( type == HFSPLUS_FILE ) { if ( fd . entrylength < sizeof ( struct hfsplus_cat_file ) ) { printk ( KERN_ERR "hfs: small file entry\\n" ) ; err = - EIO ; goto out ; } if ( filldir ( dirent , strbuf , len , filp -> f_pos , be32_to_cpu ( entry . file . id ) , DT_REG ) ) break ; } else { printk ( KERN_ERR "hfs: bad catalog entry type\\n" ) ; err = - EIO ; goto out ; } next : filp -> f_pos ++ ; if ( filp -> f_pos >= inode -> i_size ) goto out ; err = hfs_brec_goto ( & fd , 1 ) ; if ( err ) goto out ; } rd = filp -> private_data ; if ( ! rd ) { rd = kmalloc ( sizeof ( struct hfsplus_readdir_data ) , GFP_KERNEL ) ; if ( ! rd ) { err = - ENOMEM ; goto out ; } filp -> private_data = rd ; rd -> file = filp ; list_add ( & rd -> list , & HFSPLUS_I ( inode ) -> open_dir_list ) ; } memcpy ( & rd -> key , fd . key , sizeof ( struct hfsplus_cat_key ) ) ; out : hfs_find_exit ( & fd ) ; return err ; }
| <FIXS> if ( fd . entrylength > sizeof ( entry ) || fd . entrylength < 0 ) { err = - EIO ; goto out ; } <FIXE> <FIXS> err = - EIO ; goto out ; } if ( fd . entrylength > sizeof ( entry ) || fd . entrylength < 0 ) { <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-264 static struct net_device * _init_airo_card ( unsigned short irq , int port , int is_pcmcia , struct pci_dev * pci , struct device * dmdev ) { struct net_device * dev ; struct airo_info * ai ; int i , rc ; CapabilityRid cap_rid ; dev = alloc_netdev ( sizeof ( * ai ) , "" , ether_setup ) ; if ( ! dev ) { airo_print_err ( "" , "Couldn\'t alloc_etherdev" ) ; return NULL ; } ai = dev -> ml_priv = netdev_priv ( dev ) ; ai -> wifidev = NULL ; ai -> flags = 1 << FLAG_RADIO_DOWN ; ai -> jobs = 0 ; ai -> dev = dev ; if ( pci && ( pci -> device == 0x5000 || pci -> device == 0xa504 ) ) { airo_print_dbg ( "" , "Found an MPI350 card" ) ; set_bit ( FLAG_MPI , & ai -> flags ) ; } spin_lock_init ( & ai -> aux_lock ) ; sema_init ( & ai -> sem , 1 ) ; ai -> config . len = 0 ; ai -> pci = pci ; init_waitqueue_head ( & ai -> thr_wait ) ; ai -> tfm = NULL ; add_airo_dev ( ai ) ; if ( airo_networks_allocate ( ai ) ) goto err_out_free ; airo_networks_initialize ( ai ) ; skb_queue_head_init ( & ai -> txq ) ; if ( test_bit ( FLAG_MPI , & ai -> flags ) ) dev -> netdev_ops = & mpi_netdev_ops ; else dev -> netdev_ops = & airo_netdev_ops ; dev -> wireless_handlers = & airo_handler_def ; ai -> wireless_data . spy_data = & ai -> spy_data ; dev -> wireless_data = & ai -> wireless_data ; dev -> irq = irq ; dev -> base_addr = port ; <BUGS> <BUGE> SET_NETDEV_DEV ( dev , dmdev ) ; reset_card ( dev , 1 ) ; msleep ( 400 ) ; if ( ! is_pcmcia ) { if ( ! request_region ( dev -> base_addr , 64 , DRV_NAME ) ) { rc = - EBUSY ; airo_print_err ( dev -> name , "Couldn\'t request region" ) ; goto err_out_nets ; } } if ( test_bit ( FLAG_MPI , & ai -> flags ) ) { if ( mpi_map_card ( ai , pci ) ) { airo_print_err ( "" , "Could not map memory" ) ; goto err_out_res ; } } if ( probe ) { if ( setup_card ( ai , dev -> dev_addr , 1 ) != SUCCESS ) { airo_print_err ( dev -> name , "MAC could not be enabled" ) ; rc = - EIO ; goto err_out_map ; } } else if ( ! test_bit ( FLAG_MPI , & ai -> flags ) ) { ai -> bap_read = fast_bap_read ; set_bit ( FLAG_FLASHING , & ai -> flags ) ; } strcpy ( dev -> name , "eth%d" ) ; rc = register_netdev ( dev ) ; if ( rc ) { airo_print_err ( dev -> name , "Couldn\'t register_netdev" ) ; goto err_out_map ; } ai -> wifidev = init_wifidev ( ai , dev ) ; if ( ! ai -> wifidev ) goto err_out_reg ; rc = readCapabilityRid ( ai , & cap_rid , 1 ) ; if ( rc != SUCCESS ) { rc = - EIO ; goto err_out_wifi ; } ai -> wep_capable = ( cap_rid . softCap & cpu_to_le16 ( 0x02 ) ) ? 1 : 0 ; ai -> max_wep_idx = ( cap_rid . softCap & cpu_to_le16 ( 0x80 ) ) ? 3 : 0 ; airo_print_info ( dev -> name , "Firmware version %x.%x.%02d" , ( ( le16_to_cpu ( cap_rid . softVer ) >> 8 ) & 0xF ) , ( le16_to_cpu ( cap_rid . softVer ) & 0xFF ) , le16_to_cpu ( cap_rid . softSubVer ) ) ; if ( le16_to_cpu ( cap_rid . softVer ) > 0x530 || ( le16_to_cpu ( cap_rid . softVer ) == 0x530 && le16_to_cpu ( cap_rid . softSubVer ) >= 17 ) ) { airo_print_info ( ai -> dev -> name , "WPA supported." ) ; set_bit ( FLAG_WPA_CAPABLE , & ai -> flags ) ; ai -> bssListFirst = RID_WPA_BSSLISTFIRST ; ai -> bssListNext = RID_WPA_BSSLISTNEXT ; ai -> bssListRidLen = sizeof ( BSSListRid ) ; } else { airo_print_info ( ai -> dev -> name , "WPA unsupported with firmware " "versions older than 5.30.17." ) ; ai -> bssListFirst = RID_BSSLISTFIRST ; ai -> bssListNext = RID_BSSLISTNEXT ; ai -> bssListRidLen = sizeof ( BSSListRid ) - sizeof ( BSSListRidExtra ) ; } set_bit ( FLAG_REGISTERED , & ai -> flags ) ; airo_print_info ( dev -> name , "MAC enabled %pM" , dev -> dev_addr ) ; if ( probe && ! test_bit ( FLAG_MPI , & ai -> flags ) ) for ( i = 0 ; i < MAX_FIDS ; i ++ ) ai -> fids [ i ] = transmit_allocate ( ai , AIRO_DEF_MTU , i >= MAX_FIDS / 2 ) ; if ( setup_proc_entry ( dev , dev -> ml_priv ) < 0 ) goto err_out_wifi ; return dev ; err_out_wifi : unregister_netdev ( ai -> wifidev ) ; free_netdev ( ai -> wifidev ) ; err_out_reg : unregister_netdev ( dev ) ; err_out_map : if ( test_bit ( FLAG_MPI , & ai -> flags ) && pci ) { pci_free_consistent ( pci , PCI_SHARED_LEN , ai -> shared , ai -> shared_dma ) ; iounmap ( ai -> pciaux ) ; iounmap ( ai -> pcimem ) ; mpi_unmap_card ( ai -> pci ) ; } err_out_res : if ( ! is_pcmcia ) release_region ( dev -> base_addr , 64 ) ; err_out_nets : airo_networks_free ( ai ) ; err_out_free : del_airo_dev ( ai ) ; free_netdev ( dev ) ; return NULL ; }
| <FIXS> dev -> priv_flags &= ~ IFF_TX_SKB_SHARING ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static int get_siz ( Jpeg2000DecoderContext * s ) { int i ; int ncomponents ; uint32_t log2_chroma_wh = 0 ; const enum AVPixelFormat * possible_fmts = NULL ; int possible_fmts_nb = 0 ; if ( bytestream2_get_bytes_left ( & s -> g ) < 36 ) return AVERROR_INVALIDDATA ; s -> avctx -> profile = bytestream2_get_be16u ( & s -> g ) ; s -> width = bytestream2_get_be32u ( & s -> g ) ; s -> height = bytestream2_get_be32u ( & s -> g ) ; s -> image_offset_x = bytestream2_get_be32u ( & s -> g ) ; s -> image_offset_y = bytestream2_get_be32u ( & s -> g ) ; s -> tile_width = bytestream2_get_be32u ( & s -> g ) ; s -> tile_height = bytestream2_get_be32u ( & s -> g ) ; s -> tile_offset_x = bytestream2_get_be32u ( & s -> g ) ; s -> tile_offset_y = bytestream2_get_be32u ( & s -> g ) ; ncomponents = bytestream2_get_be16u ( & s -> g ) ; <BUGS> <BUGE> if ( ncomponents <= 0 ) { av_log ( s -> avctx , AV_LOG_ERROR , "Invalid number of components: %d\\n" , s -> ncomponents ) ; return AVERROR_INVALIDDATA ; } if ( ncomponents > 4 ) { avpriv_request_sample ( s -> avctx , "Support for %d components" , s -> ncomponents ) ; return AVERROR_PATCHWELCOME ; } s -> ncomponents = ncomponents ; if ( s -> tile_width <= 0 || s -> tile_height <= 0 ) { av_log ( s -> avctx , AV_LOG_ERROR , "Invalid tile dimension %dx%d.\\n" , s -> tile_width , s -> tile_height ) ; return AVERROR_INVALIDDATA ; } if ( bytestream2_get_bytes_left ( & s -> g ) < 3 * s -> ncomponents ) return AVERROR_INVALIDDATA ; for ( i = 0 ; i < s -> ncomponents ; i ++ ) { uint8_t x = bytestream2_get_byteu ( & s -> g ) ; s -> cbps [ i ] = ( x & 0x7f ) + 1 ; s -> precision = FFMAX ( s -> cbps [ i ] , s -> precision ) ; s -> sgnd [ i ] = ! ! ( x & 0x80 ) ; s -> cdx [ i ] = bytestream2_get_byteu ( & s -> g ) ; s -> cdy [ i ] = bytestream2_get_byteu ( & s -> g ) ; if ( ! s -> cdx [ i ] || s -> cdx [ i ] == 3 || s -> cdx [ i ] > 4 || ! s -> cdy [ i ] || s -> cdy [ i ] == 3 || s -> cdy [ i ] > 4 ) { av_log ( s -> avctx , AV_LOG_ERROR , "Invalid sample separation %d/%d\\n" , s -> cdx [ i ] , s -> cdy [ i ] ) ; return AVERROR_INVALIDDATA ; } log2_chroma_wh |= s -> cdy [ i ] >> 1 << i * 4 | s -> cdx [ i ] >> 1 << i * 4 + 2 ; } s -> numXtiles = ff_jpeg2000_ceildiv ( s -> width - s -> tile_offset_x , s -> tile_width ) ; s -> numYtiles = ff_jpeg2000_ceildiv ( s -> height - s -> tile_offset_y , s -> tile_height ) ; if ( s -> numXtiles * ( uint64_t ) s -> numYtiles > INT_MAX / sizeof ( * s -> tile ) ) { s -> numXtiles = s -> numYtiles = 0 ; return AVERROR ( EINVAL ) ; } s -> tile = av_mallocz_array ( s -> numXtiles * s -> numYtiles , sizeof ( * s -> tile ) ) ; if ( ! s -> tile ) { s -> numXtiles = s -> numYtiles = 0 ; return AVERROR ( ENOMEM ) ; } for ( i = 0 ; i < s -> numXtiles * s -> numYtiles ; i ++ ) { Jpeg2000Tile * tile = s -> tile + i ; tile -> comp = av_mallocz ( s -> ncomponents * sizeof ( * tile -> comp ) ) ; if ( ! tile -> comp ) return AVERROR ( ENOMEM ) ; } s -> avctx -> width = ff_jpeg2000_ceildivpow2 ( s -> width - s -> image_offset_x , s -> reduction_factor ) ; s -> avctx -> height = ff_jpeg2000_ceildivpow2 ( s -> height - s -> image_offset_y , s -> reduction_factor ) ; if ( s -> avctx -> profile == FF_PROFILE_JPEG2000_DCINEMA_2K || s -> avctx -> profile == FF_PROFILE_JPEG2000_DCINEMA_4K ) { possible_fmts = xyz_pix_fmts ; possible_fmts_nb = FF_ARRAY_ELEMS ( xyz_pix_fmts ) ; } else { switch ( s -> colour_space ) { case 16 : possible_fmts = rgb_pix_fmts ; possible_fmts_nb = FF_ARRAY_ELEMS ( rgb_pix_fmts ) ; break ; case 17 : possible_fmts = gray_pix_fmts ; possible_fmts_nb = FF_ARRAY_ELEMS ( gray_pix_fmts ) ; break ; case 18 : possible_fmts = yuv_pix_fmts ; possible_fmts_nb = FF_ARRAY_ELEMS ( yuv_pix_fmts ) ; break ; default : possible_fmts = all_pix_fmts ; possible_fmts_nb = FF_ARRAY_ELEMS ( all_pix_fmts ) ; break ; } } for ( i = 0 ; i < possible_fmts_nb ; ++ i ) { if ( pix_fmt_match ( possible_fmts [ i ] , ncomponents , s -> precision , log2_chroma_wh , s -> pal8 ) ) { s -> avctx -> pix_fmt = possible_fmts [ i ] ; break ; } } if ( s -> avctx -> pix_fmt == AV_PIX_FMT_NONE ) { av_log ( s -> avctx , AV_LOG_ERROR , "Unknown pix_fmt, profile: %d, colour_space: %d, " "components: %d, precision: %d, " "cdx[1]: %d, cdy[1]: %d, cdx[2]: %d, cdy[2]: %d\\n" , s -> avctx -> profile , s -> colour_space , ncomponents , s -> precision , ncomponents > 2 ? s -> cdx [ 1 ] : 0 , ncomponents > 2 ? s -> cdy [ 1 ] : 0 , ncomponents > 2 ? s -> cdx [ 2 ] : 0 , ncomponents > 2 ? s -> cdy [ 2 ] : 0 ) ; } s -> avctx -> bits_per_raw_sample = s -> precision ; return 0 ; }
| <FIXS> if ( s -> image_offset_x || s -> image_offset_y ) { avpriv_request_sample ( s -> avctx , "Support for image offsets" ) ; return AVERROR_PATCHWELCOME ; } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-835 static int read_part_of_packet ( AVFormatContext * s , int64_t * pts , int * len , int * strid , int read_packet ) { AVIOContext * pb = s -> pb ; PVAContext * pvactx = s -> priv_data ; int syncword , streamid , reserved , flags , length , pts_flag ; int64_t pva_pts = AV_NOPTS_VALUE , startpos ; int ret ; recover : startpos = avio_tell ( pb ) ; syncword = avio_rb16 ( pb ) ; streamid = avio_r8 ( pb ) ; avio_r8 ( pb ) ; reserved = avio_r8 ( pb ) ; flags = avio_r8 ( pb ) ; length = avio_rb16 ( pb ) ; pts_flag = flags & 0x10 ; if ( syncword != PVA_MAGIC ) { pva_log ( s , AV_LOG_ERROR , "invalid syncword\\n" ) ; return AVERROR ( EIO ) ; } if ( streamid != PVA_VIDEO_PAYLOAD && streamid != PVA_AUDIO_PAYLOAD ) { pva_log ( s , AV_LOG_ERROR , "invalid streamid\\n" ) ; return AVERROR ( EIO ) ; } if ( reserved != 0x55 ) { pva_log ( s , AV_LOG_WARNING , "expected reserved byte to be 0x55\\n" ) ; } if ( length > PVA_MAX_PAYLOAD_LENGTH ) { pva_log ( s , AV_LOG_ERROR , "invalid payload length %u\\n" , length ) ; return AVERROR ( EIO ) ; } if ( streamid == PVA_VIDEO_PAYLOAD && pts_flag ) { pva_pts = avio_rb32 ( pb ) ; length -= 4 ; } else if ( streamid == PVA_AUDIO_PAYLOAD ) { if ( ! pvactx -> continue_pes ) { int pes_signal , pes_header_data_length , pes_packet_length , pes_flags ; unsigned char pes_header_data [ 256 ] ; pes_signal = avio_rb24 ( pb ) ; avio_r8 ( pb ) ; pes_packet_length = avio_rb16 ( pb ) ; pes_flags = avio_rb16 ( pb ) ; pes_header_data_length = avio_r8 ( pb ) ; <BUGS> <BUGE> if ( pes_signal != 1 || pes_header_data_length == 0 ) { pva_log ( s , AV_LOG_WARNING , "expected non empty signaled PES packet, " "trying to recover\\n" ) ; avio_skip ( pb , length - 9 ) ; if ( ! read_packet ) return AVERROR ( EIO ) ; goto recover ; } ret = avio_read ( pb , pes_header_data , pes_header_data_length ) ; if ( ret != pes_header_data_length ) return ret < 0 ? ret : AVERROR_INVALIDDATA ; length -= 9 + pes_header_data_length ; pes_packet_length -= 3 + pes_header_data_length ; pvactx -> continue_pes = pes_packet_length ; if ( pes_flags & 0x80 && ( pes_header_data [ 0 ] & 0xf0 ) == 0x20 ) { if ( pes_header_data_length < 5 ) { pva_log ( s , AV_LOG_ERROR , "header too short\\n" ) ; avio_skip ( pb , length ) ; return AVERROR_INVALIDDATA ; } pva_pts = ff_parse_pes_pts ( pes_header_data ) ; } } pvactx -> continue_pes -= length ; if ( pvactx -> continue_pes < 0 ) { pva_log ( s , AV_LOG_WARNING , "audio data corruption\\n" ) ; pvactx -> continue_pes = 0 ; } } if ( pva_pts != AV_NOPTS_VALUE ) av_add_index_entry ( s -> streams [ streamid - 1 ] , startpos , pva_pts , 0 , 0 , AVINDEX_KEYFRAME ) ; * pts = pva_pts ; * len = length ; * strid = streamid ; return 0 ; }
| <FIXS> if ( avio_feof ( pb ) ) { return AVERROR_EOF ; } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-190 static void addArgumentToVtab ( Parse * pParse ) { if ( pParse -> sArg . z && pParse -> pNewTable ) { const char * z = ( const char * ) pParse -> sArg . z ; int n = pParse -> sArg . n ; sqlite3 * db = pParse -> db ; <BUGS> addModuleArgument ( db , pParse -> pNewTable , sqlite3DbStrNDup ( db , z , n ) ) ; <BUGE> } }
| <FIXS> addModuleArgument ( pParse , pParse -> pNewTable , sqlite3DbStrNDup ( db , z , n ) ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-476 static void ov511_mode_init_regs ( struct sd * sd ) { struct gspca_dev * gspca_dev = ( struct gspca_dev * ) sd ; int hsegs , vsegs , packet_size , fps , needed ; int interlaced = 0 ; struct usb_host_interface * alt ; struct usb_interface * intf ; intf = usb_ifnum_to_if ( sd -> gspca_dev . dev , sd -> gspca_dev . iface ) ; alt = usb_altnum_to_altsetting ( intf , sd -> gspca_dev . alt ) ; if ( ! alt ) { gspca_err ( gspca_dev , "Couldn\'t get altsetting\\n" ) ; sd -> gspca_dev . usb_err = - EIO ; <BUGS> <BUGE> return ; } packet_size = le16_to_cpu ( alt -> endpoint [ 0 ] . desc . wMaxPacketSize ) ; reg_w ( sd , R51x_FIFO_PSIZE , packet_size >> 5 ) ; reg_w ( sd , R511_CAM_UV_EN , 0x01 ) ; reg_w ( sd , R511_SNAP_UV_EN , 0x01 ) ; reg_w ( sd , R511_SNAP_OPTS , 0x03 ) ; hsegs = ( sd -> gspca_dev . pixfmt . width >> 3 ) - 1 ; vsegs = ( sd -> gspca_dev . pixfmt . height >> 3 ) - 1 ; reg_w ( sd , R511_CAM_PXCNT , hsegs ) ; reg_w ( sd , R511_CAM_LNCNT , vsegs ) ; reg_w ( sd , R511_CAM_PXDIV , 0x00 ) ; reg_w ( sd , R511_CAM_LNDIV , 0x00 ) ; reg_w ( sd , R511_CAM_OPTS , 0x03 ) ; reg_w ( sd , R511_SNAP_PXCNT , hsegs ) ; reg_w ( sd , R511_SNAP_LNCNT , vsegs ) ; reg_w ( sd , R511_SNAP_PXDIV , 0x00 ) ; reg_w ( sd , R511_SNAP_LNDIV , 0x00 ) ; if ( frame_rate > 0 ) sd -> frame_rate = frame_rate ; switch ( sd -> sensor ) { case SEN_OV6620 : sd -> clockdiv = 3 ; break ; case SEN_OV7620 : case SEN_OV7620AE : case SEN_OV7640 : case SEN_OV7648 : case SEN_OV76BE : if ( sd -> gspca_dev . pixfmt . width == 320 ) interlaced = 1 ; case SEN_OV6630 : case SEN_OV7610 : case SEN_OV7670 : switch ( sd -> frame_rate ) { case 30 : case 25 : if ( sd -> gspca_dev . pixfmt . width != 640 ) { sd -> clockdiv = 0 ; break ; } default : sd -> clockdiv = 1 ; break ; case 10 : sd -> clockdiv = 2 ; break ; case 5 : sd -> clockdiv = 5 ; break ; } if ( interlaced ) { sd -> clockdiv = ( sd -> clockdiv + 1 ) * 2 - 1 ; if ( sd -> clockdiv > 10 ) sd -> clockdiv = 10 ; } break ; case SEN_OV8610 : sd -> clockdiv = 0 ; break ; } fps = ( interlaced ? 60 : 30 ) / ( sd -> clockdiv + 1 ) + 1 ; needed = fps * sd -> gspca_dev . pixfmt . width * sd -> gspca_dev . pixfmt . height * 3 / 2 ; if ( needed > 1000 * packet_size ) { reg_w ( sd , R511_COMP_EN , 0x07 ) ; reg_w ( sd , R511_COMP_LUT_EN , 0x03 ) ; } else { reg_w ( sd , R511_COMP_EN , 0x06 ) ; reg_w ( sd , R511_COMP_LUT_EN , 0x00 ) ; } reg_w ( sd , R51x_SYS_RESET , OV511_RESET_OMNICE ) ; reg_w ( sd , R51x_SYS_RESET , 0 ) ; }
| <FIXS> return ; } if ( alt -> desc . bNumEndpoints < 1 ) { sd -> gspca_dev . usb_err = - ENODEV ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-362 struct snd_seq_client_port * snd_seq_create_port ( struct snd_seq_client * client , int port ) { unsigned long flags ; struct snd_seq_client_port * new_port , * p ; int num = - 1 ; if ( snd_BUG_ON ( ! client ) ) return NULL ; if ( client -> num_ports >= SNDRV_SEQ_MAX_PORTS ) { pr_warn ( "ALSA: seq: too many ports for client %d\\n" , client -> number ) ; return NULL ; } new_port = kzalloc ( sizeof ( * new_port ) , GFP_KERNEL ) ; if ( ! new_port ) return NULL ; new_port -> addr . client = client -> number ; new_port -> addr . port = - 1 ; new_port -> owner = THIS_MODULE ; sprintf ( new_port -> name , "port-%d" , num ) ; snd_use_lock_init ( & new_port -> use_lock ) ; port_subs_info_init ( & new_port -> c_src ) ; port_subs_info_init ( & new_port -> c_dest ) ; <BUGS> <BUGE> num = port >= 0 ? port : 0 ; mutex_lock ( & client -> ports_mutex ) ; write_lock_irqsave ( & client -> ports_lock , flags ) ; list_for_each_entry ( p , & client -> ports_list_head , list ) { if ( p -> addr . port > num ) break ; if ( port < 0 ) num = p -> addr . port + 1 ; } list_add_tail ( & new_port -> list , & p -> list ) ; client -> num_ports ++ ; new_port -> addr . port = num ; <BUGS> <BUGE> write_unlock_irqrestore ( & client -> ports_lock , flags ) ; mutex_unlock ( & client -> ports_mutex ) ; <BUGS> sprintf ( new_port -> name , "port-%d" , num ) ; <BUGE> return new_port ; }
| <FIXS> snd_use_lock_use ( & new_port -> use_lock ) ; <FIXE> <FIXS> sprintf ( new_port -> name , "port-%d" , num ) ; <FIXE> <FIXS> <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-200 static int skcipher_recvmsg ( struct kiocb * unused , struct socket * sock , struct msghdr * msg , size_t ignored , int flags ) { struct sock * sk = sock -> sk ; struct alg_sock * ask = alg_sk ( sk ) ; struct skcipher_ctx * ctx = ask -> private ; unsigned bs = crypto_ablkcipher_blocksize ( crypto_ablkcipher_reqtfm ( & ctx -> req ) ) ; struct skcipher_sg_list * sgl ; struct scatterlist * sg ; unsigned long iovlen ; struct iovec * iov ; int err = - EAGAIN ; int used ; long copied = 0 ; lock_sock ( sk ) ; <BUGS> <BUGE> for ( iov = msg -> msg_iov , iovlen = msg -> msg_iovlen ; iovlen > 0 ; iovlen -- , iov ++ ) { unsigned long seglen = iov -> iov_len ; char __user * from = iov -> iov_base ; while ( seglen ) { sgl = list_first_entry ( & ctx -> tsgl , struct skcipher_sg_list , list ) ; sg = sgl -> sg ; while ( ! sg -> length ) sg ++ ; used = ctx -> used ; if ( ! used ) { err = skcipher_wait_for_data ( sk , flags ) ; if ( err ) goto unlock ; } used = min_t ( unsigned long , used , seglen ) ; used = af_alg_make_sg ( & ctx -> rsgl , from , used , 1 ) ; err = used ; if ( err < 0 ) goto unlock ; if ( ctx -> more || used < ctx -> used ) used -= used % bs ; err = - EINVAL ; if ( ! used ) goto free ; ablkcipher_request_set_crypt ( & ctx -> req , sg , ctx -> rsgl . sg , used , ctx -> iv ) ; err = af_alg_wait_for_completion ( ctx -> enc ? crypto_ablkcipher_encrypt ( & ctx -> req ) : crypto_ablkcipher_decrypt ( & ctx -> req ) , & ctx -> completion ) ; free : af_alg_free_sg ( & ctx -> rsgl ) ; if ( err ) goto unlock ; copied += used ; from += used ; seglen -= used ; skcipher_pull_sgl ( sk , used ) ; } } err = 0 ; unlock : skcipher_wmem_wakeup ( sk ) ; release_sock ( sk ) ; return copied ? : err ; }
| <FIXS> msg -> msg_namelen = 0 ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-476 static long btrfs_ioctl_dev_info ( struct btrfs_fs_info * fs_info , void __user * arg ) { struct btrfs_ioctl_dev_info_args * di_args ; struct btrfs_device * dev ; int ret = 0 ; char * s_uuid = NULL ; di_args = memdup_user ( arg , sizeof ( * di_args ) ) ; if ( IS_ERR ( di_args ) ) return PTR_ERR ( di_args ) ; if ( ! btrfs_is_empty_uuid ( di_args -> uuid ) ) s_uuid = di_args -> uuid ; rcu_read_lock ( ) ; dev = btrfs_find_device ( fs_info -> fs_devices , di_args -> devid , s_uuid , <BUGS> NULL ) ; <BUGE> if ( ! dev ) { ret = - ENODEV ; goto out ; } di_args -> devid = dev -> devid ; di_args -> bytes_used = btrfs_device_get_bytes_used ( dev ) ; di_args -> total_bytes = btrfs_device_get_total_bytes ( dev ) ; memcpy ( di_args -> uuid , dev -> uuid , sizeof ( di_args -> uuid ) ) ; if ( dev -> name ) { strncpy ( di_args -> path , rcu_str_deref ( dev -> name ) , sizeof ( di_args -> path ) - 1 ) ; di_args -> path [ sizeof ( di_args -> path ) - 1 ] = 0 ; } else { di_args -> path [ 0 ] = '\\0' ; } out : rcu_read_unlock ( ) ; if ( ret == 0 && copy_to_user ( arg , di_args , sizeof ( * di_args ) ) ) ret = - EFAULT ; kfree ( di_args ) ; return ret ; }
| <FIXS> NULL , true ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-285 int ocfs2_set_acl ( handle_t * handle , struct inode * inode , struct buffer_head * di_bh , int type , struct posix_acl * acl , struct ocfs2_alloc_context * meta_ac , struct ocfs2_alloc_context * data_ac ) { int name_index ; void * value = NULL ; size_t size = 0 ; int ret ; if ( S_ISLNK ( inode -> i_mode ) ) return - EOPNOTSUPP ; switch ( type ) { case ACL_TYPE_ACCESS : name_index = OCFS2_XATTR_INDEX_POSIX_ACL_ACCESS ; if ( acl ) { <BUGS> umode_t mode = inode -> i_mode ; ret = posix_acl_equiv_mode ( acl , & mode ) ; if ( ret < 0 ) <BUGE> return ret ; <BUGS> if ( ret == 0 ) acl = NULL ; <BUGE> ret = ocfs2_acl_set_mode ( inode , di_bh , handle , mode ) ; if ( ret ) return ret ; } break ; case ACL_TYPE_DEFAULT : name_index = OCFS2_XATTR_INDEX_POSIX_ACL_DEFAULT ; if ( ! S_ISDIR ( inode -> i_mode ) ) return acl ? - EACCES : 0 ; break ; default : return - EINVAL ; } if ( acl ) { value = ocfs2_acl_to_xattr ( acl , & size ) ; if ( IS_ERR ( value ) ) return ( int ) PTR_ERR ( value ) ; } if ( handle ) ret = ocfs2_xattr_set_handle ( handle , inode , di_bh , name_index , "" , value , size , 0 , meta_ac , data_ac ) ; else ret = ocfs2_xattr_set ( inode , name_index , "" , value , size , 0 ) ; kfree ( value ) ; return ret ; }
| <FIXS> umode_t mode ; ret = posix_acl_update_mode ( inode , & mode , & acl ) ; if ( ret ) <FIXE> <FIXS> <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-125 void decnet_print ( netdissect_options * ndo , register const u_char * ap , register u_int length , register u_int caplen ) { register const union routehdr * rhp ; register int mflags ; int dst , src , hops ; u_int nsplen , pktlen ; const u_char * nspp ; if ( length < sizeof ( struct shorthdr ) ) { ND_PRINT ( ( ndo , "%s" , tstr ) ) ; return ; } ND_TCHECK2 ( * ap , sizeof ( short ) ) ; pktlen = EXTRACT_LE_16BITS ( ap ) ; if ( pktlen < sizeof ( struct shorthdr ) ) { ND_PRINT ( ( ndo , "%s" , tstr ) ) ; return ; } if ( pktlen > length ) { ND_PRINT ( ( ndo , "%s" , tstr ) ) ; return ; } length = pktlen ; rhp = ( const union routehdr * ) & ( ap [ sizeof ( short ) ] ) ; ND_TCHECK ( rhp -> rh_short . sh_flags ) ; mflags = EXTRACT_LE_8BITS ( rhp -> rh_short . sh_flags ) ; if ( mflags & RMF_PAD ) { u_int padlen = mflags & RMF_PADMASK ; if ( ndo -> ndo_vflag ) ND_PRINT ( ( ndo , "[pad:%d] " , padlen ) ) ; if ( length < padlen + 2 ) { ND_PRINT ( ( ndo , "%s" , tstr ) ) ; return ; } ND_TCHECK2 ( ap [ sizeof ( short ) ] , padlen ) ; ap += padlen ; length -= padlen ; caplen -= padlen ; rhp = ( const union routehdr * ) & ( ap [ sizeof ( short ) ] ) ; <BUGS> <BUGE> mflags = EXTRACT_LE_8BITS ( rhp -> rh_short . sh_flags ) ; } if ( mflags & RMF_FVER ) { ND_PRINT ( ( ndo , "future-version-decnet" ) ) ; ND_DEFAULTPRINT ( ap , min ( length , caplen ) ) ; return ; } if ( mflags & RMF_CTLMSG ) { if ( ! print_decnet_ctlmsg ( ndo , rhp , length , caplen ) ) goto trunc ; return ; } switch ( mflags & RMF_MASK ) { case RMF_LONG : if ( length < sizeof ( struct longhdr ) ) { ND_PRINT ( ( ndo , "%s" , tstr ) ) ; return ; } ND_TCHECK ( rhp -> rh_long ) ; dst = EXTRACT_LE_16BITS ( rhp -> rh_long . lg_dst . dne_remote . dne_nodeaddr ) ; src = EXTRACT_LE_16BITS ( rhp -> rh_long . lg_src . dne_remote . dne_nodeaddr ) ; hops = EXTRACT_LE_8BITS ( rhp -> rh_long . lg_visits ) ; nspp = & ( ap [ sizeof ( short ) + sizeof ( struct longhdr ) ] ) ; nsplen = length - sizeof ( struct longhdr ) ; break ; case RMF_SHORT : ND_TCHECK ( rhp -> rh_short ) ; dst = EXTRACT_LE_16BITS ( rhp -> rh_short . sh_dst ) ; src = EXTRACT_LE_16BITS ( rhp -> rh_short . sh_src ) ; hops = ( EXTRACT_LE_8BITS ( rhp -> rh_short . sh_visits ) & VIS_MASK ) + 1 ; nspp = & ( ap [ sizeof ( short ) + sizeof ( struct shorthdr ) ] ) ; nsplen = length - sizeof ( struct shorthdr ) ; break ; default : ND_PRINT ( ( ndo , "unknown message flags under mask" ) ) ; ND_DEFAULTPRINT ( ( const u_char * ) ap , min ( length , caplen ) ) ; return ; } ND_PRINT ( ( ndo , "%s > %s %d " , dnaddr_string ( ndo , src ) , dnaddr_string ( ndo , dst ) , pktlen ) ) ; if ( ndo -> ndo_vflag ) { if ( mflags & RMF_RQR ) ND_PRINT ( ( ndo , "RQR " ) ) ; if ( mflags & RMF_RTS ) ND_PRINT ( ( ndo , "RTS " ) ) ; if ( mflags & RMF_IE ) ND_PRINT ( ( ndo , "IE " ) ) ; ND_PRINT ( ( ndo , "%d hops " , hops ) ) ; } if ( ! print_nsp ( ndo , nspp , nsplen ) ) goto trunc ; return ; trunc : ND_PRINT ( ( ndo , "%s" , tstr ) ) ; return ; }
| <FIXS> ND_TCHECK ( rhp -> rh_short . sh_flags ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 enum nss_status _nss_mymachines_getpwnam_r ( const char * name , struct passwd * pwd , char * buffer , size_t buflen , int * errnop ) { _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL ; _cleanup_bus_message_unref_ sd_bus_message * reply = NULL ; _cleanup_bus_flush_close_unref_ sd_bus * bus = NULL ; const char * p , * e , * machine ; uint32_t mapped ; uid_t uid ; size_t l ; int r ; assert ( name ) ; assert ( pwd ) ; p = startswith ( name , "vu-" ) ; if ( ! p ) goto not_found ; e = strrchr ( p , '-' ) ; if ( ! e || e == p ) <BUGS> <BUGE> goto not_found ; r = parse_uid ( e + 1 , & uid ) ; if ( r < 0 ) goto not_found ; machine = strndupa ( p , e - p ) ; if ( ! machine_name_is_valid ( machine ) ) goto not_found ; r = sd_bus_open_system ( & bus ) ; if ( r < 0 ) goto fail ; r = sd_bus_call_method ( bus , "org.freedesktop.machine1" , "/org/freedesktop/machine1" , "org.freedesktop.machine1.Manager" , "MapFromMachineUser" , & error , & reply , "su" , machine , ( uint32_t ) uid ) ; if ( r < 0 ) { if ( sd_bus_error_has_name ( & error , BUS_ERROR_NO_SUCH_USER_MAPPING ) ) goto not_found ; goto fail ; } r = sd_bus_message_read ( reply , "u" , & mapped ) ; if ( r < 0 ) goto fail ; l = strlen ( name ) ; if ( buflen < l + 1 ) { * errnop = ENOMEM ; return NSS_STATUS_TRYAGAIN ; } memcpy ( buffer , name , l + 1 ) ; pwd -> pw_name = buffer ; pwd -> pw_uid = mapped ; pwd -> pw_gid = 65534 ; pwd -> pw_gecos = buffer ; pwd -> pw_passwd = ( char * ) "*" ; pwd -> pw_dir = ( char * ) "/" ; pwd -> pw_shell = ( char * ) "/sbin/nologin" ; * errnop = 0 ; return NSS_STATUS_SUCCESS ; not_found : * errnop = 0 ; return NSS_STATUS_NOTFOUND ; fail : * errnop = - r ; return NSS_STATUS_UNAVAIL ; }
| <FIXS> goto not_found ; if ( e - p > HOST_NAME_MAX - 1 ) <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-000 int main ( int argc , char * argv [ ] ) { int result ; int infoOnly = 0 ; int writeToStdio = 0 ; int readFromStdin = 0 ; int object_type = LC ; int def_srate = 0 ; int downMatrix = 0 ; int format = 1 ; int outputFormat = FAAD_FMT_16BIT ; int outfile_set = 0 ; int adts_out = 0 ; int old_format = 0 ; int showHelp = 0 ; int mp4file = 0 ; int noGapless = 0 ; char * fnp ; <BUGS> char aacFileName [ 255 ] ; char audioFileName [ 255 ] ; char adtsFileName [ 255 ] ; <BUGE> unsigned char header [ 8 ] ; float length = 0 ; FILE * hMP4File ; # ifdef _WIN32 long begin ; # else clock_t begin ; # endif unsigned long cap = NeAACDecGetCapabilities ( ) ; progName = argv [ 0 ] ; while ( 1 ) { int c = - 1 ; int option_index = 0 ; static struct option long_options [ ] = { { "quiet" , 0 , 0 , 'q' } , { "outfile" , 0 , 0 , 'o' } , { "adtsout" , 0 , 0 , 'a' } , { "oldformat" , 0 , 0 , 't' } , { "format" , 0 , 0 , 'f' } , { "bits" , 0 , 0 , 'b' } , { "samplerate" , 0 , 0 , 's' } , { "objecttype" , 0 , 0 , 'l' } , { "downmix" , 0 , 0 , 'd' } , { "info" , 0 , 0 , 'i' } , { "stdio" , 0 , 0 , 'w' } , { "stdio" , 0 , 0 , 'g' } , { "help" , 0 , 0 , 'h' } , { 0 , 0 , 0 , 0 } } ; c = getopt_long ( argc , argv , "o:a:s:f:b:l:wgdhitq" , long_options , & option_index ) ; if ( c == - 1 ) break ; switch ( c ) { case 'o' : if ( optarg ) { outfile_set = 1 ; <BUGS> <BUGE> strcpy ( audioFileName , optarg ) ; } break ; case 'a' : if ( optarg ) { adts_out = 1 ; <BUGS> <BUGE> strcpy ( adtsFileName , optarg ) ; } break ; case 's' : if ( optarg ) { char dr [ 10 ] ; if ( sscanf ( optarg , "%s" , dr ) < 1 ) { def_srate = 0 ; } else { def_srate = atoi ( dr ) ; } } break ; case 'f' : if ( optarg ) { char dr [ 10 ] ; if ( sscanf ( optarg , "%s" , dr ) < 1 ) { format = 1 ; } else { format = atoi ( dr ) ; if ( ( format < 1 ) || ( format > 2 ) ) showHelp = 1 ; } } break ; case 'b' : if ( optarg ) { char dr [ 10 ] ; if ( sscanf ( optarg , "%s" , dr ) < 1 ) { outputFormat = FAAD_FMT_16BIT ; } else { outputFormat = atoi ( dr ) ; if ( ( outputFormat < 1 ) || ( outputFormat > 5 ) ) showHelp = 1 ; } } break ; case 'l' : if ( optarg ) { char dr [ 10 ] ; if ( sscanf ( optarg , "%s" , dr ) < 1 ) { object_type = LC ; } else { object_type = atoi ( dr ) ; if ( ( object_type != LC ) && ( object_type != MAIN ) && ( object_type != LTP ) && ( object_type != LD ) ) { showHelp = 1 ; } } } break ; case 't' : old_format = 1 ; break ; case 'd' : downMatrix = 1 ; break ; case 'w' : writeToStdio = 1 ; break ; case 'g' : noGapless = 1 ; break ; case 'i' : infoOnly = 1 ; break ; case 'h' : showHelp = 1 ; break ; case 'q' : quiet = 1 ; break ; default : break ; } } faad_fprintf ( stderr , " *********** Ahead Software MPEG-4 AAC Decoder V%s ******************\\n\\n" , FAAD2_VERSION ) ; faad_fprintf ( stderr , " Build: %s\\n" , __DATE__ ) ; faad_fprintf ( stderr , " Copyright 2002-2004: Ahead Software AG\\n" ) ; faad_fprintf ( stderr , " http://www.audiocoding.com\\n" ) ; if ( cap & FIXED_POINT_CAP ) faad_fprintf ( stderr , " Fixed point version\\n" ) ; else faad_fprintf ( stderr , " Floating point version\\n" ) ; faad_fprintf ( stderr , "\\n" ) ; faad_fprintf ( stderr , " This program is free software; you can redistribute it and/or modify\\n" ) ; faad_fprintf ( stderr , " it under the terms of the GNU General Public License.\\n" ) ; faad_fprintf ( stderr , "\\n" ) ; faad_fprintf ( stderr , " **************************************************************************\\n\\n" ) ; if ( ( ( argc - optind ) < 1 ) || showHelp ) { usage ( ) ; return 1 ; } # if 0 if ( writeToStdio == 1 ) { format = 2 ; } # endif <BUGS> <BUGE> strcpy ( aacFileName , argv [ optind ] ) ; # ifdef _WIN32 begin = GetTickCount ( ) ; # else begin = clock ( ) ; # endif if ( ! writeToStdio && ! outfile_set ) { <BUGS> <BUGE> strcpy ( audioFileName , aacFileName ) ; fnp = ( char * ) strrchr ( audioFileName , '.' ) ; if ( fnp ) fnp [ 0 ] = '\\0' ; strcat ( audioFileName , file_ext [ format ] ) ; } if ( 0 == strcmp ( aacFileName , "-" ) ) { faad_fprintf ( stderr , "Reading from stdin: %s\\n" , aacFileName ) ; readFromStdin = 1 ; hMP4File = stdin ; # ifdef _WIN32 setmode ( fileno ( stdin ) , O_BINARY ) ; # endif } else { mp4file = 0 ; hMP4File = fopen ( aacFileName , "rb" ) ; if ( ! hMP4File ) { faad_fprintf ( stderr , "Error opening file: %s\\n" , aacFileName ) ; return 1 ; } } fread ( header , 1 , 8 , hMP4File ) ; if ( ! readFromStdin ) fclose ( hMP4File ) ; if ( header [ 4 ] == 'f' && header [ 5 ] == 't' && header [ 6 ] == 'y' && header [ 7 ] == 'p' ) mp4file = 1 ; if ( mp4file ) { result = decodeMP4file ( aacFileName , audioFileName , adtsFileName , writeToStdio , outputFormat , format , downMatrix , noGapless , infoOnly , adts_out , & length ) ; } else { if ( readFromStdin == 1 ) { ungetc ( header [ 7 ] , hMP4File ) ; ungetc ( header [ 6 ] , hMP4File ) ; ungetc ( header [ 5 ] , hMP4File ) ; ungetc ( header [ 4 ] , hMP4File ) ; ungetc ( header [ 3 ] , hMP4File ) ; ungetc ( header [ 2 ] , hMP4File ) ; ungetc ( header [ 1 ] , hMP4File ) ; ungetc ( header [ 0 ] , hMP4File ) ; } result = decodeAACfile ( aacFileName , audioFileName , adtsFileName , writeToStdio , def_srate , object_type , outputFormat , format , downMatrix , infoOnly , adts_out , old_format , & length ) ; } <BUGS> <BUGE> if ( ! result && ! infoOnly ) { # ifdef _WIN32 float dec_length = ( float ) ( GetTickCount ( ) - begin ) / 1000.0 ; SetConsoleTitle ( "FAAD" ) ; # else float dec_length = ( float ) ( clock ( ) - begin ) / ( float ) CLOCKS_PER_SEC ; # endif faad_fprintf ( stderr , "Decoding %s took: %5.2f sec. %5.2fx real-time.\\n" , aacFileName , dec_length , length / dec_length ) ; } <BUGS> <BUGE> return 0 ; }
| <FIXS> char * aacFileName = NULL ; char * audioFileName = NULL ; char * adtsFileName = NULL ; <FIXE> <FIXS> audioFileName = ( char * ) malloc ( sizeof ( char ) * ( strlen ( optarg ) + 1 ) ) ; if ( audioFileName == NULL ) { faad_fprintf ( stderr , "Error allocating memory for audioFileName.\\n" ) ; return 1 ; } <FIXE> <FIXS> adtsFileName = ( char * ) malloc ( sizeof ( char ) * ( strlen ( optarg ) + 1 ) ) ; if ( adtsFileName == NULL ) { faad_fprintf ( stderr , "Error allocating memory for adtsFileName.\\n" ) ; return 1 ; } <FIXE> <FIXS> aacFileName = ( char * ) malloc ( sizeof ( char ) * ( strlen ( argv [ optind ] ) + 1 ) ) ; if ( aacFileName == NULL ) { faad_fprintf ( stderr , "Error allocating memory for aacFileName.\\n" ) ; return 1 ; } <FIXE> <FIXS> audioFileName = ( char * ) malloc ( sizeof ( char ) * ( strlen ( aacFileName ) + strlen ( file_ext [ format ] ) + 1 ) ) ; if ( audioFileName == NULL ) { faad_fprintf ( stderr , "Error allocating memory for audioFileName.\\n" ) ; return 1 ; } <FIXE> <FIXS> if ( audioFileName != NULL ) free ( audioFileName ) ; if ( adtsFileName != NULL ) free ( adtsFileName ) ; <FIXE> <FIXS> if ( aacFileName != NULL ) free ( aacFileName ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-476 static void put_crypt_info ( struct fscrypt_info * ci ) { if ( ! ci ) return ; <BUGS> key_put ( ci -> ci_keyring_key ) ; <BUGE> crypto_free_skcipher ( ci -> ci_ctfm ) ; kmem_cache_free ( fscrypt_info_cachep , ci ) ; }
| <FIXS> <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-134 static rsRetVal createSocket ( instanceConf_t * info , void * * sock ) { int rv ; sublist * sub ; * sock = zsocket_new ( s_context , info -> type ) ; if ( ! sock ) { errmsg . LogError ( 0 , RS_RET_INVALID_PARAMS , "zsocket_new failed: %s, for type %d" , zmq_strerror ( errno ) , info -> type ) ; return RS_RET_INVALID_PARAMS ; } DBGPRINTF ( "imzmq3: socket of type %d created successfully\\n" , info -> type ) if ( info -> identity ) zsocket_set_identity ( * sock , info -> identity ) ; if ( info -> sndBuf > - 1 ) zsocket_set_sndbuf ( * sock , info -> sndBuf ) ; if ( info -> rcvBuf > - 1 ) zsocket_set_rcvbuf ( * sock , info -> rcvBuf ) ; if ( info -> linger > - 1 ) zsocket_set_linger ( * sock , info -> linger ) ; if ( info -> backlog > - 1 ) zsocket_set_backlog ( * sock , info -> backlog ) ; if ( info -> sndTimeout > - 1 ) zsocket_set_sndtimeo ( * sock , info -> sndTimeout ) ; if ( info -> rcvTimeout > - 1 ) zsocket_set_rcvtimeo ( * sock , info -> rcvTimeout ) ; if ( info -> maxMsgSize > - 1 ) zsocket_set_maxmsgsize ( * sock , info -> maxMsgSize ) ; if ( info -> rate > - 1 ) zsocket_set_rate ( * sock , info -> rate ) ; if ( info -> recoveryIVL > - 1 ) zsocket_set_recovery_ivl ( * sock , info -> recoveryIVL ) ; if ( info -> multicastHops > - 1 ) zsocket_set_multicast_hops ( * sock , info -> multicastHops ) ; if ( info -> reconnectIVL > - 1 ) zsocket_set_reconnect_ivl ( * sock , info -> reconnectIVL ) ; if ( info -> reconnectIVLMax > - 1 ) zsocket_set_reconnect_ivl_max ( * sock , info -> reconnectIVLMax ) ; if ( info -> ipv4Only > - 1 ) zsocket_set_ipv4only ( * sock , info -> ipv4Only ) ; if ( info -> affinity > - 1 ) zsocket_set_affinity ( * sock , info -> affinity ) ; if ( info -> sndHWM > - 1 ) zsocket_set_sndhwm ( * sock , info -> sndHWM ) ; if ( info -> rcvHWM > - 1 ) zsocket_set_rcvhwm ( * sock , info -> rcvHWM ) ; if ( info -> type == ZMQ_SUB ) { for ( sub = info -> subscriptions ; sub != NULL ; sub = sub -> next ) { zsocket_set_subscribe ( * sock , sub -> subscribe ) ; } } if ( info -> action == ACTION_CONNECT ) { <BUGS> rv = zsocket_connect ( * sock , info -> description ) ; <BUGE> if ( rv == - 1 ) { errmsg . LogError ( 0 , RS_RET_INVALID_PARAMS , "zmq_connect using %s failed: %s" , info -> description , zmq_strerror ( errno ) ) ; return RS_RET_INVALID_PARAMS ; } DBGPRINTF ( "imzmq3: connect for %s successful\\n" , info -> description ) ; } else { <BUGS> rv = zsocket_bind ( * sock , info -> description ) ; <BUGE> if ( rv == - 1 ) { errmsg . LogError ( 0 , RS_RET_INVALID_PARAMS , "zmq_bind using %s failed: %s" , info -> description , zmq_strerror ( errno ) ) ; return RS_RET_INVALID_PARAMS ; } DBGPRINTF ( "imzmq3: bind for %s successful\\n" , info -> description ) ; } return RS_RET_OK ; }
| <FIXS> rv = zsocket_connect ( * sock , "%s" , info -> description ) ; <FIXE> <FIXS> rv = zsocket_bind ( * sock , "%s" , info -> description ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-125 static struct sk_buff * ipv6_gso_segment ( struct sk_buff * skb , netdev_features_t features ) { struct sk_buff * segs = ERR_PTR ( - EINVAL ) ; struct ipv6hdr * ipv6h ; const struct net_offload * ops ; int proto ; struct frag_hdr * fptr ; unsigned int unfrag_ip6hlen ; unsigned int payload_len ; u8 * prevhdr ; int offset = 0 ; bool encap , udpfrag ; int nhoff ; bool gso_partial ; skb_reset_network_header ( skb ) ; nhoff = skb_network_header ( skb ) - skb_mac_header ( skb ) ; if ( unlikely ( ! pskb_may_pull ( skb , sizeof ( * ipv6h ) ) ) ) goto out ; encap = SKB_GSO_CB ( skb ) -> encap_level > 0 ; if ( encap ) features &= skb -> dev -> hw_enc_features ; SKB_GSO_CB ( skb ) -> encap_level += sizeof ( * ipv6h ) ; ipv6h = ipv6_hdr ( skb ) ; __skb_pull ( skb , sizeof ( * ipv6h ) ) ; segs = ERR_PTR ( - EPROTONOSUPPORT ) ; proto = ipv6_gso_pull_exthdrs ( skb , ipv6h -> nexthdr ) ; if ( skb -> encapsulation && skb_shinfo ( skb ) -> gso_type & ( SKB_GSO_IPXIP4 | SKB_GSO_IPXIP6 ) ) udpfrag = proto == IPPROTO_UDP && encap ; else udpfrag = proto == IPPROTO_UDP && ! skb -> encapsulation ; ops = rcu_dereference ( inet6_offloads [ proto ] ) ; if ( likely ( ops && ops -> callbacks . gso_segment ) ) { skb_reset_transport_header ( skb ) ; segs = ops -> callbacks . gso_segment ( skb , features ) ; } if ( IS_ERR_OR_NULL ( segs ) ) goto out ; gso_partial = ! ! ( skb_shinfo ( segs ) -> gso_type & SKB_GSO_PARTIAL ) ; for ( skb = segs ; skb ; skb = skb -> next ) { ipv6h = ( struct ipv6hdr * ) ( skb_mac_header ( skb ) + nhoff ) ; if ( gso_partial ) payload_len = skb_shinfo ( skb ) -> gso_size + SKB_GSO_CB ( skb ) -> data_offset + skb -> head - ( unsigned char * ) ( ipv6h + 1 ) ; else payload_len = skb -> len - nhoff - sizeof ( * ipv6h ) ; ipv6h -> payload_len = htons ( payload_len ) ; skb -> network_header = ( u8 * ) ipv6h - skb -> head ; if ( udpfrag ) { unfrag_ip6hlen = ip6_find_1stfragopt ( skb , & prevhdr ) ; <BUGS> <BUGE> fptr = ( struct frag_hdr * ) ( ( u8 * ) ipv6h + unfrag_ip6hlen ) ; fptr -> frag_off = htons ( offset ) ; if ( skb -> next ) fptr -> frag_off |= htons ( IP6_MF ) ; offset += ( ntohs ( ipv6h -> payload_len ) - sizeof ( struct frag_hdr ) ) ; } if ( encap ) skb_reset_inner_headers ( skb ) ; } out : return segs ; }
| <FIXS> if ( unfrag_ip6hlen < 0 ) return ERR_PTR ( unfrag_ip6hlen ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-416 <BUGS> void generic_pipe_buf_get ( struct pipe_inode_info * pipe , struct pipe_buffer * buf ) <BUGE> { <BUGS> get_page ( buf -> page ) ; <BUGE> }
| <FIXS> bool generic_pipe_buf_get ( struct pipe_inode_info * pipe , struct pipe_buffer * buf ) <FIXE> <FIXS> return try_get_page ( buf -> page ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-000 struct sk_buff * nf_ct_frag6_gather ( struct sk_buff * skb , u32 user ) { struct sk_buff * clone ; struct net_device * dev = skb -> dev ; struct frag_hdr * fhdr ; struct nf_ct_frag6_queue * fq ; struct ipv6hdr * hdr ; int fhoff , nhoff ; u8 prevhdr ; struct sk_buff * ret_skb = NULL ; if ( ipv6_hdr ( skb ) -> payload_len == 0 ) { pr_debug ( "payload len = 0\\n" ) ; return skb ; } if ( find_prev_fhdr ( skb , & prevhdr , & nhoff , & fhoff ) < 0 ) return skb ; clone = skb_clone ( skb , GFP_ATOMIC ) ; if ( clone == NULL ) { pr_debug ( "Can\'t clone skb\\n" ) ; return skb ; } NFCT_FRAG6_CB ( clone ) -> orig = skb ; if ( ! pskb_may_pull ( clone , fhoff + sizeof ( * fhdr ) ) ) { pr_debug ( "message is too short.\\n" ) ; goto ret_orig ; } skb_set_transport_header ( clone , fhoff ) ; hdr = ipv6_hdr ( clone ) ; fhdr = ( struct frag_hdr * ) skb_transport_header ( clone ) ; <BUGS> if ( ! ( fhdr -> frag_off & htons ( 0xFFF9 ) ) ) { pr_debug ( "Invalid fragment offset\\n" ) ; goto ret_orig ; } <BUGE> if ( atomic_read ( & nf_init_frags . mem ) > nf_init_frags . high_thresh ) nf_ct_frag6_evictor ( ) ; fq = fq_find ( fhdr -> identification , user , & hdr -> saddr , & hdr -> daddr ) ; if ( fq == NULL ) { pr_debug ( "Can\'t find and can\'t create new queue\\n" ) ; goto ret_orig ; } spin_lock_bh ( & fq -> q . lock ) ; if ( nf_ct_frag6_queue ( fq , clone , fhdr , nhoff ) < 0 ) { spin_unlock_bh ( & fq -> q . lock ) ; pr_debug ( "Can\'t insert skb to queue\\n" ) ; fq_put ( fq ) ; goto ret_orig ; } if ( fq -> q . last_in == ( INET_FRAG_FIRST_IN | INET_FRAG_LAST_IN ) && fq -> q . meat == fq -> q . len ) { ret_skb = nf_ct_frag6_reasm ( fq , dev ) ; if ( ret_skb == NULL ) pr_debug ( "Can\'t reassemble fragmented packets\\n" ) ; } spin_unlock_bh ( & fq -> q . lock ) ; fq_put ( fq ) ; return ret_skb ; ret_orig : kfree_skb ( clone ) ; return skb ; }
| <FIXS> <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static av_cold int xpm_decode_close ( AVCodecContext * avctx ) { XPMDecContext * x = avctx -> priv_data ; av_freep ( & x -> pixels ) ; <BUGS> <BUGE> return 0 ; }
| <FIXS> av_freep ( & x -> buf ) ; x -> buf_size = 0 ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-125 static const u_char * ikev2_t_print ( netdissect_options * ndo , int tcount , const struct isakmp_gen * ext , u_int item_len , const u_char * ep ) { const struct ikev2_t * p ; struct ikev2_t t ; uint16_t t_id ; const u_char * cp ; const char * idstr ; const struct attrmap * map ; size_t nmap ; const u_char * ep2 ; p = ( const struct ikev2_t * ) ext ; ND_TCHECK ( * p ) ; UNALIGNED_MEMCPY ( & t , ext , sizeof ( t ) ) ; ikev2_pay_print ( ndo , NPSTR ( ISAKMP_NPTYPE_T ) , t . h . critical ) ; t_id = ntohs ( t . t_id ) ; map = NULL ; nmap = 0 ; switch ( t . t_type ) { case IV2_T_ENCR : idstr = STR_OR_ID ( t_id , esp_p_map ) ; map = encr_t_map ; nmap = sizeof ( encr_t_map ) / sizeof ( encr_t_map [ 0 ] ) ; break ; case IV2_T_PRF : idstr = STR_OR_ID ( t_id , prf_p_map ) ; break ; case IV2_T_INTEG : idstr = STR_OR_ID ( t_id , integ_p_map ) ; break ; case IV2_T_DH : idstr = STR_OR_ID ( t_id , dh_p_map ) ; break ; case IV2_T_ESN : idstr = STR_OR_ID ( t_id , esn_p_map ) ; break ; default : idstr = NULL ; break ; } if ( idstr ) ND_PRINT ( ( ndo , " #%u type=%s id=%s " , tcount , STR_OR_ID ( t . t_type , ikev2_t_type_map ) , idstr ) ) ; else ND_PRINT ( ( ndo , " #%u type=%s id=%u " , tcount , STR_OR_ID ( t . t_type , ikev2_t_type_map ) , t . t_id ) ) ; cp = ( const u_char * ) ( p + 1 ) ; ep2 = ( const u_char * ) p + item_len ; while ( cp < ep && cp < ep2 ) { if ( map && nmap ) { <BUGS> cp = ikev1_attrmap_print ( ndo , cp , ( ep < ep2 ) ? ep : ep2 , map , nmap ) ; <BUGE> } else <BUGS> cp = ikev1_attr_print ( ndo , cp , ( ep < ep2 ) ? ep : ep2 ) ; <BUGE> } if ( ep < ep2 ) ND_PRINT ( ( ndo , "..." ) ) ; return cp ; trunc : ND_PRINT ( ( ndo , " [|%s]" , NPSTR ( ISAKMP_NPTYPE_T ) ) ) ; return NULL ; }
| <FIXS> cp = ikev1_attrmap_print ( ndo , cp , ep2 , map , nmap ) ; <FIXE> <FIXS> cp = ikev1_attr_print ( ndo , cp , ep2 ) ; if ( cp == NULL ) goto trunc ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-436 static void flatpak_proxy_client_init ( FlatpakProxyClient * client ) { init_side ( client , & client -> client_side ) ; init_side ( client , & client -> bus_side ) ; <BUGS> client -> auth_end_offset = AUTH_END_INIT_OFFSET ; <BUGE> client -> rewrite_reply = g_hash_table_new_full ( g_direct_hash , g_direct_equal , NULL , g_object_unref ) ; client -> get_owner_reply = g_hash_table_new_full ( g_direct_hash , g_direct_equal , NULL , g_free ) ; client -> unique_id_policy = g_hash_table_new_full ( g_str_hash , g_str_equal , g_free , NULL ) ; }
| <FIXS> client -> auth_buffer = g_byte_array_new ( ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-787 static void write_version ( FILE * fp , const char * fname , const char * dirname , xref_t * xref ) { long start ; char * c , * new_fname , data ; FILE * new_fp ; start = ftell ( fp ) ; if ( ( c = strstr ( fname , ".pdf" ) ) ) * c = '\\0' ; <BUGS> new_fname = malloc ( strlen ( fname ) + strlen ( dirname ) + 16 ) ; <BUGE> snprintf ( new_fname , strlen ( fname ) + strlen ( dirname ) + 16 , "%s/%s-version-%d.pdf" , dirname , fname , xref -> version ) ; if ( ! ( new_fp = fopen ( new_fname , "w" ) ) ) { ERR ( "Could not create file \'%s\'\\n" , new_fname ) ; fseek ( fp , start , SEEK_SET ) ; free ( new_fname ) ; return ; } fseek ( fp , 0 , SEEK_SET ) ; while ( fread ( & data , 1 , 1 , fp ) ) fwrite ( & data , 1 , 1 , new_fp ) ; fprintf ( new_fp , "\\r\\nstartxref\\r\\n%ld\\r\\n%%%%EOF" , xref -> start ) ; fclose ( new_fp ) ; free ( new_fname ) ; fseek ( fp , start , SEEK_SET ) ; }
| <FIXS> new_fname = safe_calloc ( strlen ( fname ) + strlen ( dirname ) + 16 ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-264 int generic_permission ( struct inode * inode , int mask ) { int ret ; ret = acl_permission_check ( inode , mask ) ; if ( ret != - EACCES ) return ret ; if ( S_ISDIR ( inode -> i_mode ) ) { <BUGS> if ( inode_capable ( inode , CAP_DAC_OVERRIDE ) ) <BUGE> return 0 ; if ( ! ( mask & MAY_WRITE ) ) <BUGS> if ( inode_capable ( inode , CAP_DAC_READ_SEARCH ) ) <BUGE> return 0 ; return - EACCES ; } if ( ! ( mask & MAY_EXEC ) || ( inode -> i_mode & S_IXUGO ) ) <BUGS> if ( inode_capable ( inode , CAP_DAC_OVERRIDE ) ) <BUGE> return 0 ; mask &= MAY_READ | MAY_WRITE | MAY_EXEC ; if ( mask == MAY_READ ) <BUGS> if ( inode_capable ( inode , CAP_DAC_READ_SEARCH ) ) <BUGE> return 0 ; return - EACCES ; }
| <FIXS> if ( capable_wrt_inode_uidgid ( inode , CAP_DAC_OVERRIDE ) ) <FIXE> <FIXS> if ( capable_wrt_inode_uidgid ( inode , CAP_DAC_READ_SEARCH ) ) <FIXE> <FIXS> if ( capable_wrt_inode_uidgid ( inode , CAP_DAC_OVERRIDE ) ) <FIXE> <FIXS> if ( capable_wrt_inode_uidgid ( inode , CAP_DAC_READ_SEARCH ) ) <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-189 Pairs * hstoreArrayToPairs ( ArrayType * a , int * npairs ) { Datum * key_datums ; bool * key_nulls ; int key_count ; Pairs * key_pairs ; int bufsiz ; int i , j ; deconstruct_array ( a , TEXTOID , - 1 , false , 'i' , & key_datums , & key_nulls , & key_count ) ; if ( key_count == 0 ) { * npairs = 0 ; return NULL ; } <BUGS> <BUGE> key_pairs = palloc ( sizeof ( Pairs ) * key_count ) ; for ( i = 0 , j = 0 ; i < key_count ; i ++ ) { if ( ! key_nulls [ i ] ) { key_pairs [ j ] . key = VARDATA ( key_datums [ i ] ) ; key_pairs [ j ] . keylen = VARSIZE ( key_datums [ i ] ) - VARHDRSZ ; key_pairs [ j ] . val = NULL ; key_pairs [ j ] . vallen = 0 ; key_pairs [ j ] . needfree = 0 ; key_pairs [ j ] . isnull = 1 ; j ++ ; } } * npairs = hstoreUniquePairs ( key_pairs , j , & bufsiz ) ; return key_pairs ; }
| <FIXS> if ( key_count > MaxAllocSize / sizeof ( Pairs ) ) ereport ( ERROR , ( errcode ( ERRCODE_PROGRAM_LIMIT_EXCEEDED ) , errmsg ( "number of pairs (%d) exceeds the maximum allowed (%d)" , key_count , ( int ) ( MaxAllocSize / sizeof ( Pairs ) ) ) ) ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-264 int inode_change_ok ( const struct inode * inode , struct iattr * attr ) { unsigned int ia_valid = attr -> ia_valid ; if ( ia_valid & ATTR_SIZE ) { int error = inode_newsize_ok ( inode , attr -> ia_size ) ; if ( error ) return error ; } if ( ia_valid & ATTR_FORCE ) return 0 ; if ( ( ia_valid & ATTR_UID ) && ( ! uid_eq ( current_fsuid ( ) , inode -> i_uid ) || ! uid_eq ( attr -> ia_uid , inode -> i_uid ) ) && <BUGS> ! inode_capable ( inode , CAP_CHOWN ) ) <BUGE> return - EPERM ; if ( ( ia_valid & ATTR_GID ) && ( ! uid_eq ( current_fsuid ( ) , inode -> i_uid ) || ( ! in_group_p ( attr -> ia_gid ) && ! gid_eq ( attr -> ia_gid , inode -> i_gid ) ) ) && <BUGS> ! inode_capable ( inode , CAP_CHOWN ) ) <BUGE> return - EPERM ; if ( ia_valid & ATTR_MODE ) { if ( ! inode_owner_or_capable ( inode ) ) return - EPERM ; if ( ! in_group_p ( ( ia_valid & ATTR_GID ) ? attr -> ia_gid : inode -> i_gid ) && <BUGS> ! inode_capable ( inode , CAP_FSETID ) ) <BUGE> attr -> ia_mode &= ~ S_ISGID ; } if ( ia_valid & ( ATTR_MTIME_SET | ATTR_ATIME_SET | ATTR_TIMES_SET ) ) { if ( ! inode_owner_or_capable ( inode ) ) return - EPERM ; } return 0 ; }
| <FIXS> ! capable_wrt_inode_uidgid ( inode , CAP_CHOWN ) ) <FIXE> <FIXS> ! capable_wrt_inode_uidgid ( inode , CAP_CHOWN ) ) <FIXE> <FIXS> ! capable_wrt_inode_uidgid ( inode , CAP_FSETID ) ) <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-284 static bool has_byte ( const eager_reader_t * reader ) { assert ( reader != NULL ) ; fd_set read_fds ; FD_ZERO ( & read_fds ) ; FD_SET ( reader -> bytes_available_fd , & read_fds ) ; struct timeval timeout ; timeout . tv_sec = 0 ; timeout . tv_usec = 0 ; <BUGS> select ( reader -> bytes_available_fd + 1 , & read_fds , NULL , NULL , & timeout ) ; <BUGE> return FD_ISSET ( reader -> bytes_available_fd , & read_fds ) ; }
| <FIXS> TEMP_FAILURE_RETRY ( select ( reader -> bytes_available_fd + 1 , & read_fds , NULL , NULL , & timeout ) ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-362 static int do_ip_setsockopt ( struct sock * sk , int level , int optname , char __user * optval , unsigned int optlen ) { struct inet_sock * inet = inet_sk ( sk ) ; int val = 0 , err ; if ( ( ( 1 << optname ) & ( ( 1 << IP_PKTINFO ) | ( 1 << IP_RECVTTL ) | ( 1 << IP_RECVOPTS ) | ( 1 << IP_RECVTOS ) | ( 1 << IP_RETOPTS ) | ( 1 << IP_TOS ) | ( 1 << IP_TTL ) | ( 1 << IP_HDRINCL ) | ( 1 << IP_MTU_DISCOVER ) | ( 1 << IP_RECVERR ) | ( 1 << IP_ROUTER_ALERT ) | ( 1 << IP_FREEBIND ) | ( 1 << IP_PASSSEC ) | ( 1 << IP_TRANSPARENT ) | ( 1 << IP_MINTTL ) | ( 1 << IP_NODEFRAG ) ) ) || optname == IP_MULTICAST_TTL || optname == IP_MULTICAST_ALL || optname == IP_MULTICAST_LOOP || optname == IP_RECVORIGDSTADDR ) { if ( optlen >= sizeof ( int ) ) { if ( get_user ( val , ( int __user * ) optval ) ) return - EFAULT ; } else if ( optlen >= sizeof ( char ) ) { unsigned char ucval ; if ( get_user ( ucval , ( unsigned char __user * ) optval ) ) return - EFAULT ; val = ( int ) ucval ; } } if ( ip_mroute_opt ( optname ) ) return ip_mroute_setsockopt ( sk , optname , optval , optlen ) ; err = 0 ; lock_sock ( sk ) ; switch ( optname ) { case IP_OPTIONS : { <BUGS> struct ip_options * opt = NULL ; <BUGE> if ( optlen > 40 ) goto e_inval ; err = ip_options_get_from_user ( sock_net ( sk ) , & opt , optval , optlen ) ; if ( err ) break ; <BUGS> <BUGE> if ( inet -> is_icsk ) { struct inet_connection_sock * icsk = inet_csk ( sk ) ; # if defined ( CONFIG_IPV6 ) || defined ( CONFIG_IPV6_MODULE ) if ( sk -> sk_family == PF_INET || ( ! ( ( 1 << sk -> sk_state ) & ( TCPF_LISTEN | TCPF_CLOSE ) ) && inet -> inet_daddr != LOOPBACK4_IPV6 ) ) { # endif <BUGS> if ( inet -> opt ) icsk -> icsk_ext_hdr_len -= inet -> opt -> optlen ; <BUGE> if ( opt ) <BUGS> icsk -> icsk_ext_hdr_len += opt -> optlen ; <BUGE> icsk -> icsk_sync_mss ( sk , icsk -> icsk_pmtu_cookie ) ; # if defined ( CONFIG_IPV6 ) || defined ( CONFIG_IPV6_MODULE ) } # endif } <BUGS> opt = xchg ( & inet -> opt , opt ) ; kfree ( opt ) ; <BUGE> break ; } case IP_PKTINFO : if ( val ) inet -> cmsg_flags |= IP_CMSG_PKTINFO ; else inet -> cmsg_flags &= ~ IP_CMSG_PKTINFO ; break ; case IP_RECVTTL : if ( val ) inet -> cmsg_flags |= IP_CMSG_TTL ; else inet -> cmsg_flags &= ~ IP_CMSG_TTL ; break ; case IP_RECVTOS : if ( val ) inet -> cmsg_flags |= IP_CMSG_TOS ; else inet -> cmsg_flags &= ~ IP_CMSG_TOS ; break ; case IP_RECVOPTS : if ( val ) inet -> cmsg_flags |= IP_CMSG_RECVOPTS ; else inet -> cmsg_flags &= ~ IP_CMSG_RECVOPTS ; break ; case IP_RETOPTS : if ( val ) inet -> cmsg_flags |= IP_CMSG_RETOPTS ; else inet -> cmsg_flags &= ~ IP_CMSG_RETOPTS ; break ; case IP_PASSSEC : if ( val ) inet -> cmsg_flags |= IP_CMSG_PASSSEC ; else inet -> cmsg_flags &= ~ IP_CMSG_PASSSEC ; break ; case IP_RECVORIGDSTADDR : if ( val ) inet -> cmsg_flags |= IP_CMSG_ORIGDSTADDR ; else inet -> cmsg_flags &= ~ IP_CMSG_ORIGDSTADDR ; break ; case IP_TOS : if ( sk -> sk_type == SOCK_STREAM ) { val &= ~ 3 ; val |= inet -> tos & 3 ; } if ( inet -> tos != val ) { inet -> tos = val ; sk -> sk_priority = rt_tos2priority ( val ) ; sk_dst_reset ( sk ) ; } break ; case IP_TTL : if ( optlen < 1 ) goto e_inval ; if ( val != - 1 && ( val < 0 || val > 255 ) ) goto e_inval ; inet -> uc_ttl = val ; break ; case IP_HDRINCL : if ( sk -> sk_type != SOCK_RAW ) { err = - ENOPROTOOPT ; break ; } inet -> hdrincl = val ? 1 : 0 ; break ; case IP_NODEFRAG : if ( sk -> sk_type != SOCK_RAW ) { err = - ENOPROTOOPT ; break ; } inet -> nodefrag = val ? 1 : 0 ; break ; case IP_MTU_DISCOVER : if ( val < IP_PMTUDISC_DONT || val > IP_PMTUDISC_PROBE ) goto e_inval ; inet -> pmtudisc = val ; break ; case IP_RECVERR : inet -> recverr = ! ! val ; if ( ! val ) skb_queue_purge ( & sk -> sk_error_queue ) ; break ; case IP_MULTICAST_TTL : if ( sk -> sk_type == SOCK_STREAM ) goto e_inval ; if ( optlen < 1 ) goto e_inval ; if ( val == - 1 ) val = 1 ; if ( val < 0 || val > 255 ) goto e_inval ; inet -> mc_ttl = val ; break ; case IP_MULTICAST_LOOP : if ( optlen < 1 ) goto e_inval ; inet -> mc_loop = ! ! val ; break ; case IP_MULTICAST_IF : { struct ip_mreqn mreq ; struct net_device * dev = NULL ; if ( sk -> sk_type == SOCK_STREAM ) goto e_inval ; if ( optlen < sizeof ( struct in_addr ) ) goto e_inval ; err = - EFAULT ; if ( optlen >= sizeof ( struct ip_mreqn ) ) { if ( copy_from_user ( & mreq , optval , sizeof ( mreq ) ) ) break ; } else { memset ( & mreq , 0 , sizeof ( mreq ) ) ; if ( optlen >= sizeof ( struct in_addr ) && copy_from_user ( & mreq . imr_address , optval , sizeof ( struct in_addr ) ) ) break ; } if ( ! mreq . imr_ifindex ) { if ( mreq . imr_address . s_addr == htonl ( INADDR_ANY ) ) { inet -> mc_index = 0 ; inet -> mc_addr = 0 ; err = 0 ; break ; } dev = ip_dev_find ( sock_net ( sk ) , mreq . imr_address . s_addr ) ; if ( dev ) mreq . imr_ifindex = dev -> ifindex ; } else dev = dev_get_by_index ( sock_net ( sk ) , mreq . imr_ifindex ) ; err = - EADDRNOTAVAIL ; if ( ! dev ) break ; dev_put ( dev ) ; err = - EINVAL ; if ( sk -> sk_bound_dev_if && mreq . imr_ifindex != sk -> sk_bound_dev_if ) break ; inet -> mc_index = mreq . imr_ifindex ; inet -> mc_addr = mreq . imr_address . s_addr ; err = 0 ; break ; } case IP_ADD_MEMBERSHIP : case IP_DROP_MEMBERSHIP : { struct ip_mreqn mreq ; err = - EPROTO ; if ( inet_sk ( sk ) -> is_icsk ) break ; if ( optlen < sizeof ( struct ip_mreq ) ) goto e_inval ; err = - EFAULT ; if ( optlen >= sizeof ( struct ip_mreqn ) ) { if ( copy_from_user ( & mreq , optval , sizeof ( mreq ) ) ) break ; } else { memset ( & mreq , 0 , sizeof ( mreq ) ) ; if ( copy_from_user ( & mreq , optval , sizeof ( struct ip_mreq ) ) ) break ; } if ( optname == IP_ADD_MEMBERSHIP ) err = ip_mc_join_group ( sk , & mreq ) ; else err = ip_mc_leave_group ( sk , & mreq ) ; break ; } case IP_MSFILTER : { struct ip_msfilter * msf ; if ( optlen < IP_MSFILTER_SIZE ( 0 ) ) goto e_inval ; if ( optlen > sysctl_optmem_max ) { err = - ENOBUFS ; break ; } msf = kmalloc ( optlen , GFP_KERNEL ) ; if ( ! msf ) { err = - ENOBUFS ; break ; } err = - EFAULT ; if ( copy_from_user ( msf , optval , optlen ) ) { kfree ( msf ) ; break ; } if ( msf -> imsf_numsrc >= 0x3ffffffcU || msf -> imsf_numsrc > sysctl_igmp_max_msf ) { kfree ( msf ) ; err = - ENOBUFS ; break ; } if ( IP_MSFILTER_SIZE ( msf -> imsf_numsrc ) > optlen ) { kfree ( msf ) ; err = - EINVAL ; break ; } err = ip_mc_msfilter ( sk , msf , 0 ) ; kfree ( msf ) ; break ; } case IP_BLOCK_SOURCE : case IP_UNBLOCK_SOURCE : case IP_ADD_SOURCE_MEMBERSHIP : case IP_DROP_SOURCE_MEMBERSHIP : { struct ip_mreq_source mreqs ; int omode , add ; if ( optlen != sizeof ( struct ip_mreq_source ) ) goto e_inval ; if ( copy_from_user ( & mreqs , optval , sizeof ( mreqs ) ) ) { err = - EFAULT ; break ; } if ( optname == IP_BLOCK_SOURCE ) { omode = MCAST_EXCLUDE ; add = 1 ; } else if ( optname == IP_UNBLOCK_SOURCE ) { omode = MCAST_EXCLUDE ; add = 0 ; } else if ( optname == IP_ADD_SOURCE_MEMBERSHIP ) { struct ip_mreqn mreq ; mreq . imr_multiaddr . s_addr = mreqs . imr_multiaddr ; mreq . imr_address . s_addr = mreqs . imr_interface ; mreq . imr_ifindex = 0 ; err = ip_mc_join_group ( sk , & mreq ) ; if ( err && err != - EADDRINUSE ) break ; omode = MCAST_INCLUDE ; add = 1 ; } else { omode = MCAST_INCLUDE ; add = 0 ; } err = ip_mc_source ( add , omode , sk , & mreqs , 0 ) ; break ; } case MCAST_JOIN_GROUP : case MCAST_LEAVE_GROUP : { struct group_req greq ; struct sockaddr_in * psin ; struct ip_mreqn mreq ; if ( optlen < sizeof ( struct group_req ) ) goto e_inval ; err = - EFAULT ; if ( copy_from_user ( & greq , optval , sizeof ( greq ) ) ) break ; psin = ( struct sockaddr_in * ) & greq . gr_group ; if ( psin -> sin_family != AF_INET ) goto e_inval ; memset ( & mreq , 0 , sizeof ( mreq ) ) ; mreq . imr_multiaddr = psin -> sin_addr ; mreq . imr_ifindex = greq . gr_interface ; if ( optname == MCAST_JOIN_GROUP ) err = ip_mc_join_group ( sk , & mreq ) ; else err = ip_mc_leave_group ( sk , & mreq ) ; break ; } case MCAST_JOIN_SOURCE_GROUP : case MCAST_LEAVE_SOURCE_GROUP : case MCAST_BLOCK_SOURCE : case MCAST_UNBLOCK_SOURCE : { struct group_source_req greqs ; struct ip_mreq_source mreqs ; struct sockaddr_in * psin ; int omode , add ; if ( optlen != sizeof ( struct group_source_req ) ) goto e_inval ; if ( copy_from_user ( & greqs , optval , sizeof ( greqs ) ) ) { err = - EFAULT ; break ; } if ( greqs . gsr_group . ss_family != AF_INET || greqs . gsr_source . ss_family != AF_INET ) { err = - EADDRNOTAVAIL ; break ; } psin = ( struct sockaddr_in * ) & greqs . gsr_group ; mreqs . imr_multiaddr = psin -> sin_addr . s_addr ; psin = ( struct sockaddr_in * ) & greqs . gsr_source ; mreqs . imr_sourceaddr = psin -> sin_addr . s_addr ; mreqs . imr_interface = 0 ; if ( optname == MCAST_BLOCK_SOURCE ) { omode = MCAST_EXCLUDE ; add = 1 ; } else if ( optname == MCAST_UNBLOCK_SOURCE ) { omode = MCAST_EXCLUDE ; add = 0 ; } else if ( optname == MCAST_JOIN_SOURCE_GROUP ) { struct ip_mreqn mreq ; psin = ( struct sockaddr_in * ) & greqs . gsr_group ; mreq . imr_multiaddr = psin -> sin_addr ; mreq . imr_address . s_addr = 0 ; mreq . imr_ifindex = greqs . gsr_interface ; err = ip_mc_join_group ( sk , & mreq ) ; if ( err && err != - EADDRINUSE ) break ; greqs . gsr_interface = mreq . imr_ifindex ; omode = MCAST_INCLUDE ; add = 1 ; } else { omode = MCAST_INCLUDE ; add = 0 ; } err = ip_mc_source ( add , omode , sk , & mreqs , greqs . gsr_interface ) ; break ; } case MCAST_MSFILTER : { struct sockaddr_in * psin ; struct ip_msfilter * msf = NULL ; struct group_filter * gsf = NULL ; int msize , i , ifindex ; if ( optlen < GROUP_FILTER_SIZE ( 0 ) ) goto e_inval ; if ( optlen > sysctl_optmem_max ) { err = - ENOBUFS ; break ; } gsf = kmalloc ( optlen , GFP_KERNEL ) ; if ( ! gsf ) { err = - ENOBUFS ; break ; } err = - EFAULT ; if ( copy_from_user ( gsf , optval , optlen ) ) goto mc_msf_out ; if ( gsf -> gf_numsrc >= 0x1ffffff || gsf -> gf_numsrc > sysctl_igmp_max_msf ) { err = - ENOBUFS ; goto mc_msf_out ; } if ( GROUP_FILTER_SIZE ( gsf -> gf_numsrc ) > optlen ) { err = - EINVAL ; goto mc_msf_out ; } msize = IP_MSFILTER_SIZE ( gsf -> gf_numsrc ) ; msf = kmalloc ( msize , GFP_KERNEL ) ; if ( ! msf ) { err = - ENOBUFS ; goto mc_msf_out ; } ifindex = gsf -> gf_interface ; psin = ( struct sockaddr_in * ) & gsf -> gf_group ; if ( psin -> sin_family != AF_INET ) { err = - EADDRNOTAVAIL ; goto mc_msf_out ; } msf -> imsf_multiaddr = psin -> sin_addr . s_addr ; msf -> imsf_interface = 0 ; msf -> imsf_fmode = gsf -> gf_fmode ; msf -> imsf_numsrc = gsf -> gf_numsrc ; err = - EADDRNOTAVAIL ; for ( i = 0 ; i < gsf -> gf_numsrc ; ++ i ) { psin = ( struct sockaddr_in * ) & gsf -> gf_slist [ i ] ; if ( psin -> sin_family != AF_INET ) goto mc_msf_out ; msf -> imsf_slist [ i ] = psin -> sin_addr . s_addr ; } kfree ( gsf ) ; gsf = NULL ; err = ip_mc_msfilter ( sk , msf , ifindex ) ; mc_msf_out : kfree ( msf ) ; kfree ( gsf ) ; break ; } case IP_MULTICAST_ALL : if ( optlen < 1 ) goto e_inval ; if ( val != 0 && val != 1 ) goto e_inval ; inet -> mc_all = val ; break ; case IP_ROUTER_ALERT : err = ip_ra_control ( sk , val ? 1 : 0 , NULL ) ; break ; case IP_FREEBIND : if ( optlen < 1 ) goto e_inval ; inet -> freebind = ! ! val ; break ; case IP_IPSEC_POLICY : case IP_XFRM_POLICY : err = - EPERM ; if ( ! capable ( CAP_NET_ADMIN ) ) break ; err = xfrm_user_policy ( sk , optname , optval , optlen ) ; break ; case IP_TRANSPARENT : if ( ! capable ( CAP_NET_ADMIN ) ) { err = - EPERM ; break ; } if ( optlen < 1 ) goto e_inval ; inet -> transparent = ! ! val ; break ; case IP_MINTTL : if ( optlen < 1 ) goto e_inval ; if ( val < 0 || val > 255 ) goto e_inval ; inet -> min_ttl = val ; break ; default : err = - ENOPROTOOPT ; break ; } release_sock ( sk ) ; return err ; e_inval : release_sock ( sk ) ; return - EINVAL ; }
| <FIXS> struct ip_options_rcu * old , * opt = NULL ; <FIXE> <FIXS> old = rcu_dereference_protected ( inet -> inet_opt , sock_owned_by_user ( sk ) ) ; <FIXE> <FIXS> if ( old ) icsk -> icsk_ext_hdr_len -= old -> opt . optlen ; <FIXE> <FIXS> icsk -> icsk_ext_hdr_len += opt -> opt . optlen ; <FIXE> <FIXS> rcu_assign_pointer ( inet -> inet_opt , opt ) ; if ( old ) call_rcu ( & old -> rcu , opt_kfree_rcu ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-125 static void <BUGS> l2tp_framing_cap_print ( netdissect_options * ndo , const u_char * dat ) <BUGE> { const uint32_t * ptr = ( const uint32_t * ) dat ; <BUGS> <BUGE> if ( EXTRACT_32BITS ( ptr ) & L2TP_FRAMING_CAP_ASYNC_MASK ) { ND_PRINT ( ( ndo , "A" ) ) ; } if ( EXTRACT_32BITS ( ptr ) & L2TP_FRAMING_CAP_SYNC_MASK ) { ND_PRINT ( ( ndo , "S" ) ) ; } }
| <FIXS> l2tp_framing_cap_print ( netdissect_options * ndo , const u_char * dat , u_int length ) <FIXE> <FIXS> if ( length < 4 ) { ND_PRINT ( ( ndo , "AVP too short" ) ) ; return ; } <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 static int process_line ( URLContext * h , char * line , int line_count , int * new_location ) { HTTPContext * s = h -> priv_data ; const char * auto_method = h -> flags & AVIO_FLAG_READ ? "POST" : "GET" ; char * tag , * p , * end , * method , * resource , * version ; int ret ; if ( line [ 0 ] == '\\0' ) { s -> end_header = 1 ; return 0 ; } p = line ; if ( line_count == 0 ) { if ( s -> is_connected_server ) { method = p ; while ( * p && ! av_isspace ( * p ) ) p ++ ; * ( p ++ ) = '\\0' ; av_log ( h , AV_LOG_TRACE , "Received method: %s\\n" , method ) ; if ( s -> method ) { if ( av_strcasecmp ( s -> method , method ) ) { av_log ( h , AV_LOG_ERROR , "Received and expected HTTP method do not match. (%s expected, %s received)\\n" , s -> method , method ) ; return ff_http_averror ( 400 , AVERROR ( EIO ) ) ; } } else { av_log ( h , AV_LOG_TRACE , "Autodetected %s HTTP method\\n" , auto_method ) ; if ( av_strcasecmp ( auto_method , method ) ) { av_log ( h , AV_LOG_ERROR , "Received and autodetected HTTP method did not match " "(%s autodetected %s received)\\n" , auto_method , method ) ; return ff_http_averror ( 400 , AVERROR ( EIO ) ) ; } if ( ! ( s -> method = av_strdup ( method ) ) ) return AVERROR ( ENOMEM ) ; } while ( av_isspace ( * p ) ) p ++ ; resource = p ; while ( ! av_isspace ( * p ) ) p ++ ; * ( p ++ ) = '\\0' ; av_log ( h , AV_LOG_TRACE , "Requested resource: %s\\n" , resource ) ; if ( ! ( s -> resource = av_strdup ( resource ) ) ) return AVERROR ( ENOMEM ) ; while ( av_isspace ( * p ) ) p ++ ; version = p ; while ( * p && ! av_isspace ( * p ) ) p ++ ; * p = '\\0' ; if ( av_strncasecmp ( version , "HTTP/" , 5 ) ) { av_log ( h , AV_LOG_ERROR , "Malformed HTTP version string.\\n" ) ; return ff_http_averror ( 400 , AVERROR ( EIO ) ) ; } av_log ( h , AV_LOG_TRACE , "HTTP version string: %s\\n" , version ) ; } else { while ( ! av_isspace ( * p ) && * p != '\\0' ) p ++ ; while ( av_isspace ( * p ) ) p ++ ; s -> http_code = strtol ( p , & end , 10 ) ; av_log ( h , AV_LOG_TRACE , "http_code=%d\\n" , s -> http_code ) ; if ( ( ret = check_http_code ( h , s -> http_code , end ) ) < 0 ) return ret ; } } else { while ( * p != '\\0' && * p != ':' ) p ++ ; if ( * p != ':' ) return 1 ; * p = '\\0' ; tag = line ; p ++ ; while ( av_isspace ( * p ) ) p ++ ; if ( ! av_strcasecmp ( tag , "Location" ) ) { if ( ( ret = parse_location ( s , p ) ) < 0 ) return ret ; * new_location = 1 ; <BUGS> } else if ( ! av_strcasecmp ( tag , "Content-Length" ) && s -> filesize == - 1 ) { s -> filesize = strtoll ( p , NULL , 10 ) ; <BUGE> } else if ( ! av_strcasecmp ( tag , "Content-Range" ) ) { parse_content_range ( h , p ) ; } else if ( ! av_strcasecmp ( tag , "Accept-Ranges" ) && ! strncmp ( p , "bytes" , 5 ) && s -> seekable == - 1 ) { h -> is_streamed = 0 ; } else if ( ! av_strcasecmp ( tag , "Transfer-Encoding" ) && ! av_strncasecmp ( p , "chunked" , 7 ) ) { <BUGS> s -> filesize = - 1 ; <BUGE> s -> chunksize = 0 ; } else if ( ! av_strcasecmp ( tag , "WWW-Authenticate" ) ) { ff_http_auth_handle_header ( & s -> auth_state , tag , p ) ; } else if ( ! av_strcasecmp ( tag , "Authentication-Info" ) ) { ff_http_auth_handle_header ( & s -> auth_state , tag , p ) ; } else if ( ! av_strcasecmp ( tag , "Proxy-Authenticate" ) ) { ff_http_auth_handle_header ( & s -> proxy_auth_state , tag , p ) ; } else if ( ! av_strcasecmp ( tag , "Connection" ) ) { if ( ! strcmp ( p , "close" ) ) s -> willclose = 1 ; } else if ( ! av_strcasecmp ( tag , "Server" ) ) { if ( ! av_strcasecmp ( p , "AkamaiGHost" ) ) { s -> is_akamai = 1 ; } else if ( ! av_strncasecmp ( p , "MediaGateway" , 12 ) ) { s -> is_mediagateway = 1 ; } } else if ( ! av_strcasecmp ( tag , "Content-Type" ) ) { av_free ( s -> mime_type ) ; s -> mime_type = av_strdup ( p ) ; } else if ( ! av_strcasecmp ( tag , "Set-Cookie" ) ) { if ( parse_cookie ( s , p , & s -> cookie_dict ) ) av_log ( h , AV_LOG_WARNING , "Unable to parse \'%s\'\\n" , p ) ; } else if ( ! av_strcasecmp ( tag , "Icy-MetaInt" ) ) { <BUGS> s -> icy_metaint = strtoll ( p , NULL , 10 ) ; <BUGE> } else if ( ! av_strncasecmp ( tag , "Icy-" , 4 ) ) { if ( ( ret = parse_icy ( s , tag , p ) ) < 0 ) return ret ; } else if ( ! av_strcasecmp ( tag , "Content-Encoding" ) ) { if ( ( ret = parse_content_encoding ( h , p ) ) < 0 ) return ret ; } } return 1 ; }
| <FIXS> } else if ( ! av_strcasecmp ( tag , "Content-Length" ) && s -> filesize == UINT64_MAX ) { s -> filesize = strtoull ( p , NULL , 10 ) ; <FIXE> <FIXS> s -> filesize = UINT64_MAX ; <FIXE> <FIXS> s -> icy_metaint = strtoull ( p , NULL , 10 ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 MagickExport void * AcquireQuantumMemory ( const size_t count , const size_t quantum ) { size_t extent ; <BUGS> if ( CheckMemoryOverflow ( count , quantum ) != MagickFalse ) <BUGE> return ( ( void * ) NULL ) ; extent = count * quantum ; return ( AcquireMagickMemory ( extent ) ) ; }
| <FIXS> if ( HeapOverflowSanityCheck ( count , quantum ) != MagickFalse ) <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-400 static void fpm_child_init ( struct fpm_worker_pool_s * wp ) { fpm_globals . max_requests = wp -> config -> pm_max_requests ; <BUGS> <BUGE> if ( 0 > fpm_stdio_init_child ( wp ) || 0 > fpm_log_init_child ( wp ) || 0 > fpm_status_init_child ( wp ) || 0 > fpm_unix_init_child ( wp ) || 0 > fpm_signals_init_child ( ) || 0 > fpm_env_init_child ( wp ) || 0 > fpm_php_init_child ( wp ) ) { zlog ( ZLOG_ERROR , "[pool %s] child failed to initialize" , wp -> config -> name ) ; exit ( FPM_EXIT_SOFTWARE ) ; } }
| <FIXS> fpm_globals . listening_socket = dup ( wp -> listening_socket ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-119 <BUGS> static int detect_transition_to_still ( struct twopass_rc * twopass , <BUGE> int frame_interval , int still_interval , double loop_decay_rate , double last_decay_rate ) { <BUGS> int trans_to_still = 0 ; if ( frame_interval > MIN_GF_INTERVAL && <BUGE> loop_decay_rate >= 0.999 && last_decay_rate < 0.9 ) { int j ; <BUGS> const FIRSTPASS_STATS * position = twopass -> stats_in ; FIRSTPASS_STATS tmp_next_frame ; <BUGE> for ( j = 0 ; j < still_interval ; ++ j ) { <BUGS> if ( EOF == input_stats ( twopass , & tmp_next_frame ) ) <BUGE> break ; <BUGS> if ( tmp_next_frame . pcnt_inter - tmp_next_frame . pcnt_motion < 0.999 ) <BUGE> break ; } <BUGS> reset_fpf_position ( twopass , position ) ; if ( j == still_interval ) trans_to_still = 1 ; <BUGE> } <BUGS> return trans_to_still ; <BUGE> }
| <FIXS> static int detect_transition_to_still ( VP9_COMP * cpi , <FIXE> <FIXS> TWO_PASS * const twopass = & cpi -> twopass ; RATE_CONTROL * const rc = & cpi -> rc ; if ( frame_interval > rc -> min_gf_interval && <FIXE> <FIXS> <FIXE> <FIXS> const FIRSTPASS_STATS * stats = & twopass -> stats_in [ j ] ; if ( stats >= twopass -> stats_in_end ) <FIXE> <FIXS> if ( stats -> pcnt_inter - stats -> pcnt_motion < 0.999 ) <FIXE> <FIXS> return j == still_interval ; <FIXE> <FIXS> return 0 ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-400 int xfs_setattr_nonsize ( struct xfs_inode * ip , struct iattr * iattr , int flags ) { xfs_mount_t * mp = ip -> i_mount ; struct inode * inode = VFS_I ( ip ) ; int mask = iattr -> ia_valid ; xfs_trans_t * tp ; int error ; kuid_t uid = GLOBAL_ROOT_UID , iuid = GLOBAL_ROOT_UID ; kgid_t gid = GLOBAL_ROOT_GID , igid = GLOBAL_ROOT_GID ; struct xfs_dquot * udqp = NULL , * gdqp = NULL ; struct xfs_dquot * olddquot1 = NULL , * olddquot2 = NULL ; ASSERT ( ( mask & ATTR_SIZE ) == 0 ) ; if ( XFS_IS_QUOTA_ON ( mp ) && ( mask & ( ATTR_UID | ATTR_GID ) ) ) { uint qflags = 0 ; if ( ( mask & ATTR_UID ) && XFS_IS_UQUOTA_ON ( mp ) ) { uid = iattr -> ia_uid ; qflags |= XFS_QMOPT_UQUOTA ; } else { uid = inode -> i_uid ; } if ( ( mask & ATTR_GID ) && XFS_IS_GQUOTA_ON ( mp ) ) { gid = iattr -> ia_gid ; qflags |= XFS_QMOPT_GQUOTA ; } else { gid = inode -> i_gid ; } ASSERT ( udqp == NULL ) ; ASSERT ( gdqp == NULL ) ; error = xfs_qm_vop_dqalloc ( ip , xfs_kuid_to_uid ( uid ) , xfs_kgid_to_gid ( gid ) , xfs_get_projid ( ip ) , qflags , & udqp , & gdqp , NULL ) ; if ( error ) return error ; } error = xfs_trans_alloc ( mp , & M_RES ( mp ) -> tr_ichange , 0 , 0 , 0 , & tp ) ; if ( error ) goto out_dqrele ; xfs_ilock ( ip , XFS_ILOCK_EXCL ) ; xfs_trans_ijoin ( tp , ip , 0 ) ; if ( mask & ( ATTR_UID | ATTR_GID ) ) { iuid = inode -> i_uid ; igid = inode -> i_gid ; gid = ( mask & ATTR_GID ) ? iattr -> ia_gid : igid ; uid = ( mask & ATTR_UID ) ? iattr -> ia_uid : iuid ; if ( XFS_IS_QUOTA_RUNNING ( mp ) && ( ( XFS_IS_UQUOTA_ON ( mp ) && ! uid_eq ( iuid , uid ) ) || ( XFS_IS_GQUOTA_ON ( mp ) && ! gid_eq ( igid , gid ) ) ) ) { ASSERT ( tp ) ; error = xfs_qm_vop_chown_reserve ( tp , ip , udqp , gdqp , NULL , capable ( CAP_FOWNER ) ? XFS_QMOPT_FORCE_RES : 0 ) ; if ( error ) goto out_cancel ; } } if ( mask & ( ATTR_UID | ATTR_GID ) ) { if ( ( inode -> i_mode & ( S_ISUID | S_ISGID ) ) && ! capable ( CAP_FSETID ) ) inode -> i_mode &= ~ ( S_ISUID | S_ISGID ) ; if ( ! uid_eq ( iuid , uid ) ) { if ( XFS_IS_QUOTA_RUNNING ( mp ) && XFS_IS_UQUOTA_ON ( mp ) ) { ASSERT ( mask & ATTR_UID ) ; ASSERT ( udqp ) ; olddquot1 = xfs_qm_vop_chown ( tp , ip , & ip -> i_udquot , udqp ) ; } ip -> i_d . di_uid = xfs_kuid_to_uid ( uid ) ; inode -> i_uid = uid ; } if ( ! gid_eq ( igid , gid ) ) { if ( XFS_IS_QUOTA_RUNNING ( mp ) && XFS_IS_GQUOTA_ON ( mp ) ) { ASSERT ( xfs_sb_version_has_pquotino ( & mp -> m_sb ) || ! XFS_IS_PQUOTA_ON ( mp ) ) ; ASSERT ( mask & ATTR_GID ) ; ASSERT ( gdqp ) ; olddquot2 = xfs_qm_vop_chown ( tp , ip , & ip -> i_gdquot , gdqp ) ; } ip -> i_d . di_gid = xfs_kgid_to_gid ( gid ) ; inode -> i_gid = gid ; } } if ( mask & ATTR_MODE ) xfs_setattr_mode ( ip , iattr ) ; if ( mask & ( ATTR_ATIME | ATTR_CTIME | ATTR_MTIME ) ) xfs_setattr_time ( ip , iattr ) ; xfs_trans_log_inode ( tp , ip , XFS_ILOG_CORE ) ; XFS_STATS_INC ( mp , xs_ig_attrchg ) ; if ( mp -> m_flags & XFS_MOUNT_WSYNC ) xfs_trans_set_sync ( tp ) ; error = xfs_trans_commit ( tp ) ; xfs_iunlock ( ip , XFS_ILOCK_EXCL ) ; xfs_qm_dqrele ( olddquot1 ) ; xfs_qm_dqrele ( olddquot2 ) ; xfs_qm_dqrele ( udqp ) ; xfs_qm_dqrele ( gdqp ) ; if ( error ) return error ; if ( ( mask & ATTR_MODE ) && ! ( flags & XFS_ATTR_NOACL ) ) { error = posix_acl_chmod ( inode , inode -> i_mode ) ; if ( error ) return error ; } return 0 ; out_cancel : xfs_trans_cancel ( tp ) ; <BUGS> <BUGE> out_dqrele : xfs_qm_dqrele ( udqp ) ; xfs_qm_dqrele ( gdqp ) ; return error ; }
| <FIXS> xfs_iunlock ( ip , XFS_ILOCK_EXCL ) ; <FIXE>
|
Example Vulnerable Function 1:
CWE-119 <BUGS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array -> child ; while ( c && item > 0 ) { -- item ; c = c -> next ; } return c ; } <BUGE>
Example Repair Patch 1:
<FIXS> cJSON * cJSON_GetArrayItem ( cJSON * array , int item ) { cJSON * c = array ? array -> child : 0 ; while ( c && item > 0 ) item -- , c = c -> next ; return c ; } <FIXE>
Example Vulnerable Function 2:
Vulnerable Code: CWE-20 static ext3_fsblk_t get_sb_block ( void * * data , struct super_block * sb ) { ext3_fsblk_t sb_block ; char * options = ( char * ) * data ; if ( ! options || strncmp ( options , "sb=" , 3 ) != 0 ) return 1 ; options += 3 ; sb_block = simple_strtoul ( options , & options , 0 ) ; if ( * options && * options != ',' ) { <BUGS> ext3_msg ( sb , "error: invalid sb specification: %s" , <BUGE> ( char * ) * data ) ; return 1 ; } if ( * options == ',' ) options ++ ; * data = ( void * ) options ; return sb_block ; }
Example Repair Patch 2:
<FIXS> ext3_msg ( sb , KERN_ERR , "error: invalid sb specification: %s" , <FIXE>
Example Vulnerable Function 3:
Vulnerable Code: CWE-20 void httpClientParseQopParam ( const HttpParam * param , HttpWwwAuthenticateHeader * authHeader ) { # if ( HTTP_CLIENT_DIGEST_AUTH_SUPPORT == ENABLED ) size_t i ; size_t n ; authHeader -> qop = HTTP_AUTH_QOP_NONE ; for ( i = 0 ; i < param -> valueLen ; i += ( n + 1 ) ) { for ( n = 0 ; ( i + n ) < param -> valueLen ; n ++ ) { <BUGS> if ( strchr ( ", \t" , param -> value [ i + n ] ) ) <BUGE> break ; <BUGS> <BUGE> } if ( n == 4 && ! osStrncasecmp ( param -> value + i , "auth" , 4 ) ) { authHeader -> qop = HTTP_AUTH_QOP_AUTH ; } } if ( authHeader -> qop == HTTP_AUTH_QOP_NONE ) { authHeader -> mode = HTTP_AUTH_MODE_NONE ; } # endif }
Example Repair Patch 3:
<FIXS> if ( osStrchr ( ", \t" , param -> value [ i + n ] ) != NULL ) { <FIXE> <BUGS> } <BUGE>
Generate repair patches for the following vulnerable function.
The return format should strictly follow the Example Repair Patch provided above. | CWE-416 int __ext4_journal_stop ( const char * where , unsigned int line , handle_t * handle ) { struct super_block * sb ; int err ; int rc ; if ( ! ext4_handle_valid ( handle ) ) { ext4_put_nojournal ( handle ) ; return 0 ; } <BUGS> <BUGE> if ( ! handle -> h_transaction ) { <BUGS> err = jbd2_journal_stop ( handle ) ; return handle -> h_err ? handle -> h_err : err ; <BUGE> } sb = handle -> h_transaction -> t_journal -> j_private ; <BUGS> err = handle -> h_err ; <BUGE> rc = jbd2_journal_stop ( handle ) ; if ( ! err ) err = rc ; if ( err ) __ext4_std_error ( sb , where , line , err ) ; return err ; }
| <FIXS> err = handle -> h_err ; <FIXE> <FIXS> rc = jbd2_journal_stop ( handle ) ; return err ? err : rc ; <FIXE> <FIXS> <FIXE>
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.