Fix streaming (#7)

- Fix streaming (58f6a141ad945c012bef3f17b7d0836f6213441b)
- Update pubchem_selfies.py (c9c4e090fe6525ec6adaf6eb5852c823227fa08b)
- unique keys (d9711cd921f9ad8dba1fc48348d2e54a5e4b3530)


Co-authored-by: Quentin Lhoest <[email protected]>

pubchem_selfies.py

@@ -16,6 +16,7 @@
 import json
 import glob
 import gzip
+import os
 
 import datasets
 
@@ -472,15 +473,15 @@ class PubchemSelfies(datasets.GeneratorBasedBuilder):
     def _generate_examples(self, subdirs, split):
         # The `key` is for legacy reasons (tfds) and is not important in itself, but must be unique for each example.
         for filepath in subdirs:
-            with gzip.open(filepath, mode="rt") as f:
-                rows = f.readlines()
-            for key, row in enumerate(rows):
-                data = json.loads(row)
-                properties = data["molecules"][0]["properties"]
-                yield key, {
-                    "PUBCHEM_COMPOUND_CID": properties["PUBCHEM_COMPOUND_CID"],
-                    "PUBCHEM_OPENEYE_CAN_SMILES": properties[
-                        "PUBCHEM_OPENEYE_CAN_SMILES"
-                    ],
-                    "CAN_SELFIES": properties["CAN_SELFIES"],
-                }
+            with gzip.open(open(filepath, "rb"), "rt", encoding="utf-8") as f:
+                for row_idx, row in enumerate(f):
+                    data = json.loads(row)
+                    properties = data["molecules"][0]["properties"]
+                    key = f"{os.path.basename(filepath)}_{row_idx}"
+                    yield key, {
+                        "PUBCHEM_COMPOUND_CID": properties["PUBCHEM_COMPOUND_CID"],
+                        "PUBCHEM_OPENEYE_CAN_SMILES": properties[
+                            "PUBCHEM_OPENEYE_CAN_SMILES"
+                        ],
+                        "CAN_SELFIES": properties["CAN_SELFIES"],
+                    }